Ticket #3241: t3241_kick_v6.4.patch

File t3241_kick_v6.4.patch, 25.6 KB (added by elexis, 9 years ago)

Rebased & minimized by removing cleanup. Doesn't sanitize playernames anymore since they can contain whitespace due to the rating anyway. In case autocomplete fails, /list will show the full name of everybody.

  • binaries/data/mods/public/gui/common/network.js

     
     1/**
     2 * Get a human readable version of the given disconnect reason.
     3 *
     4 * @see source/network/NetHost.h
     5 * @param reason {number}
     6 * @returns {string}
     7 */
    18function getDisconnectReason(id)
    29{
    3     // Must be kept in sync with source/network/NetHost.h
    410    switch (id)
    511    {
    612    case 0: return translate("Unknown reason");
    713    case 1: return translate("Unexpected shutdown");
    814    case 2: return translate("Incorrect network protocol version");
    915    case 3: return translate("Game is loading, please try later");
    1016    case 4: return translate("Game has already started, no observers allowed");
     17    case 5: return translate("You have been kicked from the match");
     18    case 6: return translate("You have been banned from the match");
    1119    default: return sprintf(translate("\\[Invalid value %(id)s]"), { "id": id });
    1220    }
    1321}
    1422
     23/**
     24 * Show the disconnect reason in a message box.
     25 *
     26 * @param {number} reason
     27 */
    1528function reportDisconnect(reason)
    1629{
    1730    var reasontext = getDisconnectReason(reason);
    1831
    1932    messageBox(400, 200,
    2033        translate("Lost connection to the server.") + "\n\n" + sprintf(translate("Reason: %(reason)s."), { reason: reasontext }),
    2134        translate("Disconnected"), 2);
    2235}
     36
     37/**
     38 * Get usernames sorted by player slot, observers last.
     39 * Requires g_PlayerAssignments.
     40 *
     41 * @returns {string[]}
     42 */
     43function getUsernameList()
     44{
     45    return Object.keys(g_PlayerAssignments).sort((guidA, guidB) => {
     46        let slotA = g_PlayerAssignments[guidA].player;
     47        let slotB = g_PlayerAssignments[guidB].player;
     48        if (slotA == -1) return 1;
     49        if (slotB == -1) return -1;
     50        return slotA - slotB;
     51    }).map(guid => g_PlayerAssignments[guid].name);
     52}
     53
     54/**
     55 * Execute a command locally. Requires addChatMessage.
     56 *
     57 * @param {string} input
     58 * @returns {Boolean} whether a command was executed
     59 */
     60function executeNetworkCommand(input)
     61{
     62    if (input.indexOf("/") != 0)
     63        return false;
     64
     65    var command = input.split(" ", 1)[0];
     66    var argument = input.substr(command.length + 1);
     67
     68    switch (command)
     69    {
     70    case "/list":
     71        addChatMessage({ "type": "clientlist", "guid": "local" });
     72        return true;
     73
     74    case "/kick":
     75        Engine.KickPlayer(argument, false);
     76        return true;
     77
     78    case "/ban":
     79        Engine.KickPlayer(argument, true);
     80        return true;
     81
     82    default:
     83        return false;
     84    }
     85}
  • binaries/data/mods/public/gui/gamesetup/gamesetup.js

    function handleNetMessage(message)  
    506506
    507507    case "chat":
    508508        addChatMessage({ "type": "message", "guid": message.guid, "text": message.text });
    509509        break;
    510510
     511    case "kicked":
     512        addChatMessage({ "type": message.ban ? "banned" : "kicked", "username": message.username });
     513        break;
     514
    511515    // Singular client to host message
    512516    case "ready":
    513517        g_ReadyChanged -= 1;
    514518        if (g_ReadyChanged < 1 && g_PlayerAssignments[message.guid].player != -1)
    515519            addChatMessage({ "type": "ready", "guid": message.guid, "ready": +message.status == 1 });
    function submitChatInput()  
    17741778    var input = Engine.GetGUIObjectByName("chatInput");
    17751779    var text = input.caption;
    17761780    if (!text.length)
    17771781        return;
    17781782
    1779     Engine.SendNetworkChat(text);
    17801783    input.caption = "";
     1784
     1785    if (executeNetworkCommand(text))
     1786        return;
     1787
     1788    Engine.SendNetworkChat(text);
    17811789}
    17821790
    17831791function addChatMessage(msg)
    17841792{
    17851793    var username = "";
    function addChatMessage(msg)  
    18191827    case "disconnect":
    18201828        var formattedUsername = '[color="'+ color +'"]' + username + '[/color]';
    18211829        formatted = '[font="sans-bold-13"] ' + sprintf(translate("== %(message)s"), { "message": sprintf(translate("%(username)s has left"), { "username": formattedUsername }) }) + '[/font]';
    18221830        break;
    18231831
     1832    case "clientlist":
     1833        formatted = sprintf(translate("Users: %(users)s"), { "users": getUsernameList().join(",") });
     1834        break;
     1835
     1836    case "kicked":
     1837        formatted = '[font="sans-bold-13"] ' + sprintf(translate("== %(message)s"), { "message": sprintf(translate("%(username)s has been kicked."), { "username": username }) }) + '[/font]';
     1838        break;
     1839
     1840    case "banned":
     1841        formatted = '[font="sans-bold-13"] ' + sprintf(translate("== %(message)s"), { "message": sprintf(translate("%(username)s has been banned."), { "username": username }) }) + '[/font]';
     1842        break;
     1843
    18241844    case "message":
    18251845        var formattedUsername = '[color="'+ color +'"]' + username + '[/color]';
    18261846        var formattedUsernamePrefix = '[font="sans-bold-13"]' + sprintf(translate("<%(username)s>"), { "username": formattedUsername }) + '[/font]';
    18271847        formatted = sprintf(translate("%(username)s %(message)s"), { "username": formattedUsernamePrefix, "message": message });
    18281848        break;
  • binaries/data/mods/public/gui/session/messages.js

    function handleNetMessage(message)  
    267267            obj.caption = translate("Connection to the server has been authenticated.");
    268268            obj.hidden = false;
    269269            break;
    270270        case "disconnected":
    271271            g_Disconnected = true;
    272             obj.caption = translate("Connection to the server has been lost.") + "\n\n" + translate("The game has ended.");
     272            obj.caption = translate("Connection to the server has been lost.") + "\n" +
     273                sprintf(translate("Reason: %(reason)s."), { "reason": getDisconnectReason(message.reason) }) + "\n" +
     274                translate("The game has ended.");
    273275            obj.hidden = false;
    274276            break;
    275277        default:
    276278            error("Unrecognised netstatus type '" + message.status + "'");
    277279            break;
    function handleNetMessage(message)  
    323325
    324326    case "rejoined":
    325327        addChatMessage({ "type": "rejoined", "guid": message.guid });
    326328        break;
    327329
     330    case "kicked":
     331        addChatMessage({ "type": message.ban ? "banned" : "kicked", "username": message.username });
     332        break;
     333
    328334    // To prevent errors, ignore these message types that occur during autostart
    329335    case "gamesetup":
    330336    case "start":
    331337        break;
    332338
    function submitChatInput()  
    356362    toggleChatWindow();
    357363
    358364    if (!text.length)
    359365        return;
    360366
     367    if (executeNetworkCommand(text))
     368        return;
     369
    361370    if (executeCheat(text))
    362371        return;
    363372
    364373    // Observers should only be able to chat with everyone.
    365374    if (g_IsObserver && text.indexOf("/") == 0 && text.indexOf("/me ") != 0)
    function addChatMessage(msg)  
    420429        formatted = sprintf(translate("%(player)s has left the game."), { "player": "[color=\"" + playerColor + "\"]" + username + "[/color]" });
    421430        break;
    422431    case "rejoined":
    423432        formatted = sprintf(translate("%(player)s has rejoined the game."), { "player": "[color=\"" + playerColor + "\"]" + username + "[/color]" });
    424433        break;
     434    case "clientlist":
     435        formatted = sprintf(translate("Users: %(users)s"), { "users": getUsernameList().join(",") });
     436        break;
     437    case "kicked":
     438        formatted = sprintf(translate("%(username)s has been kicked."), { "username": msg.username });
     439        break;
     440    case "banned":
     441        formatted = sprintf(translate("%(username)s has been banned."), { "username": msg.username });
     442        break;
    425443    case "defeat":
    426444        // In singleplayer, the local player is "You". "You has" is incorrect.
    427445        if (!g_IsNetworked && msg.player == Engine.GetPlayerID())
    428446            formatted = translate("You have been defeated.");
    429447        else
  • binaries/data/mods/public/gui/session/session.xml

     
    66<script file="gui/common/functions_civinfo.js"/>
    77<script file="gui/common/functions_global_object.js"/>
    88<script file="gui/common/functions_utility.js"/>
    99<script file="gui/common/l10n.js"/>
    1010<script file="gui/common/music.js"/>
     11<script file="gui/common/network.js"/>
    1112<script file="gui/common/settings.js"/>
    1213<script file="gui/common/timer.js"/>
    1314<script file="gui/common/tooltips.js"/>
    1415<!-- load all scripts in this directory -->
    1516<script directory="gui/session/"/>
  • source/gui/scripting/ScriptFunctions.cpp

    void DisconnectNetworkGame(ScriptInterfa  
    350350    SAFE_DELETE(g_NetServer);
    351351    SAFE_DELETE(g_NetClient);
    352352    SAFE_DELETE(g_Game);
    353353}
    354354
     355void KickPlayer(ScriptInterface::CxPrivate* UNUSED(pCxPrivate), CStrW playerName, bool ban)
     356{
     357    if (g_NetServer)
     358        g_NetServer->KickPlayer(playerName, ban);
     359}
     360
    355361JS::Value PollNetworkClient(ScriptInterface::CxPrivate* pCxPrivate)
    356362{
    357363    if (!g_NetClient)
    358364        return JS::UndefinedValue();
    359365
    void GuiScriptingInit(ScriptInterface& s  
    959965    scriptInterface.RegisterFunction<void, JS::HandleValue, int, &StartGame>("StartGame");
    960966    scriptInterface.RegisterFunction<void, &Script_EndGame>("EndGame");
    961967    scriptInterface.RegisterFunction<void, std::wstring, &StartNetworkHost>("StartNetworkHost");
    962968    scriptInterface.RegisterFunction<void, std::wstring, std::string, &StartNetworkJoin>("StartNetworkJoin");
    963969    scriptInterface.RegisterFunction<void, &DisconnectNetworkGame>("DisconnectNetworkGame");
     970    scriptInterface.RegisterFunction<void, CStrW, bool, &KickPlayer>("KickPlayer");
    964971    scriptInterface.RegisterFunction<JS::Value, &PollNetworkClient>("PollNetworkClient");
    965972    scriptInterface.RegisterFunction<void, JS::HandleValue, &SetNetworkGameAttributes>("SetNetworkGameAttributes");
    966973    scriptInterface.RegisterFunction<void, int, std::string, &AssignNetworkPlayer>("AssignNetworkPlayer");
    967974    scriptInterface.RegisterFunction<void, std::string, int, &SetNetworkPlayerStatus>("SetNetworkPlayerStatus");
    968975    scriptInterface.RegisterFunction<void, &ClearAllPlayerReady>("ClearAllPlayerReady");
  • source/network/NetClient.cpp

    CNetClient::CNetClient(CGame* game) :  
    9191
    9292    AddTransition(NCS_PREGAME, (uint)NMT_CHAT, NCS_PREGAME, (void*)&OnChat, context);
    9393    AddTransition(NCS_PREGAME, (uint)NMT_READY, NCS_PREGAME, (void*)&OnReady, context);
    9494    AddTransition(NCS_PREGAME, (uint)NMT_GAME_SETUP, NCS_PREGAME, (void*)&OnGameSetup, context);
    9595    AddTransition(NCS_PREGAME, (uint)NMT_PLAYER_ASSIGNMENT, NCS_PREGAME, (void*)&OnPlayerAssignment, context);
     96    AddTransition(NCS_PREGAME, (uint)NMT_KICKED, NCS_PREGAME, (void*)&OnKicked, context);
    9697    AddTransition(NCS_PREGAME, (uint)NMT_GAME_START, NCS_LOADING, (void*)&OnGameStart, context);
    9798    AddTransition(NCS_PREGAME, (uint)NMT_JOIN_SYNC_START, NCS_JOIN_SYNCING, (void*)&OnJoinSyncStart, context);
    9899
    99100    AddTransition(NCS_JOIN_SYNCING, (uint)NMT_CHAT, NCS_JOIN_SYNCING, (void*)&OnChat, context);
    100101    AddTransition(NCS_JOIN_SYNCING, (uint)NMT_GAME_SETUP, NCS_JOIN_SYNCING, (void*)&OnGameSetup, context);
    CNetClient::CNetClient(CGame* game) :  
    108109    AddTransition(NCS_LOADING, (uint)NMT_GAME_SETUP, NCS_LOADING, (void*)&OnGameSetup, context);
    109110    AddTransition(NCS_LOADING, (uint)NMT_PLAYER_ASSIGNMENT, NCS_LOADING, (void*)&OnPlayerAssignment, context);
    110111    AddTransition(NCS_LOADING, (uint)NMT_LOADED_GAME, NCS_INGAME, (void*)&OnLoadedGame, context);
    111112
    112113    AddTransition(NCS_INGAME, (uint)NMT_REJOINED, NCS_INGAME, (void*)&OnRejoined, context);
     114    AddTransition(NCS_INGAME, (uint)NMT_KICKED, NCS_INGAME, (void*)&OnKicked, context);
    113115    AddTransition(NCS_INGAME, (uint)NMT_CHAT, NCS_INGAME, (void*)&OnChat, context);
    114116    AddTransition(NCS_INGAME, (uint)NMT_GAME_SETUP, NCS_INGAME, (void*)&OnGameSetup, context);
    115117    AddTransition(NCS_INGAME, (uint)NMT_PLAYER_ASSIGNMENT, NCS_INGAME, (void*)&OnPlayerAssignment, context);
    116118    AddTransition(NCS_INGAME, (uint)NMT_SIMULATION_COMMAND, NCS_INGAME, (void*)&OnInGame, context);
    117119    AddTransition(NCS_INGAME, (uint)NMT_SYNC_ERROR, NCS_INGAME, (void*)&OnInGame, context);
    bool CNetClient::OnRejoined(void *contex  
    605607    client->PushGuiMessage(msg);
    606608
    607609    return true;
    608610}
    609611
     612bool CNetClient::OnKicked(void *context, CFsmEvent* event)
     613{
     614    ENSURE(event->GetType() == (uint)NMT_KICKED);
     615
     616    CNetClient* client = (CNetClient*)context;
     617    JSContext* cx = client->GetScriptInterface().GetContext();
     618
     619    CKickedMessage* message = (CKickedMessage*)event->GetParamRef();
     620    JS::RootedValue msg(cx);
     621    client->GetScriptInterface().Eval("({ 'type': 'kicked' })", &msg);
     622    client->GetScriptInterface().SetProperty(msg, "username", message->m_Name, false);
     623    client->GetScriptInterface().SetProperty(msg, "ban", message->m_Ban, false);
     624    client->PushGuiMessage(msg);
     625
     626    return true;
     627}
     628
    610629bool CNetClient::OnLoadedGame(void* context, CFsmEvent* event)
    611630{
    612631    ENSURE(event->GetType() == (uint)NMT_LOADED_GAME);
    613632
    614633    CNetClient* client = (CNetClient*)context;
  • source/network/NetClient.h

    private:  
    199199    static bool OnInGame(void* context, CFsmEvent* event);
    200200    static bool OnGameStart(void* context, CFsmEvent* event);
    201201    static bool OnJoinSyncStart(void* context, CFsmEvent* event);
    202202    static bool OnJoinSyncEndCommandBatch(void* context, CFsmEvent* event);
    203203    static bool OnRejoined(void* context, CFsmEvent* event);
     204    static bool OnKicked(void* context, CFsmEvent* event);
    204205    static bool OnLoadedGame(void* context, CFsmEvent* event);
    205206
    206207    /**
    207208     * Take ownership of a session object, and use it for all network communication.
    208209     */
  • source/network/NetHost.h

    enum NetDisconnectReason  
    6161{
    6262    NDR_UNKNOWN = 0,
    6363    NDR_UNEXPECTED_SHUTDOWN,
    6464    NDR_INCORRECT_PROTOCOL_VERSION,
    6565    NDR_SERVER_LOADING,
    66     NDR_SERVER_ALREADY_IN_GAME
     66    NDR_SERVER_ALREADY_IN_GAME,
     67    NDR_KICKED,
     68    NDR_BANNED
    6769};
    6870
    6971class CNetHost
    7072{
    7173public:
  • source/network/NetMessage.cpp

    CNetMessage* CNetMessageFactory::CreateM  
    133133
    134134    case NMT_REJOINED:
    135135        pNewMessage = new CRejoinedMessage;
    136136        break;
    137137
     138    case NMT_KICKED:
     139        pNewMessage = new CKickedMessage;
     140        break;
     141
    138142    case NMT_LOADED_GAME:
    139143        pNewMessage = new CLoadedGameMessage;
    140144        break;
    141145
    142146    case NMT_SERVER_HANDSHAKE:
  • source/network/NetMessages.h

     
    2626#include "ps/CStr.h"
    2727#include "scriptinterface/ScriptVal.h"
    2828
    2929#define PS_PROTOCOL_MAGIC               0x5073013f      // 'P', 's', 0x01, '?'
    3030#define PS_PROTOCOL_MAGIC_RESPONSE      0x50630121      // 'P', 'c', 0x01, '!'
    31 #define PS_PROTOCOL_VERSION             0x01010007      // Arbitrary protocol
     31#define PS_PROTOCOL_VERSION             0x01010008      // Arbitrary protocol
    3232#define PS_DEFAULT_PORT                 0x5073          // 'P', 's'
    3333
    3434// Defines the list of message types. The order of the list must not change.
    3535// The message types having a negative value are used internally and not sent
    3636// over the network. The message types used for network communication have
    enum NetMessageType  
    5656    NMT_FILE_TRANSFER_ACK,
    5757
    5858    NMT_JOIN_SYNC_START,
    5959
    6060    NMT_REJOINED,
     61    NMT_KICKED,
    6162
    6263    NMT_LOADED_GAME,
    6364    NMT_GAME_START,
    6465    NMT_END_COMMAND_BATCH,
    6566    NMT_SYNC_CHECK, // OOS-detection hash checking
    END_NMT_CLASS()  
    159160
    160161START_NMT_CLASS_(Rejoined, NMT_REJOINED)
    161162    NMT_FIELD(CStr8, m_GUID)
    162163END_NMT_CLASS()
    163164
     165START_NMT_CLASS_(Kicked, NMT_KICKED)
     166    NMT_FIELD(CStrW, m_Name)
     167    NMT_FIELD_INT(m_Ban, bool, 1)
     168END_NMT_CLASS()
     169
    164170START_NMT_CLASS_(LoadedGame, NMT_LOADED_GAME)
    165171    NMT_FIELD_INT(m_CurrentTurn, u32, 4)
    166172END_NMT_CLASS()
    167173
    168174START_NMT_CLASS_(GameStart, NMT_GAME_START)
  • source/network/NetServer.cpp

    private:  
    119119
    120120CNetServerWorker::CNetServerWorker(int autostartPlayers) :
    121121    m_AutostartPlayers(autostartPlayers),
    122122    m_Shutdown(false),
    123123    m_ScriptInterface(NULL),
    124     m_NextHostID(1), m_Host(NULL), m_Stats(NULL)
     124    m_NextHostID(1), m_Host(NULL), m_HostGUID(), m_Stats(NULL)
    125125{
    126126    m_State = SERVER_STATE_UNCONNECTED;
    127127
    128128    m_ServerTurnManager = NULL;
    129129
    void CNetServerWorker::SetupSession(CNet  
    604604    session->SetFirstState(NSS_HANDSHAKE);
    605605}
    606606
    607607bool CNetServerWorker::HandleConnect(CNetServerSession* session)
    608608{
     609    CNetServerWorker& server = session->GetServer();
     610
     611    // Disconnect banned IPs
     612    if (std::find(server.m_BannedIPs.begin(), server.m_BannedIPs.end(), session->GetIPAddress()) != server.m_BannedIPs.end())
     613    {
     614        session->Disconnect(NDR_BANNED);
     615        return false;
     616    }
     617
     618    // Send handshake challenge
    609619    CSrvHandshakeMessage handshake;
    610620    handshake.m_Magic = PS_PROTOCOL_MAGIC;
    611621    handshake.m_ProtocolVersion = PS_PROTOCOL_VERSION;
    612622    handshake.m_SoftwareVersion = PS_PROTOCOL_VERSION;
    613623    return session->SendMessage(&handshake);
    bool CNetServerWorker::HandleConnect(CNe  
    615625
    616626void CNetServerWorker::OnUserJoin(CNetServerSession* session)
    617627{
    618628    AddPlayer(session->GetGUID(), session->GetUserName());
    619629
     630    // Host is the first to join
     631    if (m_HostGUID.empty())
     632        m_HostGUID = session->GetGUID();
     633
    620634    CGameSetupMessage gameSetupMessage(GetScriptInterface());
    621635    gameSetupMessage.m_Data = m_GameAttributes.get();
    622636    session->SendMessage(&gameSetupMessage);
    623637
    624638    CPlayerAssignmentMessage assignMessage;
    void CNetServerWorker::ClearAllPlayerRea  
    707721        it->second.m_Status = 0;
    708722
    709723    SendPlayerAssignments();
    710724}
    711725
     726void CNetServerWorker::KickPlayer(const CStrW& playerName, const bool ban)
     727{
     728    // Find the user with that name
     729    std::vector<CNetServerSession*>::iterator it = std::find_if(m_Sessions.begin(), m_Sessions.end(),
     730        [&](CNetServerSession* session) { return session->GetUserName() == playerName; });
     731
     732    // and return if no one or the host has that name
     733    if (it == m_Sessions.end() || (*it)->GetGUID() == m_HostGUID)
     734        return;
     735
     736    if (ban)
     737    {
     738        // Remember name
     739        if (std::find(m_BannedPlayers.begin(), m_BannedPlayers.end(), playerName) == m_BannedPlayers.end())
     740            m_BannedPlayers.push_back(playerName);
     741
     742        // Remember IP address
     743        CStr ipAddress = GetPlayerIPAddress(playerName);
     744        if (std::find(m_BannedIPs.begin(), m_BannedIPs.end(), ipAddress) == m_BannedIPs.end())
     745            m_BannedIPs.push_back(ipAddress);
     746    }
     747
     748    // Disconnect that user
     749    (*it)->Disconnect(ban ? NDR_BANNED : NDR_KICKED);
     750
     751    // Send message notifying other clients
     752    CKickedMessage kickedMessage;
     753    kickedMessage.m_Name = playerName;
     754    kickedMessage.m_Ban = ban;
     755    Broadcast(&kickedMessage);
     756}
     757
     758CStr CNetServerWorker::GetPlayerIPAddress(const CStrW& playerName)
     759{
     760    for (CNetServerSession* session : m_Sessions)
     761        if (session->GetUserName() == playerName)
     762            return session->GetIPAddress();
     763    return "(error)";
     764}
     765
    712766void CNetServerWorker::AssignPlayer(int playerID, const CStr& guid)
    713767{
    714768    // Remove anyone who's already assigned to this player
    715769    for (PlayerAssignmentMap::iterator it = m_PlayerAssignments.begin(); it != m_PlayerAssignments.end(); ++it)
    716770    {
    bool CNetServerWorker::OnClientHandshake  
    764818    ENSURE(event->GetType() == (uint)NMT_CLIENT_HANDSHAKE);
    765819
    766820    CNetServerSession* session = (CNetServerSession*)context;
    767821    CNetServerWorker& server = session->GetServer();
    768822
     823    // Check protocol version
    769824    CCliHandshakeMessage* message = (CCliHandshakeMessage*)event->GetParamRef();
    770825    if (message->m_ProtocolVersion != PS_PROTOCOL_VERSION)
    771826    {
    772827        session->Disconnect(NDR_INCORRECT_PROTOCOL_VERSION);
    773828        return false;
    774829    }
    775830
     831    // Send handshake response
    776832    CSrvHandshakeResponseMessage handshakeResponse;
    777833    handshakeResponse.m_UseProtocolVersion = PS_PROTOCOL_VERSION;
    778834    handshakeResponse.m_Message = server.m_WelcomeMessage;
    779835    handshakeResponse.m_Flags = 0;
    780836    session->SendMessage(&handshakeResponse);
    bool CNetServerWorker::OnAuthenticate(vo  
    798854    }
    799855
    800856    CAuthenticateMessage* message = (CAuthenticateMessage*)event->GetParamRef();
    801857    CStrW username = server.DeduplicatePlayerName(SanitisePlayerName(message->m_Name));
    802858
     859    // Disconnect banned usernames
     860    if (std::find(server.m_BannedPlayers.begin(), server.m_BannedPlayers.end(), username) != server.m_BannedPlayers.end())
     861    {
     862        session->Disconnect(NDR_BANNED);
     863        return true;
     864    }
     865
    803866    // Optionally allow observers to join after the game has started
    804867    bool observerLateJoin = false;
    805868    ScriptInterface& scriptInterface = server.GetScriptInterface();
    806869    JSContext* cx = scriptInterface.GetContext();
    807870    JSAutoRequest rq(cx);
    CNetServer::~CNetServer()  
    11471210bool CNetServer::SetupConnection()
    11481211{
    11491212    return m_Worker->SetupConnection();
    11501213}
    11511214
     1215void CNetServer::KickPlayer(const CStrW& playerName, const bool ban)
     1216{
     1217    CScopeLock lock(m_Worker->m_WorkerMutex);
     1218    m_Worker->KickPlayer(playerName, ban);
     1219}
     1220
    11521221void CNetServer::AssignPlayer(int playerID, const CStr& guid)
    11531222{
    11541223    CScopeLock lock(m_Worker->m_WorkerMutex);
    11551224    m_Worker->m_AssignPlayerQueue.emplace_back(playerID, guid);
    11561225}
  • source/network/NetServer.h

    public:  
    132132    /**
    133133     * Call from the GUI to set the all player readiness to 0.
    134134     * The changes will be asynchronously propagated to all clients.
    135135     */
    136136    void ClearAllPlayerReady();
    137    
     137
     138    /**
     139     * Disconnects a player from the gamesetup / session.
     140     */
     141    void KickPlayer(const CStrW& playerName, const bool ban);
     142
    138143    /**
    139144     * Call from the GUI to asynchronously notify all clients that they should start loading the game.
    140145     */
    141146    void StartGame();
    142147
    public:  
    181186     * Send a message to the given network peer.
    182187     */
    183188    bool SendMessage(ENetPeer* peer, const CNetMessage* message);
    184189
    185190    /**
     191     * Disconnected a player from the match / gamesetup and optionally prevents him/her from rejoining.
     192     */
     193    void KickPlayer(const CStrW& playerName, const bool ban);
     194
     195    /**
    186196     * Send a message to all clients who have completed the full connection process
    187197     * (i.e. are in the pre-game or in-game states).
    188198     */
    189199    bool Broadcast(const CNetMessage* message);
    190200
     201    /**
     202     * Returns the IP address of the given connected player.
     203     */
     204    CStr GetPlayerIPAddress(const CStrW& playerName);
     205
    191206private:
    192207    friend class CNetServer;
    193208    friend class CNetFileReceiveTask_ServerRejoin;
    194209
    195210    CNetServerWorker(int autostartPlayers);
    private:  
    244259    void SetTurnLength(u32 msecs);
    245260
    246261    void AddPlayer(const CStr& guid, const CStrW& name);
    247262    void RemovePlayer(const CStr& guid);
    248263    void SetPlayerReady(const CStr& guid, const int ready);
     264    CStr GetHostGUID();
    249265    void SendPlayerAssignments();
    250266    void ClearAllPlayerReady();
    251267
    252268    void SetupSession(CNetServerSession* session);
    253269    bool HandleConnect(CNetServerSession* session);
    private:  
    297313    NetServerState m_State;
    298314
    299315    CStrW m_ServerName;
    300316    CStrW m_WelcomeMessage;
    301317
     318    std::vector<CStr> m_BannedIPs;
     319    std::vector<CStrW> m_BannedPlayers;
     320
    302321    u32 m_NextHostID;
    303322
    304323    CNetServerTurnManager* m_ServerTurnManager;
    305324
     325    CStr m_HostGUID;
     326
    306327    /**
    307328     * A copy of all simulation commands received so far, indexed by
    308329     * turn number, to simplify support for rejoining etc.
    309330     * TODO: verify this doesn't use too much RAM.
    310331     */
  • source/network/NetSession.cpp

     
    1 /* Copyright (C) 2011 Wildfire Games.
     1/* Copyright (C) 2015 Wildfire Games.
    22 * This file is part of 0 A.D.
    33 *
    44 * 0 A.D. is free software: you can redistribute it and/or modify
    55 * it under the terms of the GNU General Public License as published by
    66 * the Free Software Foundation, either version 2 of the License, or
    bool CNetClientSession::SendMessage(cons  
    173173CNetServerSession::CNetServerSession(CNetServerWorker& server, ENetPeer* peer) :
    174174    m_Server(server), m_FileTransferer(this), m_Peer(peer)
    175175{
    176176}
    177177
     178CStr CNetServerSession::GetIPAddress()
     179{
     180    char ipAddress[256] = "(error)";
     181    enet_address_get_host_ip(&(m_Peer->address), ipAddress, ARRAY_SIZE(ipAddress));
     182    return CStr(ipAddress);
     183}
     184
    178185void CNetServerSession::Disconnect(u32 reason)
    179186{
    180187    Update((uint)NMT_CONNECTION_LOST, NULL);
    181188
    182189    enet_peer_disconnect(m_Peer, reason);
  • source/network/NetSession.h

     
    1 /* Copyright (C) 2011 Wildfire Games.
     1/* Copyright (C) 2015 Wildfire Games.
    22 * This file is part of 0 A.D.
    33 *
    44 * 0 A.D. is free software: you can redistribute it and/or modify
    55 * it under the terms of the GNU General Public License as published by
    66 * the Free Software Foundation, either version 2 of the License, or
    public:  
    121121
    122122    u32 GetHostID() const { return m_HostID; }
    123123    void SetHostID(u32 id) { m_HostID = id; }
    124124
    125125    /**
     126     * Returns the IP address of the client.
     127     */
     128    CStr GetIPAddress();
     129
     130    /**
    126131     * Sends a disconnection notification to the client,
    127132     * and sends a NMT_CONNECTION_LOST message to the session FSM.
    128133     * The server will receive a disconnection notification after a while.
    129134     * The server will not receive any further messages sent via this session.
    130135     */