Ticket #3391: t3391_fix_sortable_list_column_header_v1.patch

source/gui/COList.cpp

@@ -143 +143 @@
     {
     // If somebody clicks on the column heading
     case GUIM_MOUSE_PRESS_LEFT:
     {
         bool sortable;
         GUI<bool>::GetSetting(this, "sortable", sortable);
         if (!sortable)
             return;
 
         CPos mouse = GetMousePos();
         if (!m_CachedActualSize.PointInside(mouse))
             return;
 
         float xpos = 0;
         for (size_t def = 0; def < m_ObjectsDefs.size(); ++def)
         {
             float width = m_ObjectsDefs[def].m_Width;
             // Check if it's a decimal value, and if so, assume relative positioning.
             if (m_ObjectsDefs[def].m_Width < 1 && m_ObjectsDefs[def].m_Width > 0)
                 width *= m_TotalAvalibleColumnWidth;
-            CPos leftTopCorner = m_CachedActualSize.TopLeft() + CPos(xpos, 4);
+            CPos leftTopCorner = m_CachedActualSize.TopLeft() + CPos(xpos, 0);
             if (mouse.x >= leftTopCorner.x &&
                 mouse.x < leftTopCorner.x + width &&
                 mouse.y < leftTopCorner.y + m_HeadingHeight)
             {
                 if (def != m_SelectedDef)
                 {
                     m_SelectedColumnOrder = 1;
                     m_SelectedDef = def;
                 }
                 else
                     m_SelectedColumnOrder = -m_SelectedColumnOrder;
                 GUI<CStr>::SetSetting(this, "selected_column", m_ObjectsDefs[def].m_Id.substr(5));
                 GUI<int>::SetSetting(this, "selected_column_order", m_SelectedColumnOrder);
                 GUI<int>::SetSetting(this, "selected_def", def);
                 ScriptEvent("selectioncolumnchange");
 
                 CStrW soundPath;
                 if (g_SoundManager && GUI<CStrW>::GetSetting(this, "sound_selected", soundPath) == PSRETURN_OK && !soundPath.empty())
                     g_SoundManager->PlayAsUI(soundPath.c_str(), false);