Ticket #3551: t3551_prohibit_all_cheats_for_rated_games_v2.patch

binaries/data/mods/public/simulation/components/GuiInterface.js

@@ -25 +25 @@
 {
     this.placementEntity = undefined; // = undefined or [templateName, entityID]
     this.placementWallEntities = undefined;
     this.placementWallLastAngle = 0;
     this.notifications = [];
+    this.ratingEnabled = false;
     this.renamedEntities = [];
     this.miragedEntities = [];
     this.timeNotificationID = 1;
     this.timeNotifications = [];
     this.entsRallyPointsDisplayed = [];
@@ -157 +158 @@
     }
 
     return ret;
 };
 
+GuiInterface.prototype.IsRatedGame = function()
+{
+    return this.ratingEnabled;
+}
+
+GuiInterface.prototype.SetRatedGame = function(enabled)
+{
+    this.ratingEnabled = enabled;
+}
+
 /**
  * Returns global information about the current game state, plus statistics.
  * This is used by the GUI at the end of a game, in the summary screen.
  * Note: Amongst statistics, the team exploration map percentage is computed from
  * scratch, so the extended simulation state should not be requested too often.

binaries/data/mods/public/simulation/helpers/Commands.js

@@ -98 +98 @@
         data.cmpPlayer.TributeResource(cmd.player, cmd.amounts);
     },
 
     "control-all": function(player, cmd, data)
     {
+        var cmpGuiInterface = Engine.QueryInterface(SYSTEM_ENTITY, IID_GuiInterface);
+        if (cmpGuiInterface.IsRatedGame())
+            return;
+
         data.cmpPlayer.SetControlAllUnits(cmd.flag);
     },
 
     "reveal-map": function(player, cmd, data)
     {
+        var cmpGuiInterface = Engine.QueryInterface(SYSTEM_ENTITY, IID_GuiInterface);
+        if (cmpGuiInterface.IsRatedGame())
+            return;
+
         // Reveal the map for all players, not just the current player,
         // primarily to make it obvious to everyone that the player is cheating
         var cmpRangeManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_RangeManager);
         cmpRangeManager.SetLosRevealAll(-1, cmd.enable);
     },
@@ -552 +560 @@
         });
     },
 
     "promote": function(player, cmd, data)
     {
-        // No need to do checks here since this is a cheat anyway
         var cmpGuiInterface = Engine.QueryInterface(SYSTEM_ENTITY, IID_GuiInterface);
+        if (cmpGuiInterface.IsRatedGame())
+            return;
+
         cmpGuiInterface.PushNotification({"type": "chat", "players": [player], "message": "(Cheat - promoted units)"});
 
         for each (var ent in cmd.entities)
         {
             var cmpPromotion = Engine.QueryInterface(ent, IID_Promotion);

binaries/data/mods/public/simulation/helpers/InitGame.js

@@ -39 +39 @@
         let cmpRangeManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_RangeManager);
         for (let i = 1; i < settings.PlayerData.length; ++i)
             cmpRangeManager.ExploreAllTiles(i);
     }
 
+    // TODO: cheats should also be saved in the GuiInterface instead of the Player component
+    let cmpGuiInterface = Engine.QueryInterface(SYSTEM_ENTITY, IID_GuiInterface);
+    cmpGuiInterface.SetRatedGame(settings.RatingEnabled);
+
     let cmpPlayerManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_PlayerManager);
     let cmpAIManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_AIManager);
     for (let i = 1; i < settings.PlayerData.length; ++i)
     {
         let cmpPlayer = Engine.QueryInterface(cmpPlayerManager.GetPlayerByID(i), IID_Player);