Ticket #3586: headquarters_js_v2.patch

binaries/data/mods/public/simulation/ai/petra/headquarters.js

@@ -29 +29 @@
 
     // workers configuration
     this.targetNumWorkers = this.Config.Economy.targetNumWorkers;
-    this.femaleRatio = this.Config.Economy.femaleRatio;
+    this.workerRatio = this.Config.Economy.workerRatio;
 
     this.lastTerritoryUpdate = -1;
     this.stopBuilding = new Map(); // list of buildings to stop (temporarily) production because no room
@@ -211 +211 @@
             ent.setMetadata(PlayerID, "role", undefined);
             ent.setMetadata(PlayerID, "subrole", undefined);
             ent.setMetadata(PlayerID, "plan", undefined);
-            ent.setMetadata(PlayerID, "PartOfArmy", undefined);     
+            ent.setMetadata(PlayerID, "PartOfArmy", undefined);
             if (ent.hasClass("Trader"))
             {
                 ent.setMetadata(PlayerID, "role", "trader");
                 ent.setMetadata(PlayerID, "route", undefined);
             }
-            if (ent.hasClass("Female") || ent.hasClass("CitizenSoldier"))
+            if (ent.hasClass("Worker"))
             {
                 ent.setMetadata(PlayerID, "role", "worker");
                 ent.setMetadata(PlayerID, "subrole", "idle");
@@ -379 +379 @@
 // Called by the "town phase" research plan once it's started
 m.HQ.prototype.OnTownPhase = function(gameState)
 {
-    if (this.Config.difficulty > 2 && this.femaleRatio > 0.4)
-        this.femaleRatio = 0.4;
+    if (this.Config.difficulty > 2 && this.workerRatio > 0.4)
+        this.workerRatio = 0.4;
 
     var phaseName = gameState.getTemplate(gameState.townPhase()).name();
     m.chatNewPhase(gameState, phaseName, true);
@@ -389 +389 @@
 // Called by the "city phase" research plan once it's started
 m.HQ.prototype.OnCityPhase = function(gameState)
 {
-    if (this.Config.difficulty > 2 && this.femaleRatio > 0.3)
-        this.femaleRatio = 0.3;
+    if (this.Config.difficulty > 2 && this.workerRatio > 0.3)
+        this.workerRatio = 0.3;
 
     // increase the priority of defense buildings to free this queue for our first fortress
     gameState.ai.queueManager.changePriority("defenseBuilding", 2*this.Config.priorities.defenseBuilding);
@@ -399 +399 @@
     m.chatNewPhase(gameState, phaseName, true);
 };
 
-// This code trains females and citizen workers, trying to keep close to a ratio of females/CS
-// TODO: this should choose a base depending on which base need workers
-// TODO: also there are several things that could be greatly improved here.
+// This code trains citizen workers, trying to keep close to a ratio of worker/soldiers
 m.HQ.prototype.trainMoreWorkers = function(gameState, queues)
 {
-    // Count the workers in the world and in progress
-    var numFemales = gameState.countEntitiesAndQueuedByType(gameState.applyCiv("units/{civ}_support_female_citizen"), true);
+    // default template
+    var requirementsDef = [["cost", 1], ["costsResource", 1, "food"]];
+    var classesDef = ["Support", "Worker"];
+    var templateDef = this.findBestTrainableUnit(gameState, classesDef, requirementsDef);
 
+    // Count the workers in the world and in progress
+    var numberOfWorkers = gameState.countEntitiesAndQueuedByType(templateDef);
+
     // counting the workers that aren't part of a plan
-    var numWorkers = 0;
+    var numberOfIddleWorkers = 0;
     gameState.getOwnUnits().forEach (function (ent) {
         if (ent.getMetadata(PlayerID, "role") == "worker" && ent.getMetadata(PlayerID, "plan") == undefined)
-            ++numWorkers;
+            ++numberOfIddleWorkers;
     });
-    var numInTraining = 0;
+    var numberOfWorkersInTraining = 0;
     gameState.getOwnTrainingFacilities().forEach(function(ent) {
         ent.trainingQueue().forEach(function(item) {
             if (item.metadata && item.metadata.role && item.metadata.role == "worker" && item.metadata.plan == undefined)
-                numWorkers += item.count;
-            numInTraining += item.count;
+                numberOfIddleWorkers += item.count;
+            numberOfWorkersInTraining += item.count;
         });
     });
 
     // Anticipate the optimal batch size when this queue will start
-    // and adapt the batch size of the first and second queued workers and females to the present population
+    // and adapt the batch size of the first and second queued workers to the present population
     // to ease a possible recovery if our population was drastically reduced by an attack
     // (need to go up to second queued as it is accounted in queueManager)
-    var size = numWorkers < 12 ? 1 : Math.min(5, Math.ceil(numWorkers / 10));
+    var size = numberOfIddleWorkers < 12 ? 1 : Math.min(5, Math.ceil(numberOfIddleWorkers / 10));
     if (queues.villager.plans[0])
     {
         queues.villager.plans[0].number = Math.min(queues.villager.plans[0].number, size);
@@ -440 +443 @@
             queues.citizenSoldier.plans[1].number = Math.min(queues.citizenSoldier.plans[1].number, size);
     }
 
-    var numQueuedF = queues.villager.countQueuedUnits();
-    var numQueuedS = queues.citizenSoldier.countQueuedUnits();
-    var numQueued = numQueuedS + numQueuedF;
-    var numTotal = numWorkers + numQueued;
+    var numberOfQueuedWorkers = queues.villager.countQueuedUnits();
+    var numberOfQueuedSoldiers = queues.citizenSoldier.countQueuedUnits();
+    var numberQueued = numberOfQueuedSoldiers + numberOfQueuedWorkers;
+    var numberTotal = numberOfIddleWorkers + numberQueued;
 
-    if (this.saveResources && numTotal > this.Config.Economy.popForTown + 10)
+    if (this.saveResources && numberTotal > this.Config.Economy.popForTown + 10)
         return;
-    if (numTotal > this.targetNumWorkers || (numTotal >= this.Config.Economy.popForTown &&
+    if (numberTotal > this.targetNumWorkers || (numberTotal >= this.Config.Economy.popForTown &&
         gameState.currentPhase() == 1 && !gameState.isResearching(gameState.townPhase())))
         return;
-    if (numQueued > 50 || (numQueuedF > 20 && numQueuedS > 20) || numInTraining > 15)
+    if (numberQueued > 50 || (numberOfQueuedWorkers > 20 && numberOfQueuedSoldiers > 20) || numberOfWorkersInTraining > 15)
         return;
 
-    // default template
-    var templateDef = gameState.applyCiv("units/{civ}_support_female_citizen");
     // Choose whether we want soldiers instead.
-    let femaleRatio = (gameState.isDisabledTemplates(gameState.applyCiv("structures/{civ}_field")) ? Math.min(this.femaleRatio, 0.2) : this.femaleRatio);
+    let workerRatio = (gameState.isDisabledTemplates(gameState.applyCiv("structures/{civ}_field")) ? Math.min(this.workerRatio, 0.2) : this.workerRatio);
     let template;
-    if (!gameState.templates[templateDef] || ((numFemales+numQueuedF) > 8 && (numFemales+numQueuedF)/numTotal > femaleRatio))
+    if ((numberOfWorkers + numberOfQueuedWorkers) > 8 && (numberOfWorkers + numberOfQueuedWorkers)/numberTotal > workerRatio)
     {
         let requirements;
-        if (numTotal < 45)
+        if (numberTotal < 45)
             requirements = [ ["cost", 1], ["speed", 0.5], ["costsResource", 0.5, "stone"], ["costsResource", 0.5, "metal"]];
         else
             requirements = [ ["strength", 1] ];
 
+        var classes = ["CitizenSoldier", "Infantry"];
         let proba = Math.random();
-        if (proba < 0.6)
-        {   // we require at least 30% ranged and 30% melee
-            let classes = proba < 0.3 ? ["CitizenSoldier", "Infantry", "Ranged"] : ["CitizenSoldier", "Infantry", "Melee"];
-            template = this.findBestTrainableUnit(gameState, classes, requirements);
-        }
-        if (!template)
-            template = this.findBestTrainableUnit(gameState, ["CitizenSoldier", "Infantry"], requirements);
+        //  we require at least 30% ranged and 30% melee
+        if ( proba < 0.3 )
+            classes.push("Ranged")
+        else if ( proba < 0.6 )
+            classes.push("Melee");
+
+        template = this.findBestTrainableUnit(gameState, classes, requirements);
     }
-    if (!template && gameState.templates[templateDef])
-        template = templateDef;
 
+    // If the template variable is empty, the default unit (Support unit)
+    // would be used in the next turn
+    //
     // base "0" means "auto"
-    if (template === gameState.applyCiv("units/{civ}_support_female_citizen"))
-        queues.villager.addPlan(new m.TrainingPlan(gameState, template, { "role": "worker", "base": 0 }, size, size));
+    if (!template && gameState.templates[templateDef])
+        queues.villager.addPlan(new m.TrainingPlan(gameState, templateDef, { "role": "worker", "base": 0 }, size, size));
     else if (template)
         queues.citizenSoldier.addPlan(new m.TrainingPlan(gameState, template, { "role": "worker", "base": 0 }, size, size));
 };
@@ -504 +507 @@
     var availableResources = gameState.ai.queueManager.getAvailableResources(gameState); // available (gathered) resources
     for (let type in remainingResources)
     {
-        if (type === "food")
-            continue;
         if (availableResources[type] > 800)
             continue;
         if (remainingResources[type] > 800)
@@ -638 +639 @@
         }
         this.turnCache.gatherRates = true;
     }
-    
+
     return this.currentRates;
 };
 
@@ -2065 +2066 @@
         "wantedRates": this.wantedRates,
         "currentRates": this.currentRates,
         "lastFailedGather": this.lastFailedGather,
-        "femaleRatio": this.femaleRatio,
+        "workerRatio": this.workerRatio,
         "targetNumWorkers": this.targetNumWorkers,
         "lastTerritoryUpdate": this.lastTerritoryUpdate,
         "stopBuilding": this.stopBuilding,