Ticket #3736: idleworker_V2.2.patch

binaries/data/mods/public/gui/session/minimap_panel.xml

@@ -7 +7 @@
 >
     <!-- Idle Worker Button -->
     <object size="100%-80 100%-80 100%-5 100%-5">
-        <!-- TODO: We should disable this button if there are no idle workers. -->
         <object type="button"
             tooltip_style="sessionToolTip"
             hotkey="selection.idleworker"
         >
             <translatableAttribute id="tooltip">Find idle worker</translatableAttribute>
-            <action on="Press">findIdleUnit(["Female", "Trader", "FishingBoat", "CitizenSoldier", "Healer"]);</action>
-            <action on="MouseEnter">Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle-highlight.png";</action>
-            <action on="MouseLeave">Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle.png";</action>
-            <action on="MouseLeftPress">Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle.png";</action>
-            <action on="MouseLeftRelease">Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle-highlight.png";</action>
+            <action on="Press">if (g_HasIdleWorker) findIdleUnit(g_WorkerTypes);</action>
+            <action on="MouseEnter">if (g_HasIdleWorker) Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle-highlight.png";</action>
+            <action on="MouseLeave">if (g_HasIdleWorker) Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle.png";</action>
+            <action on="MouseLeftPress">if (g_HasIdleWorker) Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle.png";</action>
+            <action on="MouseLeftRelease">if (g_HasIdleWorker) Engine.GetGUIObjectByName("idleOverlay").sprite = "stretched:session/minimap-idle-highlight.png";</action>
         </object>
     </object>
     <!-- Minimap -->

binaries/data/mods/public/gui/session/session.js

@@ -79 +79 @@
 var g_TemplateDataWithoutLocalization = {};
 var g_TechnologyData = {}; // {id:template}
 
+// List of unit types those are workers
+var g_WorkerTypes = ["Female", "Trader", "FishingBoat", "CitizenSoldier", "Healer"];
+
+// Cache the idle worker status
+var g_HasIdleWorker = false;
+
 function GetSimState()
 {
     if (!g_SimState)
@@ -529 +535 @@
         Engine.SetSimRate(speed);
 }
 
+function checkIdleWorkerState()
+{
+    for (let i = 0; i < g_WorkerTypes.length; ++i)
+    {
+        let idleUnits = Engine.GuiInterfaceCall("FindIdleUnits", {
+            "idleClass": g_WorkerTypes[i],
+            "prevUnit": undefined,
+            "limit": 1,
+            "excludeUnits": []
+        });
+        
+        if (idleUnits.length > 0) {
+            g_HasIdleWorker = true;
+            return;
+        }
+    }
+
+    // no idle workers available
+    g_HasIdleWorker = false;
+}
+
+function updateIdleWorkerButton()
+{
+    let idleWorkerButton = Engine.GetGUIObjectByName("idleOverlay");
+
+    // update state
+    checkIdleWorkerState();
+
+    // determine right button image
+    let newImage;
+    if (g_HasIdleWorker) {
+        let highlightedImage = "minimap-idle-highlight.png";
+        newImage = (idleWorkerButton.sprite == "stretched:session/" + highlightedImage) ? highlightedImage : "minimap-idle.png";
+    }
+    else
+        newImage = "minimap-idle-disabled.png";
+
+    // update image of gui button
+    idleWorkerButton.sprite = "stretched:session/" + newImage;
+}
+
 /**
  * Recomputes GUI state that depends on simulation state or selection state. Called directly every simulation
  * update (see session.xml), or from onTick when the selection has changed.
@@ -562 +609 @@
     updateSelectionDetails();
     updateBuildingPlacementPreview();
     updateTimeNotifications();
+    updateIdleWorkerButton();
 
     if (!g_IsObserver)
         updateResearchDisplay();