Ticket #3883: persist_match_settings.patch

binaries/data/mods/public/gui/gamesetup/gamesetup.js

@@ -863 +863 @@
     if (Engine.ConfigDB_GetValue("user", "persistmatchsettings") != "true")
         return;
 
+    // Load file
     let settingsFile = g_IsNetworked ? g_MatchSettings_MP : g_MatchSettings_SP;
     if (!Engine.FileExists(settingsFile))
         return;
@@ -871 +872 @@
     if (!attrs || !attrs.settings)
         return;
 
+    // Find which settings can be changed by the user
+    let allowedSettings = ["PlayerData"];
+
+    if (attrs.mapType == "skirmish")
+        allowedSettings = allowedSettings.concat(["GameType", "VictoryScripts", "WonderDuration", "PopulationCap", "Ceasefire", "StartingResources", "RevealMap", "LockTeams", "ExploreMap", "DisableTreasures"]);
+
+    if (attrs.mapType == "random")
+        allowedSettings = allowedSettings.concat(["Size", "GameType", "VictoryScripts", "WonderDuration", "PopulationCap", "Ceasefire", "StartingResources", "RevealMap", "LockTeams", "ExploreMap", "DisableTreasures"]);
+
+    attrs.settings.RatingEnabled = Engine.HasXmppClient();
+    Engine.SetRankedGame(attrs.settings.RatingEnabled);
+
+    if (g_IsNetworked && !attrs.settings.RatingEnabled)
+        allowedSettings.push("CheatsEnabled");
+
+    // Only load settings which can be changed by the user
+    for (let prop in attrs.settings)
+        if (!prop in allowedSettings)
+            delete attrs.settings[prop];
+
+    // Restore valid matchsettings
     g_IsInGuiUpdate = true;
 
     let mapName = attrs.map || "";
@@ -908 +930 @@
     // Reload, as the maptype or mapfilter might have changed
     initMapNameList();
 
-    g_GameAttributes.settings.RatingEnabled = Engine.HasXmppClient();
-    Engine.SetRankedGame(g_GameAttributes.settings.RatingEnabled);
-
     updateGUIObjects();
 }