Ticket #4112: hidereadybutton2.patch

binaries/data/mods/public/gui/gamesetup/gamesetup.js

@@ -538 +538 @@
         Engine.GetGUIObjectByName("playerAssignment["+i+"]").hidden = true;
         Engine.GetGUIObjectByName("playerCiv["+i+"]").hidden = true;
         Engine.GetGUIObjectByName("playerTeam["+i+"]").hidden = true;
     }
 
+    // The start game button should be hidden until the player assignments are received
+    // and it is known whether the local player is an observer.
+    Engine.GetGUIObjectByName("startGame").hidden = true;
     Engine.GetGUIObjectByName("startGame").enabled = true;
 }
 
 /**
  * Hides the GUI controls for clients and shows the read-only label instead.
@@ -728 +731 @@
         if (!message.newAssignments[guid])
             onClientLeave(guid);
 
     g_PlayerAssignments = message.newAssignments;
 
+    Engine.GetGUIObjectByName("startGame").hidden = !g_IsController && g_PlayerAssignments[Engine.GetPlayerGUID()].player == -1;
+
     updatePlayerList();
     updateReadyUI();
     sendRegisterGameStanza();
 }