Ticket #4112: hidereadybutton5.patch

binaries/data/mods/public/gui/gamesetup/gamesetup.js

@@ -522 +522 @@
         g_GameAttributes.settings.LastManStanding = false;
         updateGameAttributes();
     };
 }
 
+function hideStartGameButton(hidden)
+{
+    if (Engine.GetGUIObjectByName("startGame").hidden == hidden)
+        return;
+
+    Engine.GetGUIObjectByName("startGame").hidden = hidden;
+    let offset = hidden ? 144 : -144;
+
+    // Move the cheatWarningText and back button to the right when hidden.
+    let cancelGameSize = Engine.GetGUIObjectByName("cancelGame").size;
+    cancelGameSize.left += offset;
+    cancelGameSize.right += offset;
+
+    Engine.GetGUIObjectByName("cancelGame").size = cancelGameSize;
+
+    let cheatWarningTextSize = Engine.GetGUIObjectByName("cheatWarningText").size;
+    cheatWarningTextSize.right += offset;
+    Engine.GetGUIObjectByName("cheatWarningText").size = cheatWarningTextSize;
+
+    // Increase the size of onscreenToolTip when hidden.
+    let onscreenToolTipSize = Engine.GetGUIObjectByName("onscreenToolTip").size;
+    onscreenToolTipSize.right += offset;
+    Engine.GetGUIObjectByName("onscreenToolTip").size = onscreenToolTipSize;
+}
+
 /**
  * If we're a network client, hide the controls and show the text instead.
  */
 function hideControls()
 {
@@ -538 +563 @@
         Engine.GetGUIObjectByName("playerAssignment["+i+"]").hidden = true;
         Engine.GetGUIObjectByName("playerCiv["+i+"]").hidden = true;
         Engine.GetGUIObjectByName("playerTeam["+i+"]").hidden = true;
     }
 
+    // The start game button should be hidden until the player assignments are received
+    // and it is known whether the local player is an observer.
+    hideStartGameButton(true);
     Engine.GetGUIObjectByName("startGame").enabled = true;
 }
 
 /**
  * Hides the GUI controls for clients and shows the read-only label instead.
@@ -728 +756 @@
         if (!message.newAssignments[guid])
             onClientLeave(guid);
 
     g_PlayerAssignments = message.newAssignments;
 
+    hideStartGameButton(!g_IsController && g_PlayerAssignments[Engine.GetPlayerGUID()].player == -1);
+
     updatePlayerList();
     updateReadyUI();
     sendRegisterGameStanza();
 }