Ticket #4112: hidereadybutton8.patch

binaries/data/mods/public/gui/gamesetup/gamesetup.js

@@ -522 +522 @@
         g_GameAttributes.settings.LastManStanding = false;
         updateGameAttributes();
     };
 }
 
+function hideStartGameButton(hidden)
+{
+    const offset = 10;
+
+    Engine.GetGUIObjectByName("startGame").hidden = hidden;
+    let startGame = Engine.GetGUIObjectByName("startGame");
+    let right = hidden ? startGame.size.right : startGame.size.left - offset;
+
+    let cancelGameSize = Engine.GetGUIObjectByName("cancelGame").size;
+    let xButtonSize = cancelGameSize.right - cancelGameSize.left;
+    cancelGameSize.right = right;
+    right -= xButtonSize;
+
+    for (let element of ["cheatWarningText", "onscreenToolTip"])
+    {
+        let elementSize = Engine.GetGUIObjectByName(element).size;
+        elementSize.right = right - (cancelGameSize.left - elementSize.right);
+        Engine.GetGUIObjectByName(element).size = elementSize;
+    }
+
+    cancelGameSize.left = right;
+    Engine.GetGUIObjectByName("cancelGame").size = cancelGameSize;
+}
+
 /**
  * If we're a network client, hide the controls and show the text instead.
  */
 function hideControls()
 {
@@ -538 +562 @@
         Engine.GetGUIObjectByName("playerAssignment["+i+"]").hidden = true;
         Engine.GetGUIObjectByName("playerCiv["+i+"]").hidden = true;
         Engine.GetGUIObjectByName("playerTeam["+i+"]").hidden = true;
     }
 
+    // The start game button should be hidden until the player assignments are received
+    // and it is known whether the local player is an observer.
+    hideStartGameButton(true);
     Engine.GetGUIObjectByName("startGame").enabled = true;
 }
 
 /**
  * Hides the GUI controls for clients and shows the read-only label instead.
@@ -728 +755 @@
         if (!message.newAssignments[guid])
             onClientLeave(guid);
 
     g_PlayerAssignments = message.newAssignments;
 
+    hideStartGameButton(!g_IsController && g_PlayerAssignments[Engine.GetPlayerGUID()].player == -1);
+
     updatePlayerList();
     updateReadyUI();
     sendRegisterGameStanza();
 }