Ticket #4145: autocomplete_hotkey_tooltips_v1.patch

binaries/data/mods/public/gui/common/color.js

@@ -142 +142 @@
             "[color=\"" + g_HotkeyColor + "\"]" +
             "\\[" + key + "]" +
             "[/color]"
     });
 }
+
+/**
+ * The autocomplete hotkey is hardcoded in SDLK_TAB of CInput.cpp,
+ * as we don't want hotkeys interfering with typing text.
+ */
+function colorizeAutocompleteHotkey()
+{
+    return sprintf(translate("Press %(hotkey)s to autocomplete playernames."), {
+        "hotkey": "[color=\"" + g_HotkeyColor + "\"]" + "\\[Tab]" + "[/color]"
+    });
+}

binaries/data/mods/public/gui/gamesetup/gamesetup.js

@@ -522 +522 @@
         g_GameAttributes.settings.LastManStanding = false;
         updateGameAttributes();
     };
 }
 
+function updateTooltips()
+{
+    Engine.GetGUIObjectByName("chatInput").tooltip = colorizeAutocompleteHotkey();
+}
+
 /**
  * If we're a network client, hide the controls and show the text instead.
  */
 function hideControls()
 {
@@ -1456 +1461 @@
             pColorPicker.selected = g_PlayerColors.findIndex(col => sameColor(col, color));
     }
 
     updateMapDescription();
     resizeMoreOptionsWindow();
+    updateTooltips();
 
     g_IsInGuiUpdate = false;
 
     // Game attributes include AI settings, so update the player list
     updatePlayerList();

binaries/data/mods/public/gui/lobby/lobby.js

@@ -222 +222 @@
 
     // When rejoining the lobby after a game, we don't need to process presence changes
     Engine.LobbyClearPresenceUpdates();
     updatePlayerList();
     updateSubject(Engine.LobbyGetRoomSubject());
+    updateTooltips();
 }
 
 function returnToMainMenu()
 {
     Engine.StopXmppClient();
@@ -296 +297 @@
         return true;
 
     return false;
 }
 
+function updateTooltips()
+{
+    Engine.GetGUIObjectByName("chatInput").tooltip = colorizeAutocompleteHotkey();
+}
+
 /**
  * Update the subject GUI object.
  *
  * @param {string} newSubject
  */

binaries/data/mods/public/gui/replaymenu/replay_menu.js

@@ -220 +220 @@
     replaySelection.list_data = list.directories || [];
 
     replaySelection.selected = replaySelection.list.findIndex(directory => directory == g_SelectedReplayDirectory);
 
     displayReplayDetails();
+    updateTooltips();
 }
 
 /**
  * Shows preview image, description and player text in the right panel.
  */
@@ -265 +266 @@
     Engine.GetGUIObjectByName("summaryButton").hidden = !Engine.HasReplayMetadata(replay.directory);
 
     setMapPreviewImage("sgMapPreview", mapData.preview);
 }
 
+function updateTooltips()
+{
+    Engine.GetGUIObjectByName("playersFilter").tooltip =
+        translate("Filter replays by typing one or more, partial or complete playernames.") + " " +
+        colorizeAutocompleteHotkey();
+
+    let deleteTooltip = colorizeHotkey(
+        translate("Delete the selected replay using %(hotkey)s."),
+        "session.savedgames.delete");
+
+    if (deleteTooltip)
+        deleteTooltip += " " + colorizeHotkey(
+            translate("Press %(hotkey)s to delete without confirmation."),
+            "session.savedgames.noconfirmation");
+
+    Engine.GetGUIObjectByName("deleteReplayButton").tooltip = deleteTooltip;
+}
+
 /**
  * Adds grey font if replay is not compatible.
  */
 function greyout(text, isCompatible)
 {

binaries/data/mods/public/gui/session/session.js

@@ -280 +280 @@
 
     // If in Atlas editor, disable the exit button
     if (Engine.IsAtlasRunning())
         Engine.GetGUIObjectByName("menuExitButton").enabled = false;
 
-    initHotkeyTooltips();
+    updateTooltips();
 
     if (hotloadData)
         g_Selection.selected = hotloadData.selection;
 
     sendLobbyPlayerlistUpdate();
@@ -300 +300 @@
     // and it generates a massive amount of data to transmit and store
     //setTimeout(function() { reportPerformance(5); }, 5000);
     //setTimeout(function() { reportPerformance(60); }, 60000);
 }
 
-function initHotkeyTooltips()
+function updateTooltips()
 {
+    Engine.GetGUIObjectByName("chatInput").tooltip = colorizeAutocompleteHotkey() +
+        colorizeHotkey("\n" + translate("Press %(hotkey)s to chat with everyone."), "chat") +
+        colorizeHotkey("\n" +
+            (g_IsObserver ?
+                translate("Press %(hotkey)s to chat with observers.") :
+                translate("Press %(hotkey)s to chat with allies.")),
+            "teamchat");
+
     Engine.GetGUIObjectByName("idleWorkerButton").tooltip =
         colorizeHotkey("%(hotkey)s" + " ", "selection.idleworker") +
         translate("Find idle worker");
 
     Engine.GetGUIObjectByName("tradeHelp").tooltip =
@@ -376 +384 @@
     }
 
     Engine.SetViewedPlayer(g_ViewedPlayer);
 
     updateTopPanel();
-
     updateChatAddressees();
+    updateTooltips();
 
     // Update GUI and clear player-dependent cache
     onSimulationUpdate();
 
     if (g_IsDiplomacyOpen)