Ticket #6888: simple_fix.diff

binaries/data/mods/public/simulation/components/Identity.js

@@ -92 +92 @@
     this.classesList = GetIdentityClasses(this.template);
     this.visibleClassesList = GetVisibleIdentityClasses(this.template);
     if (this.template.Phenotype)
-        this.phenotype = pickRandom(this.GetPossiblePhenotypes());
+    {
+        const phenotypes = this.GetPossiblePhenotypes();
+
+        // Avoid calling Math.random to avoid out of sync RNG caused by preview entities
+        this.phenotype = phenotypes[this.entity % phenotypes.length];
+    }
     else
         this.phenotype = "default";
 

binaries/data/mods/public/simulation/templates/special/filter/preview.xml

@@ -2 +2 @@
 <Entity filtered="">
   <!-- We only want to include components which are necessary (for the visual previewing of an entity)
        and safe (i.e. won't do anything that affects the synchronised simulation state), so additions
-       to this list should be carefully considered -->
+       to this list should be carefully considered.
+
+       Any Init function of any component listed here may not call Math.random, otherwise the RNG state
+       would become out of sync with the RNG state of the other clients.
+  -->
   <!-- Attack is needed for the Actor Viewer and attack range overlay -->
   <Attack merge=""/>
   <BuildRestrictions merge=""/>