This Trac instance is not used for development anymore!

We migrated our development workflow to git and Gitea.
To test the future redirection, replace trac by ariadne in the page URL.

Custom Query (5409 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:

Results (46 - 48 of 5409)

← 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 →
Ticket Resolution Summary Owner Reporter
#6312 fixed The map size is displayed incorrectly when changing Silier Langbart
Description

In the following GIF I change the Map Size to Giant but it stays the same, only when I switch to another map and back again it shows the correct size.

The bug can be noticed for the first time with changeset [25077].
The bug was first reported by maroder. I create the ticket only so that the error is not forgotten.

The

#6392 fixed Sorting by "has password" in lobby game list does nothing. Silier nani
Description

Sorting by "has password" in lobby game list does nothing.

#6429 fixed [BUG] Barter&Trade button causes errors Silier Langbart
Description

Error message appear when using the Barter&Trade button.

to reproduce

  • Watch a replay
  • Select a player with the playerviewcontrol
  • Press the Barter&Trade button
  • Select observer mode via the playerviewcontrol

(the issue is not reproducible with the Diplomacy button)

error codes

0 A.D. (0.0.26) Main log (warnings and errors only)
ERROR: JavaScript error: gui/session/trade/TradeDialogBarterPanel.js line 27 Script value conversion check failed: v.isBoolean() (got type undefined) update@gui/session/trade/TradeDialogBarterPanel.js:27:3 updatePanels@gui/session/trade/TradeDialog.js:67:20 updateIfOpen@gui/session/trade/TradeDialog.js:62:9 onSimulationUpdate@gui/session/session.js:675:3 resetTemplates@gui/session/session.js:448:2 onSelectionChange@gui/session/top_panel/PlayerViewControl.js:119:4

ERROR: Errors executing script event "SelectionChange"

ERROR: JavaScript error: gui/session/trade/TradeDialogBarterPanel.js line 27 JS_ReportError was called update@gui/session/trade/TradeDialogBarterPanel.js:27:3 updatePanels@gui/session/trade/TradeDialog.js:67:20 updateIfOpen@gui/session/trade/TradeDialog.js:62:9 onSimulationUpdate@gui/session/session.js:675:3 resetTemplates@gui/session/session.js:448:2 onSelectionChange@gui/session/top_panel/PlayerViewControl.js:119:4

ERROR: JavaScript error: gui/session/trade/TradeDialogBarterPanel.js line 27 Script value conversion check failed: v.isBoolean() (got type undefined) update@gui/session/trade/TradeDialogBarterPanel.js:27:3 updatePanels@gui/session/trade/TradeDialog.js:67:20 updateIfOpen@gui/session/trade/TradeDialog.js:62:9 onTick@gui/session/session.js:631:4 __eventhandler52 (Tick)@session Tick:1:1

ERROR: Errors executing script event "Tick"
...

reproducible

The issue is reproducible for A25b [25860] , but not for A24b [24937].

bisect

The issue can be noticed for the first time with [25365].

solution(1)

Simply adding || false to ​Line 27 in TradeDialogBarterPanel.js

Line 
20 update()
21 {
22 let playerState = GetSimState().players[g_ViewedPlayer];
23 let canBarter = playerState && playerState.canBarter;
24
25 this.barterButtonManager.setViewedPlayer(g_ViewedPlayer);
26 this.barterButtonManager.update();
27 this.barterNoMarketsMessage.hidden = canBarter *|| false*;
28 this.barterResources.hidden = !canBarter;
29 this.barterHelp.hidden = !canBarter;
30 this.barterHelp.tooltip = sprintf(
31 translate(this.InstructionsTooltip), {
32 "quantity": this.barterButtonManager.getSelectedButton().BarterResourceSellQuantity,
33 "hotkey": colorizeHotkey("%(hotkey)s", "session.massbarter"),
34 "multiplier": this.barterButtonManager.getSelectedButton().Multiplier
35 });
36 }
37};
← 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 →
Batch Modify
Note: See TracBatchModify for help on using batch modify.
Note: See TracQuery for help on using queries.