Context Navigation

Custom Query (5409 matches)

Filters

	Status	assigned closed new reopened
And		Or

Group results by descending

Show under each result: Description

Max items per page

Results (1 - 1000 of 5409)

1 2 3 4 5 6 →

Ticket

Resolution

Summary

Owner

Reporter

#6944 fixed Shell scripts not set executable Stan Ralph Sennhauser

Description

build/resources/0ad.sh
source/tools/autolog/SVNLog/sql/createdb.sh
source/tools/templatessorter/templatessorter.sh
source/tools/tracelogger/tracelogger_options.sh

#6942 wontfix Crash in multiplayer game after consistently lowering FPS. Beedell, Roke, Julian Lockhart

Description

Of note is that this was a multiplayer game. The FPS had slowly lowered as the game progressed, to 17 FPS at times, despite both participants having very capable GPUs (1 x XFX AMD Radeon RX 5700 and 1 x AMD Radeon 7900 XTX). I don't know why the FPS lowered to such an extent, but if this Reddit comment:

Put a Max unit cap on the game. This has been a known issue that an enormous number of units can crash the game.

...is to be believed, then it might have been because each of the 4 nations in the game had approximately 2 000 troops.

#6940 duplicate Barter and Trade Menu not working on latest Windows build Riesi

Description

Hello!

When using the latest Windows automated build and playing as any faction the "Barter and Trace" menu on the top right doesnt work and throws an error.
It works on a git Linux build.

Kind regards,
Riesi

#6933 duplicate GameSettings infinite loop in multiplayer, now in singleplayer as well Murphy

Description

What do you make of this? my games fail to load and all of this flashes on the screen for a while as a window in the middle lies and says that its loading a map. All it does is stay there on the screen forever while nothing happens. It used to happen in just multiplayer. But now its in singleplayer too.

ERROR: JavaScript error: gamesettings/GameSettings.js line 97 Infinite loop initializing attributes detected, components: ["biome", "campaignData", "ceasefire", "cheats", "circularMap", "daytime", "disableSpies", "disableTreasures", "gameSpeed", "landscape", "lastManStanding", "lockedTeams", "map", "mapExploration", "mapName", "mapPreview", "mapSize", "matchID", "nomad", "playerAI", "playerCiv", "playerColor", "playerCount", "playerName", "playerTeam", "population", "rating", "regicideGarrison", "relic", "seaLevelRise", "seeds", "startingCamera", "startingResources", "teamPlacement", "triggerDifficulty", "triggerScripts", "victoryConditions", "wonder"] fromInitAttributes@gamesettings/GameSettings.js:97:9 parseSettings@gui/gamesetup/Controllers/GameSettingsController.js:191:18 onLoad@gui/gamesetup/Controllers/GameSettingsController.js:89:10 SetupWindow@gui/gamesetup/SetupWindow.js:61:11 init@gui/gamesetup/gamesetup.js:47:18 onPress@gui/pregame/MainMenuItems.js:99:13 performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9 pressButton@gui/pregame/MainMenuItemHandler.js:63:10

ERROR: GUI page 'page_gamesetup.xml': Failed to call init() function

#6920 fixed GUI property 'textcolor_selected' isn't working Vantha obelix

Description

The optional GUI property 'textcolor_selected' doesn't work for lists and other list-based objects (namely olists and dropdowns). It is correctly created in source/gui/ObjectTypes/CList.cpp, but the feature is not implemented. (the same property seems already be working for input objects)

--> see the discussion by Vantha and Stan on the forums

#6919 fixed oos error on trying to connect a multiplayer game astroajay

Description

My partner and I just installed 0AD and were trying to play a game together. I hosted the game, we used my ip address to connect her computer to mine and she joined the lobby successfully. Now however, when I started the game I got an out of sync error on turn 1 once I had the map loaded.

She got the same but got stuck on the loading screen at 100% loaded. I did notice a number of errors scrolling on the top of her computer screen on the loading screen.

My system is running ZorinOS 17.1 running on a 5th gen i5 processor(Dell Inspiron 15 3000 series).

My partner's is a windows 11 PC running on a 13th gen i5 processor (Framework 13)

I'm attaching the log files from both my computer and hers here.

I've had to compress the dumps aggressively with 7zip because they woudn't fit the 2Mb attachment limit if I didn't.

Please let me know if I can help in any other way.

#6907 fixed crash when trying to join multiplayer game Marco

Description

crash when trying to join multiplayer game Same network LAN Same 0ad release. installed at the same time. One machine on windows10 the other on ubuntu 20.04 Whatever machine try to host the game the machine trying to join crash with the same violation error

#6904 worksforme Sync of revision log halted since February 5, 2024 obelix

Description

The module revision log on the right sidebar does no more show the last revisions. This is due to a defect of the underlying RSS feed which shows as last entry Revision 28027: [i18n] Updated POT and PO files. February 5, 2024 ([28027]). As of today, current development already reached [28039].

Some months ago, there was related problem: #6874. Then feedburner was updated, but the website module didn't reflect that.

#6901 invalid update game Manuel Pernas

Description

Are OAD is there any new updated the game ,do they still under development?

#6900 invalid Increasing / decreasing camera rotation speed is inverted Papnaas Papnaas

Description

When pressing hotkey for increasing / decreasing camera rotation speed values are decreased / increased. Info text will be displayed correctly, but value increase/decrease is inverted.

#6899 fixed Player kills hostile animal owned by AI - errors about orderData undefined Freagarach Norse_Harold

Description

Summary: If a player kills a wild animal that is hostile and owned by an AI-controlled player then a large amount of warnings and errors appear.

Versions known to be affected: release version alpha 0.0.26, dev a27 version r27624, dev a27 version rc1 r27645.

Expected results: Either it is not possible for the scenario editor to create a map that causes these symptoms, or the errors do not occur when an AI-owned hostile animal is killed.

Actual results: A large amount of warning and error messages appear. Excerpts are attached.

Steps to reproduce the symptoms:

Extract the "Flatland with player-owned bears.zip" file to the mods/user/maps/scenarios folder in your 0ad game data folder.
Load the scenario "Flatland with player-owned bears". Slot yourself as player 1, and slot 1 AI in the remaining slots.
Use the cheat "gift from the gods" (type it in chat) to get p3, a lot of resources, and fast building.
Build a stable and produce 50 cavalry.
Send the cavalry to attack AI-controlled player 2, toward the east (3 o'clock).
After fighting with an AI-controlled opponent and killing one of its bears, the error should appear continuously until the AI player is neutralized.

Computing Environnment (OS brand and version, hardware, relevant driver version and other software versions): The OS I have used for testing is Linux. The problem does not seem to be hardware dependent, as others have observed the same symptoms.

Relevant logs, files that reproduce the symptoms, screenshots, etc.: (attached)

Credits: First reported by seregadushka and Alexandra in this forum post.

#6894 fixed Error when closing the game at the end of a replay phosit phosit

Description

When you close the game throu the dialog which appears ath the end of a replay there is an error printet:

ERROR: JavaScript error: gui/session/PauseControl.js line 82
Game is not started
  setPaused@gui/session/PauseControl.js:82:10
  implicitResume@gui/session/PauseControl.js:60:8
  resumeGame@gui/session/session.js:507:17
  onPageClosed@gui/session/SessionMessageBox.js:35:4
  setButtonCaptionsAndVisibitily/</button[i].onPress@gui/common/utilities.js:29:11

The error does not appear when playing a game (instead of watching a replay) or when manually open the exit dialog.

It has been introduced by [27883]

#6893 fixed PetraAI tries to research Wicker Basket and Ahimsa phosit phosit

Description

When PetraAI plays as the Mauryas PetraAI tries to research Wicker Basket and Ahimsa.

Wicker Basket and Ahimsa are a "technology pair", a player can research only one of them.

This ticket is only about the Wicker Basket and Ahimsa pair. Propably PetraAI also can't handle other technology pairs.

The defect is present since the technology pair got introduced in [27958].

I'll attach a replay but it's easy to reproduce with ./binaries/system/pyrogenesis --autostart=random/mainland --autostart-ai=1:petra --autostart-civ=1:maur.

#6891 fixed Units Demo is broken - something aura related wowgetoffyourcellphone marder

Description

Bug found by @phosit https://trac.wildfiregames.com/ticket/6890?replyto=4#comment:4 reproduce -> start units demo e.g. error:

structures/ishtar_gate...
ERROR: JavaScript error: simulation/components/Auras.js line 116
AuraTemplates.Get(...) is undefined
  Auras.prototype.CalculateAffectedPlayers@simulation/components/Auras.js:116:38
  Auras.prototype.Clean@simulation/components/Auras.js:244:8
  Auras.prototype.Init@simulation/components/Auras.js:18:7
  @maps/scenarios/units_demo.js:38:19
ERROR: JavaScript error: simulation/components/Auras.js line 116
AuraTemplates.Get(...) is undefined
  Auras.prototype.CalculateAffectedPlayers@simulation/components/Auras.js:116:38
  Auras.prototype.Clean@simulation/components/Auras.js:244:8
  Auras.prototype.OnOwnershipChanged@simulation/components/Auras.js:489:7
  @maps/scenarios/units_demo.js:86:16
ERROR: Script message handler OnOwnershipChanged failed
ERROR: JavaScript error: simulation/components/Auras.js line 171
AuraTemplates.Get(...) is undefined
  Auras.prototype.GetType@simulation/components/Auras.js:171:23
  Auras.prototype.IsRangeAura@simulation/components/Auras.js:196:14
  Auras.prototype.GetRangeOverlays@simulation/components/Auras.js:89:13
  RangeOverlayManager.prototype.UpdateRangeOverlays@simulation/components/RangeOverlayManager.js:29:51
  RangeOverlayManager.prototype.OnOwnershipChanged@simulation/components/RangeOverlayManager.js:67:8
  @maps/scenarios/units_demo.js:86:16
ERROR: Script message handler OnOwnershipChanged failed

Affects probably also other maps where the units are used.

problem seems to be https://code.wildfiregames.com/rP27919

#6890 fixed Errors when building Stables as Seleucids Riesi

Description

I pulled the latest revision 27936 on Linux and when building a Stable as Seleucids the game throws an error when its completed. Also when you select the stable you get another different error.

Steps to reproduce:

1) Start game as Seleucids
2) "gift of the gods"
3) build stable and get first error
4) select stable get different error

#6889 invalid Failed to garrison entity at the start of a game. phosit

Description

When you start a game on Elephantine or Extinct Volcano a bunch of such errors occur:

ERROR: failed to garrison entity 743 (units/kush/support_healer_e) inside 219

#6885 duplicate buildingAI: Split building attack and rally point, non-random buildingAI real_tabasco_sauce

Description

Randomly selecting targets for each arrow from a building is not ideal for gameplay's sake: -not very effective vs rushes -mainly more effective en mass (ie turtling)

It is nice for this sort of thing to be player controlled. It is more interesting and exciting this way, and adds playable content.

First, the building arrows should work somewhat like UnitAI, with the closest unit being attacked by default. (https://code.wildfiregames.com/D4964) Then, buildings should be given the ability to focus their fire, similarly to unitAI, returning to default once the focused unit is deceased or out of range. The controls for attacking vs setting a rally point will need to be separated with a hotkey enabling one over the other. This would probably cause issues with siege towers and ships as long as they use buildingAI.

#6883 fixed r27673 introduced serialization test failure wraitii Vladislav Belov

Description

r27673 introduced serialization test failure (I've bisected it between 27104 and 27894):

Assertion failed: "0 && (L"Serialization test failure")"
Location: simulation2.cpp:334 (CSimulation2Impl::ReportSerializationFailure)

Full log: https://code.wildfiregames.com/P298

Reported for SVN head by @phosit: https://irclogs.wildfiregames.com/%230ad-dev/2023-10-25-QuakeNet-%230ad-dev.log

11:20 < phosit> Did somebody test the serializationtest in the last few months? It crashes as soon as the map is loaded.
11:21 < phosit> Assertion failed: "0 && (L"Serialization test failure")"
11:22 < Vladislav> phosit: you could try bisect.
11:23 < phosit> I can't build versions that are older then a few months
12:00 < Vladislav> phosit: if you can describe steps I can try to bisect tonight.
12:07 < phosit> just run `./binaries/system/pyrogenesis --serializationtest --autostart=scenarios/arcadia`
12:08 < phosit> `./binaries/system/pyrogenesis --serializationtest --autostart=scenarios/arcadia --autostart-nonvisual` also does not work but for a different reason

#6878 duplicate Issues when trying to start a network game vpereira

Description

I'm running 0AD 26, and when setting a multiplayer game with regicide and hero garrison, I get eventually the following problem (screenshot attached).

The error happens not always, but quite often. I'm running it on Windows 11, local network with more 2 players.

#6874 fixed Sync of revision log halted since September 22, 2023 obelix

Description

The module 'revision log' on the right sidebar does no more synchronize with the underlying RSS feed. The last shown entry is Revision 27853: [i18n] Updated POT and PO files. September 22, 2023 while the feedburner.com-feed 0adrevisions already shows revision Revision 27865: [Gameplay][Balance] Reduce bolt and cata prepare time to help with ... October 1, 2023.

#6870 duplicate a dupe of #6543 whocares

Description

golly the hoops but this is for a nice furtures. seems better then aoe2. more complicated. maybe more , anyways.

i was in a multiplayer game. then i quickly quit. then tried to restart the app. got a dupe on the problem.

Much to our regret we must report the program has encountered an error.

Please let us know at https://trac.wildfiregames.com/ and attach the crashlog.txt and crashlog.dmp files.
You may find paths to these files at https://trac.wildfiregames.com/wiki/GameDataPaths 

Details: unhandled exception (Access violation reading 0x00000410)

Location: unknown:0 (?)

Call stack:

(error while dumping stack: No stack frames found)
errno = 2 (Error during IO)
OS error = 0 (no error code was set)

#6862 duplicate Can't open the Single Player Match Setup screen DougRenaud

Description

It used to work but all of a sudden it started showing error messages every time I try to open the SP Match Setup screen and infinitely loads . Everything else seemingly works fine; multiplayer, campaign, tutorial, scenario editor, all good. I tried uninstalling and reinstalling; no luck.

#6859 duplicate JavaScript Error for single player Matches. virgaux

Description

Hi I'm getting this error when I'm trying to play single-player matches.

Here is the screenshot of the error, https://drive.google.com/file/d/1JTE8zLOREuOa2gCJUBbMCFNC4-Znd22Y/view?usp=sharing

Is there something I need to do to make it work?

#6857 duplicate Ошибка в лобби Doppel

Description

При попытке создать игру выдает ряд ошибок

#6856 fixed improve color of repair icon abian abian

Description

The icon for the repair action is unusually dark compared to the rest, and may suggest that it is disabled.

I propose to adjust it to look as follows.

#6850 fixed add brief explanations to the tooltips of the alert buttons abian abian

Description

The two alert buttons currently have tooltips only with the texts "Raise an alert!" and "End of alert.", with no explanation of the effects.

#6848 fixed Unplayable map; Elefantine? phosit Nick_S

Description

Hi. I today played the Elephantine map in the largest version and there doesn't seems to be any way for either side to build docks. Witch makes the map a bit impossible to win when there is water dividing the map. It seems that the edge of the beach is to steep into the water or that it might be to deep to close to the shoreline. There are more maps to play so I'm not in a hurry - but would be nice if any one could verify this or tell me that I'm wrong. I have tried different tribes with the same result. Running; "Alpha XXVI; Zhuangzi" if that helps in any way.

Best regards from Nick_S.

#6847 fixed MacOS libzip compile error with premake / update-workspace.sh Stan John-Mason Shackelford

Description

Attempting to build from master on OS X, having addressed the issue described in track #6797, the following error occurs when running ./update-workspace as described in https://trac.wildfiregames.com/wiki/BuildInstructions#Buildthegame

$ ./clean-workspaces.sh 
Cleaning bundled third-party dependencies...
.....
Removing generated stub and test files...
Cleaning build output...

Done. Try running update-workspaces.sh again now.
$ export
export HOMEBREW_CELLAR="/usr/local/Cellar"
export HOMEBREW_PREFIX="/usr/local"
export HOMEBREW_REPOSITORY="/usr/local/Homebrew"
export INFOPATH="/usr/local/share/info:"
export LANG="en_US.UTF-8"
export MANPATH="/usr/local/share/man::"
export OLDPWD
export PATH="/usr/local/bin:/usr/local/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/jpshack/code/arcanist/bin/"
export PWD="/Users/jpshack/code/0ad-jpshack/build/workspaces"
export SHELL="/bin/zsh"
export SHLVL="2"
export SSH_AUTH_SOCK="/private/tmp/com.apple.launchd.p1bbgQiJIy/Listeners"
export TERM="xterm-256color"
export TERM_PROGRAM="Apple_Terminal"
export TERM_PROGRAM_VERSION="447"
export XPC_FLAGS="0x0"
export XPC_SERVICE_NAME="0"
export __CFBundleIdentifier="com.apple.Terminal"

$ ./update-workspaces.sh 
==== Building lua-lib (release) ====
==== Building zip-lib (release) ====
Creating obj/Release/lua-lib
lapi.c
Creating obj/Release/zip-lib
mkstemp.c
../../contrib/libzip/mkstemp.c:76:8: error: call to undeclared function 'getpid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        pid = getpid();
              ^
1 error generated.
make[1]: *** [obj/Release/zip-lib/mkstemp.o] Error 1
make: *** [zip-lib] Error 2
make: *** Waiting for unfinished jobs....
.....
Linking lua-lib
ERROR: Premake build failed

#6846 fixed Revert non-ASCII characters from source and configuration files introduced in rP27786 Vladislav Belov Vladislav Belov

Description

https://code.wildfiregames.com/rP27786

#6844 fixed LOS updating is broken after rP27695 Vladislav Belov Vladislav Belov

Description

https://code.wildfiregames.com/rP27695

Reported by wowgetoffyourcellphone

Also here: https://wildfiregames.com/forum/topic/107592-fog-of-war-bug-svn/

#6842 fixed Add compute shader support to backends Vladislav Belov Vladislav Belov

Description

Compute shaders are mainly needed for the following tasks:

Skinning - to reduce CPU load by delegating that work to GPU
Upscaling (FSR)/Downscaling (Supersampling) - to be able to render the game in a different resolution for performance/quality

We need to implement them for GL and Vulkan backends.

Refs: https://wildfiregames.com/forum/topic/102722-support-for-amd-fidelityfx-super-resolution-and-vulkan/

#6841 fixed when only one entity of a type is selected/garrisoned, don't show the number abian abian

Description

I would expect...

... to be...

It's easy to understand that there's only one entity unless a number is indicated. Not showing the number 1 makes it easier to distinguish single entities from batches, and also makes it easier to recognize the icons that the number 1 partially covers.

#6838 fixed include military formation descriptions abian abian

Description

It would be nice to have descriptions of military formations as tooltips.

#6837 fixed Liu Bang doesn't give all cav dmg bonus wowgetoffyourcellphone Gurken Khan

Description

Liu Bang's aura doesn't give all cav the +20% dmg bonus as advertised.

First reported by GaiusJuliusPfifficus: https://wildfiregames.com/forum/topic/107591-hero-bug/?do=findComment&comment=553803

#6831 fixed Archers may be missing on Jebal Barka's walls since A25. marder elexis

Description

[10:05:41] <elexis1> lairkers in D5042 discovered that jebel barkal archers on walls (hard difficulty) have disappeared since A25
[10:06:01] <elexis1> he said he has a workaround for it
[10:06:07] <elexis1> said garrisoning on walls was removed for turret code
[10:06:13] <elexis1> should have at least a ticket

#6828 duplicate Stuck screen: "Loading Map Data...Please Wait" after trying to Host Game Melissa

Description

So, I was using the lobby fine, hosting and joining games but for some reason it started not working and giving a loading map data error and staying on the same screen.

#6826 worksforme A 27 mod not replacing the resource upgrades ShadowOfHassen

Description

I installed my mod (https://mod.io/g/0ad/m/0-ad-balancing-mod) on a 27 and when it was enabled it does not change the resource types.

My mod changes the resource upgrade costs for the resource gathering upgrades.

#6825 fixed Bugs in the new Maurya Palace wowgetoffyourcellphone Langbart

Description

CLASSES issue: to reproduce

redundant Harmya class, it is used nowhere, false positive when checking the classes in the Identity.js schema (Ref: #6792)

HEALTH issue: to reproduce

start maur game
select a human ==> errors
add Health component

ERROR: RelaxNGValidator: Validation error: foundation%7Cstructures/maur/palace:1: Expecting an element Max, got nothing
ERROR: RelaxNGValidator: Validation error: foundation%7Cstructures/maur/palace:1: Invalid sequence in interleave
ERROR: RelaxNGValidator: Validation error: foundation%7Cstructures/maur/palace:1: Element Health failed to validate content
ERROR: RelaxNGValidator: Validation failed for '(null)'
ERROR: Failed to validate entity template 'foundation|structures/maur/palace'
ERROR: Error creating foundation entity for 'structures/maur/palace'

BUILD RESTRICTIONS issue part 1: to reproduce

wrong class in BuildRestrictions

binaries/data/mods/public/simulation/templates/structures/maur/palace.xml

-              a
   <BuildRestrictions>
     <Category>Palace</Category>
     <Distance>
       <FromClass>CivicCenter</FromClass>
+      <FromClass>CivilCentre</FromClass>
       <MaxDistance>60</MaxDistance>
     </Distance>
   </BuildRestrictions>

BUILD RESTRICTIONS issue part 2: to reproduce

the palace needs to be within 60m from a cc
it is too low for a typical build setup, the player is forced to demolish existing structures by the time he reached the City phase or he has to build the palace near a new cc
increase the number or lift the arbitrarily set restriction, as having an entity limit is already enough

VISION issue: to reproduce

Build palace
tear down CC, walk away, the palace remains in the dark
if it's mine, it should have at least a little vision

nitpicks (not important)

consider increasing GarrisonHolder to 10 to be more consistent with similar templates, e.g. structures/pers/apadana.xml
typo in an unrelated maur template

binaries/data/mods/public/simulation/templates/structures/maur/tower_double.xml

-              a
   <Identity>
     <GenericName>Rampart Tower</GenericName>
     <SelectionGroupName>structures/maur/tower_double</SelectionGroupName>
     <Tooltip>Higher health tower with ramparts for up to 16 archers. Visibly garrisoned archers recieve a range and armor bonus. Only archers can garrison. Needs the murder holes tech to protect its foot.</Tooltip>
+    <Tooltip>Higher health tower with ramparts for up to 16 archers. Visibly garrisoned archers receive a range and armor bonus. Only archers can garrison. Needs the murder holes tech to protect its foot.</Tooltip>
     <Civ>maur</Civ>
     <SpecificName>Udarka</SpecificName>
     <Requirements>

notes

Creating phab diffs for non-trivial changes is better for finding bugs before they are committed, and you have violated this rule time and time again. Every person goes through this process to make their changes to the game, except you. This is unfair and leads to unnecessary bug reports because your commits are often full of errors and almost never follow exciting conventions and naming schemes that make working with template files more predictable.

#6822 duplicate Application is crashing on launch Sean Henry

Description

When launching the game I am getting the following error message:

Details: unhandled exception (std::out_of_range("invalid bitset<N> position"))

Location: unknown:0 (RtlGetAppContainerNamedObjectPath)

Call stack:

(error while dumping stack: No stack frames found) errno = 0 (No error reported here) OS error = 0 (no error code was set)

#6821 fixed Redundant options dialog popup without making any changes wraitii Langbart

Description

to reproduce

start a normal match, go to options
make no changes and try to close the options
dialog pops up asking You have unsaved changes, do you want to close this window?

bisect

[27192]

related ticket #6205 and commit [25802]
- setting same Priority:

#6818 fixed Invalid warning message for Kastasta wowgetoffyourcellphone obelix

Description

In Saharan Oases (4): When selecting the Kastasta (Farmstead) nearby your cc and right-clicking on its icon (the goat) the game prints a warning message. This only happens, when it's not already conquered resp. still under gaias sovereignty.

WARNING: Unrecognized phase (phase_city)

This confuses, especially new, gamers and should be changed.

See also: https://wildfiregames.com/forum/topic/107313-alpha-27-pre-releaserelease-candidate-build-testing/?do=findComment&comment=552843

I'll look at it, probably a mixup when I ported the files from DE to EA. (wowgetoffyourcellphone)

#6817 duplicate Javascript Error: Infinite loop detected in Single Player > Matches option Akash Kumar Sharma

Description

First time after installation when playing Single Player and Matches with some preference options, Game working fine. But again when trying to play Match even after restarting it is throwing some error.

Windows 11

#6815 invalid Number of players in single player mode cannot be changed Woutthefxck

Description

Hey so yeah as the summary states, the default number of 2 cannot be changed to more. I am playing the newest version (just downloaded it) on a Mac.

#6809 duplicate Unsaved Changes in-game Options berhudar

Description

When you play a game (not in starting page) and wanna go to options to check something without doing something the game considers it like you have done some changes in the options and asking you everytime that you have some unsaved changes still wanna quit?

#6807 fixed gloox crash on macOS with TLS froissant Itms

Description

In the RC version, a macOS user has gloox crashing with TLS enabled.

https://wildfiregames.com/forum/topic/107313-alpha-27-pre-releaserelease-candidate-build-testing/?do=findComment&comment=551853

Can someone on macOS reproduce the issue in a clean environment?

#6806 fixed Incorrect Translations for timers Stan berhudar

Description

Timers use format string such as HH:mm:ss HH:mm and mm:ss` Those should not be translated but their format might differ betwen countries. E.g. one could write 10:00 for ten minutes remaining, or 10 00 or 10-00. One solution could be to replace the specifier by %hours:%minutes:%seconds allowing only the separator to be changed.

#6805 fixed Flickering/Mosaic pattern on screen when starting the game Vladislav Belov berhudar

Description

Flickering vertically on whole screen on random areas in different widthes with OpenGL (OpenGL-ARB and Vulkan with no flickering issue) when you run the a27 RC for the first time (While neither moving the screen nor cursor, in standby).

#6800 fixed [Arch Linux]: AtlasUI build fails with uint8_t and invalid type errors. phosit Caleb Marshall

Description

Building on an Arch Linux system, I get the following error:

Command:

[caleb@NerdTop gcc]$ make -j4

Error:

==== Building AtlasUI (release) ====
MapDialog.cpp
MapResizeDialog.cpp
PseudoMiniMapPanel.cpp
AtlasDialog.cpp
In file included from /usr/include/boost/preprocessor/variadic/elem.hpp:102,
                 from /usr/include/boost/preprocessor/tuple/elem.hpp:23,
                 from ../../../source/tools/atlas/GameInterface/MessagesSetup.h:109,
                 from ../../../source/tools/atlas/GameInterface/Messages.h:22,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/MapDialog/MapDialog.cpp:23:
../../../source/tools/atlas/GameInterface/Messages.h:215:31: error: ‘uint8_t’ was not declared in this scope
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                               ^~~~~~~
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/Messages.h:23:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   22 | #include "MessagesSetup.h"
  +++ |+#include <cstdint>
   23 | #endif
../../../source/tools/atlas/GameInterface/Messages.h:215:38: error: template argument 1 is invalid
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                                      ^
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/Messages.h:215:38: error: template argument 2 is invalid
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                                      ^
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:61: error: template argument 1 is invalid
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                             ^
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
make[1]: *** [AtlasUI.make:255: obj/AtlasUI_Release/MapDialog.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /usr/include/boost/preprocessor/variadic/elem.hpp:102,
                 from /usr/include/boost/preprocessor/tuple/elem.hpp:23,
                 from ../../../source/tools/atlas/GameInterface/MessagesSetup.h:109,
                 from ../../../source/tools/atlas/GameInterface/Messages.h:22,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/MapResizeDialog/PseudoMiniMapPanel.cpp:23:
../../../source/tools/atlas/GameInterface/Messages.h:215:31: error: ‘uint8_t’ was not declared in this scope
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                               ^~~~~~~
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/Messages.h:23:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   22 | #include "MessagesSetup.h"
  +++ |+#include <cstdint>
   23 | #endif
../../../source/tools/atlas/GameInterface/Messages.h:215:38: error: template argument 1 is invalid
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                                      ^
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/Messages.h:215:38: error: template argument 2 is invalid
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                                      ^
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:61: error: template argument 1 is invalid
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                             ^
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
In file included from /usr/include/boost/preprocessor/variadic/elem.hpp:102,
                 from /usr/include/boost/preprocessor/tuple/elem.hpp:23,
                 from ../../../source/tools/atlas/GameInterface/MessagesSetup.h:109,
                 from ../../../source/tools/atlas/GameInterface/Messages.h:22,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/MapResizeDialog/MapResizeDialog.cpp:22:
../../../source/tools/atlas/GameInterface/Messages.h:215:31: error: ‘uint8_t’ was not declared in this scope
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                               ^~~~~~~
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/Messages.h:23:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   22 | #include "MessagesSetup.h"
  +++ |+#include <cstdint>
   23 | #endif
../../../source/tools/atlas/GameInterface/Messages.h:215:38: error: template argument 1 is invalid
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                                      ^
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/Messages.h:215:38: error: template argument 2 is invalid
  215 |                 ((std::vector<uint8_t>, imageBytes))
      |                                      ^
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:48: note: in expansion of macro ‘B_TYPE’
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                ^~~~~~
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/GameInterface/MessagesSetup.h:120:61: error: template argument 1 is invalid
  120 | #define B_MEMBERS(r, data, n, elem) Shareable< B_TYPE(elem) > B_NAME(elem);
      |                                                             ^
/usr/include/boost/preprocessor/seq/for_each_i.hpp:85:66: note: in expansion of macro ‘B_MEMBERS’
   85 | # define BOOST_PP_SEQ_FOR_EACH_I_M_I(r, macro, data, seq, i, sz) macro(r, data, i, BOOST_PP_SEQ_HEAD(seq))
      |                                                                  ^~~~~
/usr/include/boost/preprocessor/control/iif.hpp:32:31: note: in expansion of macro ‘QUERY_WITHOUT_INPUTS’
   32 | # define BOOST_PP_IIF_1(t, f) t
      |                               ^
../../../source/tools/atlas/GameInterface/Messages.h:212:1: note: in expansion of macro ‘QUERY’
  212 | QUERY(RasterizeMinimap,
      | ^~~~~
../../../source/tools/atlas/AtlasUI/CustomControls/MapResizeDialog/PseudoMiniMapPanel.cpp: In constructor ‘PseudoMiniMapPanel::PseudoMiniMapPanel(wxWindow*, int)’:
../../../source/tools/atlas/AtlasUI/CustomControls/MapResizeDialog/PseudoMiniMapPanel.cpp:64:43: error: invalid type argument of unary ‘*’ (have ‘int’)
   64 |         std::vector<uint8_t> imageBytes = *qryBackground.imageBytes;
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [AtlasUI.make:261: obj/AtlasUI_Release/PseudoMiniMapPanel.o] Error 1
make[1]: *** [AtlasUI.make:258: obj/AtlasUI_Release/MapResizeDialog.o] Error 1
make: *** [Makefile:181: AtlasUI] Error 2

System Information:

[caleb@NerdTop 0ad]$ neofetch
                   -`                    caleb@NerdTop 
                  .o+`                   ------------- 
                 `ooo/                   OS: Arch Linux x86_64 
                `+oooo:                  Host: Latitude 3190 2-in-1 
               `+oooooo:                 Kernel: 6.3.1-arch2-1 
               -+oooooo+:                Uptime: 3 hours, 53 mins 
             `/:-:++oooo+:               Packages: 2088 (pacman), 13 (flatpak) 
            `/++++/+++++++:              Shell: bash 5.1.16 
           `/++++++++++++++:             Resolution: 1366x768 
          `/+++ooooooooooooo/`           DE: Plasma 5.27.5 
         ./ooosssso++osssssso+`          WM: kwin 
        .oossssso-````/ossssss+`         Theme: [Plasma], Default [GTK2/3] 
       -osssssso.      :ssssssso.        Icons: Papirus-Dark [Plasma], Papirus-Dark [GTK2/3] 
      :osssssss/        osssso+++.       Terminal: konsole 
     /ossssssss/        +ssssooo/-       CPU: Intel Pentium Silver N5000 (4) @ 2.700GHz 
   `/ossssso+/:-        -:/+osssso+-     GPU: Intel GeminiLake [UHD Graphics 605] 
  `+sso+:-`                 `.-/+oso:    Memory: 3836MiB / 7763MiB 
 `++:.                           `-/+/
 .`                                 `/

#6799 duplicate 0ad: Javascript Error before game settings Ahoybrause

Description

Game shows errors before game settings are made.

[4.461] error: JavaScript error: gamesettings/GameSettings.js line 97
[4.461] error: Infinite loop initializing attribute detected, componentes: ["biome", "campaignData", "ceasefire" ......
[4.461] error: fromInitAttributes@gamesettings/GameSettings.js:97:9
[4.461] error: parseSettings@gui/gamesetup/controllers/GameSettingsController.js:191:18 [4.461] error: onLoad@gui/gamesetup/Controllers/GameSettingsController.[js:89:10 js:89:10]
[4.461] error: SetupWindows@gui/gamesetup/SetupWindows.js:61:11
[4.461] error: init@gui/gamesetup/gamesetup.js:47:18 [4.461] error: onPress@gui/pregame/MainMenuItems.js:99:13 [4.461] error: performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9
[4.461] error: pressButton@gui/pregame/MainMenuItemHandler.js:63:10
[4.461] error: GUI page 'page_gamesetup.xml': Failed to call init() function

I have already deleted all the data belonging 0ad from the hard drive and uninstalled the game. Reinstalling did not solve the problem.

#6798 fixed incompatible or missing mods error is shown on every game start pat

Description

I am using Arch Linux and installed 0ad from pacman (0ad a26-6 and 0ad-data a26-1). When I start the game the 'Incompatible mods' warning is shown. In the 'Enabled Mods' section is one red mod with name 'This mod does not exist'. I disabled the mod and enabled the '0ad' mod from the 'Available Mods' section. I Saved the Configuration and restarted 0ad (quit and start) and the same message is shown again. The mod '0ad' is not enabled and 'This mod does not exist' is back again in the enabled section.

When I use the 'Save and Restart' button the game starts, but all configurations are empty and the game behaves wrong.

So, I think there must be some problem with storing my configuration. I reinstalled 0ad but the error persisted.

I had an old version installed, which worked without errors. After updating to version a26-6 the error occurred.

#6793 fixed Untranslated sentence in tutorials Vladimír Repka

Description

Description I am testing in the Slovak language. First I started "Learn to Play" and "Tutorial". In the game it navigates me how to proceed. Some sentences are translated and some are not, I am sending screenshots:

https://drive.google.com/file/d/1R8xNGgEKpLiDiAS3pURnV4d30vFzHqna/view?usp=share_link

https://drive.google.com/file/d/1IYy4cgUj2YQK1yLsBA5QaA98lgs0r8s4/view?usp=share_link

Submit Date: 25.4.2023

Platform: PC

Operating system: Win 10 home ver.21H2 64bit

0 A.D. ver.: Alfa26 - 13.9.2022(27104)

#6792 fixed Update Entity component documentation file for A27 Stan Langbart

Description

Issues noticed when scrolling through the Entity component documentation:

Stackability in helpers/Attack.js breaks html with special DOUBLE QUOTATION MARK (“)
- use normal escaped double quotes \"
SortingOrder in Formation breaks html with special DOUBLE QUOTATION MARK (“)
- use normal escaped double quotes \"
TerritoryDecay looks messy in its RELAX NG grammar fragment . (its the only one)
EntityLimits could use more explanation on its children
fix 8 typos
- 1x miliseconds should be milliseconds
- 1x resouces should be resources
- 3x occurances should be occurrences
- 1x occurence should be occurrence
- 1x decending should be descending
- 1x colums should be columns
remove multiple double points at the end of sentences ..
- added through convertrng.xsl .../>.</p>
ModifiersManager seems to be a system component it should not be in the list
- it is missing some documentation to not be included in the entity-component list

binaries/data/mods/public/simulation/components/ModifiersManager.js

-              a
 function ModifiersManager() {}
 ModifiersManager.prototype.Schema =
     "<empty/>";
+    "<a:component type='system'/><empty/>";
 ModifiersManager.prototype.Init = function()
+{

add the missing and remove the redundant values in some schema lists (Ref: Phab:D386)
- script below for future updates

[BuildRestrictions] missing Category: Academy,ArmyCamp,Colony,Dock,GreatTower,ImperialCourt,ImperialMinistry,Palace,RotaryMill,Structure,TempleOfVesta,Wall,Yakhchal

[BuildRestrictions] redundant Category: Apadana,Gladiator,Hall,Hero,Juggernaut,PyramidSmall,UniqueBuilding,WarDog

[Identity] missing Civ: han

[Identity] missing Classes: Bireme,Formation,Quinquereme,RotaryMill,Trireme

[Identity] missing VisibleClasses: Academy,GreatTower,Heavy,IceHouse,ImperialCourt,ImperialMinistry,LaoziGate,Light,Medium,Minister,Shrine,Tent,Trumpeter

[Identity] redundant VisibleClasses: Bireme,Quinquereme,RotaryMill,Trireme

[TrainingRestrictions] missing Category: Animal,Centurion,Gladiator,Minister

script to find values that are duplicated, missing or redundant in the schema for certain components.

place it in a GUI .js file, for example MainMenuPage.js

// [component,value] = component and the value to search for within the component tag
const data = [["BuildRestrictions", "Category"], ["Identity", "Civ"], ["Identity", "Classes"], ["Identity", "VisibleClasses"], ["TrainingRestrictions", "Category"]];

for (const [component, value] of data)
{
    const classSet = new Set();

    // Define regular expressions for extracting values from the templates and schema
    const extractTemplateRegex = new RegExp(`<${component}[^>]*>[\\s\\S]*?<${value}[^>]*>([^<]+)<\/${value}>[\\s\\S]*?<\/${component}>`);
    const extractSchemaRegex = new RegExp(`\\b${value}\\b.*?Choices include: ?([^.']+)`);

    // Use the regex to extract the list of possible values from the schema file
    const classSchemaArray = Engine.ReadFile(`simulation/components/${component}.js`)
        .match(extractSchemaRegex)[1]
        .split(/\s*,\s*|\s*\(\w+.*?\),?\s*/);

    for (const file of Engine.ListDirectoryFiles("simulation/templates", "*.xml", true))
    {
        let match = Engine.ReadFile(file).match(extractTemplateRegex)
        if (match)
            // Split the match into individual values and add them to the classSet
            match[1].split(/\s+/).filter(str => /^\w+$/.test(str)).forEach(x => classSet.add(x));
    }

    // Check for duplicates in the schema list and warn if found
    if (new Set(classSchemaArray).size !== classSchemaArray.length)
        warn(`[${component}] duplicates in ${value} schema list\n`);

    // Check for missing values in the schema list and warn if found
    const missing = Array.from(classSet).filter(ele => !classSchemaArray.includes(ele)).sort().toString();
    if (missing.length)
        warn(`[${component}] missing ${value}: ${missing}\n`);

    // Check for redundant values in the schema list and warn if found
    const redundant = classSchemaArray.filter(ele => !Array.from(classSet).includes(ele)).sort().toString();
    if (redundant.length)
        warn(`[${component}] redundant ${value}: ${redundant}\n`);
}

#6791 fixed Strip vision_revealers of redundant components and make it invisible wowgetoffyourcellphone Langbart

Description

[27347] added a new object that makes an area outside of player territory temporarily visible by removing the Shroud of Darkness (SOD) before it disappears quickly. The effect leaves an explored area in the Fog of War (FOW) to signal to the player that something exists there, e.g. a field, treasure, tower, and so on.

issues

the object should not be visible outside of atlas even if it's only very brief, check skirmishes/miletus_peninsula_2p

currently it has multiple redundant components being called, such as Identity, Obstruction, Footprint, ...
- remove everything that is not needed

check template_territory_pull.xml doing it with less components

possible solution

also remove Identity from the children

binaries/data/mods/public/simulation/templates/template_vision_revealer.xml

-              a
 <?xml version="1.0" encoding="utf-8"?>
 <Entity>
-  <Decay>
-    <Active>false</Active>
-    <SinkingAnim>false</SinkingAnim>
-    <DelayTime>0.0</DelayTime>
-    <SinkRate>100.0</SinkRate>
-    <SinkAccel>100</SinkAccel>
-  </Decay>
-  <Footprint>
-    <Square width="8" depth="8.0"/>
-    <Height>7.0</Height>
-  </Footprint>
   <Health>
     <Max>1</Max>
     <RegenRate>-1</RegenRate>
     <IdleRegenRate>0</IdleRegenRate>
     <DeathType>corpse</DeathType>
+    <DeathType>vanish</DeathType>
     <Unhealable>true</Unhealable>
   </Health>
-  <Identity>
-    <Civ>gaia</Civ>
-    <GenericName>Vision Revealer</GenericName>
-    <Icon>technologies/spy_trader.png</Icon>
-    <Undeletable>false</Undeletable>
-  </Identity>
-  <Obstruction>
-    <Active>true</Active>
-    <BlockMovement>false</BlockMovement>
-    <BlockPathfinding>false</BlockPathfinding>
-    <BlockFoundation>false</BlockFoundation>
-    <BlockConstruction>false</BlockConstruction>
-    <DisableBlockMovement>false</DisableBlockMovement>
-    <DisableBlockPathfinding>false</DisableBlockPathfinding>
-    <DeleteUponConstruction>false</DeleteUponConstruction>
-    <Static width="8.0" depth="8.0"/>
-  </Obstruction>
-  <OverlayRenderer/>
   <Ownership/>
   <Position>
     <Altitude>0</Altitude>
+    <Altitude>15</Altitude>
     <Anchor>upright</Anchor>
     <Floating>false</Floating>
     <FloatDepth>0</FloatDepth>
     <TurnRate>6</TurnRate>
   </Position>
   <Selectable>
+    <EditorOnly/>
     <Overlay>
       <Outline>
         <LineTexture>outline_border.png</LineTexture>
 …
       </Outline>
     </Overlay>
   </Selectable>
-  <StatusBars>
-    <BarWidth>2.0</BarWidth>
-    <BarHeight>0.333</BarHeight>
-    <HeightOffset>5.0</HeightOffset>
-  </StatusBars>
   <Visibility>
     <RetainInFog>true</RetainInFog>
     <AlwaysVisible>false</AlwaysVisible>
     <Corpse>false</Corpse>
     <Preview>false</Preview>
   </Visibility>
-  <Vision>
-    <Range>1</Range>
-  </Vision>
   <VisualActor>
     <Actor>props/special/common/vision_revealer_01.xml</Actor>
     <SilhouetteDisplay>false</SilhouetteDisplay>
     <SilhouetteOccluder>true</SilhouetteOccluder>
     <VisibleInAtlasOnly>false</VisibleInAtlasOnly>
+    <VisibleInAtlasOnly>true</VisibleInAtlasOnly>
   </VisualActor>
 </Entity>

nitpick

rename the individual children to better match the naming scheme of territory_pulls
- vision_revealers/10_meters into vision_revealers/vision_revealer_10
increase the Altitude in the Position to make it fly above a structure, like a small sun

#6785 fixed premake sysincludedirs deprecated s0600204 Ralph Sennhauser

Description

Using premake-5.0.0_beta2

** Warning: the field sysincludedirs has been deprecated and will be removed.
   Use `externalincludedirs` instead.

#6771 fixed Unable to start AI sandbox difficulty from the command line Freagarach Langbart

Description

to reproduce

try to start a match with an AI player set to difficulty 0 (sandbox)
- see binaries/system/readme.txt

Line
12	-autostart-ai=PLAYER:AI sets the AI for PLAYER (e.g. 2:petra)
13	-autostart-aidiff=PLAYER:DIFF sets the DIFFiculty of PLAYER's AI (0: sandbox, 5: very hard)
14	-autostart-aiseed=AISEED sets the seed used for the AI random generator (default 0, use -1 for random)

pyrogenesis -autostart="random/mainland" -autostart-ai=1:petra -autostart-aidiff=1:0 -autostart-player=-1

errrors

0 A.D. (0.0.27) Main log (warnings and errors only)
ERROR: JavaScript error: gamesettings/attributes/PlayerAI.js line 51 Engine.ConfigDB_GetValue is not a function fromInitAttributes@gamesettings/attributes/PlayerAI.js:51:46 fromInitAttributes@gamesettings/GameSettings.js:90:17 AutoStart@autostart/autostart.js:6:17 autostartHost@autostart/entrypoint.js:49:23

Engine exited successfully on 2023-04-01 at 14:38:55 with 423 message(s), 1 error(s) and 0 warning(s).

reproducible

issue does not occur in A25b [25860]
issue occurs in A26 [27104]

bisect (not tested, just a guess based on previous tickets)

likely introduced with [26584]

related tickets

#6471 (21/Mar/22)
#6521 (26/Apr/22)

#6770 duplicate Dynamic layout for summary obelix

Description

Not all parts of the UI are adjusted for window size. In the reported case the summary contains table headings not dynamic enough to handle long word/terms (especially appearing in German language).

Proposal by vladislavbelov at the forums:

'I think we might make a dynamic layout: if we have width <= 1024 (or some min_width property) then we stick to the current layout else we extend a table accounting preferred widths of its columns (preferred means translated text width + some padding).'

#6768 fixed Crash when there are to many entities Vladislav Belov David Preston

Description

First time I have seen this error after many, many games.

Assertion failed: "m_EntitiesDrawn < MAX_ENTITIES_DRAWN"
Location: minimaptexture.cpp:691 (CMiniMapTexture::RenderFinalTexture)

Call stack:

01361DF8

01364C08

01367523

013510D5


errno = 0 (No error reported here)
OS error = 0 (no error code was set)

Windows 7 Pro SP1, GTX 750 Ti

Clicked 'Continue' (I think) and briefly saw a different, more OS-related error before prog bailed out completely leaving no opportunity to gather any more info.

#6766 fixed [macOS Vulkan] Assertion failed Langbart

Description

to reproduce

start a game with civs listed in the table below, place those buildings

pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan -autostart="random/mainland" -autostart-civ=1:<CIV NAME>

civ	building(s) causing Assertion failed	building(s) causing spirv errors
athen	corral, forge	dock
brit	forge	wonder
gaul	forge	wonder
kush		Blemmye camp
mace	corral, forge	dock
maur	forge
pers	wonder
ptol	market	wonder
rome	forge

lldb for athen corral

Assertion failed: "m_Framebuffer->GetDepthStencilAttachment() != textureToBind"
Location: DeviceCommandContext.cpp:901 (SetTexture)

Call stack:

(error while dumping stack: Function not supported)
errno = 0 (No error reported here)
OS error = ?


(C)ontinue, (S)uppress, (B)reak, Launch (D)ebugger, or (E)xit?
e
Redirecting call to abort() to mozalloc_abort

pyrogenesis was compiled with optimization - stepping may behave oddly; variables may not be available.
Process 22693 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000010115eb80 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
   30   #ifdef MOZ_WIDGET_ANDROID
   31     abortThroughJava(msg);
   32   #endif
-> 33     MOZ_CRASH();
   34   }
   35   
   36   #ifdef MOZ_WIDGET_ANDROID
Target 0: (pyrogenesis) stopped.
(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x000000010115eb80 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
    frame #1: 0x0000000101cd844d pyrogenesis`::abort() at mozalloc_abort.cpp:86:3 [opt]
    frame #2: 0x0000000100566676 pyrogenesis`sys_display_error(text=<unavailable>, flags=6) at unix.cpp:268:4 [opt]
    frame #3: 0x0000000100549123 pyrogenesis`debug_DisplayError(wchar_t const*, unsigned long, void*, wchar_t const*, wchar_t const*, int, char const*, long volatile*) [inlined] CallDisplayError(text=L"Assertion failed: \"m_Framebuffer->GetDepthStencilAttachment() != textureToBind\"\r\nLocation: DeviceCommandContext.cpp:901 (SetTexture)\r\n\r\nCall stack:\r\n\r\n(error while dumping stack: Function not supported)\r\nerrno = 0 (No error reported here)\r\nOS error = ?\r\n", flags=6) at debug.cpp:374:8 [opt]
    frame #4: 0x0000000100549106 pyrogenesis`debug_DisplayError(description=L"Assertion failed: \"m_Framebuffer->GetDepthStencilAttachment() != textureToBind\"", flags=6, context=0x00007ffeefbfd640, lastFuncToSkip=<unavailable>, pathname=L"../../../source/renderer/backend/vulkan/DeviceCommandContext.cpp", line=901, func=<unavailable>, suppress=0x0000000103d06118) at debug.cpp:460 [opt]
    frame #5: 0x000000010054998e pyrogenesis`debug_OnAssertionFailure(expr=<unavailable>, suppress=0x0000000103d06118, file=<unavailable>, line=<unavailable>, func=<unavailable>) at debug.cpp:547:9 [opt]
    frame #6: 0x0000000100429e6a pyrogenesis`Renderer::Backend::Vulkan::CDeviceCommandContext::SetTexture(this=0x0000000105f08480, bindingSlot=25, texture=0x000000010b3b2230) at DeviceCommandContext.cpp:901:3 [opt]
    frame #7: 0x00000001003c0c25 pyrogenesis`ShadowMap::BindTo(this=0x000000010696bcf0, deviceCommandContext=0x0000000105f08480, shader=0x000000012f7b1490) const at ShadowMap.cpp:653:24 [opt]
    frame #8: 0x00000001003ac609 pyrogenesis`ShaderRenderModifier::BeginPass(this=0x000000010f09ff50, deviceCommandContext=0x0000000105f08480, shader=0x000000012f7b1490) at RenderModifiers.cpp:83:19 [opt]
    frame #9: 0x0000000100384080 pyrogenesis`ShaderModelRenderer::Render(this=0x000000010b2257d0, deviceCommandContext=0x0000000105f08480, modifier=std::__1::shared_ptr<RenderModifier>::element_type @ 0x000000010f09ff50 strong=2 weak=1, context=0x0000000000000000, cullGroup=<unavailable>, flags=<unavailable>) at ModelRenderer.cpp:623:15 [opt]
    frame #10: 0x00000001003b8a16 pyrogenesis`CSceneRenderer::Internals::CallModelRenderers(this=0x000000010696a800, deviceCommandContext=0x0000000105f08480, context=0x00007ffeefbfe3b0, cullGroup=1, flags=1) at SceneRenderer.cpp:161:27 [opt]
    frame #11: 0x00000001003b8775 pyrogenesis`CSceneRenderer::RenderShadowMap(this=0x000000010f808468, deviceCommandContext=0x0000000105f08480, context=<unavailable>) at SceneRenderer.cpp:327:7 [opt]
    frame #12: 0x00000001003bb25a pyrogenesis`CSceneRenderer::PrepareSubmissions(this=0x000000010f808468, deviceCommandContext=0x0000000105f08480, waterScissor=0x000000010f808724) at SceneRenderer.cpp:821:3 [opt]
    frame #13: 0x00000001003bc4c2 pyrogenesis`CSceneRenderer::PrepareScene(this=0x000000010f808468, deviceCommandContext=0x0000000105f08480, scene=0x000000010b252180) at SceneRenderer.cpp:1135:2 [opt]
    frame #14: 0x00000001003af455 pyrogenesis`CRenderer::RenderFrameImpl(this=0x000000010e74d9a0, renderGUI=<unavailable>, renderLogger=<unavailable>) at Renderer.cpp:487:22 [opt]
    frame #15: 0x00000001003ad76d pyrogenesis`CRenderer::RenderFrame(this=0x000000010e74d9a0, needsPresent=true) at Renderer.cpp:457:3 [opt]
    frame #16: 0x0000000100004bd1 pyrogenesis`RunGameOrAtlas(PS::span<char const* const>) [inlined] Frame() at main.cpp:444:13 [opt]
    frame #17: 0x0000000100004310 pyrogenesis`RunGameOrAtlas(argv=<unavailable>) at main.cpp:687 [opt]
    frame #18: 0x00000001000028f7 pyrogenesis`main(argc=6, argv=0x00007ffeefbfeec8) at main.cpp:740:2 [opt]
    frame #19: 0x00007fff665c3cc9 libdyld.dylib`start + 1
    frame #20: 0x00007fff665c3cc9 libdyld.dylib`start + 1

{
    "name": "0ad-spirv",
    "version": "0.27.17",
    "label": "SPIR-V shaders",
    "url": "https://play0ad.com",
    "description": "SPIR-V shaders for Vulkan backend.",
    "dependencies": ["0ad>=0.0.27"]
}

#6762 worksforme mac m1 can't start game aqax3

Description

I downloaded the m1 version directly from the page, because torrent has no seeders, and can't open the app, because the files are damaged

#6761 duplicate Crashing when opened Justin

Description

At first I was installing the latest version (0.0.26), but I was trying to install a mod onto it and it required an older version. I made sure to uninstall the newest version so I could get the older one ready, but every time I try to install that version of 0 A.D. the game crashes and says:

Much to our regret we must report the program has encountered an error.

Please let us know at http://trac.wildfiregames.com/ and attach the crashlog.txt and crashlog.dmp files. You may find paths to these files at https://trac.wildfiregames.com/wiki/GameDataPaths

Details: unhandled exception (std::out_of_range("invalid bitset<N> position"))

Location: unknown:0 (RtlClearBits)

Call stack:

(error while dumping stack: No stack frames found) errno = 0 (No error reported here) OS error = 0 (no error code was set)

I contacted the owner of the mod and they tried to help me with it, but ultimately its a problem with the game engine.

#6756 fixed palm_tropical visual bug wowgetoffyourcellphone Langbart

Description

reported in the forum by Akira Kurosawa
- Metal palm trees (1/Mar/23)

to reproduce

open Atlas
place some gaia/tree/palm_tropical.xml

possible solution

wowgetoffyourcellphone wrote:

... The uv map just needs fixed, is all. Probably added geometry to allow for the texture area provided.

#6755 fixed Incorrect description for modifying the BatchTimeModifier Langbart

Description

vaguely reported in the forum by wang_wei_2
- Incredibly fast training times (3/Mar/23)

to reproduce

start a game with Athens
build a barracks and look at the time it takes to train Hoplites in different batches

research Conscription

source:ps/trunk/binaries/data/mods/public/art/textures/ui/session/portraits/technologies/fist_spear_fire.png@27570

and look at the time it takes to train Hoplites again

Line
1	{
2	"genericName": "Conscription",
3	"description": "Significantly increase training speed of infantry by training them in large batches or companies.",
4	"cost": {
5	"food": 500
6	},
7	"requirements": {
8	"all": [
9	{ "tech": "phase_city" },
10	{ "notciv": "pers" }
11	]
12	},
13	"requirementsTooltip": "Unlocked in City Phase.",
14	"icon": "ist_spear_fire.pngf",
15	"researchTime": 40,
16	"tooltip": "Barracks −10% batch training time.",
17	"modifications": [
18	{ "value": "Trainer/BatchTimeModifier", "add": -0.1 }
19	],
20	"affects": ["Barracks"],
21	"soundComplete": "interface/alarm/alarm_upgradearmory.xml"
22	}

Batch size	Normal Time (in seconds)	Conscription Time (in seconds)	% Change
5	37	31	-16.22%
10	64	51	-20.3%
15	88	67	-23.86%
20	110	82	-25.45%

A reduction of 0.1 will not result in a 10% reduction in batch time. It will always depend on the batch size, thus any description claiming a constant percentage reduction is incorrect.

Batch Training Time = costBuildTime * batchSize^{batchTimeModifier}

Changing the Cost Build Time
Batch Training Time change = newCostBuildTime/oldCostBuildTime -1

Changing the Batch Time Modifier
Batch Training Time change = batchSize^{newBatchTimeModifier - oldBatchTimeModifier} -1

BatchTimeFactor was added with [12877]
- renamed to BatchTimeModifier in [12883]
- see comment:20:ticket:1717 by zoot
  - the name change was done to better clarify that it is an exponent

affected files:

.json
- barracks_batch_training.json added with [13400]
- stable_batch_training.json added with [13407]
- phase_city_pers.json added with [26996]
- phase_town_pers.json added with [26996]
.xml
- civil_centre_court.xml added with [26634]
  - batch time modifier was halved
    - batch size x would lead to a Batch Training Time change of: x^0.4-0.8-1
      - batch size 16 = -67%
      - batch size 32 = -75%
      - batch size 64 = -81%
      - ...

possible solution (1)

Adapt description to vaguely describe that there is a reduction
- it must be short and precise, no long, overly complex, compound sentences

possible solution (2)

modify Cost/BuildTime instead of Trainer/BatchTimeModifier

    "modifications": [
        { "value": "Cost/BuildTime", "multiply": 0.9 },

#6753 duplicate Error - ios High Sierra 10.13.6 Nemo Fbis

Description

Hey guys, first time ever here. I am a occasional 0ad player, ive been playing during quarantine in 2021 with no probs with the same laptop.

MacBook Pro (13-inch, Mid 2012) 2,5 GHz Intel Core i5 8 GB 1333 MHz DDR3 Intel HD Graphics 4000 1536 MB

I know its an old one but is ok.

i have this error in the photo and cannot play. any help please?

#6752 needsinfo Visuals are often scrambled John

Description

Icons and other images are often scrambled, including colours and layout, and icons in game. See attached screenshots as examples.

#6751 duplicate Update Mongoose phosit

Description

We use Mongoose 3.1. Curently the newest Mongoose version is 7.9.

Version 3.1 does manage some background threads (were the event handlers are executed). Newer versions don't do that. We have to poll once in a while. That allows us to execute the event handlers in the task manager. We need repeating tasks (see #5874) to call poll once in a while.

#6750 fixed After queued construction of several fields, woman becomes idle Freagarach Langbart

Description

to reproduce

start a game with the Han select at least 4 women and task them to build two rice fields
- You can also choose another civ, but then you would need 6 women
hold the shift key pressed while giving the order
when the second field is fully constructed, one woman becomes idle

bisect

[27559]

#6746 fixed Animal becomes idle for queued garrison Freagarach Langbart

Description

to reproduce

build and select two corrals
press ctrl while keeping shift pressed, right-click on the first corral and then on the second corral
make animals, note that the animal from the first corral does not go into the second corral once the first corral is full

expected behavior

animal goes into the second corral and does not become idle

#6744 fixed Negative animal costs and eco points in the summary Freagarach Langbart

Description

to reproduce

build a corral
make a sheep
check summary => score => economy score
check summary => resources => gathered/used

reproducible

works correctly in Alpha XXI Ulysses [18915]

Alpha XXII Venustas [19922] it shows the correct resources, but the economy score shows -5

Alpha XXIII [21946] negative eco score and wrong gathered/used

Phab:D1052

@temple wrote: (26/Nov/17) We keep track of the vegetarian food gathered, so I think the vegetarian ratio is still correct. It can get weird if we train some sheep but don't gather them, since that counts as negative food gathered, so the ratio could be over 100% or even negative in the very early game. But I don't think that's anything to worry about.

Phab:rP20543 (concerned raised - 20/Oct/19)

@elexis wrote: It changes history, once a resource was gathered, it will remain true that the resource was gathered. Therefore the number of resources gathered should be monotonically increasing. Since the economy score is also the number of resources gathered divided by 10, it equally becomes possible to reduce the score over time. Even possible to get negative score by starting the match, training some sheep and not gathering them.

simulation/components/StatisticsTracker.js

Line
219	if (cmpUnitEntityIdentity.HasClass("Domestic") && costs)
220	{
221	// Subtract costs for sheep/goats/pigs to get the net food gain/use for corralling
222	this.resourcesUsed.food -= costs.food;
223	this.resourcesGathered.food -= costs.food;
224	}

expected behavior

gather resource counter never becomes negative
no change of the history by subtracting the used resources
no negative eco points

#6740 fixed scrolling on dropdown menus causes lobby to refresh over and over Dunedan sternstaub

Description

using the scroll wheel on a dropdown menu in a hosted game causes the lobby to refresh multiple times

steps to reproduce:

1) creating a game on the multiplayer lobby

2) scroll down a dropdown menu for any option which is represented in the lobby grid view, e.g. map or player count

3) click on the small speech bubble on the right to open the lobby view

4) see how every second or so, the lobby completely refreshes, cycling through all the options which have been selected ("hovered", so to speak) in the game settings.

i have no idea if this only affects the player who created the match (and did the scrolling) or the whole public lobby.

bisect

[24686]

#6739 fixed Orange flashing pop counter on cheat code Freagarach Langbart

Description

to reproduce

start a map with a civ of your own choice
enter gift from the gods
select CC and enter salad bowl 200
- You may have to run the command twice for civs with a large CC like Han/Ptol/Maur
notice the pop counter blinks orange
delete all units, it still flashes
it only stops when producing a new unit
minimal replay (~1min)
- attachment:commands.txt

reproducible

does not occur in A25b
starts to occur with A26

bisect

(none, likely [26000])

possible solution ?

binaries/data/mods/public/simulation/components/Trainer.js

a	b	Trainer.prototype.Item.prototype.Spawn = function()
304	304	}
305	305	if (this.count)
306	306	{
	307	const cmpProductionQueue = Engine.QueryInterface(this.trainer, IID_ProductionQueue);
	308	if (cmpProductionQueue.queue.length)
307	309	cmpPlayer.BlockTraining();
308	310
309	311	if (!this.spawnNotified)

#6738 fixed Textures having png and dds in tree - part 2 Stan Ralph Sennhauser

Description

Sine #6326 a few new ones were added, still there should only be a png or dds per name.

./binaries/data/mods/public/art/textures/skins/gaia/bamboo.dds
./binaries/data/mods/public/art/textures/skins/props/head/pers_face_i.dds
./binaries/data/mods/public/art/textures/skins/props/head/pers_face_j.dds
./binaries/data/mods/public/art/textures/skins/props/head/pers_face_b.dds
./binaries/data/mods/public/art/textures/skins/props/head/pers_face_a.dds

#6736 duplicate Warning and Error displayed in game Matteo Nigro

Description

The message is repeated hundreds of times by varying the type of structure:

WARNING: PlayerID 6 | Petra error in incrementBuilderCounters for structures/spart/syssiton with count < 0

Added to this is this error message:

ERROR: JavaScript error: simulation/ai/common-api/utils.js line 27 undefined has no properties API3</m.SquareVectorDistance@simulation/ai/common-api/utils.js:27:2 PETRA.AttackPlan.prototype.getNearestTarget@simulation/ai/petra/attackPlan.js:939:19 PETRA.AttackPlan.prototype.UpdateTarget@simulation/ai/petra/attackPlan.js:1959:22 PETRA.AttackPlan.prototype.update@simulation/ai/petra/attackPlan.js:1336:13 PETRA.AttackManager.prototype.update@simulation/ai/petra/attackManager.js:322:27 PETRA.HQ.prototype.update@simulation/ai/petra/headquarters.js:2285:22 PETRA.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:118:11 m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:64:7

#6735 fixed Frantic activity of AI-controlled relics Langbart

Description

to reproduce

start a map with ai controlled players and some relics (currently at [27531] there is a bug, wait till Phab:D4934 has been merged)

# 1v1 AI match with 14 relics; small map; pay attention to the relics being captured
pyrogenesis -autostart-size=128 -autostart="random/mainland" -autostart-ai=1:petra -autostart-ai=2:petra -autostart-victory=capture_the_relic -autostart-reliccount=14 -autostart-player=-1

move the game speed to 20x
wait till some captured relics reach the civic center
notice the frantic movement of the relic trying to find a spot

replay

attachment:commands_27531_D4933_D4934.txt:ticket:6385

reproducible

issue is not reproducible on A23b
a bit observable in A24b and A25b, but they find their position more quickly and are not trapped in an endless loop
issue is reproducible in A26

bisect

(none)

#6733 duplicate Garrison waypoint cursor can be incorrect wowgetoffyourcellphone

Description

If I set a waypoint from a barracks or other soldier producing structure to an enemy structure the cursor is always attack, setting an attack command for the outcoming units.

But if that building is unattackable (it can only be captured for example), the newly trained units will just stand there in front of their trainer building. Expected Behavior:

That waypoint cursor should have changed to capture in this instance and the exiting units should have gone to go capture that building.

#6732 worksforme New temple tech for self healing while being garrisoned in a ship obelix

Description

Now, garrisoned units in ships do not heal themselves like on land (if the temple tech is researched) or get healed by nearby priests.

Proposed enhancement: If you garrison units in war ships, they shall heal themselves, after a tech in temple is researched. This new research option would succes the research of the "heart". Game balancers may state if those units get the same speed of healing like on land or slower.

#6729 fixed [macOS] Check for the existence of libMoltenVK Stan Langbart

Description

Check if the libMoltenVK.dylib still exists in the binaries/system/ folder.

reason

was looking for a bug
had some problems building
deleted the binaries/system/ folder and made a clean build
got some errors when trying to start Vulkan

errors

0 A.D. (0.0.27) Main log (warnings and errors only)
WARNING: Failed to load @executable_path/libMoltenVK.dylib.

ERROR: Unable to create device for Vulkan backend, switching to GL.

Engine exited successfully on 2023-02-08 at 07:37:26 with 1035 message(s), 1 error(s) and 1 warning(s).

workaround

# delete the file
rm -rf libraries/osx/molten-vk/.already-built
# run the script again
./libraries/osx/build-osx-libs.sh
# start vulkan
pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan

possible solution

libraries/osx/build-osx-libs.sh

                LIB_URL="https://releases.wildfiregames.com/libs/"
 mkdir -p "molten-vk"
 pushd "molten-vk" > /dev/null
 if [[ "$force_rebuild" = "true" ]] || [[ ! -e .already-built ]] || [[ "$(<.already-built)" != "$MOLTENVK_VERSION" ]]
+if [[ "$force_rebuild" = "true" ]] || [[ ! -e .already-built ]] || [[ "$(<.already-built)" != "$MOLTENVK_VERSION" ]] || [[ ! -e ../../../binaries/system/libMoltenVK.dylib ]]
 then
   INSTALL_DIR="../../../../binaries/system/"
   rm -f .already-built

#6728 fixed Give the name of the civilization for the generic name of the relic wowgetoffyourcellphone Langbart

Description

to reproduce

go to options General => Naming of entities.
select Only Generic Names from the dropdown

start a map with some relics

# command line
pyrogenesis -autostart-size=128 -autostart="random/mainland" -autostart-victory=capture_the_relic -autostart-reliccount=14

select some Relics
notice it is hard to differentiate them without the tooltip

expected behavior

the relics would be called with their civ name

possible solution

14x

binaries/data/mods/public/simulation/templates/units/maur/catafalque.xml

-              a
   </Auras>
   <Identity>
     <Civ>maur</Civ>
+    <GenericName>Mauryan Catafalque</GenericName>
     <SpecificName>Bindusara</SpecificName>
   </Identity>
 </Entity>

nitpick

the option Naming of entities. is the only one that has a redundant . (added with [25116])

#6727 fixed Rally point relics Freagarach Langbart

Description

to reproduce

start a map with some relics

# command line
pyrogenesis -autostart-size=128 -autostart="random/mainland" -autostart-victory=capture_the_relic -autostart-reliccount=14

train a horse in your CivicCenter
set the rally point from the CivicCenter to a relic
notice the horse will not move to the relic after it has been trained

bisect

when reverting [27506] and [27399] the issue cleanly resolves.

#6726 duplicate Set HiDPI as default Langbart

Description

HiDPI makes the icon/text look sharper.

Under macOS you can use HiDPI with Vulkan, only problem so far is that a lot of text is not rendered, but no errors occur and it is playable.

# start HiDPI in macos
pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan -conf=hidpi:true

#6724 fixed Requirement tooltip errors for Ptolemaic barracks Freagarach Langbart

Description

to reproduce

start map with ptol
build && select a Barrack
errors
the Royal Guard Infantry has two requirements phase_city and unlock_champion_infantry

errors

ERROR: JavaScript error: gui/common/l10n.js line 69
Script value conversion check failed: v.isString() || v.isNumber() || v.isBoolean() (got type undefined)
  translate@gui/common/l10n.js:69:36
  getRequirementsTooltip@gui/common/tooltips.js:975:23
  setupButton@gui/session/selection_panels.js:1051:4
  setupUnitPanel@gui/session/unit_commands.js:94:35
  updateUnitCommands@gui/session/unit_commands.js:152:18
  updateSelectionDetails@gui/session/selection_details.js:537:20
  updateGUIObjects@gui/session/session.js:730:2
  onSimulationUpdate@gui/session/session.js:680:2
  __eventhandler6 (SimulationUpdate)@session SimulationUpdate:1:1
ERROR: Errors executing script event "SimulationUpdate"

bisect

likley [27245]

possible solution

binaries/data/mods/public/simulation/templates/units/ptol/champion_infantry_pikeman.xml

-              a
     <Icon>units/ptol/champion_infantry.png</Icon>
     <Requirements>
       <Techs datatype="tokens">unlock_champion_infantry</Techs>
+      <Tooltip>Ask Freagarach</Tooltip>
     </Requirements>
   </Identity>
   <VisualActor>

related ticket to requirement feature

#6705

#6723 fixed [Vulkan] Lowering shader effects causes black spots on fields Langbart

Description

to reproduce

go to settings, enable Vulkan and set Shader effects to a value between 1 ≤ x < 8
restart the game (even if Vulkan was already set, and you only adjusted Shader effects)
start a map with any civ except Han (rice fields don't have this issue)
- Hint: skirmishes/nile_river_4p has pre-placed farm fields, well-suited for testing this issue

build a farm field and notice the issue seen in the image

# command line
pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan -autostart="skirmishes/nile_river_4p"  -autostart-civ=1:athen -conf=materialmgr.quality:5

further actors with the same issue

the problem can also be found in actor|props/flora/grass_tropic_field.xml, which often occurs in the India biome

bisect (update)

[27368] ~35 files contain the basic_trans_wind_grain_norm_spec.xml file, undo the change and the issue disappears

cd binaries/data/mods/public/art
rg --stats --files-with-matches --type xml "basic_trans_wind_grain_norm_spec.xml"

actors/props/flora/grass_summer.xml
actors/props/flora/grass_tropic_field.xml
actors/props/flora/grass_soft_small_tall.xml
actors/props/flora/reeds_giant.xml
actors/props/flora/grass_soft_dry_small_tall.xml
actors/props/flora/grass_soft_large.xml
actors/props/flora/grass_medit_field.xml
actors/props/flora/grass_soft_small.xml
actors/props/flora/grass_field_flowering_tall.xml
actors/props/flora/grass_wispy.xml
actors/props/flora/farming_wheat_harvest_b.xml
actors/props/flora/grass_woody.xml
actors/props/flora/grass_leafy.xml
actors/props/flora/grass_field_dry_tall.xml
actors/props/flora/farming_wheat_harvest_a.xml
actors/props/flora/grass_tropical.xml
actors/props/flora/papyrus.xml
actors/props/flora/grass_soft_dry_small.xml
actors/props/flora/grass_woody_dry.xml
actors/props/flora/cattails_autumn.xml
actors/props/flora/grass_soft_dry_large_tall.xml
actors/props/flora/grass_savanna.xml
actors/props/flora/grass_soft_dry_large.xml
actors/props/flora/grass_temp_field.xml
actors/props/flora/grass_field_dry_tall_b.xml
actors/props/flora/grass_soft_large_tall.xml
actors/props/flora/farming_millet_harvest_d.xml
actors/props/flora/grass_temp_field_dry.xml
actors/props/flora/cattails.xml
actors/props/flora/farming_millet_harvest_b.xml
actors/props/flora/farming_millet_harvest_c.xml
actors/props/flora/farming_barley_harvest_a.xml
actors/props/flora/farming_millet_harvest_a.xml
actors/props/flora/grass_temp_field_brown.xml
actors/props/flora/farming_barley_harvest_b.xml

35 matches
35 matched lines
35 files contained matches
7347 files searched
0 bytes printed
8144330 bytes searched
1.657385 seconds spent searching
0.304723 seconds

note

0ad-spirv version

{
    "name": "0ad-spirv",
    "version": "0.27.13",
    "label": "SPIR-V shaders",
    "url": "https://play0ad.com",
    "description": "SPIR-V shaders for Vulkan backend.",
    "dependencies": ["0ad>=0.0.27"]
}

#6720 fixed [Vulkan] blinking obstruction overlay Langbart

Description

to reproduce

enable Vulkan as renderbackend

start the random/wall_demo map

pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan -autostart="random/wall_demo"

open Developer Overlay - Alt+D
toggle the option `

Obstruction overlay`

see GIF below

similar tickets

#6717

#6719 fixed [macOS] [Vulkan] Suppress mvk-info messages from command line Stan Langbart

Description

originally posted on D4905 (26/Jan/23)

to reproduce

enable Vulkan as renderbackend

start pyrogenesis, for example

pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan

notice the terminal output fills up with mvk-info

pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan 
Valid app bundle detected
TIMER| InitVfs: 2.166 ms
FILES| Main log written to '/Users/paria/Library/Application Support/0ad/logs/mainlog.html'
FILES| Interesting log written to '/Users/paria/Library/Application Support/0ad/logs/interestinglog.html'
TIMER| CONFIG_Init: 9.619 ms
Valid app bundle detected
Valid app bundle detected
Sound: AlcInit success, using Built-in Output
[mvk-info] MoltenVK version 1.2.2, supporting Vulkan version 1.2.239.
    The following 78 Vulkan extensions are supported:
        VK_KHR_16bit_storage v1
        VK_KHR_8bit_storage v1
        VK_KHR_bind_memory2 v1
        VK_KHR_copy_commands2 v1
        VK_KHR_create_renderpass2 v1
        VK_KHR_dedicated_allocation v3
        VK_KHR_depth_stencil_resolve v1
        VK_KHR_descriptor_update_template v1
        VK_KHR_device_group v4
        VK_KHR_device_group_creation v1
        VK_KHR_driver_properties v1
        VK_KHR_dynamic_rendering v1
        VK_KHR_external_fence v1
        VK_KHR_external_fence_capabilities v1
        VK_KHR_external_memory v1
        VK_KHR_external_memory_capabilities v1
        VK_KHR_external_semaphore v1
        VK_KHR_external_semaphore_capabilities v1
        VK_KHR_fragment_shader_barycentric v1
        VK_KHR_get_memory_requirements2 v1
        VK_KHR_get_physical_device_properties2 v2
        VK_KHR_get_surface_capabilities2 v1
        VK_KHR_imageless_framebuffer v1
        VK_KHR_image_format_list v1
        VK_KHR_maintenance1 v2
        VK_KHR_maintenance2 v1
        VK_KHR_maintenance3 v1
        VK_KHR_multiview v1
        VK_KHR_portability_subset v1
        VK_KHR_push_descriptor v2
        VK_KHR_relaxed_block_layout v1
        VK_KHR_sampler_mirror_clamp_to_edge v3
        VK_KHR_sampler_ycbcr_conversion v14
        VK_KHR_separate_depth_stencil_layouts v1
        VK_KHR_shader_draw_parameters v1
        VK_KHR_shader_float_controls v4
        VK_KHR_shader_float16_int8 v1
        VK_KHR_shader_subgroup_extended_types v1
        VK_KHR_spirv_1_4 v1
        VK_KHR_storage_buffer_storage_class v1
        VK_KHR_surface v25
        VK_KHR_swapchain v70
        VK_KHR_swapchain_mutable_format v1
        VK_KHR_timeline_semaphore v2
        VK_KHR_uniform_buffer_standard_layout v1
        VK_KHR_variable_pointers v1
        VK_EXT_debug_marker v4
        VK_EXT_debug_report v10
        VK_EXT_debug_utils v2
        VK_EXT_descriptor_indexing v2
        VK_EXT_fragment_shader_interlock v1
        VK_EXT_hdr_metadata v2
        VK_EXT_host_query_reset v1
        VK_EXT_image_robustness v1
        VK_EXT_inline_uniform_block v1
        VK_EXT_memory_budget v1
        VK_EXT_metal_objects v1
        VK_EXT_metal_surface v1
        VK_EXT_private_data v1
        VK_EXT_robustness2 v1
        VK_EXT_sample_locations v1
        VK_EXT_scalar_block_layout v1
        VK_EXT_separate_stencil_usage v1
        VK_EXT_shader_stencil_export v1
        VK_EXT_shader_viewport_index_layer v1
        VK_EXT_subgroup_size_control v2
        VK_EXT_swapchain_colorspace v4
        VK_EXT_texel_buffer_alignment v1
        VK_EXT_vertex_attribute_divisor v3
        VK_AMD_gpu_shader_half_float v2
        VK_AMD_negative_viewport_height v1
        VK_AMD_shader_trinary_minmax v1
        VK_INTEL_shader_integer_functions2 v1
        VK_GOOGLE_display_timing v1
        VK_MVK_macos_surface v3
        VK_MVK_moltenvk v36
        VK_NV_fragment_shader_barycentric v1
        VK_NV_glsl_shader v1
[mvk-info] GPU device:
        model: NVIDIA GeForce GT 650M
        type: Discrete
        vendorID: 0x10de
        deviceID: 0x0fd5
        pipelineCacheUUID: 000027DA-0A0F-07D1-0000-000000000000
    supports the following Metal Versions, GPU's and Feature Sets:
        Metal Shading Language 2.2
        GPU Family Mac 1
        GPU Family Common 2
        GPU Family Common 1
        macOS GPU Family 1 v4
        macOS GPU Family 1 v3
        macOS GPU Family 1 v2
        macOS GPU Family 1 v1
[mvk-info] GPU device:
        model: Intel HD Graphics 4000
        type: Integrated
        vendorID: 0x8086
        deviceID: 0x0166
        pipelineCacheUUID: 000027DA-0A0F-07D1-0000-000000000000
    supports the following Metal Versions, GPU's and Feature Sets:
        Metal Shading Language 2.2
        GPU Family Mac 1
        GPU Family Common 2
        GPU Family Common 1
        macOS GPU Family 1 v4
        macOS GPU Family 1 v3
        macOS GPU Family 1 v2
        macOS GPU Family 1 v1
[mvk-info] Created VkInstance for Vulkan version 1.1.0, as requested by app, with the following 2 Vulkan extensions enabled:
        VK_KHR_surface v25
        VK_MVK_macos_surface v3
[mvk-info] Vulkan semaphores using Metal implicit guarantees within a single queue.
[mvk-info] Created VkDevice to run on GPU NVIDIA GeForce GT 650M with the following 1 Vulkan extensions enabled:
        VK_KHR_swapchain v70
[mvk-info] Created 3 swapchain images with initial size (1280, 800) and contents scale 1.0 for screen Built-in Display.
FILES| UserReport written to '/Users/paria/Library/Application Support/0ad/logs/userreport_hwdetect.txt'
TIMER| RunHardwareDetection: 16.196 ms
FILES| Hardware details written to '/Users/paria/Library/Application Support/0ad/logs/system_info.txt'
TIMER| write_sys_info: 17.03 ms
TIMER| InitRenderer: 105.117 ms
TIMER| ps_console: 10.174 ms
TIMER| ps_lang_hotkeys: 4.933 ms
TIMER| common/modern/setup.xml: 2.632 ms
TIMER| common/modern/styles.xml: 582 us
TIMER| common/modern/sprites.xml: 1.829 ms
TIMER| common/global.xml: 927 us
TIMER| common/setup.xml: 737 us
TIMER| common/sprites.xml: 963 us
TIMER| common/styles.xml: 163 us
TIMER| pregame/backgrounds/: 707 us
TIMER| pregame/sprites.xml: 631 us
TIMER| pregame/styles.xml: 73 us
TIMER| pregame/mainmenu.xml: 75.632 ms

expected behaviour

hide those messages from the terminal

#6717 fixed [macOS] [Vulkan] Texture Quality mischief Vladislav Belov Langbart

Description

originally posted on D4905 (26/Jan/23)

to reproduce

enable Vulkan as renderbackend

start any map, for example random/mainland

 pyrogenesis -mod=public -mod=0ad-spirv -conf=rendererbackend:vulkan -autostart="random/mainland"

go into settings and change the option under Texture Quality
textures start to blink, see video link below
- https://ttm.sh/SIe.25x_1000

bisect

(not possible, Vulkan support came with [27488] for macOS)

#6716 fixed Update gitignore for molten-vk Stan Langbart

Description

to reproduce

run
```
./libraries/osx/build-osx-libs.sh
```

check git status

❯ git status --short
?? libraries/osx/molten-vk/

bisect

[27488]

similar commits in the past

#6402 FreeType
- GitHub: Ignore freetype build artifacts on macOS (21/Dec/21)

#6715 fixed GUI scaling messes up selection rectangle in ATLAS only trompetin17 AlThePhoenix

Description

I noticed that while I have GUI scaling set to 125% in the game's options, whenever I want to do a drag selection in ATLAS with the Move/Rotate cursor ONLY, the rectangle that appears (which shows you where you are going to select things) is in the wrong position.

I cannot really make a screenshot of this because the cursor doesn't appear in them, but just to make sure you understand what rectangle I'm talking about:

#6710 fixed --with-system-premake is broken Itms Stan

Description

As reported on Phab:D3127 A made a mistake was made when adding a the --with-system-premake option in Phab:D2519/ Phab:rP23675. It does not go in the correct folder.

Patch by sera:

build/workspaces/update-workspaces.sh

                fi
 # Now run premake to create the makefiles
+cd ../premake/premake5
 premake_command="premake5"
 if [ "$with_system_premake5" = "false" ]; then
   # Build bundled premake
-  cd ../premake/premake5
   PREMAKE_BUILD_DIR=build/gmake2.unix
   # BSD and OS X need different Makefiles
   case "`uname -s`" in

#6708 fixed Catapults fire infinitely marder Langbart

Description

this issue has several reporters:

borg via Catapults fire infinitely (18/Jan/23)
andy5995 Alpha 26 Pre-release/Release Candidate Build Testing (29/Jul/22)

to reproduce

build a siege catapult, attack a large building (fortress, city center).
the siege units do not see the progress of their destruction and therefore fire continuously.

reproducible

there is no such issue in A23
- in A23 the difference between Range and MaxRange was 40
- average CC has a footprint of 32x32 (diagonal 45)

bisect

the initial change was [24658]
- reducing the Range from 120 to 100
then came [25341] making the issue worse
- MaxRange gets increased from 80 to 100
[26703] adds a bit of range back
- Range goes from 100 to 115

expected behavior

Catapults need to know when a buildings is down, they can't just fire for ever

possible solutions

(A) decrease attack range again
(B) increase vision range even more
in the forum is a mentioning of a patch to making attackers temporary visible

#6707 fixed Animal actor on siege catapult changes color through packing Freagarach Langbart

Description

This issue was reported by Aristippus of Cyrene in the forum

Chinese mangonels (15/Dec/22)

to reproduce

start a game with Han, or any other civ that has a catapult
unpack it and pack it a couple of times, pay attention to the color of the animal

HAN

MACE

reproducible

this has been the case since at least A24 [24937]

possible workaround

change the settings to None for Model appearance randomization
- this setting came with [25613]

expected behaviour

the animal actor changes back to its original color instead of choosing a random color

#6705 fixed GAIA woman requirement errors Freagarach Langbart

Description

to reproduce

start a game with any civ, except Han
type exodia 1 or resign immediately
select a GAIA woman

errors

ERROR: Error calling component script function ScriptCall
 ERROR: JavaScript error: simulation/helpers/Requirements.js line 124
cmpTechManager is null
  RequirementsHelper.prototype.AllRequirementsMet@simulation/helpers/Requirements.js:124:6
  RequirementsHelper.prototype.AreRequirementsMet@simulation/helpers/Requirements.js:93:14
  GuiInterface.prototype.AreRequirementsMet@simulation/components/GuiInterface.js:667:50
  GuiInterface.prototype.ScriptCall@simulation/components/GuiInterface.js:2130:20
  setupButton@gui/session/selection_panels.js:169:34
  setupUnitPanel@gui/session/unit_commands.js:94:35
  updateUnitCommands@gui/session/unit_commands.js:152:18
  updateSelectionDetails@gui/session/selection_details.js:537:20
  updateGUIObjects@gui/session/session.js:730:2
  onSimulationUpdate@gui/session/session.js:680:2
  __eventhandler54 (SimulationUpdate)@session SimulationUpdate:1:1

bisect

[27245]

possible solution ?

binaries/data/mods/public/simulation/helpers/Requirements.js

                RequirementsHelper.prototype.AllRequirementsMet = function(template, cmpTechMana
         if (requirementType === "Techs")
             for (const tech of requirement.split(" "))
                 if (tech[0] === "!" ? cmpTechManager.IsTechnologyResearched(tech.substring(1)) :
                     !cmpTechManager.IsTechnologyResearched(tech))
+                    !cmpTechManager?.IsTechnologyResearched(tech))
                     return false;
+    }
     return true;

#6703 duplicate Force delete does not work. real_tabasco_sauce

Description

Regardless of the hotkey selected, force delete (or delete without confirmation) does not work. Instead, I am presented with the delete confirmation window. Not sure if other mac users have this issue. steps to reproduce:

Start a game
Select a unit
try Shift+delete to delete the unit without confirmation.

Thanks!

#6702 wontfix [macOS debug mode] pyrogenesis_dbg process freezes or is extremely slow when starting the game Langbart

Description

to reproduce

build the macOS debug version
- BuildInstructions#Buildthegame macOS debug

./build/workspaces/update-workspaces.sh -j5 && cd gcc && make config=debug -j5

this will create another executable called pyrogenesis_dbg in the /binaries/system folder

run pyrogenesis_dbg and try to initialize a game or watch a replay

# Example: start a Mainland map from the command line
pyrogenesis_dbg -conf=mod.enabledmods:"mod public" -autostart="random/mainland"

the loading page is displayed, from here are two possibilities
(A) the process hangs, as shown in red, and I quit the process manually

(B) it does spawn into the game after roughly 5mins, but its painfully slow and definitely unplayable.
- the performance I received in this mode is even worse then what I described in ~~#6593~~ (Ref: #6193)

notes

all tests were done with the default settings
I never used pyrogenesis_dbg for play testing, so I can't even give a rough estimate how long this has been broken
this ticket was created after investigating Ticket #6699

bisect

(none, too time consuming at the moment)

#6700 duplicate Can't Create New Single Player Match Paul Anthony Hoti

Description

Last night, tried to start game. Couldn't, kept getting this message.

The screen says "Please wait, loading". There are a dozen error messages in the background. They go away after 15 seconds, but the match never loads.

Re-installed, still having same problem.

#6698 wontfix Premake doesn't invalidate targets after changing defines Itms Stan

Description

To reproduce. On linux or macOS run update-workspaces.sh --without-upnpc AFTER BUILDING NETWORK.

<built-in>:1:9: warning: 'CONFIG2_MINIUPNPC' macro redefined [-Wmacro-redefined]
#define CONFIG2_MINIUPNPC 0
        ^
/Users/stan/0ad-svn/build/workspaces/gcc/../../../source/lib/config2.h:86:10: note: previous definition is here
# define CONFIG2_MINIUPNPC 1
         ^
1 warning generated.
Undefined symbols for architecture arm64:
  "_FreeUPNPUrls", referenced from:
      std::__1::__function::__func<CNetServerWorker::SetupUPnP()::$_0, std::__1::allocator<CNetServerWorker::SetupUPnP()::$_0>, void ()>::operator()() in libnetwork.a(NetServer.o)
  "_UPNP_AddPortMapping", referenced from:
      CNetServerWorker::SetupUPnP() in libnetwork.a(NetServer.o)
  "_UPNP_GetExternalIPAddress", referenced from:
      CNetServerWorker::SetupUPnP() in libnetwork.a(NetServer.o)
  "_UPNP_GetIGDFromUrl", referenced from:
      CNetServerWorker::SetupUPnP() in libnetwork.a(NetServer.o)
  "_UPNP_GetSpecificPortMappingEntry", referenced from:
      CNetServerWorker::SetupUPnP() in libnetwork.a(NetServer.o)
  "_UPNP_GetValidIGD", referenced from:
      CNetServerWorker::SetupUPnP() in libnetwork.a(NetServer.o)
  "_freeUPNPDevlist", referenced from:
      std::__1::__function::__func<CNetServerWorker::SetupUPnP()::$_0, std::__1::allocator<CNetServerWorker::SetupUPnP()::$_0>, void ()>::operator()() in libnetwork.a(NetServer.o)
  "_strupnperror", referenced from:
      CNetServerWorker::SetupUPnP() in libnetwork.a(NetServer.o)
  "_upnpDiscover", referenced from:
      CNetServerWorker::SetupUPnP() in libnetwork.a(NetServer.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [../../../binaries/system/pyrogenesis] Error 1
make: *** [pyrogenesis] Error 2

#6697 invalid [macOS] 0ad drives up memory and CPU usage making the computer unusable Langbart

Description

I have built spidermonkey 91 on the 11/jan/23 (GitHub) on commit [27409]
- I did not notice any performance issues, while debugging and playing for over a week
on the 18/Jan/23 I did a rebuild of spidermonkey, ever since then I noticed my RAM is being filled up by some processes when the game crashes or throws errors or I just play the game, they are called ReportCrash, spindump and sandboxed
- killing those processes manually solves the issue and my RAM reaches normal levels again
- had no problems with such processes in the past
in the last 24hrs I needed to reboot my PC 4x, that is the reason for the ticket.

Note: The steps for reproduction could not be clearly determined. This is not a good bug report. Think of it more as documentation of a problem that is not yet fully understood.

questions

is it possible that 0ad is the cause of those processes mentioned above to eat my memory and CPU?
is it possible the issue was introduced between 10-18/Jan/23 ?
- list of commits that touched the library folder

❯ git log HEAD...HEAD~10 --oneline --format="%cd %h %an %s" libraries/
17/Jan/23 f76a92f4d0 Itms Fix and cleanup the SM91 build, fixes #6676.
14/Jan/23 cdfe6cc87e Stan Fix typo noticed by @Itms Refs #6676 Phab:rP27409 Differential Revision: https://code.wildfiregames.com/D4888
14/Jan/23 56690ca834 Stan Fix a bug with Python >= 3.11 where -rU was removed as an open flag. Patch by: @sera Refs #6676 Phab:rP27409 Differential Revision: https://code.wildfiregames.com/D4888
14/Jan/23 255d879edb Stan Fix a case sensitive issue on macOS. macOS usually do not use a case sensitive filesystem, hence why it got unnoticed. Reported by: @Freagarach Refs: Phab:rP27409
12/Jan/23 a9e965f2cb Stan Commit the Spidermonkey tarball, as it puts extra strain on CI, and package manager builds don't have internet. Reported by: @Norse_Harold
10/Jan/23 9513e7eb79 Stan [SM91] Update to Spidermonkey 91.1.3 APIs Fixes: #5986 Patch by: @wraitii Comments by: @nwtour, @Stan

image of `ReportCrash` process

video of `spindump` process

https://ttm.sh/SqL.8x_1500p (link will be dead within a year)

Why are "spindump" and "sandboxd" eating up all my CPU? (27/May/21)
ReportCrash High CPU & How to Disable reportcrash in Mac OSX (28/Sep/16)
What is Spindump? How to read, analysis and disable Spindump (27/Sep/18)

#6696 fixed DumpSchema command line option segfaults on Linux Itms Stan

Description

When running the following command on Linux (macOS and Windows seem unaffected):

$ pyrogenesis -mod=public -dumpSchema

The file is generated correctly but a segfault occurs.

TIMER| InitVfs: 11.0418 ms
FILES| Main log written to '/home/builder/.config/0ad/logs/mainlog.html'
FILES| Interesting log written to '/home/builder/.config/0ad/logs/interestinglog.html'
TIMER| CONFIG_Init: 61.519 ms
Generated entity.rng
mozilla::detail::MutexImp::~MutexImpl: pthread_mutex_destroy failed: Device or resource busy
Segmentation fault (core dumped)

GameSetup.cpp#L600

Line
593	if (args.Has("dumpSchema"))
594	{
595	CSimulation2 sim(NULL, g_ScriptContext, NULL);
596	sim.LoadDefaultScripts();
597	std::ofstream f("entity.rng", std::ios_base::out \| std::ios_base::trunc);
598	f << sim.GenerateSchema();
599	std::cout << "Generated entity.rng\n";
600	exit(0);
601	}

It seems that replacing exit(0) by return false prevents the segfault

 if (args.Has("dumpSchema"))
 {
     CSimulation2 sim(NULL, g_ScriptContext, NULL);
     sim.LoadDefaultScripts();
     std::ofstream f("entity.rng", std::ios_base::out | std::ios_base::trunc);
     f << sim.GenerateSchema();
     std::cout << "Generated entity.rng\n";
-    exit(0);
+    return false;
 }

#6695 fixed Decal Alpha Rendering Badly wowgetoffyourcellphone

Description

The alpha of decals is being rendered poorly. See Screenshots, which can illustrate the issue better than words.

#6694 fixed "Requires Town Phase" and "Requires City Phase" should be in red abian abian

Description

The text of the lines "Requires Town Phase" and "Requires City Phase" should be in red when warning of unfulfilled requirements, just like the "Insufficient resources" message and others.

#6693 wontfix Review malware reported by clamav Andrew

Description

In the sourcecode cloned from github malware was reported when running clamscan. Here's the output:

0ad/build/bin/cxxtestgen.exe: Win.Malware.Python-9941399-0 FOUND

This should be looked into, if not already known.

#6691 fixed Template viewer for mace storehouse tech displays wrong time Freagarach Langbart

Description

reported by 0ad is the best rts game in the forum: Game guide of Macedonians error reporting (24/Dec/22)

Macedonian has warehouse technology - 100% of the study time. However, when the player clicks on "Learn Game > Structure > Warehouse (right mouse button)" or clicks on the right mouse button of the warehouse in the game, it shows the cost time. This may confuse the player.

bisect

likley introduced with the introduction of the new civbonus for the Macedonians in [26627]

related ticket

#6587 (10/Jul/22)

possible solution ?

binaries/data/mods/public/gui/reference/viewer/ViewerPage.js

                class ViewerPage extends ReferencePage
             let researchers = templateLists.techs.get(currentTemplateName);
             if (researchers && researchers.length)
+            {
                 this.currentTemplate.researchedByListOfNames = researchers.map(researcher => getEntityNames(this.TemplateParser.getEntity(researcher, this.activeCiv)));
+                const {techCostMultiplier} = this.TemplateParser.getEntity(researchers[0], this.activeCiv);
+                for (const res in this.currentTemplate.cost)
+                    if (this.currentTemplate.cost[res])
+                        this.currentTemplate.cost[res] *= techCostMultiplier[res];
+            }
+        }
         if (this.currentTemplate.builder && this.currentTemplate.builder.length)

#6690 fixed Logical issues following garrison domestic animals into the corral Langbart

Description

[27244] allowed to garrison domestic animals into the corral

corral dropsite (decided against, see comments)

The corral has to become a drop site, I can garrison animals in it and get a trickle, but I can't drop food there right now.

minister (fixed)

the Han minister should be allowed in the corral to increase productivity, or the description of his tooltip should be adjusted

#6689 fixed Corral garrison flag missing wowgetoffyourcellphone Langbart

Description

description

all entities capable of garrisoning should have a flag at the top
[27244] allowed to garrison domestic animals into the corral

to reproduce

start a map, build a corral, garrison a trained animal in it
notice no flag on the roof

tutorial adding a flag

Forum: Adding flags to builings (19/Aug/21)

related ticket

#4581 Flags for all garrisonable buildings and units (20/May/17)

#6687 fixed Tooltip trickle food rate for garrisoned animals Grapjas Langbart

Description

description

[27244] allowed to garrison domestic animals into the corral to get a resource trickle of food.

problem

The trickle rate per animal (cow, goat, ...) is unclear.

possible solutions

Idea NO.1

Change the resource trickle rate based on flesh
- For example, in AOE2 mills can be garrisoned with animals (max 10) to generate 3.5 food per second per 100 flesh.
- Source: ageofempires.fandom.com/wiki/Buildings_(Age_of_Empires_II)

Idea NO.2

write the trickle rate in the tooltip of the animal template

nitpick

Information about the animals garrisoning in the corral and the free supply of food is described twice.

#6685 fixed Type /clear command in gamesetup - error - caption does not exist trompetin17 Norse_Harold

Description

Start hosting a multiplayer game. At the map selection screen (gamesetup), type the following in the chat input box and press enter.

/clear

The chat text is not cleared, and this warning is shown at the top of the screen and in terminal output.

ERROR: Property 'caption' does not exist!
ERROR: Errors executing script event "Press"
ERROR: JavaScript error: gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessagesPanel.js line 46
invalid property id
  clearChatMessages@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessagesPanel.js:46:3
  executeNetworkCommand@gui/common/network.js:184:29
  onPress@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatInputPanel.js:47:8

#6683 fixed Han art oddity upon death Stan Langbart

Description

to reproduce

when a Champion Infantry Crossbowman dies, the remaining weapon raises up like a cross
it occurs only with the champion unit, not with the normal crossbowman

when a Han War Chariot dies, the remaining flag keeps standing up

expected behavior

the weapon/ flag falls flat or disappears upon death
- The flag can be justified, but it takes forever to disappear, and it looks stupid to build a house on it.

#6682 fixed Python checkrefs.py update required after changeset 27245 Freagarach Langbart

Description

to reproduce

navigate to 0ad/source/tools/entity
run python3 checkrefs.py -u
among other files, two techs are listed phase_city.json and phase_town.json

WARNING - Unused file 'public/simulation/data/technologies/phase_city.json'
WARNING - Unused file 'public/simulation/data/technologies/phase_town.json'

bisect

[27245]

related tickets

#6681 fixed Unable to start game when switching to Vulkan for macOS Vladislav Belov Langbart

Description

to reproduce

start 0ad, go to settings
switch to Vulkan (renderer backend)
close 0ad
start 0ad
unable to change the renderer backend through the user interface
- manually removing Vulkan from the user.cfg solves the issue

❯ pyrogenesis
TIMER| InitVfs: 1.716 ms
FILES| Main log written to '/Users/paria/Library/Application Support/0ad/logs/mainlog.html'
FILES| Interesting log written to '/Users/paria/Library/Application Support/0ad/logs/interestinglog.html'
TIMER| CONFIG_Init: 5.345 ms
Sound: AlcInit success, using Built-in Output
WARNING: Failed to set the video mode to fullscreen for the chosen resolution 1920x1200:32 ("Failed to load Vulkan Portability library"), falling back to windowed mode
ERROR: SetVideoMode failed in SDL_CreateWindow: 1024x768:32 0 ("Failed to load Vulkan Portability library")
libc++abi.dylib: terminating with uncaught exception of type PSERROR_System_VmodeFailed
zsh: abort      pyrogenesis

lldb

❯ lldb /Users/paria/Developer/0ad/binaries/system/pyrogenesis
(lldb) target create "/Users/paria/Developer/0ad/binaries/system/pyrogenesis"
Current executable set to '/Users/paria/Developer/0ad/binaries/system/pyrogenesis' (x86_64).
(lldb) run
    Process 45495 launched: '/Users/paria/Developer/0ad/binaries/system/pyrogenesis' (x86_64)
    TIMER| InitVfs: 10.462 ms
FILES| Main log written to '/Users/paria/Library/Application Support/0ad/logs/mainlog.html'
FILES| Interesting log written to '/Users/paria/Library/Application Support/0ad/logs/interestinglog.html'
TIMER| CONFIG_Init: 5.371 ms
2023-01-11 15:19:32.142559+0100 pyrogenesis[45495:426324] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x10583cf80> F8BB1C28-BAE8-11D6-9C31-00039315CD46
2023-01-11 15:19:32.180927+0100 pyrogenesis[45495:426324]  HALC_ShellDriverPlugIn::Open: Can't get a pointer to the Open routine
2023-01-11 15:19:32.181749+0100 pyrogenesis[45495:426324]  HALC_ShellDriverPlugIn::Open: Can't get a pointer to the Open routine
Sound: AlcInit success, using Built-in Output
WARNING: Failed to set the video mode to fullscreen for the chosen resolution 1920x1200:32 ("Failed to load Vulkan Portability library"), falling back to windowed mode
ERROR: SetVideoMode failed in SDL_CreateWindow: 1024x768:32 0 ("Failed to load Vulkan Portability library")
libc++abi.dylib: terminating with uncaught exception of type PSERROR_System_VmodeFailed
Process 45495 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fff66e3832a libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fff66e3832a <+10>: jae    0x7fff66e38334            ; <+20>
    0x7fff66e3832c <+12>: movq   %rax, %rdi
    0x7fff66e3832f <+15>: jmp    0x7fff66e32619            ; cerror_nocancel
    0x7fff66e38334 <+20>: retq   
Target 0: (pyrogenesis) stopped.
(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x00007fff66e3832a libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fff66ef8e60 libsystem_pthread.dylib`pthread_kill + 430
    frame #2: 0x00007fff66dbf808 libsystem_c.dylib`abort + 120
    frame #3: 0x00007fff64024458 libc++abi.dylib`abort_message + 231
    frame #4: 0x00007fff640158bf libc++abi.dylib`demangling_terminate_handler() + 262
    frame #5: 0x00007fff65b52a5f libobjc.A.dylib`_objc_terminate() + 104
    frame #6: 0x00007fff64023887 libc++abi.dylib`std::__terminate(void (*)()) + 8
    frame #7: 0x00007fff640261a2 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 27
    frame #8: 0x00007fff64026169 libc++abi.dylib`__cxa_throw + 113
    frame #9: 0x000000010020bfe2 pyrogenesis`InitGraphics(args=0x00007ffeefbfec40, flags=<unavailable>, installedMods=<unavailable>) at GameSetup.cpp:639:4 [opt]
    frame #10: 0x0000000100003c87 pyrogenesis`RunGameOrAtlas(argv=<unavailable>) at main.cpp:682:4 [opt]
    frame #11: 0x00000001000022f7 pyrogenesis`main(argc=1, argv=0x00007ffeefbfef80) at main.cpp:740:2 [opt]
    frame #12: 0x00007fff66cf0cc9 libdyld.dylib`start + 1

expected behavior

a warning should show up, Vulkan isn't supported, similar to Post-processing/ Antialiasing
- related ticket: #5969 - Antialiasing error and warnings (macOS) (23/Jan/21)

#6680 fixed ParamNode warnig with changeset 27406 - crossbow_training Langbart

Description

to reproduce

start a game with the Han
select units
warning shows up

WARNING: [ParamNode] Could not remove token 'crossbow_training' from node 'Technologies'; not present in list nor inherited (possible typo?)

bisect

[27406]

issue sits in

binaries/data/mods/public/simulation/templates/structures/han/academy.xml

-              a
   <Researcher>
     <Technologies datatype="tokens">
       -barracks_batch_training
+      -crossbow_training
       -unlock_champion_infantry
     </Technologies>
   </Researcher>

#6679 fixed Update .gitignore for spidermonkey 91.13.1 Stan Langbart

Description

to reproduce

build spidermonkey mozjs-91.13.1
check git status

similar commits in the past to solve the issue

Update .gitignore to ignore SpiderMonkey 78 build artifacts (7/Dec/20)
Update .gitignore to ignore SpiderMonkey 68 build artifacts (6/Dec/20)
...

bisect

[27409]

#6678 invalid resources used superior to resources harvested + resources exchanged kmc

Description

I saved a party where the Petra bot amount of resources used is greater than the harvested + exchanged I join a screen shot that shows the resources at the end of the party and the saved party. You can see that the metal used is 26180 while the metal harvested is 17454 and the exchanged is 5601. 17454+5601=23055

Where do the missing 26180-23055=3125 come from ?

Screenshots

#6676 fixed python 3.11 build fix Itms fabio

Description

See https://salsa.debian.org/games-team/0ad/-/commit/7048ef33282782d9af46335c9d928dfa9d9f379d

#6675 duplicate Units drowning are missing from the summary Stan

Description

https://wildfiregames.com/forum/topic/96804-alpha26-feedback-and-suggested-changes/?do=findComment&comment=539271

When a ship is destroyed that had units garrisoned inside, these units disappear form the game (they've presumably died in the shipwreck) but they are not included in the lost unit counter in the stats. Is this intentional?

Screenshot from the stats of my playing Corsica and Sardinia for the first time in a while. You can see that the total of units lost from red and yellow are lower than the number of trained units.

Disclaimer: new to the forum (not new to the game, started playing in 2018). If this is not the right place for this kind of post, lmk. I sifted through the FAQ as well as this thread, and did a quick reddit search on r/0ad and did not see anything recent about this topic, but I'd be surprised if I was the first to bring it up. Game version: Alpha26

#6674 fixed Status bars partially hidden Vladislav Belov Langbart

Description

to reproduce

Note: The steps for reproduction could not be clearly determined, the following points only increase the probability of the issue occurring. It has to do with the camera angle.

start the skirmishes/acropolis_bay_2p map with Mauryans
look at the CC/ towers, notice the status bars are partially hidden

can also be determined in the atlas

bisect

bisecting points to this changeset [27328]

reproducible

Never noticed the issue in any prior release!

#6672 invalid i can´t connect and play online, please help me and thanks for all inaki7

Description

Could not connect to the server. occurs when the UDP20595 port is not forwarded to the host, or due to the action of a firewall or virus

#6670 fixed Negative used resources in summary Freagarach Langbart

Description

reported by KarloManco in the forum: resourcesUsed counter bug (21/Dec/22)

When a unit which is being trained is cancelled, the resourcesUsed counter is decreased by twice the cost of this unit

to reproduce

Click on any building to train a new unit
Cancel the unit before it is completed.
Check in the summary the Resources Used field

reproducible

issue is not reproducible in A25b [25860]

bisect

[26000]

possible solution

KarloManco:

I have checked (in the newest version, [27288]) that by commenting lines 153 and 154 in the mentioned file (Trainer.js) the issue sees to be solved.

#6669 duplicate Heroes in training queue disrupt the auto-queue wowgetoffyourcellphone

Description

When a hero is in the training queue and that building is on auto-queue, training that hero turns the auto-queue off. Other one-time entities, such as technologies, do not disrupt the auto-queue in this way.

What should happen is the same with technologies: The hero (or other train-limited unit) is trained and then removed from the queue without disrupting the auto-queue.

#6668 duplicate Object seed changes when packing/unpacking. Stan

Description

Thread:https://wildfiregames.com/forum/topic/101769-chinese-mangonels/

Probably something wrong in Transform.js.

#6664 invalid update game Manuel Pernas

Description

how can get the complete game with all the new updates ?

#6663 fixed Big Screenshot is broken in Atlas Stan

Description

It seems it was introduced by Phab:rP27256 Wxwidgets doesn't seem to like invalidating buffers.

#6661 invalid Undeletable siege turret added with changeset 27115 causes errors Langbart

Description

to reproduce

start a map with Ptol
build a harbor and produce a units/ptol/champion_juggernaut
sink the ship near the shore
siege will remain alive and keep shooting
AI throws errors

ERROR: JavaScript error: simulation/ai/petra/entityExtend.js line 64
resistanceStrength is undefined
  PETRA.getMaxStrength@simulation/ai/petra/entityExtend.js:64:6
  PETRA.DefenseArmy.prototype.evaluateStrength@simulation/ai/petra/defenseArmy.js:492:23
  PETRA.DefenseArmy.prototype.addFoe@simulation/ai/petra/defenseArmy.js:66:7
  PETRA.DefenseArmy@simulation/ai/petra/defenseArmy.js:38:8
  PETRA.DefenseManager.prototype.makeIntoArmy@simulation/ai/petra/defenseManager.js:77:19
  PETRA.DefenseManager.prototype.checkEnemyUnits@simulation/ai/petra/defenseManager.js:250:9
  PETRA.DefenseManager.prototype.update@simulation/ai/petra/defenseManager.js:62:7
  PETRA.HQ.prototype.update@simulation/ai/petra/headquarters.js:2274:22
  PETRA.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:118:11
  m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:64:7

#6660 invalid Disable unload warning for siege turret on ship wowgetoffyourcellphone Langbart

Description

[27115] added a siege turret to the units/ptol/champion_juggernaut
if you try to unload it, a warning shows up

expected behavior

warning should not show up

#6659 fixed RelaxNGValidator validate entity errors on changeset 27241 for elephant Freagarach Langbart

Description

to reproduce

start scenarios/units_demo map
errors fill the screen

logs

0 A.D. (0.0.27) Main log (warnings and errors only)
ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/cart/champion_elephant:1: Element Resources failed to validate content

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/cart/champion_elephant:1: Element Loot failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'units/cart/champion_elephant'

ERROR: Failed to load units/cart/champion_elephant

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/kush/champion_elephant:1: Element Resources failed to validate content

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/kush/champion_elephant:1: Element Loot failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'units/kush/champion_elephant'

ERROR: Failed to load units/kush/champion_elephant

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/maur/champion_elephant:1: Element Resources failed to validate content

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/maur/champion_elephant:1: Element Loot failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'units/maur/champion_elephant'

ERROR: Failed to load units/maur/champion_elephant

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/pers/champion_elephant:1: Element Resources failed to validate content

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/pers/champion_elephant:1: Element Loot failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'units/pers/champion_elephant'

ERROR: Failed to load units/pers/champion_elephant

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/ptol/champion_elephant:1: Element Resources failed to validate content

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/ptol/champion_elephant:1: Element Loot failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'units/ptol/champion_elephant'

ERROR: Failed to load units/ptol/champion_elephant

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/sele/champion_elephant:1: Element Resources failed to validate content

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/sele/champion_elephant:1: Element Loot failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'units/sele/champion_elephant'

ERROR: Failed to load units/sele/champion_elephant

bisect

[27241]

#6658 invalid Game crashes for changeset 27115 on sandbox_ptolemies map Langbart

Description

to reproduce

start the scenarios/sandbox_ptolemies.xml map
game crashes before you can spawn into the map, you only see the loading page

logs

Assertion failed: "!EntityExists(ent)"
Location: ComponentManager.cpp:790 (AllocateEntityHandle)

Call stack:

(error while dumping stack: Function not supported)
errno = 0 (No error reported here)
OS error = ?


(C)ontinue, (S)uppress, (B)reak, Launch (D)ebugger, or (E)xit?

lldb

❯ lldb /Users/paria/Developer/0ad/binaries/system/pyrogenesis
(lldb) target create "/Users/paria/Developer/0ad/binaries/system/pyrogenesis"
Current executable set to '/Users/paria/Developer/0ad/binaries/system/pyrogenesis' (x86_64).
(lldb) run
Process 96379 launched: '/Users/paria/Developer/0ad/binaries/system/pyrogenesis' (x86_64)
TIMER| InitVfs: 7.205 ms
FILES| Main log written to '/Users/paria/Library/Application Support/0ad/logs/mainlog.html'
FILES| Interesting log written to '/Users/paria/Library/Application Support/0ad/logs/interestinglog.html'
TIMER| CONFIG_Init: 7.981 ms
2022-11-23 02:43:33.706275+0100 pyrogenesis[96379:781639] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x107e0cf60> F8BB1C28-BAE8-11D6-9C31-00039315CD46
2022-11-23 02:43:33.759227+0100 pyrogenesis[96379:781639]  HALC_ShellDriverPlugIn::Open: Can't get a pointer to the Open routine
2022-11-23 02:43:33.759733+0100 pyrogenesis[96379:781639]  HALC_ShellDriverPlugIn::Open: Can't get a pointer to the Open routine
Sound: AlcInit success, using Built-in Output
FILES| UserReport written to '/Users/paria/Library/Application Support/0ad/logs/userreport_hwdetect.txt'
TIMER| RunHardwareDetection: 5.527 ms
FILES| Hardware details written to '/Users/paria/Library/Application Support/0ad/logs/system_info.txt'
TIMER| write_sys_info: 16.745 ms
TIMER| InitRenderer: 8.966 ms
TIMER| ps_console: 11.179 ms
TIMER| ps_lang_hotkeys: 5.032 ms
TIMER| common/modern/setup.xml: 1.849 ms
TIMER| common/modern/styles.xml: 477 us
TIMER| common/modern/sprites.xml: 1.595 ms
TIMER| common/global.xml: 899 us
TIMER| common/setup.xml: 553 us
TIMER| common/sprites.xml: 725 us
TIMER| common/styles.xml: 458 us
TIMER| pregame/backgrounds/: 2.361 ms
TIMER| pregame/sprites.xml: 259 us
TIMER| pregame/styles.xml: 155 us
TIMER| pregame/mainmenu.xml: 60.065 ms
2022-11-23 02:43:37.372842+0100 pyrogenesis[96379:781766] flock failed to lock maps file: errno = 35
2022-11-23 02:43:37.373520+0100 pyrogenesis[96379:781766] flock failed to lock maps file: errno = 35
TIMER| common/modern/setup.xml: 201 us
TIMER| common/modern/styles.xml: 191 us
TIMER| common/modern/sprites.xml: 1.485 ms
TIMER| common/setup.xml: 350 us
TIMER| common/sprites.xml: 481 us
TIMER| common/styles.xml: 131 us
TIMER| gamesetup/setup.xml: 637 us
TIMER| gamesetup/styles.xml: 360 us
TIMER| gamesetup/gamesetup.xml: 164.871 ms
TIMER| common/global.xml: 552 us
FILES| JSON data written to '/Users/paria/Library/Application Support/0ad/config/matchsettings.json'
FILES| Replay written to '/Users/paria/Library/Application Support/0ad/replays/0.0.27/2022-11-23_0018'
TIMER| common/modern/setup.xml: 202 us
TIMER| common/modern/styles.xml: 271 us
TIMER| common/modern/sprites.xml: 1.303 ms
TIMER| common/global.xml: 317 us
TIMER| common/setup.xml: 268 us
TIMER| common/sprites.xml: 467 us
TIMER| common/styles.xml: 128 us
TIMER| loading/styles.xml: 1.784 ms
TIMER| loading/sprites.xml: 481 us
TIMER| loading/loading.xml: 20.47 ms
Assertion failed: "!EntityExists(ent)"
Location: ComponentManager.cpp:790 (AllocateEntityHandle)

Call stack:

(error while dumping stack: Function not supported)
errno = 0 (No error reported here)
OS error = ?


(C)ontinue, (S)uppress, (B)reak, Launch (D)ebugger, or (E)xit?
e
Redirecting call to abort() to mozalloc_abort

pyrogenesis was compiled with optimization - stepping may behave oddly; variables may not be available.
Process 96379 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x00000001010ab700 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
   30   #ifdef MOZ_WIDGET_ANDROID
   31     abortThroughJava(msg);
   32   #endif
-> 33     MOZ_CRASH();
   34   }
   35   
   36   #ifdef MOZ_WIDGET_ANDROID
Target 0: (pyrogenesis) stopped.
(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x00000001010ab700 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
    frame #1: 0x0000000101bc445d pyrogenesis`::abort() at mozalloc_abort.cpp:82:3 [opt]
    frame #2: 0x0000000100501f96 pyrogenesis`sys_display_error(text=<unavailable>, flags=6) at unix.cpp:268:4 [opt]
    frame #3: 0x00000001004e46f3 pyrogenesis`debug_DisplayError(wchar_t const*, unsigned long, void*, wchar_t const*, wchar_t const*, int, char const*, long volatile*) [inlined] CallDisplayError(text=L"Assertion failed: \"!EntityExists(ent)\"\r\nLocation: ComponentManager.cpp:790 (AllocateEntityHandle)\r\n\r\nCall stack:\r\n\r\n(error while dumping stack: Function not supported)\r\nerrno = 0 (No error reported here)\r\nOS error = ?\r\n", flags=6) at debug.cpp:374:8 [opt]
    frame #4: 0x00000001004e46d6 pyrogenesis`debug_DisplayError(description=L"Assertion failed: \"!EntityExists(ent)\"", flags=6, context=0x00007ffeefbfd940, lastFuncToSkip=<no summary available>, pathname=<no summary available>, line=<no summary available>, func=<no value available>, suppress=<no summary available>) at debug.cpp:460 [opt]
    frame #5: 0x00000001004e4f5e pyrogenesis`debug_OnAssertionFailure(expr=<no summary available>, suppress=<no summary available>, file=<no summary available>, line=<no summary available>, func=<no value available>) at debug.cpp:547:9 [opt]
    frame #6: 0x0000000100193e86 pyrogenesis`CComponentManager::AllocateEntityHandle(this=<no summary available>, ent=<no summary available>) at ComponentManager.cpp:790:2 [opt]
    frame #7: 0x0000000100190ded pyrogenesis`CComponentManager::AddEntity(this=<no summary available>, templateName=L"", ent=<no summary available>) at ComponentManager.cpp:840:25 [opt]
    frame #8: 0x00000001002eaae1 pyrogenesis`CXMLReader::ReadEntities(this=<no summary available>, parent=(m_Pointer = <no value available>), end_time=<no summary available>) at MapReader.cpp:1054:25 [opt]
    frame #9: 0x00000001002ecb03 pyrogenesis`CXMLReader::ProgressiveReadEntities(this=<no summary available>) at MapReader.cpp:1189:11 [opt]
    frame #10: 0x00000001002de6e1 pyrogenesis`CMapReader::ReadXMLEntities(this=<no summary available>) at MapReader.cpp:1251:24 [opt]
    frame #11: 0x00000001002311f9 pyrogenesis`LDR_ProgressiveLoad(time_budget=<no summary available>, description=<no summary available>, max_chars=<no summary available>, progress_percent=<no summary available>) at Loader.cpp:217:16 [opt]
    frame #12: 0x0000000100004734 pyrogenesis`RunGameOrAtlas(PS::span<char const* const>) at main.cpp:304:16 [opt]
    frame #13: 0x0000000100004670 pyrogenesis`RunGameOrAtlas(PS::span<char const* const>) [inlined] Frame() at main.cpp:398 [opt]
    frame #14: 0x0000000100004450 pyrogenesis`RunGameOrAtlas(argv=const PS::span<const char *const> @ scalar) at main.cpp:687 [opt]
    frame #15: 0x0000000100002a37 pyrogenesis`main(argc=<no summary available>, argv=<no summary available>) at main.cpp:740:2 [opt]
    frame #16: 0x00007fff6f3e9cc9 libdyld.dylib`start + 1

bisect

crash came with [27115]

commit d3376ae06fa996b8ab7c98eaa53b759c61db0c89
Author: wowgetoffyourcellphone <wowgetoffyourcellphone@3db68df2-c116-0410-a063-a993310a9797>
Date:   05/Oct/22
 
    [Alpha 27][Art][Portraits][Templates] Moving portrait textures to their own specific folders
    
    This commit is for the templates
    
    git-svn-id: https://svn.wildfiregames.com/public/ps/trunk@27115 3db68df2-c116-0410-a063-a993310a9797
 
 
 358 files changed, 396 insertions(+), 357 deletions(-)

#6657 fixed Elite units small discrepancy between maxHitpoints and hitpoints Freagarach Langbart

Description

to reproduce

start the units_demo map

pyrogenesis -autostart="scenarios/units_demo" -autostart-victory="endless"

seek the Mauryan Hero Healer Acharya Chanakya, somewhere in the back rows. You will find him, because he is the only one walking around .

the Healer is going to some Elite units to heal them, for example the Cretan Mercenary Archer

select the Cretan Mercenary Elite Archer, toggle the Developer Overlay Alt+D and the option Display selection state
- the difference between hitpoints and maxHitpoints is only 0.00000000000001 == 1E-14

the Mauryan Hero Healer is the only walking around, because of its large vision range he inherits from the simulation/templates/template_unit_hero.xml template

Line
66	</TrainingRestrictions>
67	<Vision>
68	<Range>100</Range>
69	</Vision>
70	</Entity>

other healers have only 30 vision - simulation/templates/template_unit_support_healer.xml

Line
53	</Sound>
54	<Vision>
55	<Range>30</Range>
56	</Vision>
57	</Entity>

minimal amount of units to reproduce the issue

change the units_demo.js to only show three units. the combo is enough to create the discrepancy in health points.

binaries/data/mods/public/maps/scenarios/units_demo.js

                let maxh = 0;
 let gap = 14;
 let cmpTemplateManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_TemplateManager);
 for (let template of cmpTemplateManager.FindAllTemplates(actors))
+for (let template of ["units/mace/hero_pyrrhus_i", "units/iber/catafalque", "units/maur/elephant_archer_e"])
+{
     print(template + "...\n");

intended behavior

the hitpoints for all elite units should be the same as the maxHitpoints when the game starts

cause of the issue

See the comment by Stan suggesting floating point math

❯ node
Welcome to Node.js v19.1.0.
> 0.1+0.2
0.30000000000000004

possible solution

one-line change, there is a calculation being made in the Health.js file.

example `units/maur/elephant_archer_e`

# this.hitpoints * newMaxHitpoints / oldMaxHitpoints
❯ node
Welcome to Node.js v19.1.0.
> 233.75000000000003*292.18750000000006/233.75000000000003
# 292.1875

binaries/data/mods/public/simulation/components/Health.js

a	b	Health.prototype.RecalculateValues = function()
465	465	let newMaxHitpoints = ApplyValueModificationsToEntity("Health/Max", +this.template.Max, this.entity);
466	466	if (oldMaxHitpoints != newMaxHitpoints)
467	467	{
468		let newHitpoints = ~~this.hitpoints * newMaxHitpoints/~~oldMaxHitpoints;
	468	let newHitpoints = (this.hitpoints === oldMaxHitpoints) ? newMaxHitpoints : this.hitpoints * newMaxHitpoints / oldMaxHitpoints;
469	469	this.maxHitpoints = newMaxHitpoints;
470	470	this.SetHitpoints(newHitpoints);
471	471	}

#6656 fixed Athens Gymnasium has no TerritoryInfluence boost Freagarach Langbart

Description

to reproduce

start a normal map with Athen
enter cheat code: back to the future to reach Town Phase
build a Gymnasium at the border
see GIF below for more clarity - gymnasium vs barracks

bisect

[24104] removed the TerritoryInfluence from the template_structure_special file.
- Diff - D3016 (25/Sep/20)

Nescio: Removes <TerritoryInfluence> from template_structure_special.xml, since that belongs in most of its children too.

possible solution

Give it the same boost as the Athen Council Chamber (Prytaneion)

templates/structures/athen/prytaneion.xml - Line 48

binaries/data/mods/public/simulation/templates/structures/athen/gymnasium.xml

-              a
       <constructed>interface/complete/building/complete_gymnasium.xml</constructed>
     </SoundGroups>
   </Sound>
+  <TerritoryInfluence>
+    <Root>false</Root>
+    <Radius>38</Radius>
+    <Weight>40000</Weight>
+  </TerritoryInfluence>
   <Trainer>
     <BatchTimeModifier>0.7</BatchTimeModifier>
     <Entities datatype="tokens">

optional

Add a test to one of the entity python tools that children of the template_structure_special.xml file should have a TerritoryInfluence boost.

#6655 invalid Victory is declared at the very start of a solo match kevin.chavanne@…

Description

Since today (never happened before), whatever match I choose, victory is declared at the very start, there is nothing to play. I am using Ubuntu with Alpha xxvi SOLVED I found out, both challengers belonged to the same team, teams were not reset after a 2x2 game Maybe implement an automatic reset on teams would be nice

#6654 fixed AI sometimes makes demands to an already defeated player Freagarach Gurken Khan

Description

Sometimes the AI tries to negotiate with a player that's already defeated: makes no sense.

See: PetraAI bot doesn't recognize defeat of competitor, it's trading with (11/Oct/22)

analysing the replay from the forum link above

11:40 `User` wants to become neutral with `Lysander`
11:40 `Lysander` wants `1000 Food`
11:50 `User` sends `Lysander` `1000 Food`
11:50 `User` becomes neutral with `Lysander`

30:00 `User` wants to become allied with `Lysander` 
30:00 `Lysander` wants `1000 Food`
30:00-31:00 `User` sends `Lysander` `400 Food` (and `200 Metal, 100 Wood`)
31:10 `User` resigns
32:10 `Lysander` wants the remaining `600 Food` (asking a private message)

to reproduce

start a match with some AI's
try to make an alliance, where the AI asks you for a tribute
only send a part of the tribute
get defeated, for example with cheat code exodia 1
AI asks you in a private message, for the rest
- Attaching minimal replay (~2min) commands.txt

note

To see private messages from the AI when watching the replay:

either change the name in the user.cfg to the name of the player, whose private messages from the AI you would like to see or
change the name in the attached replay file

#6653 wontfix (0 A.D) Conflicting and missing files when trying to install OpenSUSE dependencies Gracz

Description

I was trying to install the dependencies for 0 A.D. on my OpenSUSE Tumbleweed by following the steps in this guide but I got some error messages about not found packages and conflicting files. It would be nice if you could update the dependencies needed or what should I do to get the installation done?

Thanks in advance

#6652 duplicate ERROR: JavaScript error: simulation/ai/common-api/utils.js line 27 fabio

Description

While playing on 0.0.26 I got this:

ERROR: JavaScript error: simulation/ai/common-api/utils.js line 27
b is undefined
  API3</m.SquareVectorDistance@simulation/ai/common-api/utils.js:27:2
  PETRA.AttackPlan.prototype.getNearestTarget@simulation/ai/petra/attackPlan.js:939:19
  PETRA.AttackPlan.prototype.UpdateTarget@simulation/ai/petra/attackPlan.js:1994:25
  PETRA.AttackPlan.prototype.update@simulation/ai/petra/attackPlan.js:1336:13
  PETRA.AttackManager.prototype.update@simulation/ai/petra/attackManager.js:322:27
  PETRA.HQ.prototype.update@simulation/ai/petra/headquarters.js:2285:22
  PETRA.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:118:11
  m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:64:7
ERROR: JavaScript error: simulation/ai/common-api/utils.js line 27
b is undefined
...

#6651 fixed Structure Tree shouldn't fail for empty history strings Freagarach Stan

Description

Currently if a civilization has no history string, like for instance the ponies in ponies ascendant, the structure tree breaks with the following error

ERROR: JavaScript error: gui/reference/structree/StructreePage.js line 51 Script value conversion check failed: v.isString()  v.isNumber()  v.isBoolean() (got type undefined)

History being an optional tag in cmpIdentity (https://github.com/0ad/0ad/blob/master/binaries/data/mods/public/simulation/components/Identity.js#L45) it is not required to be there.

#6648 fixed %(resource)s are not translated in AI private messages Freagarach Gurken Khan

Description

When AIs make demands in private messages the resources are not translated but use the English terms like "food".

PetraAI bot doesn't recognize defeat of competitor, it's trading with (11/Oct/22)

possible solution ?

binaries/data/mods/public/simulation/ai/petra/chatHelper.js

                PETRA.chatAnswerRequestDiplomacy = function(gameState, player, requestType, resp
         "message": "/msg " + gameState.sharedScript.playersData[player].name + " " +
             pickRandom(this.answerDiplomacyRequestMessages[requestType][response]),
         "translateMessage": true,
         "translateParameters": requiredTribute ? ["_amount_", "_resource_", "_player_"] : ["_player_"],
+        "translateParameters": { "_resource_": "withinSentence" } ,
         "parameters": requiredTribute ?
             { "_amount_": requiredTribute.wanted, "_resource_": requiredTribute.type, "_player_": player } :
+            { "_amount_": requiredTribute.wanted, "_resource_": Resources.GetNames()[requiredTribute.type], "_player_": player } :
             { "_player_": player }
     });
 };

the Resources.GetNames()[requiredTribute.type] transforms wood into Wood
the { "_resource_": "withinSentence" } for finding the correctly translated word with the translateObjectKeys function in ChatMessageFormatPlayer.js.

l10n/nl.public-gui-other.po

Line
7285	#. Translation: Word as used at the beginning of a sentence or as a single-
7286	#. word sentence.
7287	#: simulation/data/resources/wood.jsonname
7288	msgctxt "firstWord"
7289	msgid "Wood"
7290	msgstr "Hout"
7291
7292	#. Translation: Word as used in the middle of a sentence (which may require
7293	#. using lowercase
7294	#. for your language).
7295	#: simulation/data/resources/wood.jsonname
7296	msgctxt "withinSentence"
7297	msgid "Wood"
7298	msgstr "Hout"
7299
7300	#. Translation: Word as used at the beginning of a sentence or as a single-
7301	#. word sentence.
7302	#: simulation/data/resources/wood.jsonsubtypes.tree
7303	msgctxt "firstWord"
7304	msgid "Tree"
7305	msgstr "Boom"

note

the missing space in the dutch text, which can be seen in the image above, is a problem of the translator and is not caused by this patch

l10n/nl.public-simulation-other.po

Line
245	#: simulation/ai/petra/chatHelper.js:81
246	#, javascript-format
247	msgid ""
248	"%(_player_)s, you must send me a tribute of %(_amount_)s %(_resource_)s "
249	"before I accept an alliance with you."
250	msgstr "%(_player_)s, u moet eerst %(_amount_)s%(_resource_)s als geschenk sturen voordat ik een bondgenootschap met u accepteer."

#6645 duplicate Javascript Error Chris

Description

Ich kann kein Singleplayer Spiel öffnen da er mir einen Javascript Error anzeigt. Ich kann Ihnen gerne einen Screenshot davon schicken.

#6644 fixed Game Menu not accessible when playing at resolution 5120x1440 fullscreen krafel

Description

If I play 0 A.D. (great game btw!) in fullscreen mode with auto-detected or manually set resolution of 5120x1440, the game starts up, but the menu on the left side is not accessible, the mouse pointer would not move there. If I set the mode to windowed in the user.cfg and xres/yres to that resolution or another, lower one, everything works as expected.

OS is fedora 36, monitor model is Philips 499P

#6643 fixed Atlas previews are broken Vladislav Belov Stan

Description

The code incorrectly assumes that the pngs are always present when they are not.

Initial report here: https://wildfiregames.com/forum/topic/94443-0admapnewtest/?do=findComment&comment=522698

Mitigation there: https://wildfiregames.com/forum/topic/95696-alpha-26-atlas-terrain-texture-previews-fix/#comment-524159

Could have been revealed by r26142

#6641 needsinfo error on startup maxi

Description

Assertion failed: "exts && "call ogl_Init before using this function"" Location: ogl.cpp:193 (ogl_HaveExtension)

Call stack:

ogl_HaveExtensions (ogl.cpp:270)

dummy = 0 (0x00000000) ext = (unavailable)

Renderer::Backend::GL::CDevice::Create (device.cpp:328)

window = (unavailable) arb = (unavailable) maxTextureSize = 0 (0x00000000) device = (unique_ptr<Renderer::Backend::GL::CDevice,default_delete<Renderer::Backend::GL::CDevice> >) isDebugInCore = (unavailable - internal error)

context = [2048]

16 (0x10) 96 (0x60) 0 (0x00) 128 (0x80) 0 (0x00) 0 (0x00) 0 (0x00) 0 (0x00) 168 (0xA8) 12 (0x0C) 94 (0x5E) 0 (0x00) 216 (0xD8) 228 (0xE4) 79 (0x4F) 0 (0x00) ...

maxSamples = (unavailable - internal error)

maxAnisotropy = (unavailable - internal error)

enableDebugMessages = false id = (unavailable - internal error)

CVideoMode::CreateBackendDevice (videomode.cpp:537)

this = (unavailable) createSDLContext = true

CVideoMode::CreateBackendDevice (videomode.cpp:542)

this = (unavailable) createSDLContext = true

CVideoMode::SetVideoMode (videomode.cpp:307)

this = (unavailable) w = 1920 (0x00000780) h = 1080 (0x00000438) bpp = 24 (0x00000018) fullscreen = (unavailable) fullscreen = true flags = (unavailable - internal error)

borderlessFullscreen = true borderlessWindow = true

CVideoMode::InitSDL (videomode.cpp:466)

this = (unavailable) w = (unavailable) h = (unavailable) h = 1080 (0x00000438) bpp = 24 (0x00000018) forceGLVersion = false debugContext = false mode =

format = 370546692 (0x16161804) w = 1920 (0x00000780) h = 1080 (0x00000438) refresh_rate = 64 (0x00000040) driverdata = 0x04682390

forceGLProfile = { (unsupported basic_string<char,char_traits<char> >) } forceGLMajorVersion = 50 (0x00000032) forceGLMinorVersion = 1960114064 (0x74D4F790) profile = (unavailable - internal error)

InitGraphics (gamesetup.cpp:638)

args = (unavailable) args = (unavailable) flags = (unavailable) installedMods = 0x00000001 installedMods = (unavailable) profilerGPUEnable = false renderPath = { (unsupported basic_string<char,char_traits<char> >) } context = [2048]

200 (0xC8) 239 (0xEF) 79 (0x4F) 0 (0x00) 0 (0x00) 0 (0x00) 0 (0x00) 0 (0x00) (uninitialized) 169 (0xA9) 120 (0x78) 119 (0x77) 200 (0xC8) 239 (0xEF) 79 (0x4F) 0 (0x00) ...

rq =

cx = (unavailable - internal error)

glob =

{ (js::WrappedPtrOperations<JSObject *,JS::Handle<JSObject *> >) } ptr = (unavailable - internal error)

nativeScope =

{ (js::WrappedPtrOperations<JSObject *,JS::Handle<JSObject *> >) } ptr = (unavailable - internal error)

m_ScriptInterface = (unavailable - internal error)

m_FormerRealm = (unavailable - internal error)

data =

{

(js::WrappedPtrOperations<JS::Value,JS::Rooted<JS::Value> >)

}

stack = (unavailable - internal error)

prev = (unavailable - internal error)

ptr =

asBits_ = (unavailable - internal error)

setup_gui = (unavailable - internal error)

scriptInterface = (shared_ptr<ScriptInterface>) e = 0xFFFFFFFF ->

(exception) m_msg = (unavailable - internal error)

g_GUI = (unavailable - internal error)

RunGameOrAtlas (main.cpp:683)

argc = 1 (0x00000001) argv = 0x04680008 -> 0x04680028 -> "C:\Users\maxib\AppData\Local\0 A.D. alpha\binaries\system\pyrogenesis.exe" isNonVisualReplay = false flags = 8 (0x00000008) args =

m_Args = (unsupported vector<pair<CStr8,CStr8> >) m_Arg0 =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 92 ('\')

m_ArgsWithoutName = (unsupported vector<CStr8 >)

isNonVisual = false isUsingRLInterface = false scriptEngine =

(Singleton<ScriptEngine>) m_Contexts = (unsupported list<JSContext const * >)

res = 1e-07 (0x3E7AD7F29ABCAF48) isVisualReplay = (unavailable - internal error)

modsToInstall = (unsupported vector<Path >) replayFile =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 47 ('/')

<begin>$L0 = 0x00000000 <end>$L0 = 0x00000000 modPath =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 203

paths =

m_root =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 10277

m_rdata =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 156

m_gameData =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 24238

m_userData =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 11276

m_config =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 1522

m_cache =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 6108

m_logs =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 1522

replay =

m_Stream = 0x00000000

builder =

m_VFS = (shared_ptr<IVFS>) m_Files = (unsupported vector<Path >) m_TempDir =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 65534

m_NumBaseMods = 5241208 (0x004FF978)

paths =

m_root =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 10277

m_rdata =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 156

m_gameData =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 24238

m_userData =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 11276

m_config =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 1522

m_cache =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 6108

m_logs =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 1522

mod =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 38 ('&')

zip =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 64104

mods = (unsupported vector<CStr8 >) i = (unavailable - internal error)

installedMods = (unsupported vector<CStr8 >) paths =

m_root =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 10277

m_rdata =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 156

m_gameData =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 24238

m_userData =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 11276

m_config =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 1522

m_cache =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 6108

m_logs =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 1522

installer =

m_VFS = (shared_ptr<IVFS>) m_ModsDir =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 5576

m_TempDir =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 0

m_CacheDir =

path = (unsupported basic_string<wchar_t,char_traits<wchar_t> >) separator = 44640

m_InstalledMods = (unsupported vector<CStr8 >)

modInterface =

m_CmptPrivate =

pScriptInterface = 0x006E6F69 ->

m_CmptPrivate =

pScriptInterface = 0x00000000 pCBData = 0x00000000

m = (unique_ptr<ScriptInterface_impl,default_delete<ScriptInterface_impl> >) m_CustomObjectTypes = (unsupported map<basic_string<char,char_traits<char> >,ScriptInterface::CustomType >)

pCBData = 0x0479B032

m = (unique_ptr<ScriptInterface_impl,default_delete<ScriptInterface_impl> >) m_CustomObjectTypes = (unsupported map<basic_string<char,char_traits<char> >,ScriptInterface::CustomType >)

<end>$L1 = (unavailable) <begin>$L1 = (unavailable - internal error)

result = (unavailable - internal error)

g_Profiler2 =

m_Initialised = (unavailable - internal error)

m_FrameNumber = (unavailable - internal error)

m_MgContext = (unavailable - internal error)

m_GPU = (unavailable - internal error)

m_Mutex = (mutex) m_Threads = (unsupported vector<unique_ptr<CProfiler2::ThreadStorage,default_delete<CProfiler2::ThreadStorage> > >)

g_Game = (unavailable - internal error)

g_NetClient = (unavailable - internal error)

g_Shutdown = (unavailable - internal error)

SDL_main (main.cpp:739)

argc = 1 (0x00000001) argv = 0x04680008 (see above)

main_getcmdline (sdl_windows_main.c:74)

argvw = (unavailable) argc = (unavailable)

scrt_common_main_seh (exe_common.inl:288)

has_cctor = false main_result = (unavailable - internal error)

tls_init_callback = (unavailable - internal error)

is_nested = false tls_dtor_callback = (unavailable - internal error)

main_result = 0 (0x00000000) scrt_current_native_startup_state = (unavailable - internal error)

CallStartupWithinTryBlock (wseh.cpp:363)

ret = (unavailable) ret = 0 (0x00000000)

RtlGetAppContainerNamedObjectPath (:0)

errno = 0 (No error reported here) OS error = 127 (The specified procedure could not be found.)

#6638 needsinfo Apple game crash Kevin E Fraley

Description

Translated Report (Full Report Below)

Process: pyrogenesis [8356] Path: /Users/USER/Desktop/0 A.D..app/Contents/MacOS/pyrogenesis Identifier: com.wildfiregames.0ad Version: 0.0.25b (0.0.25b) Code Type: X86-64 (Native) Parent Process: launchd [1] User ID: 501

Date/Time: 2022-10-06 09:34:23.2765 -0500 OS Version: macOS 12.6 (21G115) Report Version: 12 Anonymous UUID: DE948911-6A77-E415-84DA-6B70FBAFBEA5

Sleep/Wake UUID: 18237E5B-34C3-4ABE-940C-574325351CC0

Time Awake Since Boot: 47000 seconds Time Since Wake: 1360 seconds

System Integrity Protection: enabled

Crashed Thread: 0 main Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_PROTECTION_FAILURE at 0x00007ff7b268df58 Exception Codes: 0x0000000000000002, 0x00007ff7b268df58 Exception Note: EXC_CORPSE_NOTIFY

Termination Reason: Namespace SIGNAL, Code 11 Segmentation fault: 11 Terminating Process: exc handler [8356]

VM Region Info: 0x7ff7b268df58 is in 0x7ff7aee8e000-0x7ff7b268e000; bytes after start: 58720088 bytes before end: 167

REGION TYPE START - END [ VSIZE] PRT/MAX SHRMOD REGION DETAIL MALLOC_LARGE 7fac8a698000-7fac8a6ef000 [ 348K] rw-/rwx SM=PRV GAP OF 0x4b2479f000 BYTES

---> STACK GUARD 7ff7aee8e000-7ff7b268e000 [ 56.0M] ---/rwx SM=NUL ... for thread 0

Stack 7ff7b268e000-7ff7b2e8e000 [ 8192K] rw-/rwx SM=PRV thread 0

Thread 0 Crashed:: main Dispatch queue: com.apple.main-thread 0 pyrogenesis 0x10df79bb5 js::jit::JSJitFrameIter::machineState() const + 53

Thread 1:: Task Mgr #0 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3029bb Threading::WorkerThread::RunUntilDeath() + 299 4 pyrogenesis 0x10d3055da void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 2:: Task Mgr #1 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3029bb Threading::WorkerThread::RunUntilDeath() + 299 4 pyrogenesis 0x10d3055da void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 3:: Task Mgr #2 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3029bb Threading::WorkerThread::RunUntilDeath() + 299 4 pyrogenesis 0x10d3055da void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 4:: Task Mgr #4 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3029bb Threading::WorkerThread::RunUntilDeath() + 299 4 pyrogenesis 0x10d3055da void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 5:: Task Mgr #3 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3029bb Threading::WorkerThread::RunUntilDeath() + 299 4 pyrogenesis 0x10d3055da void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 6:: Task Mgr #5 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3029bb Threading::WorkerThread::RunUntilDeath() + 299 4 pyrogenesis 0x10d3055da void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 7:: Task Mgr #6 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3029bb Threading::WorkerThread::RunUntilDeath() + 299 4 pyrogenesis 0x10d3055da void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 8:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 9:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 10:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 11:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 12:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 13:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 14:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 15:: JS Helper 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10e16777b mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&) + 75

Thread 16: 0 libsystem_kernel.dylib 0x7ff80a86e97a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x7ff80a86ece8 mach_msg + 56 2 pyrogenesis 0x10e110703 MachExceptionHandlerThread() + 771

Thread 17:: AMCP Logging Spool 0 libsystem_kernel.dylib 0x7ff80a86e9b6 semaphore_wait_trap + 10 1 caulk 0x7ff8133ab2e6 caulk::mach::semaphore::wait_or_error() + 16 2 caulk 0x7ff813393148 caulk::concurrent::details::worker_thread::run() + 36 3 caulk 0x7ff813392e0c void* caulk::thread_proxy<std::__1::tuple<caulk::thread::attributes, void (caulk::concurrent::details::worker_thread::*)(), std::__1::tuple<caulk::concurrent::details::worker_thread*> > >(void*) + 41 4 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 5 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 18:: CSoundManagerWorker 0 libsystem_kernel.dylib 0x7ff80a8712be semwait_signal + 10 1 libsystem_c.dylib 0x7ff80a785863 nanosleep + 196 2 pyrogenesis 0x10d798b16 SDL_Delay_REAL + 102 3 pyrogenesis 0x10d5d95f7 SDL_Delay + 23 4 pyrogenesis 0x10d34a1e7 CSoundManagerWorker::Run() + 583 5 pyrogenesis 0x10d349f59 Threading::HandleExceptionsBase<&(CSoundManagerWorker::RunThread(CSoundManagerWorker*)), void (*)(CSoundManagerWorker*)>::Wrapper(CSoundManagerWorker*) + 121 6 pyrogenesis 0x10d34a50a void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(CSoundManagerWorker*), CSoundManagerWorker*> >(void*) + 58 7 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 8 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 19:: CUserReportWorker 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d30c668 CUserReporterWorker::Run() + 920 4 pyrogenesis 0x10d30c1f8 Threading::HandleExceptionsBase<&(CUserReporterWorker::RunThread(CUserReporterWorker*)), void (*)(CUserReporterWorker*)>::Wrapper(CUserReporterWorker*) + 120 5 pyrogenesis 0x10d30e80a void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(CUserReporterWorker*), CUserReporterWorker*> >(void*) + 58 6 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 7 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 20:: SDLTimer 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 pyrogenesis 0x10d78f7ed SDL_CondWaitTimeout_REAL + 205 3 pyrogenesis 0x10d78f1c5 SDL_SemWaitTimeout_REAL + 181 4 pyrogenesis 0x10d662df6 SDL_TimerThread + 614 5 pyrogenesis 0x10d6623c4 SDL_RunThread + 132 6 pyrogenesis 0x10d78ec35 RunThread + 21 7 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 8 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 21:: TextureConverter 0 libsystem_kernel.dylib 0x7ff80a8713ea psynch_cvwait + 10 1 libsystem_pthread.dylib 0x7ff80a8aba6f _pthread_cond_wait + 1249 2 libc++.1.dylib 0x7ff80a809d02 std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&) + 18 3 pyrogenesis 0x10d3f1bb9 CTextureConverter::RunThread(CTextureConverter*) + 249 4 pyrogenesis 0x10d3f284a void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(CTextureConverter*), CTextureConverter*> >(void*) + 58 5 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 6 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 22:: com.apple.NSEventThread 0 libsystem_kernel.dylib 0x7ff80a86e97a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x7ff80a86ece8 mach_msg + 56 2 CoreFoundation 0x7ff80a97236d CFRunLoopServiceMachPort + 319 3 CoreFoundation 0x7ff80a9709f8 CFRunLoopRun + 1276 4 CoreFoundation 0x7ff80a96fe3c CFRunLoopRunSpecific + 562 5 AppKit 0x7ff80d5179ce _NSEventThread + 132 6 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 7 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 23:: com.apple.audio.IOThread.client 0 libsystem_kernel.dylib 0x7ff80a86e97a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x7ff80a86ece8 mach_msg + 56 2 CoreAudio 0x7ff80c4f1c07 HALB_MachPort::SendSimpleMessageWithSimpleReply(unsigned int, unsigned int, int, int&, bool, unsigned int) + 111 3 CoreAudio 0x7ff80c37c729 HALC_ProxyIOContext::IOWorkLoop() + 3931 4 CoreAudio 0x7ff80c37b205 invocation function for block in HALC_ProxyIOContext::HALC_ProxyIOContext(unsigned int, unsigned int) + 63 5 CoreAudio 0x7ff80c547616 HALB_IOThread::Entry(void*) + 72 6 libsystem_pthread.dylib 0x7ff80a8ab4e1 _pthread_start + 125 7 libsystem_pthread.dylib 0x7ff80a8a6f6b thread_start + 15

Thread 24: 0 libsystem_pthread.dylib 0x7ff80a8a6f48 start_wqthread + 0

Thread 25: 0 libsystem_pthread.dylib 0x7ff80a8a6f48 start_wqthread + 0

Thread 0 crashed with X86 Thread State (64-bit):

rax: 0xff7803a02c4b0088 rbx: 0x00007ff7b268e6c0 rcx: 0x00007ff7b2dba820 rdx: 0x00007ff7b2dba810 rdi: 0x00007ff7b268e660 rsi: 0x00007ff7b268e660 rbp: 0x00007ff7b268e630 rsp: 0x00007ff7b268df60

r8: 0x0000000000006020 r9: 0x0000000000000020 r10: 0x00000000bc67e576 r11: 0x00007fac699ba680

r12: 0x00007ff7b268e660 r13: 0x000000000000018b r14: 0x00007ff7b268e1e0 r15: 0x00007ff7b268e1e0 rip: 0x000000010df79bb5 rfl: 0x0000000000210297 cr2: 0x00007ff7b268df58

Logical CPU: 2 Error Code: 0x00000006 (no mapping for user data write) Trap Number: 14

Thread 0 instruction stream:

74 8b e8 fe 47 c6 00 48-8d 05 04 be aa 02 48 8d t...G..H......H. 0d de 20 c9 02 48 89 01-c7 04 25 00 00 00 00 4a .. ..H....%....J 00 00 00 e8 33 da 1e 00-0f 1f 00 41 57 41 56 41 ....3......AWAVA 54 53 48 81 ec 58 02 00-00 49 89 f4 49 89 fe 48 TSH..X...I..I..H 8b 05 05 cd be 02 48 8b-00 48 89 84 24 50 02 00 ......H..H..$P.. 00 41 83 7c 24 08 07 0f-84 91 03 00 00 4c 89 e7 .A.|$........L..

[e8]e6 fe ff ff 49 89 c7-49 8b 54 24 28 48 85 d2 .....I..I.T$(H.. <==

75 23 4c 89 e7 e8 d1 fe-ff ff 41 8b 74 24 10 48 u#L.......A.t$.H 8b 48 30 2b 31 48 89 c7-e8 8e 59 f8 ff 48 89 c2 .H0+1H....Y..H.. 49 89 54 24 28 48 8d 7c-24 10 4c 89 fe e8 f9 5e I.T$(H.|$.L....^{0a 00 49 8b 1c 24 4c 89-e7 e8 9d fe ff ff 8b 40 ..I..$L........@
64 0f 28 05 f3 66 cc 00-0f 29 44 24 50 0f 28 05 d.(..f...)D$P.(.}

Binary Images:

0x10d072000 - 0x110b65fff com.wildfiregames.0ad (0.0.25b) <c3acd240-8880-34fb-8889-5fe77bd4428f> /Users/USER/Desktop/0 A.D..app/Contents/MacOS/pyrogenesis

0x7ff80a86d000 - 0x7ff80a8a4fff libsystem_kernel.dylib (*) <8cc28466-fd2f-3c80-9834-9525b7beac19> /usr/lib/system/libsystem_kernel.dylib 0x7ff80a8a5000 - 0x7ff80a8b0fff libsystem_pthread.dylib (*) <b5454e27-e8c7-3fdb-b77f-714f1e82e70b> /usr/lib/system/libsystem_pthread.dylib 0x7ff80a7fe000 - 0x7ff80a856fff libc++.1.dylib (*) <e67ac91f-f1dc-30ec-84f3-83f5bdad3434> /usr/lib/libc++.1.dylib 0x7ff813391000 - 0x7ff8133b2fff com.apple.audio.caulk (1.0) <8e7b3d95-1d47-3f17-9512-c5fcc30792c2> /System/Library/PrivateFrameworks/caulk.framework/Versions/A/caulk 0x7ff80a775000 - 0x7ff80a7fdfff libsystem_c.dylib (*) <e42e9d7a-03b4-340b-b61e-dcd45fd4acc0> /usr/lib/system/libsystem_c.dylib 0x7ff80a8f2000 - 0x7ff80adf4fff com.apple.CoreFoundation (6.9) <93c48919-68af-367e-9a67-db4159bc962c> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x7ff80d36b000 - 0x7ff80e1fafff com.apple.AppKit (6.9) <06015263-62ac-3b08-a298-dc835c18452a> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x7ff80c1c2000 - 0x7ff80c8f7fff com.apple.audio.CoreAudio (5.0) <9be547d0-0af1-3470-afde-2ac4cd34441e> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio

0x0 - 0xffffffffffffffff ??? (*) <00000000-0000-0000-0000-000000000000> ???

External Modification Summary:

Calls made by other processes targeting this process:

task_for_pid: 0 thread_create: 0 thread_set_state: 0

Calls made by this process:

task_for_pid: 0 thread_create: 0 thread_set_state: 0

Calls made by all processes on this machine:

task_for_pid: 0 thread_create: 0 thread_set_state: 0

VM Region Summary: ReadOnly portion of Libraries: Total=1.0G resident=0K(0%) swapped_out_or_unallocated=1.0G(100%) Writable regions: Total=2.4G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=2.4G(100%)

VIRTUAL REGION

REGION TYPE SIZE COUNT (non-coalesced) =========== ======= ======= Accelerate framework 512K 4 Activity Tracing 256K 1 CG backing stores 3840K 4 CG image 912K 20 ColorSync 216K 25 CoreAnimation 48K 8 CoreGraphics 4K 1 CoreUI image data 304K 5 Foundation 32K 2 IOKit 7940K 1 Kernel Alloc Once 8K 1 MALLOC 1.9G 1409 MALLOC guard page 32K 8 MALLOC_NANO (reserved) 384.0M 1 reserved VM address space (unallocated) ObjC additional data 15K 1 OpenGL GLSL 256K 3 STACK GUARD 56.1M 26 Stack 32.6M 26 VM_ALLOCATE 2.1G 1243 VM_ALLOCATE (reserved) 280K 7 reserved VM address space (unallocated) CTF 756 1 DATA 34.7M 382 DATA_CONST 18.8M 224 DATA_DIRTY 974K 130 FONT_DATA 4K 1 GLSLBUILTINS 5176K 1 LINKEDIT 658.2M 12 TEXT 385.3M 395 UNICODE 592K 1 dyld private memory 1024K 1 mapped file 82.7M 20 shared memory 788K 18 =========== ======= ======= TOTAL 5.6G 3982 TOTAL, minus reserved VM space 5.3G 3982

Full Report

{"app_name":"pyrogenesis","timestamp":"2022-10-06 09:34:23.00 -0500","app_version":"0.0.25b","slice_uuid":"c3acd240-8880-34fb-8889-5fe77bd4428f","build_version":"0.0.25b","platform":1,"bundleID":"com.wildfiregames.0ad","share_with_app_devs":1,"is_first_party":0,"bug_type":"309","os_version":"macOS 12.6 (21G115)","incident_id":"5B7102F6-302C-4257-B7AB-E052D97F72F8","name":"pyrogenesis"} {

"uptime" : 47000, "procLaunch" : "2022-10-06 09:30:28.2663 -0500", "procRole" : "Foreground", "version" : 2, "userID" : 501, "deployVersion" : 210, "modelCode" : "iMac17,1", "procStartAbsTime" : 46913357219757, "coalitionID" : 2751, "osVersion" : {

"train" : "macOS 12.6", "build" : "21G115", "releaseType" : "User"

}, "captureTime" : "2022-10-06 09:34:23.2765 -0500", "incident" : "5B7102F6-302C-4257-B7AB-E052D97F72F8", "bug_type" : "309", "pid" : 8356, "procExitAbsTime" : 47148353411014, "cpuType" : "X86-64", "procName" : "pyrogenesis", "procPath" : "\/Users\/USER\/Desktop\/0 A.D..app\/Contents\/MacOS\/pyrogenesis", "bundleInfo" : {"CFBundleShortVersionString":"0.0.25b","CFBundleVersion":"0.0.25b","CFBundleIdentifier":"com.wildfiregames.0ad"}, "storeInfo" : {"deviceIdentifierForVendor":"C7340364-8A8A-5B03-9419-9B2BCDAF5080","thirdParty":true}, "parentProc" : "launchd", "parentPid" : 1, "coalitionName" : "com.wildfiregames.0ad", "crashReporterKey" : "DE948911-6A77-E415-84DA-6B70FBAFBEA5", "wakeTime" : 1360, "sleepWakeUUID" : "18237E5B-34C3-4ABE-940C-574325351CC0", "sip" : "enabled", "vmRegionInfo" : "0x7ff7b268df58 is in 0x7ff7aee8e000-0x7ff7b268e000; bytes after start: 58720088 bytes before end: 167\n REGION TYPE START - END [ VSIZE] PRT\/MAX SHRMOD REGION DETAIL\n MALLOC_LARGE 7fac8a698000-7fac8a6ef000 [ 348K] rw-\/rwx SM=PRV \n GAP OF 0x4b2479f000 BYTES\n---> STACK GUARD 7ff7aee8e000-7ff7b268e000 [ 56.0M] ---\/rwx SM=NUL ... for thread 0\n Stack 7ff7b268e000-7ff7b2e8e000 [ 8192K] rw-\/rwx SM=PRV thread 0", "isCorpse" : 1, "exception" : {"codes":"0x0000000000000002, 0x00007ff7b268df58","rawCodes":[2,140701826867032],"type":"EXC_BAD_ACCESS","signal":"SIGSEGV","subtype":"KERN_PROTECTION_FAILURE at 0x00007ff7b268df58"}, "termination" : {"flags":0,"code":11,"namespace":"SIGNAL","indicator":"Segmentation fault: 11","byProc":"exc handler","byPid":8356}, "vmregioninfo" : "0x7ff7b268df58 is in 0x7ff7aee8e000-0x7ff7b268e000; bytes after start: 58720088 bytes before end: 167\n REGION TYPE START - END [ VSIZE] PRT\/MAX SHRMOD REGION DETAIL\n MALLOC_LARGE 7fac8a698000-7fac8a6ef000 [ 348K] rw-\/rwx SM=PRV \n GAP OF 0x4b2479f000 BYTES\n---> STACK GUARD 7ff7aee8e000-7ff7b268e000 [ 56.0M] ---\/rwx SM=NUL ... for thread 0\n Stack 7ff7b268e000-7ff7b2e8e000 [ 8192K] rw-\/rwx SM=PRV thread 0", "extMods" : {"caller":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"system":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"targeted":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"warnings":0}, "faultingThread" : 0, "threads" : [{"queue":"com.apple.main-thread","instructionState":{"instructionStream":{"bytes":[116,139,232,254,71,198,0,72,141,5,4,190,170,2,72,141,13,222,32,201,2,72,137,1,199,4,37,0,0,0,0,74,0,0,0,232,51,218,30,0,15,31,0,65,87,65,86,65,84,83,72,129,236,88,2,0,0,73,137,244,73,137,254,72,139,5,5,205,190,2,72,139,0,72,137,132,36,80,2,0,0,65,131,124,36,8,7,15,132,145,3,0,0,76,137,231,232,230,254,255,255,73,137,199,73,139,84,36,40,72,133,210,117,35,76,137,231,232,209,254,255,255,65,139,116,36,16,72,139,72,48,43,49,72,137,199,232,142,89,248,255,72,137,194,73,137,84,36,40,72,141,124,36,16,76,137,254,232,249,94,10,0,73,139,28,36,76,137,231,232,157,254,255,255,139,64,100,15,40,5,243,102,204,0,15,41,68,36,80,15,40,5],"offset":96}},"frames":[{"imageOffset":15760309,"symbol":"js::jit::JSJitFrameIter::machineState() const","symbolLocation":53,"imageIndex":0}],"id":478453,"triggered":true,"threadState":{"r13":{"value":395},"rax":{"value":18408467463349665928},"rflags":{"value":2163351},"cpu":{"value":2},"r14":{"value":140701826867680},"rsi":{"value":140701826868832},"r8":{"value":24608},"cr2":{"value":140701826867032},"rdx":{"value":140701834389520},"r10":{"value":3160925558},"r9":{"value":32},"r15":{"value":140701826867680},"rbx":{"value":140701826868928},"trap":{"value":14,"description":"(no mapping for user data write)"},"err":{"value":6},"r11":{"value":140378482910848},"rip":{"value":4529298357,"matchesCrashFrame":1},"rbp":{"value":140701826868784},"rsp":{"value":140701826867040},"r12":{"value":140701826868832},"rcx":{"value":140701834389536},"flavor":"x86_THREAD_STATE","rdi":{"value":140701826868832}},"name":"main"},{"id":478458,"name":"Task Mgr #0","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2689467,"symbol":"Threading::WorkerThread::RunUntilDeath()","symbolLocation":299,"imageIndex":0},{"imageOffset":2700762,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478459,"name":"Task Mgr #1","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2689467,"symbol":"Threading::WorkerThread::RunUntilDeath()","symbolLocation":299,"imageIndex":0},{"imageOffset":2700762,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478460,"name":"Task Mgr #2","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2689467,"symbol":"Threading::WorkerThread::RunUntilDeath()","symbolLocation":299,"imageIndex":0},{"imageOffset":2700762,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478461,"name":"Task Mgr #4","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2689467,"symbol":"Threading::WorkerThread::RunUntilDeath()","symbolLocation":299,"imageIndex":0},{"imageOffset":2700762,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478462,"name":"Task Mgr #3","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2689467,"symbol":"Threading::WorkerThread::RunUntilDeath()","symbolLocation":299,"imageIndex":0},{"imageOffset":2700762,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478463,"name":"Task Mgr #5","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2689467,"symbol":"Threading::WorkerThread::RunUntilDeath()","symbolLocation":299,"imageIndex":0},{"imageOffset":2700762,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478464,"name":"Task Mgr #6","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2689467,"symbol":"Threading::WorkerThread::RunUntilDeath()","symbolLocation":299,"imageIndex":0},{"imageOffset":2700762,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(Threading::WorkerThread*), Threading::WorkerThread*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478465,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478466,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478467,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478468,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478469,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478470,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478471,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478472,"name":"JS Helper","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":17782651,"symbol":"mozilla::detail::ConditionVariableImpl::wait_for(mozilla::detail::MutexImpl&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> const&)","symbolLocation":75,"imageIndex":0}]},{"id":478473,"frames":[{"imageOffset":6522,"symbol":"mach_msg_trap","symbolLocation":10,"imageIndex":1},{"imageOffset":7400,"symbol":"mach_msg","symbolLocation":56,"imageIndex":1},{"imageOffset":17426179,"symbol":"MachExceptionHandlerThread()","symbolLocation":771,"imageIndex":0}]},{"id":478476,"name":"AMCP Logging Spool","frames":[{"imageOffset":6582,"symbol":"semaphore_wait_trap","symbolLocation":10,"imageIndex":1},{"imageOffset":107238,"symbol":"caulk::mach::semaphore::wait_or_error()","symbolLocation":16,"imageIndex":4},{"imageOffset":8520,"symbol":"caulk::concurrent::details::worker_thread::run()","symbolLocation":36,"imageIndex":4},{"imageOffset":7692,"symbol":"void* caulk::thread_proxy<std::__1::tuple<caulk::thread::attributes, void (caulk::concurrent::details::worker_thread::*)(), std::__1::tuple<caulk::concurrent::details::worker_thread*> > >(void*)","symbolLocation":41,"imageIndex":4},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478521,"name":"CSoundManagerWorker","frames":[{"imageOffset":17086,"symbol":"semwait_signal","symbolLocation":10,"imageIndex":1},{"imageOffset":67683,"symbol":"nanosleep","symbolLocation":196,"imageIndex":5},{"imageOffset":7498518,"symbol":"SDL_Delay_REAL","symbolLocation":102,"imageIndex":0},{"imageOffset":5666295,"symbol":"SDL_Delay","symbolLocation":23,"imageIndex":0},{"imageOffset":2982375,"symbol":"CSoundManagerWorker::Run()","symbolLocation":583,"imageIndex":0},{"imageOffset":2981721,"symbol":"Threading::HandleExceptionsBase<&(CSoundManagerWorker::RunThread(CSoundManagerWorker*)), void (*)(CSoundManagerWorker*)>::Wrapper(CSoundManagerWorker*)","symbolLocation":121,"imageIndex":0},{"imageOffset":2983178,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(CSoundManagerWorker*), CSoundManagerWorker*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478522,"name":"CUserReportWorker","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":2729576,"symbol":"CUserReporterWorker::Run()","symbolLocation":920,"imageIndex":0},{"imageOffset":2728440,"symbol":"Threading::HandleExceptionsBase<&(CUserReporterWorker::RunThread(CUserReporterWorker*)), void (*)(CUserReporterWorker*)>::Wrapper(CUserReporterWorker*)","symbolLocation":120,"imageIndex":0},{"imageOffset":2738186,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(CUserReporterWorker*), CUserReporterWorker*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478523,"name":"SDLTimer","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":7460845,"symbol":"SDL_CondWaitTimeout_REAL","symbolLocation":205,"imageIndex":0},{"imageOffset":7459269,"symbol":"SDL_SemWaitTimeout_REAL","symbolLocation":181,"imageIndex":0},{"imageOffset":6229494,"symbol":"SDL_TimerThread","symbolLocation":614,"imageIndex":0},{"imageOffset":6226884,"symbol":"SDL_RunThread","symbolLocation":132,"imageIndex":0},{"imageOffset":7457845,"symbol":"RunThread","symbolLocation":21,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478542,"name":"TextureConverter","frames":[{"imageOffset":17386,"symbol":"psynch_cvwait","symbolLocation":10,"imageIndex":1},{"imageOffset":27247,"symbol":"_pthread_cond_wait","symbolLocation":1249,"imageIndex":2},{"imageOffset":48386,"symbol":"std::1::condition_variable::wait(std::1::unique_lock<std::__1::mutex>&)","symbolLocation":18,"imageIndex":3},{"imageOffset":3668921,"symbol":"CTextureConverter::RunThread(CTextureConverter*)","symbolLocation":249,"imageIndex":0},{"imageOffset":3672138,"symbol":"void* std::1::thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(CTextureConverter*), CTextureConverter*> >(void*)","symbolLocation":58,"imageIndex":0},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":478552,"name":"com.apple.NSEventThread","frames":[{"imageOffset":6522,"symbol":"mach_msg_trap","symbolLocation":10,"imageIndex":1},{"imageOffset":7400,"symbol":"mach_msg","symbolLocation":56,"imageIndex":1},{"imageOffset":525165,"symbol":"CFRunLoopServiceMachPort","symbolLocation":319,"imageIndex":6},{"imageOffset":518648,"symbol":"CFRunLoopRun","symbolLocation":1276,"imageIndex":6},{"imageOffset":515644,"symbol":"CFRunLoopRunSpecific","symbolLocation":562,"imageIndex":6},{"imageOffset":1755598,"symbol":"_NSEventThread","symbolLocation":132,"imageIndex":7},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":479177,"name":"com.apple.audio.IOThread.client","frames":[{"imageOffset":6522,"symbol":"mach_msg_trap","symbolLocation":10,"imageIndex":1},{"imageOffset":7400,"symbol":"mach_msg","symbolLocation":56,"imageIndex":1},{"imageOffset":3341319,"symbol":"HALB_MachPort::SendSimpleMessageWithSimpleReply(unsigned int, unsigned int, int, int&, bool, unsigned int)","symbolLocation":111,"imageIndex":8},{"imageOffset":1812265,"symbol":"HALC_ProxyIOContext::IOWorkLoop()","symbolLocation":3931,"imageIndex":8},{"imageOffset":1806853,"symbol":"invocation function for block in HALC_ProxyIOContext::HALC_ProxyIOContext(unsigned int, unsigned int)","symbolLocation":63,"imageIndex":8},{"imageOffset":3692054,"symbol":"HALB_IOThread::Entry(void*)","symbolLocation":72,"imageIndex":8},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":2},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":2}]},{"id":479858,"frames":[{"imageOffset":8008,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":2}]},{"id":479885,"frames":[{"imageOffset":8008,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":2}]}], "usedImages" : [ {

"source" : "P", "arch" : "x86_64", "base" : 4513538048, "CFBundleShortVersionString" : "0.0.25b", "CFBundleIdentifier" : "com.wildfiregames.0ad", "size" : 61816832, "uuid" : "c3acd240-8880-34fb-8889-5fe77bd4428f", "path" : "\/Users\/USER\/Desktop\/0 A.D..app\/Contents\/MacOS\/pyrogenesis", "name" : "pyrogenesis", "CFBundleVersion" : "0.0.25b"

}, {

"source" : "P", "arch" : "x86_64", "base" : 140703305224192, "size" : 229376, "uuid" : "8cc28466-fd2f-3c80-9834-9525b7beac19", "path" : "\/usr\/lib\/system\/libsystem_kernel.dylib", "name" : "libsystem_kernel.dylib"

}, {

"source" : "P", "arch" : "x86_64", "base" : 140703305453568, "size" : 49152, "uuid" : "b5454e27-e8c7-3fdb-b77f-714f1e82e70b", "path" : "\/usr\/lib\/system\/libsystem_pthread.dylib", "name" : "libsystem_pthread.dylib"

}, {

"source" : "P", "arch" : "x86_64", "base" : 140703304769536, "size" : 364544, "uuid" : "e67ac91f-f1dc-30ec-84f3-83f5bdad3434", "path" : "\/usr\/lib\/libc++.1.dylib", "name" : "libc++.1.dylib"

}, {

"source" : "P", "arch" : "x86_64", "base" : 140703451123712, "CFBundleShortVersionString" : "1.0", "CFBundleIdentifier" : "com.apple.audio.caulk", "size" : 139264, "uuid" : "8e7b3d95-1d47-3f17-9512-c5fcc30792c2", "path" : "\/System\/Library\/PrivateFrameworks\/caulk.framework\/Versions\/A\/caulk", "name" : "caulk"

}, {

"source" : "P", "arch" : "x86_64", "base" : 140703304208384, "size" : 561152, "uuid" : "e42e9d7a-03b4-340b-b61e-dcd45fd4acc0", "path" : "\/usr\/lib\/system\/libsystem_c.dylib", "name" : "libsystem_c.dylib"

}, {

"source" : "P", "arch" : "x86_64h", "base" : 140703305768960, "CFBundleShortVersionString" : "6.9", "CFBundleIdentifier" : "com.apple.CoreFoundation", "size" : 5255168, "uuid" : "93c48919-68af-367e-9a67-db4159bc962c", "path" : "\/System\/Library\/Frameworks\/CoreFoundation.framework\/Versions\/A\/CoreFoundation", "name" : "CoreFoundation", "CFBundleVersion" : "1866"

}, {

"source" : "P", "arch" : "x86_64", "base" : 140703350304768, "CFBundleShortVersionString" : "6.9", "CFBundleIdentifier" : "com.apple.AppKit", "size" : 15269888, "uuid" : "06015263-62ac-3b08-a298-dc835c18452a", "path" : "\/System\/Library\/Frameworks\/AppKit.framework\/Versions\/C\/AppKit", "name" : "AppKit", "CFBundleVersion" : "2113.60.148"

}, {

"source" : "P", "arch" : "x86_64", "base" : 140703331786752, "CFBundleShortVersionString" : "5.0", "CFBundleIdentifier" : "com.apple.audio.CoreAudio", "size" : 7561216, "uuid" : "9be547d0-0af1-3470-afde-2ac4cd34441e", "path" : "\/System\/Library\/Frameworks\/CoreAudio.framework\/Versions\/A\/CoreAudio", "name" : "CoreAudio", "CFBundleVersion" : "5.0"

}, {

"size" : 0, "source" : "A", "base" : 0, "uuid" : "00000000-0000-0000-0000-000000000000"

}

"sharedCache" : { "base" : 140703302197248, "size" : 19331678208, "uuid" : "73669942-bd8a-3e40-951f-7fbe07b51cb8"

"vmSummary" : "ReadOnly portion of Libraries: Total=1.0G resident=0K(0%) swapped_out_or_unallocated=1.0G(100%)\nWritable regions: Total=2.4G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=2.4G(100%)\n\n VIRTUAL REGION \nREGION TYPE SIZE COUNT (non-coalesced) \n=========== ======= ======= \nAccelerate framework 512K 4 \nActivity Tracing 256K 1 \nCG backing stores 3840K 4 \nCG image 912K 20 \nColorSync 216K 25 \nCoreAnimation 48K 8 \nCoreGraphics 4K 1 \nCoreUI image data 304K 5 \nFoundation 32K 2 \nIOKit 7940K 1 \nKernel Alloc Once 8K 1 \nMALLOC 1.9G 1409 \nMALLOC guard page 32K 8 \nMALLOC_NANO (reserved) 384.0M 1 reserved VM address space (unallocated)\nObjC additional data 15K 1 \nOpenGL GLSL 256K 3 \nSTACK GUARD 56.1M 26 \nStack 32.6M 26 \nVM_ALLOCATE 2.1G 1243 \nVM_ALLOCATE (reserved) 280K 7 reserved VM address space (unallocated)\nCTF 756 1 \nDATA 34.7M 382 \nDATA_CONST 18.8M 224 \nDATA_DIRTY 974K 130 \nFONT_DATA 4K 1 \nGLSLBUILTINS 5176K 1 \nLINKEDIT 658.2M 12 \nTEXT 385.3M 395 \nUNICODE 592K 1 \ndyld private memory 1024K 1 \nmapped file 82.7M 20 \nshared memory 788K 18 \n=========== ======= ======= \nTOTAL 5.6G 3982 \nTOTAL, minus reserved VM space 5.3G 3982 \n", "legacyInfo" : { "threadTriggered" : {

"name" : "main", "queue" : "com.apple.main-thread"

}

"trialInfo" : { "rollouts" : [

{

"rolloutId" : "5fc94383418129005b4e9ae0", "factorPackIds" : {

}, "deploymentId" : 240000486

}, {

"rolloutId" : "60186475825c62000ccf5450", "factorPackIds" : {

}, "deploymentId" : 240000026

}

], "experiments" : [

{

"treatmentId" : "5b729754-3882-4560-826f-9c0bc27d77c6", "experimentId" : "6192fb082171a2330e561df0", "deploymentId" : 400000035

}

]

} }

Model: iMac17,1, BootROM 451.140.1.0.0, 4 processors, Quad-Core Intel Core i7, 4 GHz, 16 GB, SMC 2.33f12 Graphics: AMD Radeon R9 M390, AMD Radeon R9 M390, PCIe, 2 GB Display: iMac, Retina 5K (5120 x 2880), Main, MirrorOff, Online Memory Module: BANK 0/DIMM0, 8 GB, DDR3, 1867 MHz, 0x802C, 0x31364B544631473634485A2D314739453220 Memory Module: BANK 1/DIMM0, 8 GB, DDR3, 1867 MHz, 0x802C, 0x31364B544631473634485A2D314739453220 AirPort: spairport_wireless_card_type_wifi (0x14E4, 0x14A), Broadcom BCM43xx 1.0 (7.77.111.1 AirPortDriverBrcmNIC-1710.4) AirPort: Bluetooth: Version (null), 0 services, 0 devices, 0 incoming serial ports Network Service: Wi-Fi, AirPort, en1 Serial ATA Device: APPLE SSD SM0128G, 121.33 GB Serial ATA Device: APPLE HDD ST3000DM001, 3 TB USB Device: USB30Bus USB Device: Bluetooth USB Host Controller USB Device: FaceTime HD Camera (Built-in) USB Device: USB Receiver Thunderbolt Bus: iMac, Apple Inc., 28.1

#6637 fixed .cargo directory created off user's home dir tim

Description

when building 0ad a .cargo directory containing a zero length .package-cache file is created from the user's home directory. This is being run on a non-debian based system (slackware) so apt is not used or present. Is there a way to prevent this directory being created outside of the extracted source tree? I test the build in an overlayfs chroot and everything else is created in the expected location. the build script is virtually the same as the one at https://slackbuilds.org/slackbuilds/15.0/games/0ad/0ad.SlackBuild updated for v 0.0.26-alpha and also uses https://slackbuilds.org/slackbuilds/15.0/games/0ad/disable-root-check.patch to allow root to create the package (as is standard for slackware packages)

#6636 fixed Add Vulkan renderer backend support Vladislav Belov Vladislav Belov

Description

Currently we're heavily CPU bound during rendering phase because of unoptimized art. As we might have a lot of draw calls (up to 50k in the worst case). Most of which can't be truly instanced.

To decrease CPU time during draw command processing we can add Vulkan and build draw commands lists by ourselves.

#6630 duplicate test_regression_rP26522 fails on Debian Ludovic Rousseau

Description

I am packing 0ad for Debian/Ubuntu. The code builds fine but the tests execution fails with:

Running cxxtest tests (391 tests)...........Skipping map generator tests (can't find binaries/data/mods/public/maps/random/tests/)
.............................
In TestCGUIText::test_regression_rP26522:
./source/gui/tests/test_CGUIText.h:319: Error: Expected ((g_VFS->Mount(L"", DataDir() / "mods" / "mod" / "", VFS_MOUNT_MUST_EXIST)) == INFO::OK), found (-110100 != 0)
ERROR: Failed to open font file fonts/sans-bold-13.fnt
ERROR: Failed to open font file fonts/sans-10.fnt
./source/gui/tests/test_CGUIText.h:332: Error: Expected (text.GetSize().Height == 14 + 9 + 8 * 2), found (22.0000 != 39)
.............................................................................................................................................................................................................................................Skipping globalscripts tests (can't find binaries/data/mods/public/globalscripts/tests/)
.Skipping component scripts tests (can't find binaries/data/mods/public/simulation/components/tests/setup.js)
................................................................................................................
Failed 1 and Skipped 0 of 391 tests
Success rate: 99%

The complete build log with the error is available at https://people.debian.org/~rousseau/0ad_0.0.26-1_amd64.build

I do not have sans-bold-13.fnt or sans-10.fnt files installed on my Debian system. I also could not find them in any Debian package.

For now I disabled the test for the Debian package and it looks like the game works fine.

It would be nice to have the test fixed for Alpha 27.

#6629 fixed Fails to open single player matches after enabling RegicideGarrison for a random map wraitii elconde

Description

Enabling RegicideGarrison for a random triggers the following error after re-entering single player match:

ERROR: JavaScript error: gamesettings/GameSettings.js line 97
Infinite loop initializing attributes detected, components: ["biome", "campaignData", "ceasefire", "cheats", "circularMap", "daytime", "disableSpies", "disableTreasures", "gameSpeed", "landscape", "lastManStanding", "lockedTeams", "map", "mapExploration", "mapName", "mapPreview", "mapSize", "matchID", "nomad", "playerAI", "playerCiv", "playerColor", "playerCount", "playerName", "playerTeam", "population", "rating", "regicideGarrison", "relic", "seaLevelRise", "seeds", "startingCamera", "startingResources", "teamPlacement", "triggerDifficulty", "triggerScripts", "victoryConditions", "wonder"]
  fromInitAttributes@gamesettings/GameSettings.js:97:9
  parseSettings@gui/gamesetup/Controllers/GameSettingsController.js:191:18
  onLoad@gui/gamesetup/Controllers/GameSettingsController.js:89:10
  SetupWindow@gui/gamesetup/SetupWindow.js:61:11
  init@gui/gamesetup/gamesetup.js:47:18
  onPress@gui/pregame/MainMenuItems.js:99:13
  performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9
  pressButton@gui/pregame/MainMenuItemHandler.js:63:10
ERROR: GUI page 'page_gamesetup.xml': Failed to call init() function

Refs: https://wildfiregames.com/forum/topic/95151-i-dont-know-what-to-do-can-someone-help-me-and-explain/

#6628 invalid Error in Spanish text - Settings Menu>Hotkeys>Category>In Game Diptro

Description

Hello, there is an error in Spanish text at:

Settings Menu > Hotkeys > Category > In Game > Back to work "Y" When you move de mouser over the text it shows: "No pedir informacion al borrar un edificio/unidad"

#6625 fixed Fix DisplayVersion in NSIS on Windows Vladislav Belov Vladislav Belov

Description

Current we use inconsistent versioning for the Windows installer (r*-alpha instead of 0.0.*): https://trac.wildfiregames.com/browser/ps/trunk/source/tools/dist/0ad.nsi#L165

It also affects versioning in winget: https://github.com/microsoft/winget-pkgs/pull/80769

That might confuse users unfamiliar with r*-alpha format.

Refs: https://issuehint.com/issue/microsoft/winget-pkgs/56595

#6624 invalid A26 crashing when started via LinuxMint Cinnamon rori1977

Description

Hello, first of all big thanks for releasing A26 - well done.

I would like to share an observation occuring when starting A26 via LinuxMint Cinnamon via the start menu.

Observed behaviour:

Click LinumMint "Start"-button
Click Games
Click 0 AD

The window manager crashes and I am being logged out. After loggin in again to LinuxMint I can resume as normal.

Surprisingly everything works well, when I start 0ad via the "terminal". Doing this work flawlessly, so my assumtion is that there is an issue between 0ad and the Cinnamon Window Manager.

As I am a bit new, please guide me should I have missing to include relevant information for you.

#6623 fixed Han farming upgrades are broken Stan

Description

As reported by Edwarf han farming updates don't work and get stuck at 0.6 (1.2*0.5)

<@Edwarf> la collecte de nourriture est buggé avec les han, il y a plus le taux de collecte du riz sur les femmes et si c'est le même que les autres civ avec les 3 amelioration on passe de 0.5 à 0.6
en gros il y en a qu'une qui fonctionne ?
<@Stan> Ils ne sont plus séparés c'est le mêmeAvec le bonus des fermes moins chères
<@Edwarf> Ok bah ça marche pas bien : 0.5 * 1.2 * 1.2 * 1.2 = 0.6
<@Stan> Ca pourra être corrigé dans le mod de wraitii

#6621 needsinfo Volume gets reset despite having correct setting when game starts Nikhil Baliga

Description

Steps to duplicate: Start the game and set master volume to a low setting. You can hear the volume reducing. Save changes. Exit game and restart. Volume is again quite loud. However, settings still shows the value to be low. So, we have to again readjust to same value and save changes.

#6619 invalid Problemas con el contador de madera / Problems with the wooden counter Eduardo

Description

Hola! queria avisar que el contador de madera, no agrega ni disminuye su cantidad, lo que entorpece el juego ya que no te permite acumular madera para seguir avanzando. / Hello! I wanted to warn you that the wood counter does not add or decrease its quantity, which hinders the game since it does not allow you to accumulate wood to continue advancing.

P.D.: Sorry for my bad english, I'm from Argentina xD.

Chau! / Bye!

#6618 fixed Assertion failed: "cache.Validate()" on Ryzen (Zen 3) CPU Andrew

Description

Hello. It seems I was faced with the same issue as https://trac.wildfiregames.com/ticket/4360

I try to start 0 A.D on Linux Mint 20.3 (Una) OS and Ryzen 7 5700X CPU and see follow screen:

If click few times "Continue" - game starts in windowed mode.

The interesting thing is that I just have downgraded OS from Mint 21 (because I had some another troubles here - with some another software :)), and game started pretty well here. But now - on older version it doesn't.

#6616 invalid Unable to connect to the server Kenneth Gil

Description

Before it gave me an error and they told me to disable the TLS encryption and it worked, I could play with a friend, days passed and now I can join the Lobby but it does not let me enter a multiplayer game because I get the message "Unable to connect to the server" "usually occurs when the UDP port 20595 is not forwarded to the host, or by the action of a firewall or antivirus." only in a few games it lets me join but I am only interested in multiplayer to play with a friend and I can not do it. version: 22 ago. 2021 (25860)

#6615 fixed premake should fail if wx-config can't be found Stan Andy Alt

Description

If premake (update-workspaces.sh) can't find wx-config, it will spit out a message saying so but will continue on. The build will fail during the Atlas build because wx.h can't be found.

When premake looks for wx-config, it should exit immediately

https://wildfiregames.com/forum/topic/82754-alpha-26-pre-releaserelease-candidate-build-testing/?do=findComment&comment=517545

#6612 invalid match won on startup noideaforpseudo

Description

Hello, 0AD is amazing, thank you !

I tested this Solo > Matchs by default : 2 players, me and AI

Map type : random filter : all maps choose map : random

Start … I won ! 😃 there is no match actually : as soon as the map is loaded, there is a popup saying "you won ! do you want to quit ?" If I change players parameters to 4, it's ok.

Regards

#6609 duplicate Unable to verify server certificate or connection not fully completed Kenneth Gil

Description

I wanted to play multiplayer with a friend and I can not do it, when I enter multiplayer and multiplayer room asks me to create an account, when I register and I get a message "could not verify the server certificate or the connection was not completed at all", also if I go to multiplayer and join the game, when I click continue a message appears "It has not been possible to connect to the server, usually happens when the UDP port 20595 is not redirected to the host, or by action of a firewall or antivirus". I disabled the firewall but it still gave the same error. My friend is from Spain and I am from Ecuador, I don't know if it has something to do with this. I hope you can help me, thanks. (Note: I speak spanish, this message was translated on the internet)

#6607 invalid Memory leak/race condition in Future phosit

Description

While working on Phab:D4730 i noticed that the SharedState is held in the Future and the PackagedTask by a std::shared_ptr. If both get destroyed "at the same time" reference count is decremented only once and there is a memory leak. I didn't test if there actualy is a memory leak.

Solutions:

C++20 will have std::atomic<std::shared_ptr<>> but clang didn't implement it yet.
We could implement ower own atomicSharedPtr<> but that is error-prone.

My Solution:

The Future should only hold a unique_ptr and the PackagedTask a reference to the shared state. The destructor of the shared state has to blok until the PackagedTask is destructed/lets go of th reference. The downside of this approach is that the future can not be canceled. Instead a Future can request a cancelation. When the TaskManager invokes the PackagedTask it will not execute the function but set the state to canceled which allows the SharedState to be destructed. Since the TaskManager is moastly empty the SharedState will be canceled soon after cancelation is requested. At the back of my mind there is also the idea that we can remove PackagedTask and the queue from the TaskManager. Instead TaskManager holds a pointer to a "SharedState" with holds a pointer to the next. Building a linked list of tasks. This will have very little overhead and can propably be done lock-free.

#6603 fixed [macOS] mod.json issue Stan Langbart

Description

to reproduce

place a mod into your 0ad/mods folder (see wiki/GameDataPaths)
- for example git clone https://github.com/nanihadesuka/autociv.git
start pyrogenesis
warnings come up and files are being written to the directory you started the command from containing infos from mod.json
see warnings, images and log output below for more clarity

Warnings

0 A.D. (0.0.26) Main log (warnings and errors only)
WARNING: Could not write external mod.json for zipped mod 'public'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'Macedonia_0ad'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod '0ad-space'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'community-maps-2-git'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'ffm_4k'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod '0ad_GoodCursor'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'boonGUI'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'delenda_est'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'mare_nostrum'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'LocalRatings'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'fgod.exp.280320201820'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'autociv'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'rl-scenarios'. The mod should be reinstalled.

Engine exited successfully on 2022-08-16 at 12:38:42 with 469 message(s), 0 error(s) and 13 warning(s).

Images

Log Output

These warnings showed up when compiling the game after upgrading from [27054] to [27056].

==== Building scriptinterface (release) ====
==== Building engine (release) ====
Mod.cpp
ModInstaller.cpp
ModIo.cpp
../../../source/ps/ModInstaller.cpp:121:28: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
        const char* modJsonPath = OsString(modDir / L"mod.json").c_str();
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../source/ps/Mod.cpp:62:28: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
        const char* modJsonPath = OsString(modsPath / mod / L"mod.json").c_str();
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
1 warning generated.
Linking engine
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
==== Building graphics (release) ====

bisect

either it was [27055] or [27056]

note

It was reproducible even after deleting the cache folder and doing a clean install.

#6602 duplicate Game crashes on startup BrandonPilcher

Description

I am unable to start the game since it crashes on launch. Error message and .dmp are attached.

#6600 invalid Miniupnp library download broken Langbart

Description

Try to install miniupnp

build-osx-libs.sh

The link is dead at the moment.

Line
926	LIB_ARCHIVE="$LIB_VERSION.tar.gz"
927	LIB_DIRECTORY="$LIB_VERSION"
928	LIB_URL="http://miniupnp.tuxfamily.org/files/download.php?file="
929
930	mkdir -p miniupnpc

Alternatives:

#6596 needsinfo Game Crash (weird reason) Dimitri

Description

Was playing 0 A.D., fantastic game by the way, and I was playing the Egypt map with my dad, on the Nile. Hosts 4 players, and we were playing against bots, nothing out of the ordinary. There were some starter fields by my civic center, which I didn't use until 30 min into the game. I tried to get my females to harvest the field, but it refused to let me. So I decided to destroy the field to build my own, but the GAME CRASHED. Here's the error stuff:

Details: unhandled exception (PSERROR_Serialize_InvalidScriptValue("Serialize_InvalidScriptValue"))

Location: binaryserializer.cpp:129 (CBinarySerializerScriptImpl::HandleScriptVal)

Call stack:

(error while dumping stack: No stack frames found) errno = 0 (No error reported here) OS error = 0 (no error code was set)

IDK why this would cause the crash, but it did. Thought it was weird, and you guys should know. Have a good day!

~Dimitri

#6594 duplicate map re make required corsica vz sardinia giant smiley ferdi

Description

corsica vz sardinia giant. the hills on one side of the map are unclimbable so you cant reach two of the players

#6593 duplicate [macOS] Performance issue full screen for India biome Langbart

Description

Issue

When playing a specific random map with the default settings applied in full screen everything felt very slow, like walking through mud. Performance was better in window mode.

to reproduce

start the following map with the default settings and full screen

Notice the extreme performance drop between full screen and window mode.
See video below for more clarity. Watch the women walking to the meeting point. Everything is smooth in window mode, but slow in full screen mode.

https://ttm.sh/wvr.mp4

observations

After only reducing the materialmgr.quality value from 10 to 1 the performance is ~~much better~~ less bad.
When only lowering the adaptivefps.session from 60 to 20 as mentioned in #6193 the slowdown is not noticeable between full screen and window mode.
When only switching from OpenGL to OpenGL ARB or Vulkan (came with [27488]) the slowdown is not noticeable.

bisect

I am very confident that the change set [26859] is the cause of the problem.
Just to be clear, I also tested [26858], but the performance problem could not be observed in this big change set, it must be [26859].

#6592 wontfix Auto-research/ hide techs under specific conditions Langbart

Description

issues

1st part - Auto-research Cartography on fully revealed maps

Darkcity outlined an issue related to Cartography in the forum.

Disabling cartography in revealed map (17/Jul/22)

I think at present we still see cartograpgy in revealed map, becasue it has following use case, "Able to check allies resources and scores". [...] if map is revealed than why not research cartography be default? Since player can see everything on the map?

2nd part - Hide unproductive techs

Cartography, Diaspora and Commercial Treaty are only useful with mutual allies so they should be hidden if there are none and the teams are locked. For 1v1's it can also be argued that the techs should be hidden even if the teams are not locked, if the two parties become allies the game is over anyway.

Change set [25869] programmed that maps with the Reveal option enabled automatically research Cartography as well.
It was changed to its current mode with [26151].

notes

The first part of the issue could be voided because with A26 we get a new option Allied View. This allows the setting desired by Darkcity, while still retaining an option of the status quo to invest in research to get the actual benefit (Access to summary of your allies).

The second part falls under Quality of Life improvement, as fewer useless techs are presented.
Side effects could be:

Confusion about what is represented in the structure tree.
If a tech score is introduced, it would always set back the player without allies compared to the player with allies.

#6591 fixed New icon for the Han campion crossbow Stan marder

Description

https://trac.wildfiregames.com/changeset/27009 introduced a new champion crossbow unit for the Han.

Would be nice if it would have it's own icon and not reusing the Macedonian one.

#6590 fixed Server Certification error Soyisabelruiz

Description

Error while trying to sign up in the multiplayer lobby, cant log in or create account...

#6589 duplicate SERVER PROBLEMS Soyisabelruiz

Description

No se pudo verificar el certificado del servidor The server certificate cannot be verified Please help

#6588 invalid ungarrisonable filter does nothing Andy Alt

Description

The filter disableGarrisonHolder.xml was renamed to ungarrisonable.xml (2 or 3 releases ago?)

I tried using it for a wonder, but it doesn't do anything.

I think it's because the only template that seems to be using the 'Garrisonable' field is templates/template_unit.xml

That's the field specified in the 'ungarrisonable.xml' filter:

<Entity merge="">
  <Garrisonable disable=""/>
</Entity>

But the other templates are using the 'GarrisonHolder' field; for example, template_structure_wonder.xml:

  <GarrisonHolder>
    <Max>50</Max>
    <EjectHealth>0.1</EjectHealth>
    <EjectClassesOnDestroy datatype="tokens">Unit</EjectClassesOnDestroy>
    <List datatype="tokens">Support Soldier</List>
    <BuffHeal>5</BuffHeal>
    <LoadingRange>2</LoadingRange>
  </GarrisonHolder>

#6587 fixed Tooltip issue after modifying a tech for the Macedonian civ bonus marder Langbart

Description

Obelix reported an issue in the forum about a side effect of the new civbonus (mace_storehouse.json) for the Macedonians (added with [26627]).

Alpha 26 Pre-release/Release Candidate Build Testing (10/Jul/22)

issue

The tech sets the time to zero

Line
10	"modifications": [
11	{
12	"value": "Researcher/TechCostMultiplier/time",
13	"replace": 0
14	}
15	],

the tooltip time is checked twice for its existence with an if statement (if(0) equals to false).

Line
720	let totalCosts = multiplyEntityCosts(template, buildingsCountToTrainFullBatch * fullBatchSize + remainderBatch);
721	if (template.cost.time)
722	totalCosts.time = Math.ceil(template.cost.time * (entity ? Engine.GuiInterfaceCall("GetBatchTime", {
723	"entity": entity,
724	"batchSize": buildingsCountToTrainFullBatch > 0 ? fullBatchSize : remainderBatch
725	}) : 1));
726
727	let costs = [];
728	for (let type of getCostTypes())
729	if (totalCosts[type])
730	costs.push(sprintf(translate("%(component)s %(cost)s"), {

See also comment:3 below for the other issue regarding the correct display of the tooltip in the structure tree for the modified techs.

possible solutions

idea A

rework the JavaScript part for the tooltip. The result would display a time of 0.

binaries/data/mods/public/gui/common/tooltips.js

                function getEntityCostComponentsTooltipString(template, entity, buildingsCountTo
     if (!template.cost)
         return [];
     let totalCosts = multiplyEntityCosts(template, buildingsCountToTrainFullBatch * fullBatchSize + remainderBatch);
     if (template.cost.time)
+    if (typeof template.cost.time == "number")
         totalCosts.time = Math.ceil(template.cost.time * (entity ? Engine.GuiInterfaceCall("GetBatchTime", {
             "entity": entity,
             "batchSize": buildingsCountToTrainFullBatch > 0 ? fullBatchSize : remainderBatch
-…
+               function getEntityCostComponentsTooltipString(template, entity, buildingsCountTo
     let costs = [];
     for (let type of getCostTypes())
         if (totalCosts[type])
+        if (typeof totalCosts[type] == "number")
             costs.push(sprintf(translate("%(component)s %(cost)s"), {
                 "component": resourceIcon(type),
                 "cost": totalCosts[type]

idea B

rework the tech, by doing a multiplication with a low value e.g. 0.01 (similar to the cheat code gift from the gods to get fast actions (fastactions.js). The result would display a time of 1.

binaries/data/mods/public/simulation/data/technologies/civbonuses/mace_storehouse.json

-              a
     "description": "The Macedonian economy relied greatly on their vast natural resources.",
     "requirements": { "civ": "mace" },
     "icon": "wood_axe.png",
     "tooltip": "Storehouse technologies −100% research time.",
+    "tooltip": "Research happens instantly.",
     "modifications": [
         { "value": "Researcher/TechCostMultiplier/time", "replace": 0 }
+        { "value": "Researcher/TechCostMultiplier/time", "multiply": 0.01 }
     ],
     "affects": ["Storehouse"]
+}

additional nitpick

(just a point of polish that they could choose to ignore it)

The string Right-click (tooltips.js) should get a color treatment,

Line
1210	// Translation: Appears in a tooltip to indicate that right-clicking the corresponding GUI element will open the Template Details GUI page.
1211	return translate("Right-click to view more information.");
1212	}

like its being done for the string Click in the getOrderTooltip function (CounterManager.js).

Line
101	return "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), {
102	"hotkey": setStringTags("\\[Click]", g_HotkeyTags),
103	"order":

#6586 fixed 0ad fails to start if broken symlink is in mods folder phosit Andy Alt

Description

This happens on the svn version (maybe on a25, but I haven't tested it).

0ad fails to start if a broken symlink is in the mods folder. The error message doesn't indicate the specific problem.

Steps to reproduce:

Close 0ad if it's open
In your mods folder, add a broken symlink
Start 0ad

TIMER| CONFIG_Init: 1.74907 ms
Function call failed: return value was -1 (Function failed (no details available))
Location: file_system.cpp:123 (GetDirectoryEntries)

Call stack:

(0x5613abf648ce) ./pyrogenesis(+0x6438ce) [0x5613abf648ce]
(0x5613abf0f2ef) ./pyrogenesis(+0x5ee2ef) [0x5613abf0f2ef]
(0x5613abf10ef4) ./pyrogenesis(+0x5efef4) [0x5613abf10ef4]
(0x5613abf0f503) ./pyrogenesis(+0x5ee503) [0x5613abf0f503]
(0x5613abf266a2) ./pyrogenesis(+0x6056a2) [0x5613abf266a2]
(0x5613abc1b2ed) ./pyrogenesis(+0x2fa2ed) [0x5613abc1b2ed]
(0x5613abbf71be) ./pyrogenesis(+0x2d61be) [0x5613abbf71be]
(0x5613ab9d9296) ./pyrogenesis(+0xb8296) [0x5613ab9d9296]
(0x5613ab9c4bc7) ./pyrogenesis(+0xa3bc7) [0x5613ab9c4bc7]
(0x7f4993a94290) /usr/lib/libc.so.6(+0x29290) [0x7f4993a94290]
(0x7f4993a9434a) /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7f4993a9434a]
(0x5613ab9d5bd5) ./pyrogenesis(+0xb4bd5) [0x5613ab9d5bd5]

errno = 40 (?)
OS error = ?

#6585 fixed Error with 0 AD launch Alec Villanueva

Description

Much to our regret we must report the program has encountered an error.

Please let us know at http://trac.wildfiregames.com/ and attach the crashlog.txt and crashlog.dmp files. You may find paths to these files at https://trac.wildfiregames.com/wiki/GameDataPaths

Details: unhandled exception (Access violation reading 0x0000000C)

Location: unknown:0 (?)

Call stack:

(error while dumping stack: No stack frames found) errno = 13 (Insufficient access rights to open file) OS error = 0 (no error code was set)

#6583 fixed Garrison with formation gives errors. Freagarach Freagarach

Description

Start a match, make a formation, garrison the formation in the CC. Unload the CC, watch the errors when hovering.

#6581 fixed Flickering tooltip for user report button Langbart

Description

The issue was reported by max_torch

Mouse hover tooltip of the "Enable Feedback" button flickers rapidly (23/Jun/22)

to reproduce

Open 0 A.D.
Move the cursor above the Enable Feedback button in the bottom right corner
See GIF below for more clarity

possible solution

Remove the tooltip or make use of the pgToolTip object.

binaries/data/mods/public/gui/pregame/userreport/userreport.xml

-              a
     <object type="text" name="userReportText" style="userReportText" size="2 2 100%-2 100%-40"/>
     <object type="button" name="userReportEnableButton" style="StoneButton" size="8 100%-36 151 100%-8"/>
+    <object type="button" name="userReportEnableButton" style="StoneButton" tooltip_style="pgToolTip" size="8 100%-36 151 100%-8"/>
     <object type="button" name="userReportTermsButton" style="StoneButton" size="100%-151 100%-36 100%-8 100%-8"/>
 </object>

reproducible

The poor positioning of the tooltip has been there since A23b, but the severe flickering started with A25b. There was NO flickering in A24b. Why does it flicker?

related discussion

IRC 0ad-dev 15/May/22

20:31 <@Stan> Someone reported that the userreporter flickers on macos
[...]
20:32 <@Stan> I think it triggers some z fighting with macos widgets

#6580 fixed Trouble with merging formations Freagarach Langbart

Description

Issue No.1 - conversion check

This issue was first reported by andy5995 in the forum

Feedbacks from A26 SVN tests (22/Jun/22)

errors

ERROR: JavaScript error: simulation/components/Formation.js line 931
Script value conversion check failed: v.isString() || v.isNumber() || v.isBoolean() (got type undefined)
  Formation.prototype.ComputeMotionParameters@simulation/components/Formation.js:931:16
  Formation.prototype.AddMembers@simulation/components/Formation.js:449:7
  Formation.prototype.ShapeUpdate@simulation/components/Formation.js:973:8
  Timer.prototype.OnUpdate@simulation/components/Timer.js:139:44
ERROR: Script message handler OnUpdate failed

to reproduce

Note: The steps for reproduction could not be clearly determined, the following points only increase the probability of the error occurring.

Start a map with three unit groups, each with at least 4 entities.
Position them far apart and select them all.
First choose the None formation and after that the Box formation
Units should not come together, but only form a formation at the position they are currently at.
Now order all three groups to come together by clicking at the center point.
Check the images below and the first minute of the attached replay for more clarity: conversion_check.txt

possible solution for issue no.1

binaries/data/mods/public/simulation/components/Formation.js

                Formation.prototype.ShapeUpdate = function()
         // Merge the members from the twin formation into this one
         // twin formations should always have exactly the same orders.
         let otherMembers = cmpOtherFormation.members;
+        if (otherMembers.length == 0)
+            continue;
         cmpOtherFormation.RemoveMembers(otherMembers);
         this.AddMembers(otherMembers);
         Engine.DestroyEntity(this.twinFormations[i]);

Issue No.2

It is related to problem no. 1. If the group is not successfully merged, there is a big problem that prevents any interaction with the game when trying to select certain units that have not been successfully merged into the new large formation.

errors

ERROR: JavaScript error: gui/session/selection.js line 500
GetEntityState(...) is null
  EntitySelection.prototype.addFormationMembers@gui/session/selection.js:500:39
  EntitySelection.prototype.setHighlightList@gui/session/selection.js:433:20
  handleInputBeforeGui@gui/session/input.js:529:16

to reproduce

Note: The steps for reproduction could not be clearly determined, the following points only increase the probability of the error occurring.

Try the steps from issue no.1 with a mixture of different unit types.
This might take multiple runs to occur.
Watch the replay GetEntityState_null.txt till 50 seconds have gone by and then try to select all the units that have tried to merge.

bisect

(not yet)

reproducible

Could not trigger any of the errors described above in A25b, I guess the problem must have been introduced after [25860].

additional notes

Tested on [26983] with default settings.

#6579 fixed Wrong animation selected for unit activity Stan Langbart

Description

The recent animation cleanup in the actor files causes a lot of issues. Very often a wrong animation is being displayed.

to reproduce for an Athens spearman

Start a map with Athens, select the spearmen and have them start collecting wood.
Pay attention when they move between drop points.
See GIF/Image below for more clarity. On the left side is [26964], on the right side [26963].

bisect

The problem with the Athenian spearman described above occurred with [26964].
More civs and units are affected, e.g. the Roman swordsman.

possible solution

Adding frequency="1"

binaries/data/mods/public/art/actors/units/athenians/infantry_spearman_b.xml

-              a
     <variant file="biped/approach_praise.xml"/>
   </group>
   <group>
     <variant name="Idle"/>
+    <variant frequency="1" name="Idle"/>
     <variant file="biped/formations/phalanx_front.xml"/>
     <variant file="biped/formations/phalanx_mid.xml"/>
     <variant file="biped/formations/phalanx_back.xml"/>

related ticket

#6566

#6578 fixed Warnings for too many minimap icons Stan Langbart

Description

to reproduce

start the egypt_3pv3p map

Warnings show up

WARNING: Too many minimap icons to draw.

See image below for more clarity

bisect

[26949] The patch was tested for patch ID 20476 (15/Jun/22-8:35PM) and did not display any warnings. The warnings came with patch ID 20480 (16/Jun/22-5:27PM).

#6573 fixed Overlaping dialog "Connect to game lobby" marder phosit

Description

If i open Multiplayer >> Game Lobby the "Connect to game lobby" dialog is opened but the "Multiplayer Lobby" dialog is behind it. The decorations can be seen.

reproducible

Issue can be reproduced up to A23b, but not for A22. See image below for more clarity.

possible solution

Reduce the width of the entrance dialog slightly optionally annotating the choice for the dimension.

binaries/data/mods/public/gui/prelobby/entrance/entrance.xml

-              a
     <!-- Add a translucent black background to fade out the menu page -->
     <object type="image" sprite="ModernFade"/>
     <object name="dialog" type="image" style="ModernDialog" size="50%-230 50%-130 50%+230 50%+130">
+    <object name="dialog" type="image" style="ModernDialog" size="50%-215 50%-130 50%+215 50%+130">
         <object style="ModernLabelText" type="text" size="50%-128 -18 50%+128 14">
             <translatableAttribute id="caption">Multiplayer Lobby</translatableAttribute>

#6571 fixed Phasing up with cheat code for Athens Freagarach Langbart

Description

to reproduce

Start a game with Athen (other civs are fine)
enter gift from the gods or back to the future
Note that the phase symbol is not changing in the Civic Centre.

bisecting guessing

I assume it is this one [26298]

reproducible

The issue is not reproducible in A25b [25860]

possible solution

binaries/data/mods/public/simulation/helpers/Cheat.js

                function Cheat(input)
         else
             return;
+        if (TechnologyTemplates.Has(parameter + "_" + cmpPlayer.civ))
+            parameter += "_" + cmpPlayer.civ;
+        const civMe = Engine.QueryInterface(playerEnt, IID_Identity).GetCiv();
+        if (TechnologyTemplates.Has(parameter + "_" + civMe))
+               parameter += "_" + civMe;
         else
             parameter += "_generic";

#6570 fixed Naval Shipyard unusable Freagarach Langbart

Description

An issue was reported by Freagarach via IRC 0ad-dev 11/Jun/22

[...] Carths Super Dock is broken.

to reproduce

Build the Carthaginian Naval Shipyard and try to produce something
Warnings shows up

WARNING: Trainer without Production Queue found: 2204.

note

Tested all the other civs and I think this is the only structure that has this problem, at least the ones that are accessible in the main game.

#6569 fixed Visibility issue with smoothlos in fast forward observer mode Vladislav Belov Langbart

Description

to reproduce

Default settings applied
Create a replay in which your unit establishes an outpost in the outskirts of your area.
View the replay, but at a minimum of 5x or even better 10x speed and set the view to that player.
- Alternatively, you can start a game with delenda_est activated and set the game speed to 10x.
the visibility does not adjust (20x) or lags behind noticeable (5x), if you lower the speed below 2x it does work properly.
See GIF/image below for more clarity.

bisect

[26922]

workaround

Set smoothlos=false

reproducible

When watching in 20xfast-forward with smootlos=true in A25b, the visibility works correctly.

#6568 invalid Formations bigger than 20 should hold up a flag Dworv

Description

There may already be a way to do this that I'm not aware of, but I think that having one person from a formation of 20 or larger hold up a flag would enhance the battle experience, as well as make it more clear who is who during large battles between more than two sides.

#6567 fixed Only specific name for Han females displayed wowgetoffyourcellphone Langbart

Description

The Han woman only shows the specific name. Mix-up between Specific and Generic in the Identity section.
Earliest commit from the Han mod bca4b9f (9/Jan/20).

templates/units/han/support_female_citizen.xml

Line
8	<Identity>
9	<Civ>han</Civ>
10	<GenericName>Fù Nǚ</GenericName>
11	<Icon>units/han/support_female_citizen.png</Icon>
12	</Identity>

Other Han units and structures are fine.

additional nit pick

Changing the default setting for howtoshownames from 0 to 1 would be more consistent, as the general name is always listed before the specific name in the template files.

#6566 fixed Han gather_grain animation is not chosen correctly for Spearman and Pikeman Freagarach Langbart

Description

I could not find the steps to reproduce the problem conclusively, but it happened to me at least twice and only with the Han. See the attached replay (animation_broke_rice_gather.txt) and the GIF below for more clarity. The unit still farms, but the gather_grain animation does not work properly.

possibly related

~~Similar sounding problem reported by borg via the forum~~

~~Han women cant get food from farms after "gift from the gods" (11/Jun/22)~~

EDIT 12/Jun/22 with [26937]

~~The issue is still noticeable, see attached replay (farmMe_rP26937.txt ~3min mark) and GIF below for more clarity. The unit simply stops the animation, still gathering though.~~

EDIT 13/Jun/22

~~Reproduce: Add a small distance between the rice field and the drop point, so that the unit has to walk. The problem can only be observed for Han citizen-soldiers.~~

~~Seems to do with approach_rice.xml and the line <variant file="biped/approach_rice.xml"/> in the binaries/data/mods/public/art/actors/units/han/ files. Ref: [26937]~~

Update

to reproduce

Open Atlas and place a CC and a Han rice field next to each other without leaving a gap between them.
Place a han/infantry_spearman_b.xml and a han/infantry_halberdman_b.xml and start the simulation. (Only these two unit types - Spearman and Pikeman - are affected by the Han.)
Order them to gather
Wait until they reach the CC, the animation for gathering is not chosen.

issue

wiki/Actors#Randomnessandselections

If two variants have equal frequency values, they have equal chance of being selected.

I think in Atlas the top line is always chosen, moving the line for gather_grain above carry_food would also work, at least in Atlas.

binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml

-              a
   </group>
   <group>
     <variant file="biped/base_spearman_shield_relax.xml"/>
+    <variant file="biped/gather_grain.xml"/>
     <variant file="biped/carry_food.xml">
       <props>
         <prop actor="props/units/helmets/han_ricehat.xml" attachpoint="helmet"/>
 …
     <variant file="biped/formations/anti_cavalry_back.xml"/>
     <variant file="biped/attack_slaughter.xml"/>
     <variant file="biped/gather_tree.xml"/>
-    <variant file="biped/gather_grain.xml"/>
     <variant file="biped/gather_fruit.xml"/>
     <variant file="biped/gather_meat.xml"/>
     <variant file="biped/gather_rock.xml"/>

possible solution

binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml

-              a
         <prop actor="props/units/helmets/han_ricehat.xml" attachpoint="helmet"/>
       </props>
     </variant>
-    <variant file="biped/attack_capture.xml"/>
-    <variant file="biped/formations/anti_cavalry_front.xml"/>
-    <variant file="biped/formations/anti_cavalry_back.xml"/>
-    <variant file="biped/attack_slaughter.xml"/>
-    <variant file="biped/gather_tree.xml"/>
-    <variant file="biped/gather_grain.xml"/>
-    <variant file="biped/gather_fruit.xml"/>
-    <variant file="biped/gather_meat.xml"/>
-    <variant file="biped/gather_rock.xml"/>
-    <variant file="biped/gather_ore.xml"/>
-    <variant file="biped/gather_ruins.xml"/>
-    <variant file="biped/gather_praise.xml"/>
-    <variant file="biped/build.xml"/>
-    <variant file="biped/build_farm.xml"/>
-    <variant file="biped/death_infantry.xml"/>
     <variant file="biped/carry_meat.xml"/>
     <variant file="biped/carry_wood.xml"/>
     <variant file="biped/carry_stone.xml"/>
 …
     <variant file="biped/approach_praise.xml"/>
   </group>
   <group>
+    <variant name="Idle"/>
+    <variant frequency="1" name="Idle"/>
+    <variant file="biped/attack_capture.xml"/>
+    <variant file="biped/attack_slaughter.xml"/>
+    <variant file="biped/gather_tree.xml"/>
+    <variant file="biped/gather_grain.xml"/>
+    <variant file="biped/gather_fruit.xml"/>
+    <variant file="biped/gather_meat.xml"/>
+    <variant file="biped/gather_rock.xml"/>
+    <variant file="biped/gather_ore.xml"/>
+    <variant file="biped/gather_ruins.xml"/>
+    <variant file="biped/gather_praise.xml"/>
+    <variant file="biped/build.xml"/>
+    <variant file="biped/build_farm.xml"/>
+    <variant file="biped/death_infantry.xml"/>
   </group>
   <material>player_trans.xml</material>
 </actor>

additional nitpick

Other actors, such as romans/infantry_spearman_b.xml, should receive a similar treatment.

#6565 fixed Han units are not distributed across all mixed civ fields Langbart

Description

to reproduce

Place a rice field and a normal grain field next to each other.
Order at least 6 "Han" units to start farming by right-clicking on one of the two fields.
The units will only occupy the jobs on one field, the rest of the farmers will go idle.
See GIF below for more clarity.

expected behaviour

Units should fill the open work spots of both fields.

slightly related ticket

#6559

#6564 invalid Translation to spanish travi3334

Description

The tips or data on the loading screen are interesting and along with everything, they should translate it into Spanish

#6563 invalid Healers should count as military units travi3334

Description

Healers must be part of military units for them to be selected using the military unit selection shortcut only.

#6561 duplicate Avoid unnecessary decimal points for resource statistics in the Summary Langbart

Description

Related forum thread: Alpha 26 Pre-release/Release Candidate Build Testing (9/Jun/22)

possible solution

Some values e.g. military or the economy score already receive a Math.round treatment (see summary/counters.js).

Line
128	/**
129	* Keep this in sync with the score computation in session/ for the lobby rating reports!
130	*/
131	function calculateEconomyScore(playerState, index)
132	{
133	let total = 0;
134
135	// Notice that this skips the vegetarianFood property of resourcesGathered
136	for (let type of g_ResourceData.GetCodes())
137	total += playerState.sequences.resourcesGathered[type][index];
138
139	total += playerState.sequences.tradeIncome[index];
140	return Math.round(total / 10);
141	}
142
143	/**
144	* Keep this in sync with the score computation in session/ for the lobby rating reports!
145	*/
146	function calculateMilitaryScore(playerState, index)
147	{
148	return Math.round((playerState.sequences.enemyUnitsKilledValue[index] +
149	playerState.sequences.unitsCapturedValue[index] +
150	playerState.sequences.enemyBuildingsDestroyedValue[index] +
151	playerState.sequences.buildingsCapturedValue[index]) / 10);
152	}

Adding Math.round to more statistics seems like a quick&dirty solution.

Line
223	function calculateResources(playerState, index, type)
224	{
225	return {
226	"count": playerState.sequences.resourcesCount[type][index],
227	"gathered": playerState.sequences.resourcesGathered[type][index],
228	"used": playerState.sequences.resourcesUsed[type][index] - playerState.sequences.resourcesSold[type][index]
229	};
230	}

related ticket

Similar problem, but no mention of the decimal problem

#4097 - Not enough space for resources in summary screen (12/Jul/16)
#4099

related patch

A similar problem was recently fixed for tooltips

Phab:D4332 - Ceil the resource costs for insufficient resources. (23/Jan/22)

#6560 fixed Han barracks/ stable champions tech marder Langbart

Description

[26632] and [26633] have added two technologies that are only available in captured barracks/stables of non-Han civilisations.

issue

The info can not be accessed from the structure tree.

possible solution

The Han are by far the most unique civilisation, they can lose this technology or give it to them normally so it shows up in the structure tree.

related thread

Fixing Chinese Han (11/Mar/22)

Player of 0AD

If you conquer barracks or stables of another civ, you can train champions there. Must be a bug, it's too OP.

Alpha 26 Pre-release/Release Candidate Build Testing (14/Jun/22)

Gurken Khan

I can't produce one specific unit there.

#6559 fixed Problem: rice as a food subtype Langbart

Description

Gurken Khan pointed out a rice issue

Yeah, no. I hereby petition rice to count as vegetarian! ;)

Alpha 26 Pre-release/Release Candidate Build Testing (9/Jun/22)

food.json lists rice as a subtype

Line
6	"subtypes": {
7	"fish": "Fish",
8	"fruit": "Fruit",
9	"grain": "Grain",
10	"meat": "Meat",
11	"rice": "Rice"
12	},
13	"properties": [
14	"barterable",

The issue was pointed out by Nescio0 with commit 498061f (16/Jul/20).

Don't introduce rice resource subtype:

This is not compatible with the public mod.
Making it only available to Han China means their fields are useless when captured by other civs, whereas the reverse is not true.
food.grain does not represent only wheat, but also other grains:cereals (e.g. barley, oats, rye, spelt, sorghum, millet, maize, and yes, rice) ...

In a later commit (de1bd77 (25/Sep/21)) it was reintroduced and later folded into the main game.

related discussion

IRC 0ad-dev 16/May/22

12:09 < marder> do we really need a food.rice resource for the han?
[...]
13:09 <@Stan> @tell marder it was justified since rice fields are smaller iirc

forum threads

Addition of Han Chinese to 0AD (20/Apr/21)
Fixing Chinese Han (20/Feb/22)

slightly related ticket

#6565

#6558 fixed ratings engine always counts me as lost Dunedan The Elder Rabbit

Description

Even when I win a game the ratings engine calls me as lost after the game in the lobby and reduces my rating

related ticket

#4540

#6557 needsinfo error on start up M.McGarry

Description

installed game, tried to run for first time, received error code as below

Details: unhandled exception (Access violation reading 0x0000000C)

Location: unknown:0 (?)

Call stack:

(error while dumping stack: No stack frames found) errno = 13 (Insufficient access rights to open file) OS error = 0 (no error code was set)

#6556 fixed Blemmye Desert Raider has a very bright rein when zoomed out Stan Langbart

Description

to reproduce

Default settings applied
Start a Mainland map with the Kushites
Produce some Blemmye Desert Raider (produced at the Blemmye Camp)
Look at the reins, they are very bright, they catch the eye very easily.
- You have to change the camera angle a little and zoom out, up close the reins look more brown.
See image below for more clarity

reproducible

It looks less bright in A23, but starting with A24 it is bright.

note

Ticket can be closed if this is intended to look like that.

#6555 needsinfo crash during gameplay ggdogsteam

Description

the game carshed during game play i do not remember the detail but here is the crashlog and game save files before crashing and BTW i have created a ticket before and u guys have responded to me through email but i can not reply ur games Gamil just told me it is impossible to send my reply to the that email address

#6554 duplicate Game crashes upon Launch misterdole

Description

Hey there. I was trying to play this game for the first time. I grabbed the latest installer, installed fresh, and proceed to have the game crash upon launch:

Much to our regret we must report the program has encountered an error.

Please let us know at http://trac.wildfiregames.com/ and attach the crashlog.txt and crashlog.dmp files.
You may find paths to these files at https://trac.wildfiregames.com/wiki/GameDataPaths 

Details: unhandled exception (std::out_of_range("invalid bitset<N> position"))

Location: unknown:0 (RtlGetFullPathName_UEx)

Call stack:

(error while dumping stack: No stack frames found)
errno = 0 (No error reported here)
OS error = 0 (no error code was set)

I am running on Windows 11, 12th Gen Intel(R) Core(TM) i7-12700K 3.61 GHz

#6553 fixed Unknown string loaded from matchsettings.json disables the game wraitii Langbart

Description

With [26913] the string for Conquest Civic Centers was changed which caused a problem for gameboy.

Related forum thread: Unable to start the game. (31/May/22)

to reproduce

Open your existing matchsettings.json and modify a string under VictoryConditions e.g. "conquest" => "con"
Open the game (make sure the option Persist match settings is enabled)
Select Single Player => Matches
Errors should fill the screen

errors

0 A.D. (0.0.26) Main log (warnings and errors only)
ERROR: JavaScript error: gamesettings/attributes/VictoryConditions.js line 73 this.conditions[name] is undefined _add@gamesettings/attributes/VictoryConditions.js:73:7 fromInitAttributes@gamesettings/attributes/VictoryConditions.js:38:10 fromInitAttributes@gamesettings/GameSettings.js:90:17 parseSettings@gui/gamesetup/Controllers/GameSettingsController.js:191:18 onLoad@gui/gamesetup/Controllers/GameSettingsController.js:89:10 SetupWindow@gui/gamesetup/SetupWindow.js:61:11 init@gui/gamesetup/gamesetup.js:47:18 onPress@gui/pregame/MainMenuItems.js:99:13 performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9 pressButton@gui/pregame/MainMenuItemHandler.js:63:10

ERROR: GUI page 'page_gamesetup.xml': Failed to call init() function

possible solution

Check if the value loaded from the matchsettings.json is real.
Example: gamesettings/attributes/VictoryConditions

    fromInitAttributes(attribs)
    {
        let legacy = this.getLegacySetting(attribs, "VictoryConditions");
+       const checkForExistence = legacy.filter(x => Object.keys(this.conditions).some(y => x === y));
+       legacy = checkForExistence.length === 0 ? "" : checkForExistence;
        if (legacy)
        {
            this.disabled = new Set();
            this.active = new Set();

reproducible

Issue can be reproduced in A25 [25848], but not in A24 [24937].

bisect

[25077] would only trigger errors, but still allow interaction with the game setup.

[25099] would completely prevent interaction with the game setup

related chat

# notes
[13:00:09] elexis try wraitii and my gamesetup rewrite
[13:00:21] Langbart https://code.wildfiregames.com/D3243 ?
[...]
[13:02:01] elexis it also introduced a lot of "legacy" keywords, which inherently sounds like adding deprecated code
[13:02:56] elexis the idea of my gamesetup code was that the JSON file is loaded, if its not valid JSON it might or might not show an error message but then not do any further errors.
[13:02:56] elexis if it is valid JSON it hands over the object to all of the setting parser, and each one takes what is valid or doesn't take anything
[13:03:36] elexis but for that process to never break it would require every single setting parser to never break when receiving a valid JSON with bad semantics (according to the revision of the code)
[13:04:25] elexis so I guess it can be any commit changing any victory setting parser
[13:05:01] elexis I dont know what that legacy code parsing should do, but its usually simpler and more safe to discard an illegal object instead of trying to repair it
[13:05:29] elexis so I suspect its better to delete more code than to extend it
[...]
[13:11:02] elexis SetLegacySetting sounds a lot like supporting to parse old matchsettings
[13:12:47] elexis but the fromInitAttributes reads like it always uses this path
[13:14:30] elexis perhaps he deems the object structure legacy but didnt add code for a new one and thus just calls the old one legacy?

#6551 fixed Incorrect text alignment handling of spaces around wrapping wraitii Stan

Description

See https://code.wildfiregames.com/D4662

#6550 fixed Crash atlas in relation to Terrain.cpp CalcPosition trompetin17 Langbart

Description

Testing on the latest GIT version [26910].

to reproduce

Start the editor
Click Paint terrain texture
Click Terrain
Hold Shift and do a single click at the ground texture
Click Map icon
Click Change players and change the Num players from 8 to 2
Click Map icon again
Click Generate map
Boom

GAME STARTED, ALL INIT COMPLETE
pyrogenesis was compiled with optimization - stepping may behave oddly; variables may not be available.
Process 40415 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
    frame #0: 0x000000010033b723 pyrogenesis`CTerrain::CalcPosition(this=<unavailable>, i=<unavailable>, j=95, pos=0x00007ffeefbfafb0) const at Terrain.cpp:106:15 [opt]
   103 	{
   104 		ssize_t hi = Clamp<ssize_t>(i, 0, m_MapSize - 1);
   105 		ssize_t hj = Clamp<ssize_t>(j, 0, m_MapSize - 1);
-> 106 		u16 height = m_Heightmap[hj*m_MapSize + hi];
   107 		pos.X = float(i*TERRAIN_TILE_SIZE);
   108 		pos.Y = float(height*HEIGHT_SCALE);
   109 		pos.Z = float(j*TERRAIN_TILE_SIZE);
Target 0: (pyrogenesis) stopped.
(lldb) bt

Note: If there is no crash, try it a couple of times. Sometimes it does occur on the first attempt, sometimes it takes up to 3 runs.

See GIF below for more clarity

Higher quality video (link will be dead within a year)

https://ttm.sh/bXL.mp4

lldb

(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
  * frame #0: 0x000000010033b723 pyrogenesis`CTerrain::CalcPosition(this=<unavailable>, i=<unavailable>, j=95, pos=0x00007ffeefbfafb0) const at Terrain.cpp:106:15 [opt]
    frame #1: 0x00000001003bef31 pyrogenesis`TerrainOverlay::RenderTile(this=0x000000011241eae0, deviceCommandContext=0x0000000110ee6310, color=0x00007ffeefbfb030, drawHidden=<unavailable>, i=51, j=95) at TerrainOverlay.cpp:160:15 [opt]
    frame #2: 0x0000000100414161 pyrogenesis`BrushTerrainOverlay::ProcessTile(this=0x000000011241eae0, deviceCommandContext=0x0000000110ee6310, i=<unavailable>, j=<unavailable>) at Brushes.cpp:67:3 [opt]
    frame #3: 0x00000001003bee4c pyrogenesis`TerrainOverlay::RenderBeforeWater(this=0x000000011241eae0, deviceCommandContext=0x0000000110ee6310) at TerrainOverlay.cpp:137:4 [opt]
    frame #4: 0x00000001003be67d pyrogenesis`ITerrainOverlay::RenderOverlaysBeforeWater(deviceCommandContext=0x0000000110ee6310) at TerrainOverlay.cpp:77:34 [opt]
    frame #5: 0x00000001003b0409 pyrogenesis`CSceneRenderer::RenderRefractions(this=0x000000010b074260, deviceCommandContext=0x0000000110ee6310, context=0x00007ffeefbfb3d0, scissor=<unavailable>) at SceneRenderer.cpp:672:2 [opt]
    frame #6: 0x00000001003b0e3a pyrogenesis`CSceneRenderer::RenderSubmissions(this=0x000000010b074260, deviceCommandContext=0x0000000110ee6310, waterScissor=0x00007ffeefbfb610) at SceneRenderer.cpp:810:5 [opt]
    frame #7: 0x00000001003b2130 pyrogenesis`CSceneRenderer::RenderScene(this=0x000000010b074260, deviceCommandContext=0x0000000110ee6310, scene=0x0000000113487410) at SceneRenderer.cpp:1143:2 [opt]
    frame #8: 0x00000001003a4671 pyrogenesis`CRenderer::RenderFrameImpl(this=0x0000000110ee47e0, renderGUI=<unavailable>, renderLogger=<unavailable>) at Renderer.cpp:459:22 [opt]
    frame #9: 0x00000001003a444d pyrogenesis`CRenderer::RenderFrame(this=0x0000000110ee47e0, needsPresent=false) at Renderer.cpp:416:3 [opt]
    frame #10: 0x0000000100459c17 pyrogenesis`AtlasViewGame::Render(this=<unavailable>) at View.cpp:232:13 [opt]
    frame #11: 0x000000010042a227 pyrogenesis`AtlasMessage::fRenderLoop(msg=0x00007ffeefbfbb20) at GraphicsSetupHandlers.cpp:252:25 [opt]
    frame #12: 0x0000000100451248 pyrogenesis`MessagePasserImpl::Query(this=<unavailable>, msg=0x00007ffeefbfbb20, (null)=<unavailable>)()) at MessagePasserImpl.cpp:68:3 [opt]
    frame #13: 0x00000001082725f5 libAtlasUI.dylib`ScenarioEditor::OnTimer(wxTimerEvent&) [inlined] AtlasMessage::QueryMessage::Post(this=<unavailable>) at ScenarioEditor.cpp:1157:19 [opt]
    frame #14: 0x00000001082725df libAtlasUI.dylib`ScenarioEditor::OnTimer(this=0x000000010584f800, evt=<unavailable>) at ScenarioEditor.cpp:696 [opt]
    frame #15: 0x00000001085a498f libAtlasUI.dylib`wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) + 447
    frame #16: 0x00000001085a5f3a libAtlasUI.dylib`wxEvtHandler::ProcessEventLocally(wxEvent&) + 90
    frame #17: 0x00000001085a5dd0 libAtlasUI.dylib`wxEvtHandler::ProcessEvent(wxEvent&) + 96
    frame #18: 0x00000001085a64ec libAtlasUI.dylib`wxEvtHandler::SafelyProcessEvent(wxEvent&) + 12
    frame #19: 0x000000010856062a libAtlasUI.dylib`wxTimerImpl::SendEvent() + 90
    frame #20: 0x00007fff38a91718 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
    frame #21: 0x00007fff38a9127e CoreFoundation`__CFRunLoopDoTimer + 872
    frame #22: 0x00007fff38a90d69 CoreFoundation`__CFRunLoopDoTimers + 322
    frame #23: 0x00007fff38a759ed CoreFoundation`__CFRunLoopRun + 1885
    frame #24: 0x00007fff38a74c33 CoreFoundation`CFRunLoopRunSpecific + 466
    frame #25: 0x00007fff37690aad HIToolbox`RunCurrentEventLoopInMode + 292
    frame #26: 0x00007fff376906e4 HIToolbox`ReceiveNextEventCommon + 359
    frame #27: 0x00007fff37690569 HIToolbox`_BlockUntilNextEventMatchingListInModeWithFilter + 64
    frame #28: 0x00007fff35cd93c9 AppKit`_DPSNextEvent + 883
    frame #29: 0x00007fff35cd7c10 AppKit`-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
    frame #30: 0x00007fff35cc991e AppKit`-[NSApplication run] + 658
    frame #31: 0x00000001083aaa8a libAtlasUI.dylib`wxGUIEventLoop::OSXDoRun() + 186
    frame #32: 0x000000010858441d libAtlasUI.dylib`wxCFEventLoop::DoRun() + 29
    frame #33: 0x00000001084fcffe libAtlasUI.dylib`wxEventLoopBase::Run() + 158
    frame #34: 0x00000001084cf9b3 libAtlasUI.dylib`wxAppConsoleBase::MainLoop() + 99
    frame #35: 0x000000010836baaa libAtlasUI.dylib`wxApp::OnRun() + 26
    frame #36: 0x000000010827013e libAtlasUI.dylib`::Atlas_StartWindow(type=<unavailable>) at DLLInterface.cpp:154:12 [opt]
    frame #37: 0x0000000100415092 pyrogenesis`BeginAtlas(args=0x00007ffeefbff310, dll=0x0000000103c52ab8) at GameLoop.cpp:136:2 [opt]
    frame #38: 0x00000001002069fd pyrogenesis`ATLAS_RunIfOnCmdLine(CmdLineArgs const&, bool) [inlined] ATLAS_Run(args=0x00007ffeefbff310, flags=1) at Atlas.cpp:54:7 [opt]
    frame #39: 0x00000001002069de pyrogenesis`ATLAS_RunIfOnCmdLine(args=0x00007ffeefbff310, force=<unavailable>) at Atlas.cpp:77 [opt]
    frame #40: 0x00000001000049be pyrogenesis`RunGameOrAtlas(argc=<unavailable>, argv=<unavailable>) at main.cpp:573:6 [opt]
    frame #41: 0x0000000100003b76 pyrogenesis`main(argc=2, argv=0x00007ffeefbff650) at main.cpp:739:2 [opt]
    frame #42: 0x00007fff727aacc9 libdyld.dylib`start + 1

reproducible

The crash could be reproduced up to A22, after which I stopped testing.

#6549 fixed Unit icon Han siege tower Stan Langbart

Description

Changeset [26910] has changed the appearance of the Han siege tower so that the old unit icon no longer matches the appearance of this unit.

Similar to #6503, but not reopening that.

#6548 fixed Error with maps created in the atlas with the victory condition "Conquest Civic Centers" Freagarach Langbart

Description

to reproduce

Start the Scenario Editor (aka Atlas)
Tick Conquest Civic Centers and save the map.
Start it normally from the GUI with the 0 A.D. app.
Errors appear when selecting the map in the game setup.

errors

ERROR: Error in timer: TypeError: this.conditions[name] is undefined _add@gamesettings/attributes/VictoryConditions.js:73:7 onMapChange@gamesettings/attributes/VictoryConditions.js:53:9 init/<@gamesettings/attributes/VictoryConditions.js:14:38 _trigger@gui/common/Observable.js:45:12 set@gui/common/Observable.js:35:11 selectMap@gamesettings/attributes/Map.js:44:3 call@gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Dropdowns/MapSelection.js:124:23 updateTimers@gui/common/timer.js:61:8 onTick@gui/gamesetup/SetupWindow.js:107:3 @gui/gamesetup/SetupWindow.js:57:64

What is the issue?

The VictoryConditions in the newly created .xml file lists conquest_civic_centres.

Line
1	],
2	"Preview": "",
3	"RevealMap": false,
4	"VictoryConditions": [
5	"conquest_civic_centres"
6	]
7	}
8	]]></ScriptSettings>

The Map.cpp file takes the Title of the VictoryConditions makes it lower case and fills the gaps with an underscore.

Line
189	for (const std::string& victoryConditionJson : victoryConditionData)
190	{
191	AtObj victoryCondition = AtlasObject::LoadFromJSON(victoryConditionJson);
192	long index = wxWindow::NewControlId();
193	wxString title = wxString::FromUTF8(victoryCondition["Data"]["Title"]);
194	std::string escapedTitle = title.Lower().ToStdString();
195	std::replace(escapedTitle.begin(), escapedTitle.end(), ' ', '_');
196	AtObj updateCondition = *(victoryCondition["Data"]["Title"]);
197	updateCondition.setString(escapedTitle.c_str());
198	m_VictoryConditions.insert(std::pair<long, AtObj>(index, victoryCondition));
199	CREATE_CHECKBOX(this, vcGridSizer, title, "Select " + title + " victory condition.", index);
200	}

In the game setup the function loadVictoryConditions checks for the filename NOT the title.

Line
215	/**
216	* Loads available victoryCondtions from json files.
217	*
218	* @returns {Array\|undefined}
219	*/
220	function loadVictoryConditions()
221	{
222	let subdir = "victory_conditions/";
223
224	let victoryConditions = listFiles(g_SettingsDirectory + subdir, ".json", false).map(victoryScriptName => {
225	let victoryCondition = loadSettingValuesFile(subdir + victoryScriptName + ".json");
226	if (victoryCondition)
227	victoryCondition.Name = victoryScriptName;
228	return victoryCondition;
229	});
230
231	if (victoryConditions.some(victoryCondition => victoryCondition == undefined))
232	return undefined;
233
234	return victoryConditions.sort((a, b) => a.GUIOrder - b.GUIOrder \|\| (a.Title > b.Title ? 1 : a.Title > b.Title ? -1 : 0));
235	}

The end result differs from the actual file name conquest_civiccentres.json. The issue does not occur with capture_the_relic.json.

reproducible

Issue can be reproduced up to A25, in A24 there was no option in Atlas to do this. It was added with [25422].

possible solution

Simplest solution is changing the file name from conquest_civiccentres.json to conquest_civic_centres.json.

#6547 fixed GLX_EXTENSIONS has incorrect case. Brent Johnson Stan

Description

In the userreport_hwdetect.txt file GLX_EXTENSIONS is written as glx_extensions

#6546 fixed Shroud of Darkness (SoD) visible terrain and territory lines Vladislav Belov Langbart

Description

An issue was reported via IRC 0ad-dev 28/May/22

07:09 < Freagarach_afk> No, that I see the terrain and territory lines in SoD.
07:11 < Freagarach_afk> It seems it depends on the map also.
07:11 < Freagarach_afk> With some terrains it is more visible.

GL ARB Smoothlos=true Add to surexpose to make it more visible. Before reveal map After reveal map

to reproduce

Switch to GL ARB backend
Restart the Game (Make Sure Smoothlos is on)
Open Acropolis bay,
move around and notice everything is black.
Open the dev overlay
Reveal Map, and hide it again.
move around and notice everything is still slightly visible.

bisect

Was likely triggered after the LOS changes. [26906]

~~Note: macOS - [26908] I could not reproduce the problem and only created the ticket so that it would not be forgotten.~~ see comment:5:ticket:6546

possible solution

Revert the default setting for smoothlos back to false.

reproducible

Adding smoothlos = "true" to the user.cfg file and testing on older versions. The problem could be reproduced up to Alpha XVI - Patañjali [15148]. Below that I have not tested.

additional nit-pick

smoothlos was unintentionally removed from the options with [25581].
See IRC 0ad-dev 2/Jun/22/3/Jun/22

17:16 < Langbart> @tell wraitii was intended to remove smoothlos with changeset rP25581?
[...]
 07:16 < wraitii> @tell langbart: re rP25581, it looks like it wasn't, but I think vlad recently activated by default (asked him), so maybe the bug can now be seen as  'invalid'

It may or may not be added back into the options, that is at the judgement of the patch maker.

#6545 duplicate A red line from the centre of my screen to top left r0Gu3

Description

It is a minor bug which does not affect the gameplay at all. I see a red line from the centre of my screen to the top left corner of the screen. I was playing a tutorial match when I witnessed that. It was present for 90% of the time and I haven't got the time to play it again so cannot confirm on whether it is only present in the tutorial match or all the matches.

I am on a M1 MacBook Pro, in case it's an OS problem.

#6544 fixed Include list of unused data json files in checkrefs.py marder Langbart

Description

Having fewer files to translate is good. To find unused files automatically, it should be integrated into the python script checkrefs.py.

Aura

Name	Removed from template with	Removed from the Game
~~structures/rotary_mill~~	[25561]	[26900]
~~units/han_minister_cost~~	unused in the main game	[26900]
~~units/elephant_worker~~	[26898]	[26900]
~~han_hero_wei_qing_3.json~~	[26980]	[26992]

Technologies

Name	Removed from template with	Removed from the Game
~~upgrade_rank_advanced_crossbow~~	unused in the main game	[26900]
~~upgrade_rank_elite_crossbow~~	unused in the main game	[26900]
~~pair_unlock_arrows_type~~	[26469]	[26900]

shell function

used for finding unlisted data json files in the simulation folder

function unusedJSON {
  CURRENT_DIR=$(pwd)
  cd ~/0ad/binaries/data/mods/public/simulation/data/auras || return 1
  printf "\e[1;97mList unused Auras:\e[0m\n"
  for a in $(find . -name "*.json" | sed 's|./||;s|.json||'); do
    if [[ $(grep --include=\*.xml -rw ~/0ad/binaries/data/mods/public/simulation -e "$a" | wc -c) -eq 0 ]]; then
      echo "$a"
    fi
  done
  cd ~/0ad/binaries/data/mods/public/simulation/data/technologies || return 1
  printf "\e[1;97m\nList unused Technologies:\e[0m\n"
  for t in $(find . -name "*.json" | xargs grep -Le 'autoResearch.*true' | sed 's|./||;s|.json||'); do
    if [[ $(grep --include={*.xml,test_Researcher.js,pair_unlock*.json} -rw ~/0ad/binaries/data/mods/public/simulation -e "$t" | wc -c) -eq 0 ]]; then
      echo "$t"
    fi
  done
  cd "${CURRENT_DIR}" || return 1
}

related tickets

#3800 (4/Mar/16)

#6542 fixed Update checkrefs python script Stan Langbart

Description

to reproduce

navigate to source/tools/entity and run checkrefs.py

bisect

[26879]

log output

❯ python3 checkrefs.py
INFO - Checking public's integrity.
INFO - The following mods will be loaded: public|mod.
INFO - Loading maps PMP...
INFO - Loading entities...
INFO - Loading actors...
INFO - Loading variants...
INFO - Loading art files...
INFO - Loading materials...
INFO - Loading particles...
INFO - Loading sound groups...
INFO - Loading audio files...
INFO - Loading GUI XML...
INFO - Loading GUI data...
INFO - Loading civs...
INFO - Loading random maps...
INFO - Loading techs...
INFO - Loading terrains...
INFO - Loading auras...
INFO - Loading tips...
INFO - Looking for missing files...
WARNING - Missing file 'autostart/autostart.js' referenced by: public/gui/autostart/autostart.xml
WARNING - Missing file 'gamesettings/GameSetting.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/GameSettings.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Biome.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/CampaignData.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Ceasefire.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Cheats.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/CircularMap.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Daytime.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/DisableSpies.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/DisableTreasures.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/GameSpeed.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Landscape.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/LastManStanding.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/LockedTeams.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Map.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/MapExploration.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/MapName.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/MapPreview.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/MapSize.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/MatchID.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Nomad.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/PlayerAI.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/PlayerCiv.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/PlayerColor.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/PlayerCount.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/PlayerName.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/PlayerTeam.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Population.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Rating.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/RegicideGarrison.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Relic.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/SeaLevelRise.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Seeds.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/StartingCamera.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/StartingResources.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/TeamPlacement.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/TriggerDifficulty.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/TriggerScripts.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/VictoryConditions.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml
WARNING - Missing file 'gamesettings/attributes/Wonder.js' referenced by: public/gui/autostart/autostart.xml, public/gui/campaigns/default_menu/CampaignMenu.xml, public/gui/gamesetup/gamesetup.xml

Ticket #6544 was closed, it was mentioned to also list unused Auras & Technologies. Replying to stanislas69:

[...] I suppose they should be reported by checkrefs -u

#6541 invalid Batch training shows incorrect value Stan

Description

Steps to reproduce

Select a civ center
Use the batch training feature.
Keep shift pressed
Notice the UI now shows twice the number of units that will be trained (e.g. if BT is 5 it's gonna show 10)

#6540 duplicate Batch training resize triggers camera rotation on mac Stan

Description

Steps to reproduce

On a mac select a civ center
Enable batch training by pressing shift and try using the mouse wheel
Notice it makes the camera turn. This behaviour should only happen out of the UI.

This works correctly on Linux and Windows

#6538 fixed A8 and L8 are unsupported framebuffer formats for some drivers Vladislav Belov

Description

As reported on the forum: https://wildfiregames.com/forum/topic/80452-rev26886-crashes-on-game-start-only-me-closed/ we can't render to A8.

#6537 fixed Shadows have a grid-like structure for openGL ARB Vladislav Belov Langbart

Description

to reproduce

Go to the settings and switch to openGL ARB
Restart the game and start a new match, check the shadows.
See image below for more clarity

bisect

[26485]

reproducible

There is no difference between Prefer GLSL and without GLSL in A25b for shadows.

#6536 fixed Disabled icons are slightly colored for openGL ARB Vladislav Belov Langbart

Description

to reproduce

Go to the settings and switch to openGL ARB
Restart the game and start a new game, check the HUD
See image below for more clarity --> pay attention to the Wonder icon

bisect

(not yet)

reproducible

There is no difference between Prefer GLSL and without GLSL in A25b for disabled icons in the HUD.

#6535 duplicate Cant log in multiplayer manuval88

Description

i want to play with a friend, and when im going to register there is an error that say "the server certificate could not be verified or the session was not completed at all" i dont know what to do and how to enter multiplayer

#6534 fixed OpenGL ARB doesn't show territory lines. Vladislav Belov Freagarach

Description

On SVN (r26855) using the OpenGL ARB renderer means territory lines aren't shown on the map anymore (but are on the minimap).

#6533 fixed Big jump in msec/frame Vladislav Belov Langbart

Description

to reproduce

start the combat_demo_huge map
open the wiki/EngineProfiling#In-gameprofiler
check msec/frame under render
the jump is noticeable between [26406] and [26405], see image below

bisect

[26406]

EDIT (1)

Langbart: could check what's slower inside render?

Pay attention to rendering bucketed submissions (inside render models/ shadow map/ render submissions/ render) [26406] ~105 msec/fram [26405] ~12 msec/frame

IRC conversation 6/May/22

18:06 < Langbart> Vladislav r26406 caused a big discrepancy for the msec/frame.
[...]
18:06 < Langbart> shall i make a ticket ?
18:09 < Vladislav> Langbart: yep.

#6530 duplicate carthography tooltip text extending tooltip panel marder

Description

#6529 duplicate Game won't run Na2S

Description

the game won't run sorry i don't speak english very well i'm french

#6528 duplicate 0ad 25 no start Jiri Boruvka

Description

Hello, transplanted windows to a new machine. With 0ad, uninstalled and freshly installed. Game does not start 32bit problem?

#6527 fixed Wonder duration timer is reset when a teammate is defeated wraitii Langbart

Description

An issue was reported via the forum by ettubrutus.

Even if you build a wonder first before any of the bots, if one of the bots on your team is wiped out then the teams change I guess and suddenly you are no longer winning in N minutes [...]

teamplay w/ wonder bug (3/May/22)

to reproduce

Make a game with two teams and at least one teammate, set the victory condition to wonder with a wonder duration timer, e.g. 10 minutes.

Use the auto command below to quickly start such a game.

binaries/system/pyrogenesis -conf=mod.enabledmods:"public" -autostart="random/mainland" -autostart-players=3 -autostart-team=1:1 -autostart-team=2:1 -autostart-team=3:2 -autostart-victory=wonder -autostart-wonderduration=10

Type gift from the gods and build a wonder.
The timer should now appear and normally run down.
If you type exodia, your teammate (player 2) should be defeated and the timer will reset to 10 minutes.

bisect

[21441] seems to be the candidate that made this change. A concern was raised by elexis on this commit.

elexis: If my allies were defeated or declared war on me, that shouldn't make me lose the victory timer.

See discussion about this change: https://code.wildfiregames.com/rP21441#31049

reproducible

Reproducible for the current GIT version [26850] and up to A23b [21946].
At A22 - Venustas [19922] the issue is not reproducible, the timer does not reset.

possible solution

Maybe set WonderVictoryPlayerDefeated to false in Line 166 for the WonderVictory.js.

Line
165	cmpTrigger.RegisterTrigger("OnPlayerWon", "WonderVictoryPlayerWon", { "enabled": true });
166	cmpTrigger.RegisterTrigger("OnPlayerDefeated", "WonderVictoryPlayerDefeated", { "enabled": false });
167	cmpTrigger.wonderVictoryMessages = {};
168	}

#6526 fixed Give ships and siege weapons resistance against poison attacks marder Langbart

Description

Since [24508] the game has a unit that can poison every other unit including ships and siege weapons.

to reproduce

Get some Mauryan Guard Archer and let them shoot at a ship or a siege weapon.
- Alternatively, download poisonMe.pmp and poisonMe.xml and place them in your binaries/data/mods/public/maps/skirmishes folder
- Start the map from the GUI or via the command line
```
binaries/system/pyrogenesis -conf=mod.enabledmods:"public" -autostart="skirmishes/poisonMe"
```

expected behaviour

A ship or a siege weapon should not be effected by a poison attack.

possible solution

Give boats and siege weapons full resistance against poison attacks.

Line
1	<ApplyStatus>
2	<Poisoned>
3	<Duration>0.0</Duration>
4	<BlockChance>1</BlockChance>
5	</Poisoned>
6	</ApplyStatus>

#6525 fixed OpenGL ARB causes big slow down Vladislav Belov Langbart

Description

Testing latest GIT version and noticed a big slowdown when using openGL ARB on the Ratumacos map.

to reproduce

Download the attached replay ratumacos.zip
Set the Renderer backend in the graphics options to OpenGL ARB
Start the replay, set the view to paria and click Follow Player
Notice the extreme slowdown
The replay is only 2:42mins long, but counting the real time it takes 3:34mins with OpenGL ARB and only 2:55mins with OpenGL to complete the replay.

bisect

[26815]
(On [26814] the times to complete the replay are more similar between OpenGL and OpenGL ARB.)

related IRC conversation

IRC 0ad-dev 2/May/22

10:48 < Vladislav> Langbart: according to profiling data chopiness might be because of shadows

#6524 fixed Atlas editor crash related to actor viewer Vladislav Belov Langbart

Description

Testing on the latest GIT version [26845] a seg fault was discovered.

to reproduce

Open the editor
Click Play under Simulation test
Switch to the Object tab
Click Switch to Actor Viewer
Click the Map tab icon
Click Reset under Simulation test
Crash

TIMER| session/session.xml: 198.891 ms
2022-05-02 11:41:09.151440+0200 pyrogenesis[13687:170421] [pyrogenesis] IIOIOSurfaceWrapper:1376: *** pixelformat '... ' not handled
Assertion failed: "!UpdateDirty()"
Location: TerritoryTexture.cpp:62 (GetTexture)

Call stack:

(error while dumping stack: Function not supported)
errno = 60 (?)
OS error = ?

lldb

Process 13687 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000010109c1d0 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
   30  	#ifdef MOZ_WIDGET_ANDROID
   31  	  abortThroughJava(msg);
   32  	#endif
-> 33  	  MOZ_CRASH();
   34  	}
   35  	
   36  	#ifdef MOZ_WIDGET_ANDROID
Target 0: (pyrogenesis) stopped.
(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x000000010109c1d0 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
    frame #1: 0x0000000101b93e3d pyrogenesis`::abort() at mozalloc_abort.cpp:82:3 [opt]
    frame #2: 0x00000001004f2a66 pyrogenesis`sys_display_error(text=<unavailable>, flags=6) at unix.cpp:268:4 [opt]
    frame #3: 0x00000001004d51e3 pyrogenesis`debug_DisplayError(wchar_t const*, unsigned long, void*, wchar_t const*, wchar_t const*, int, char const*, long volatile*) [inlined] CallDisplayError(text=L"Assertion failed: \"!UpdateDirty()\"\r\nLocation: TerritoryTexture.cpp:62 (GetTexture)\r\n\r\nCall stack:\r\n\r\n(error while dumping stack: Function not supported)\r\nerrno = 60 (?)\r\nOS error = ?\r\n", flags=6) at debug.cpp:374:8 [opt]
    frame #4: 0x00000001004d51c6 pyrogenesis`debug_DisplayError(description=L"Assertion failed: \"!UpdateDirty()\"", flags=6, context=0x00007ffeefbfa480, lastFuncToSkip=<unavailable>, pathname=L"../../../source/graphics/TerritoryTexture.cpp", line=62, func=<unavailable>, suppress=0x0000000103b51d60) at debug.cpp:460 [opt]
    frame #5: 0x00000001004d5a4e pyrogenesis`debug_OnAssertionFailure(expr=<unavailable>, suppress=0x0000000103b51d60, file=<unavailable>, line=<unavailable>, func=<unavailable>) at debug.cpp:547:9 [opt]
    frame #6: 0x00000001003451f5 pyrogenesis`CTerritoryTexture::GetTexture(this=0x00000001082045e0) at TerritoryTexture.cpp:62:2 [opt]
    frame #7: 0x00000001002f7424 pyrogenesis`CMiniMapTexture::RenderFinalTexture(this=<unavailable>, deviceCommandContext=<unavailable>) at MiniMapTexture.cpp:417:52 [opt]
    frame #8: 0x00000001003ad9ab pyrogenesis`CSceneRenderer::RenderSubmissions(this=0x0000000108167e30, deviceCommandContext=0x0000000111ba2b80, waterScissor=0x00007ffeefbfb530) at SceneRenderer.cpp:763:33 [opt]
    frame #9: 0x00000001003aefb0 pyrogenesis`CSceneRenderer::RenderScene(this=0x0000000108167e30, deviceCommandContext=0x0000000111ba2b80, scene=0x0000000106283400) at SceneRenderer.cpp:1163:2 [opt]
    frame #10: 0x0000000100405f06 pyrogenesis`ActorViewer::Render(this=0x000000010511c650) at ActorViewer.cpp:530:32 [opt]
    frame #11: 0x000000010044cb22 pyrogenesis`AtlasViewActor::Render(this=0x0000000116380b80) at View.cpp:96:17 [opt]
    frame #12: 0x000000010041dd27 pyrogenesis`AtlasMessage::fRenderLoop(msg=0x00007ffeefbfbb60) at GraphicsSetupHandlers.cpp:253:25 [opt]
    frame #13: 0x0000000100444d48 pyrogenesis`MessagePasserImpl::Query(this=<unavailable>, msg=0x00007ffeefbfbb60, (null)=<unavailable>)()) at MessagePasserImpl.cpp:68:3 [opt]
    frame #14: 0x000000010b0125f5 libAtlasUI.dylib`ScenarioEditor::OnTimer(wxTimerEvent&) [inlined] AtlasMessage::QueryMessage::Post(this=<unavailable>) at ScenarioEditor.cpp:1157:19 [opt]
    frame #15: 0x000000010b0125df libAtlasUI.dylib`ScenarioEditor::OnTimer(this=0x0000000105826a00, evt=<unavailable>) at ScenarioEditor.cpp:696 [opt]
    frame #16: 0x000000010b34498f libAtlasUI.dylib`wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) + 447
    frame #17: 0x000000010b345f3a libAtlasUI.dylib`wxEvtHandler::ProcessEventLocally(wxEvent&) + 90
    frame #18: 0x000000010b345dd0 libAtlasUI.dylib`wxEvtHandler::ProcessEvent(wxEvent&) + 96
    frame #19: 0x000000010b3464ec libAtlasUI.dylib`wxEvtHandler::SafelyProcessEvent(wxEvent&) + 12
    frame #20: 0x000000010b30062a libAtlasUI.dylib`wxTimerImpl::SendEvent() + 90
    frame #21: 0x00007fff372c3db8 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
    frame #22: 0x00007fff372c391e CoreFoundation`__CFRunLoopDoTimer + 872
    frame #23: 0x00007fff372c3409 CoreFoundation`__CFRunLoopDoTimers + 322
    frame #24: 0x00007fff372a806d CoreFoundation`__CFRunLoopRun + 1885
    frame #25: 0x00007fff372a72b3 CoreFoundation`CFRunLoopRunSpecific + 466
    frame #26: 0x00007fff35f14aad HIToolbox`RunCurrentEventLoopInMode + 292
    frame #27: 0x00007fff35f147c5 HIToolbox`ReceiveNextEventCommon + 584
    frame #28: 0x00007fff35f14569 HIToolbox`_BlockUntilNextEventMatchingListInModeWithFilter + 64
    frame #29: 0x00007fff3455d659 AppKit`_DPSNextEvent + 883
    frame #30: 0x00007fff3455bea0 AppKit`-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
    frame #31: 0x00007fff3454dbae AppKit`-[NSApplication run] + 658
    frame #32: 0x000000010b14aa8a libAtlasUI.dylib`wxGUIEventLoop::OSXDoRun() + 186
    frame #33: 0x000000010b32441d libAtlasUI.dylib`wxCFEventLoop::DoRun() + 29
    frame #34: 0x000000010b29cffe libAtlasUI.dylib`wxEventLoopBase::Run() + 158
    frame #35: 0x000000010b26f9b3 libAtlasUI.dylib`wxAppConsoleBase::MainLoop() + 99
    frame #36: 0x000000010b10baaa libAtlasUI.dylib`wxApp::OnRun() + 26
    frame #37: 0x000000010b01013e libAtlasUI.dylib`::Atlas_StartWindow(type=<unavailable>) at DLLInterface.cpp:154:12 [opt]
    frame #38: 0x0000000100408b92 pyrogenesis`BeginAtlas(args=0x00007ffeefbff320, dll=0x0000000103bdd988) at GameLoop.cpp:136:2 [opt]
    frame #39: 0x000000010020806d pyrogenesis`ATLAS_RunIfOnCmdLine(CmdLineArgs const&, bool) [inlined] ATLAS_Run(args=0x00007ffeefbff320, flags=1) at Atlas.cpp:54:7 [opt]
    frame #40: 0x000000010020804e pyrogenesis`ATLAS_RunIfOnCmdLine(args=0x00007ffeefbff320, force=<unavailable>) at Atlas.cpp:77 [opt]
    frame #41: 0x000000010000443e pyrogenesis`RunGameOrAtlas(argc=<unavailable>, argv=<unavailable>) at main.cpp:578:6 [opt]
    frame #42: 0x00000001000035f6 pyrogenesis`main(argc=2, argv=0x00007ffeefbff668) at main.cpp:743:2 [opt]
    frame #43: 0x00007fff703d9cc9 libdyld.dylib`start + 1
    frame #44: 0x00007fff703d9cc9 libdyld.dylib`start + 1

bisect

[26170]

reproducible

The bug is not reproducible with A25b [25860].

#6523 duplicate Deep Freeze interface on the "Download Mods" button Langbart

Description

An issue has been reported via the forum by nwtour. Creating an extra ticket so that the problem is not forgotten.

Feedbacks from A26 SVN tests (1/May/22)

to reproduce

Switch language to Russian
Open the Mod selection page
Click Download Mods
Deep Freeze, computer becomes unresponsive

bisect

nwtour: Bisect commit [26522]

related tickets

#6451

#6521 fixed Allow to set the biome with the autostart command Freagarach Langbart

Description

issue

The -autostart-seed=SEED flag allows a specific random map to be loaded, this is great for testing. The changes made with commit [26584] now also load different biomes. This forces you to load the same map multiple times to get the specific seed/ biome you want to test.

to reproduce

Choose a random map that has several biomes, e.g., Mainland.

Start this map with the -autostart-seed flag from the command line, e.g.

binaries/system/pyrogenesis -conf=mod.enabledmods:"public" -autostart="random/mainland" -autostart-seed=100

Close 0 A.D. and run the same command again, usually a different biome will appear.

possible solution

Add a -autostart-biome flag to the command line.

code snippet from Phab:D4117

source/ps/GameSetup/GameSetup.cpp

                bool Autostart(const CmdLineArgs& args)
             CStr num = args.Get("autostart-players");
             numPlayers = num.ToUInt();
+        }
+        // Set biome if wanted
+        if (args.Has("autostart-biome"))
+        {
+            CStr biome = args.Get("autostart-biome");
+            Script::SetProperty(rq, settings, "Biome", biome);
+        }
         // Set up player data
         for (size_t i = 0; i < numPlayers; ++i)
+        {

tested with the following command

binaries/system/pyrogenesis -conf=mod.enabledmods:"public" -autostart="random/mainland" -autostart-seed=100 -autostart-biome="generic/nubia"

related ticket

#6471 (21/Mar/22)

#6520 fixed Selection shapes decouple from units Vladislav Belov Langbart

Description

An issue was reported via IRC 0ad-dev 26/Apr/22 by wowgetoffmang

04:02 < Langbart> [...] What is the issue with the ships ?
04:12 < wowgetoffmang> It was in Atlas that I couldn't see the selection shape for ships.
04:15 < wowgetoffmang> lol...
04:15 < wowgetoffmang> Selection shapes decouple from units
...
05:18 < Langbart> does the ship issue happens consistently or was it a one time thing ?
05:26 < wowgetoffmang> k thnx. I saw it happen with ships and als briefly with land units in a  different match

reproducible

Edit (27/Apr/22)

see comment:1
- Alternatively, download both files findme.pmp and findme.xml and place them in your binaries/data/mods/public/maps/scenarios folder
- Start the map from the GUI or via the command line
```
binaries/system/pyrogenesis -conf=mod.enabledmods:"mod public" -autostart="scenarios/findme"
```
- After opening the map, move the units/athen/ship_merchant the problem described above should become apparent.

small discussion on IRC 0ad-dev 26/Apr/22

21:05 < Vladislav> Meh, https://imgur.com/a/wMIAExM
21:06 < Langbart> looks similar to what i did
21:07 < Langbart> https://code.wildfiregames.com/F2671570
21:10 < Vladislav> Not exactly, you lifted up the water for the whole map.
21:12 < Langbart> ok you win.
21:12 < Langbart> it does make a difference
21:21 < Vladislav> It might be related to passability updates.

bisect

[26815]

#6519 fixed Inconsistent fire explosion on destructed buildings Vladislav Belov Langbart

Description

Play testing on the latest GIT version.

Sometimes large fire clouds arise from destructed buildings. See a couple of examples below.

The particle effect is not consistently reproducible with every time i rewatch the same replay, sometimes these clouds appear, sometimes they are even larger and the particles stay for a long time or disappear quickly, or they don't show up at all. The occurrence and appearance is very inconsistent. The speed you watch might effect the appearance of those particles. I will attach a replay, but you may not even see any fire explosions on every run.

2022-04-26_0017.zip

reproducible

I don't recall ever seeing such extreme fire clouds in any of the released versions, there are flying fireballs but they always appear similar and do not vary in size and length of the appearance.

bisect

[26815]

related IRC 0ad-dev

wowgetoffmang 26/Apr/22

03:28 < wowgetoffmang> I see no blacksmith smoke when the Forge is researching.
03:28 < wowgetoffmang> I see no destruction dust
03:29 < wowgetoffmang> Also, props disappear as a building sinks during destruction
03:32 < Langbart> Currently, I also don't see any smoke on the Forge. I will do some bisecting.
03:34 < wowgetoffmang> Thank you Langbart
03:38 < wowgetoffmang> Hmm, ship selections too?
03:39 < wowgetoffmang> https://trac.wildfiregames.com/changeset/26823
03:39 < wowgetoffmang> ?
04:02 < Langbart> Bisecting by checking the smoke on the HAN forge results in this commit: rP26815

#6517 fixed Gamesetup issue Langbart

Description

gameboy reported an issue in the forum on the latest version SVN [26824].

Related forum thread: SVN26824 error! (25/Apr/22)

issue

Open the gamesetup page
Errors appear

bisect

[26824]

#6514 duplicate Add a "Generate Preview" button to Atlas wowgetoffyourcellphone

Description

It would be a great feature to have a button in Atlas that generates a preview image for the map being worked on. That way all preview images can be standardized and anyone making a new map can easily get a preview image for their map without needing to muck around with screenshots and image editing software.

Features and Behavior:

A small button in the map setting panel under the Preview field.
Clicking this button generates an image of the whole map in the proper resolution and format and places the image in the correct game directory.
Also doing this automatically enters the file name of the new image in the Preview field.
Bonus: Add a "Browse..." button as well that opens the map preview folder and allows the player to manually select a preview image.

#6513 fixed Segfault on autostart nonVisual games bb Langbart

Description

issue

start a game from the command line with the -autostart-nonvisual flag

binaries/system/pyrogenesis -conf=mod.enabledmods:"public" -autostart="random/mainland" -autostart-nonvisual

Segfault

bb has already created a patch. It is better to also create a ticket to increase the chances that it will not be forgotten.

IRC 23/Apr/22

23:14 <@Stan> Langbart: you can also create a rb for non visual mode if you like

lldb

(lldb) run -conf=mod.enabledmods:"public" -autostart="random/mainland" -autostart-nonvisual
Process 79078 launched: '/Users/paria/0ad/binaries/system/pyrogenesis' (x86_64)
TIMER| InitVfs: 6.383 ms
FILES| Main log written to '/Users/paria/Library/Application Support/0ad/logs/mainlog.html'
FILES| Interesting log written to '/Users/paria/Library/Application Support/0ad/logs/interestinglog.html'
TIMER| CONFIG_Init: 7.804 ms
Assertion failed: "ms_singleton"
Location: Singleton.h:51 (GetSingleton)

Call stack:

(error while dumping stack: Function not supported)
errno = 0 (No error reported here)
OS error = ?


(C)ontinue, (S)uppress, (B)reak, Launch (D)ebugger, or (E)xit?
e
Redirecting call to abort() to mozalloc_abort

pyrogenesis was compiled with optimization - stepping may behave oddly; variables may not be available.
Process 79078 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000010109c1f0 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
   30  	#ifdef MOZ_WIDGET_ANDROID
   31  	  abortThroughJava(msg);
   32  	#endif
-> 33  	  MOZ_CRASH();
   34  	}
   35  	
   36  	#ifdef MOZ_WIDGET_ANDROID
Target 0: (pyrogenesis) stopped.
(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x000000010109c1f0 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
    frame #1: 0x0000000101b93e3d pyrogenesis`::abort() at mozalloc_abort.cpp:82:3 [opt]
    frame #2: 0x00000001004f2a86 pyrogenesis`sys_display_error(text=<unavailable>, flags=6) at unix.cpp:268:4 [opt]
    frame #3: 0x00000001004d5203 pyrogenesis`debug_DisplayError(wchar_t const*, unsigned long, void*, wchar_t const*, wchar_t const*, int, char const*, long volatile*) [inlined] CallDisplayError(text=L"Assertion failed: \"ms_singleton\"\r\nLocation: Singleton.h:51 (GetSingleton)\r\n\r\nCall stack:\r\n\r\n(error while dumping stack: Function not supported)\r\nerrno = 0 (No error reported here)\r\nOS error = ?\r\n", flags=6) at debug.cpp:374:8 [opt]
    frame #4: 0x00000001004d51e6 pyrogenesis`debug_DisplayError(description=L"Assertion failed: \"ms_singleton\"", flags=6, context=0x00007ffeefbfe000, lastFuncToSkip=<no summary available>, pathname=<no summary available>, line=<no summary available>, func=<no value available>, suppress=<no summary available>) at debug.cpp:460 [opt]
    frame #5: 0x00000001004d5a6e pyrogenesis`debug_OnAssertionFailure(expr=<no summary available>, suppress=<no summary available>, file=<no summary available>, line=<no summary available>, func=<no value available>) at debug.cpp:547:9 [opt]
    frame #6: 0x00000001002ce960 pyrogenesis`CFontMetrics::CFontMetrics(CStrIntern) [inlined] Singleton<CRenderer>::GetSingleton() at Singleton.h:51:3 [opt]
    frame #7: 0x00000001002ce930 pyrogenesis`CFontMetrics::CFontMetrics(this=<no summary available>, font=CStrIntern @ scalar) at FontMetrics.cpp:29 [opt]
    frame #8: 0x00000001001d993c pyrogenesis`CConsole::Init(this=<no summary available>) at CConsole.cpp:97:21 [opt]
    frame #9: 0x0000000100214e5f pyrogenesis`InitPs(setup_gui=<no summary available>, gui_page=<no summary available>, srcScriptInterface=<no summary available>, initData=JS::HandleValue @ scalar) at GameSetup.cpp:201:14 [opt]
    frame #10: 0x0000000100213a36 pyrogenesis`Autostart(args=<no summary available>) at GameSetup.cpp:1127:3 [opt]
    frame #11: 0x00000001002151eb pyrogenesis`InitNonVisual(args=<no summary available>) at GameSetup.cpp:721:2 [opt] [artificial]
    frame #12: 0x0000000100004aaa pyrogenesis`RunGameOrAtlas(argc=<no summary available>, argv=<no summary available>) at main.cpp:672:4 [opt]
    frame #13: 0x00000001000035b6 pyrogenesis`main(argc=<no summary available>, argv=<no summary available>) at main.cpp:743:2 [opt]
    frame #14: 0x00007fff68073cc9 libdyld.dylib`start + 1
(lldb)

#6512 fixed Water weed Freagarach Langbart

Description

azayrahmad made some remarks in the forum about the gather_water_weeding.json tech.

Related forum thread: Water weeding (22/Apr/22)

I'm Indonesian where rice is our staple food. As far as I know there is no weed that supply rice plants with nutrients (weeds are robbing rice's nutrients, if any). There are some that could be planted side by side with rice, but it's for land optimization, not to improve the rice's nutrients.

Introduced by artoo (udeved) with commit fe32e78 (29/Jan/20)
Removed by Nescio0 wit commit 498061f (16/Jul/20)
Reintroduced by artoo (udeved) with commit de1bd77 (25/Sep/21)

issue(s)

The extra to in the description should at least be removed or remove/ change the entire tech.
gather_farming_water_weeding.json

Line
1	{
2	"genericName": "Water Weeding",
3	"description": "Grow water weeds to to supply rice plants with nutricients.",
4	"cost": {
5	"wood": 300,

#6511 fixed Pressing the Enter key should close the chat if nothing is typed. Silier Langbart

Description

Youtuber Alistair Findlay reports an inconvenience on the current development version.

0 A.D. a26 preview (I get EPICALLY frustrated) (23/Apr/22)

issue

Watch the video ~29min:50sec
When opening the chat window and nothing has been typed into the chat field pressing the Enter key should close the window.

elexis

[23:51:00] elexis 29:47 should be simple

#6509 fixed Numbering of the control groups Silier Langbart

Description

Youtuber Alistair Findlay reports an issue on the current development version.

0 A.D. a26 preview (I get EPICALLY frustrated) (23/Apr/22)

issue

Watch video ~18min:10sec

Control group should not be from 0-9, but rather from 1-10.

solution

Silier has already made a patch. It is better to also make a ticket to increase the chances that it will not be forgotten to be added to the game.

related tickets

#773

#6506 fixed Mouse cursor - selection bug Langbart

Description

Youtuber Alistair Findlay outlines a bug on the current development version.

0 A.D. a26 preview (I get EPICALLY frustrated) (23/Apr/22)

issue

Check the video at 2min:25secs!

When he clicks, the mouse moves one pixel to the side.

Quote

It probably happens [...] at 1080p maybe 4-5% of the time, barely noticeable. At 1440p it happens 20% of the time, at 4k it happens practically half the time.

(I could not reproduce the problem on macOS, the ticket was created before the problem fades into oblivion.)

#6505 needsinfo Problems with the installation Barak

Description

The problem will be that i have Windows 11 and it is not compatible with your game, so any advice it will be highly appreciated.

Following I attached the fail message:

Details: unhandled exception (Access violation reading 0x0000000C)

Location: unknown:0 (?)

Call stack:

(error while dumping stack: No stack frames found) errno = 13 (Insufficient access rights to open file) OS error = 0 (no error code was set)

#6504 duplicate HELP ERROR 0AD HaronAdler

Description

Cuando quiero iniciar sesion dentro de 0AD me sale un error diciendo "No se pudo verificar el certificado del servidor o no se completo la conexion del todo".

#6503 fixed Han Chinese siege towers issues Stan Langbart

Description

Two issues

~~Attack~~

~~IRC 0ad-dev 29/Apr/22~~

18:26 < phosit> It looks weird if the siege towers of Han Chinese attack: The lances stab even if the tower is far away from the enemy
18:28 < phosit> looks like attack_ranged animation is just a placeholder?

~~See GIF below, the tower is manned by women and does not shoot any arrows, the moving spears give the false impression that it is some kind of deadly weapon even though it is completely harmless.~~

Garrison flag

It is a bit short. ~~Flag hides when the tower is idle, see GIF below.~~

#6502 fixed Icon construction panel order marder Langbart

Description

Issue A - Ministry (Han)

The ministry sits next to the civic centre in the construction panel, although it cannot be built outside its territory, the icon should be moved down at least one line. So it is consistent with the order set in [23548].

This patch lists the centre, crannog, and colony first, before the house etc.

Issue B - Ice house (Persian)

It looks better if the ice house is next to the house, similar to what was done with the Kush pyramid. See picture below for more clarity.

possible solution

Change the order in the simulation/templates/mixins/builder.xml file.

#6500 fixed Empty vertex shader description name. Vladislav Belov Freagarach

Description

When starting the game (on rP26798) with OpenGL ARB as the render backend, I get the following error: ERROR: Empty attribute name in vertex shader description 'shaders/arb/canvas2d.vp'. Switching to the other backend doesn't show the error (obviously).

#6499 worksforme fps limiter seems to be broken marder

Description

user.cfg says
adaptivefps.session = "60"

but I get a variable framerate of 70-130

#6498 duplicate sound issue VinceCaruso

Description

I reported my sound going out earlier and the only thing that started it again was to restart my entire computer system.

HOWEVER, after 1 game and logging out to watch some tutorials on youtube, I came back to have the same issue.

I've been playing for about a month and today is the first time it's happened. None of my other sound is affected - just this game. And I don't want to restart my computer each time I start a new game.

any suggestions?

#6497 needsinfo Problems with the sound VinceCaruso

Description

For no reason the sound stop today. I exited the game completely, checked that my sound was working fine (youtube), logged back on - no sound. reset all the settings to factory and reinput them... still no sound

EDIT

(comment from a duplicated ticket #6498 from the same reporter)

I reported my sound going out earlier and the only thing that started it again was to restart my entire computer system.

HOWEVER, after 1 game and logging out to watch some tutorials on youtube, I came back to have the same issue.

I've been playing for about a month and today is the first time it's happened. None of my other sound is affected - just this game. And I don't want to restart my computer each time I start a new game.

any suggestions?

#6496 fixed zlib library - LIB_URL has changed Stan Langbart

Description

ref #4362

issue

the link of old releases has changed
All released versions of zlib

IRC 0ad-dev (13/Apr/22)

15:16 < kumikumi> I'm at the head of SVN and I'm getting a 404 error (from http://zlib.net/zlib-1.2.11.tar.gz ) when running the "build-osx-libs.sh" script
15:17 < kumikumi> bumping ZLIB_VERSION to zlib-1.2.12 seems to fix it
15:18 < Freagarach> Yeah, I see they updated it and the URL is dead now.
15:19 < Freagarach> It seems better to link to /fossils/<version>

tested

The update to the latest version (zlib-1.2.12.tar.gz) worked under macOS 10.15, the game compiled successfully and opened normally.

#6495 fixed [macOS] Instant crash Vladislav Belov Langbart

Description

to reproduce

Start 0ad on GIT version [26777]
Crash occurs regardless of user.cfg settings

lldb

(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x0000000000000000
    frame #1: 0x00000001003f20bf pyrogenesis`Renderer::Backend::GL::CShaderProgramGLSL::CShaderProgramGLSL(this=<unavailable>, device=0x0000000105065580, name=<unavailable>, vertexFilePath=0x00007ffeefbfe010, fragmentFilePath=0x00007ffeefbfdff0, defines=0x00007ffeefbfdf80, vertexAttribs=size=2, streamflags=9) at ShaderProgram.cpp:358:3 [opt]
    frame #2: 0x00000001003ee76b pyrogenesis`Renderer::Backend::GL::CShaderProgram::Create(Renderer::Backend::GL::CDevice*, CStr8 const&, CShaderDefines const&) [inlined] Renderer::Backend::GL::CShaderProgramGLSL::CShaderProgramGLSL(this=0x00000001052d19b0, device=0x0000000105065580, name=0x00000001052cdb50, vertexFilePath=0x00007ffeefbfe010, fragmentFilePath=0x00007ffeefbfdff0, defines=0x00007ffeefbfdf80, vertexAttribs=size=2, streamflags=<unavailable>) at ShaderProgram.cpp:348:2 [opt]
    frame #3: 0x00000001003ee731 pyrogenesis`Renderer::Backend::GL::CShaderProgram::Create(Renderer::Backend::GL::CDevice*, CStr8 const&, CShaderDefines const&) [inlined] std::__1::__unique_if<Renderer::Backend::GL::CShaderProgramGLSL>::__unique_single std::__1::make_unique<Renderer::Backend::GL::CShaderProgramGLSL, Renderer::Backend::GL::CDevice*&, CStr8 const&, Path const&, Path const&, CShaderDefines const&, std::__1::map<CStrIntern, int, std::__1::less<CStrIntern>, std::__1::allocator<std::__1::pair<CStrIntern const, int> > > const&, int&>(__args=0x00000001052cdb50, __args=0x00007ffeefbfe010, __args=0x00007ffeefbfdff0, __args=0x00007ffeefbfdf80, __args=size=2) at memory:3033 [opt]
    frame #4: 0x00000001003ee71d pyrogenesis`Renderer::Backend::GL::CShaderProgram::Create(Renderer::Backend::GL::CDevice*, CStr8 const&, CShaderDefines const&) [inlined] Renderer::Backend::GL::CShaderProgram::ConstructGLSL(device=0x0000000105065580, name=0x00000001052cdb50, vertexFile=0x00007ffeefbfe010, fragmentFile=0x00007ffeefbfdff0, defines=0x00007ffeefbfdf80, vertexAttribs=size=2, streamflags=9) at ShaderProgram.cpp:985 [opt]
    frame #5: 0x00000001003ee71d pyrogenesis`Renderer::Backend::GL::CShaderProgram::Create(device=0x0000000105065580, name=0x00000001052cdb50, baseDefines=<unavailable>) at ShaderProgram.cpp:948 [opt]
    frame #6: 0x00000001003e73cc pyrogenesis`Renderer::Backend::GL::CDevice::CreateShaderProgram(this=<unavailable>, name=<unavailable>, defines=<unavailable>) at Device.cpp:826:9 [opt]
    frame #7: 0x0000000100336d95 pyrogenesis`CShaderProgram::Reload(this=0x00000001052cdb50) at ShaderProgram.cpp:39:35 [opt]
    frame #8: 0x000000010033125c pyrogenesis`CShaderManager::LoadProgram(this=0x000000010b894038, name=0x00007ffeefbfe530, defines=0x00007ffeefbfe3b0) at ShaderManager.cpp:79:12 [opt]
    frame #9: 0x0000000100334083 pyrogenesis`CShaderManager::NewEffect(this=0x000000010b894038, name=<unavailable>, baseDefines=0x00007ffeefbfebb8, tech=std::__1::shared_ptr<CShaderTechnique>::element_type @ 0x0000000105144650 strong=1 weak=1) at ShaderManager.cpp:398:5 [opt]
    frame #10: 0x0000000100331ab9 pyrogenesis`CShaderManager::LoadEffect(this=0x000000010b894038, name=CStrIntern @ 0x00007ffeefbfe8c8, defines=<unavailable>) at ShaderManager.cpp:122:7 [opt]
    frame #11: 0x00000001002c7ab2 pyrogenesis`CCanvas2D::Impl::BindTechIfNeeded(this=0x0000000105143a70) at Canvas2D.cpp:84:40 [opt]
    frame #12: 0x00000001002c84fd pyrogenesis`CCanvas2D::DrawTexture(this=0x00007ffeefbfee70, texture=std::__1::shared_ptr<CTexture>::element_type @ 0x00000001081a9580 strong=3 weak=2, destination=<unavailable>, source=<unavailable>, multiply=0x00000001156346f0, add=0x00000001156346e0, grayscaleFactor=0) at Canvas2D.cpp:318:5 [opt]
    frame #13: 0x000000010047aa1c pyrogenesis`GUIRenderer::Draw(Calls=0x00000001156141a0, canvas=0x00007ffeefbfee70) at GUIRenderer.cpp:344:10 [opt]
    frame #14: 0x0000000100494994 pyrogenesis`CImage::Draw(this=<unavailable>, canvas=<unavailable>) at CImage.cpp:36:9 [opt]
    frame #15: 0x0000000100451acc pyrogenesis`CGUI::Draw(this=<unavailable>, canvas=0x00007ffeefbfee70) at CGUI.cpp:346:25 [opt]
    frame #16: 0x0000000100471931 pyrogenesis`CGUIManager::Draw(this=<unavailable>, canvas=0x00007ffeefbfee70) const at GUIManager.cpp:396:10 [opt]
    frame #17: 0x00000001003a4ae7 pyrogenesis`CRenderer::RenderFrame2D(this=0x0000000108197c20, renderGUI=<unavailable>, renderLogger=<unavailable>) at Renderer.cpp:512:10 [opt]
    frame #18: 0x00000001003a2cbe pyrogenesis`CRenderer::RenderFrameImpl(this=0x0000000108197c20, renderGUI=true, renderLogger=true) at Renderer.cpp:482:2 [opt]
    frame #19: 0x00000001003a2aaa pyrogenesis`CRenderer::RenderFrame(this=0x0000000108197c20, needsPresent=true) at Renderer.cpp:429:4 [opt]
    frame #20: 0x0000000100006a71 pyrogenesis`RunGameOrAtlas(int, char const**) [inlined] Frame() at main.cpp:452:13 [opt]
    frame #21: 0x00000001000061c0 pyrogenesis`RunGameOrAtlas(argc=<unavailable>, argv=<unavailable>) at main.cpp:691 [opt]
    frame #22: 0x00000001000047b6 pyrogenesis`main(argc=1, argv=0x00007ffeefbff680) at main.cpp:743:2 [opt]
    frame #23: 0x00007fff6814dcc9 libdyld.dylib`start + 1

bisect

[26776]

#6494 fixed Rectangular texture error on water when dying Vladislav Belov Langbart

Description

A user called Sevda reported a bug in the forum. I am just creating the ticket so the issue will not be forgotten.

Another bug found, when a whale is killed, this is shown as the corpse. There is no error returned but a sudden square black hole in the middle of the ocean ...

Naval gameplay: flaws and fixes (4/Apr/22)

A similar issue happened to me as well.

to reproduce

Start the game with default settings
Start the forest_battle_4p map
Select the harbor in the middle and produce a fishing boat (use cheat code wololo before)
When I sink the fishing boat it looks like in the image below.

See image of dead whale on Corinthian Isthmus (2) map below.

EDIT 18/Apr/22

~~Toggling Real water depth in the settings no longer shows the rectangle.~~
- Toggling the Real water depth off will show just less of of the square but does not hide the rectangle.
- See forum thread: When Death encountered a Bug (18/Apr/22)
Also some units don't show a rectangle upon death e.g. Han fishing boat (see GIF below).

bisect

[26284]

reproducible

Issue is reproducible with current git version [26759].
Issue is not reproducible with A25b.

#6492 fixed Autoqueue corral issue Freagarach Langbart

Description

to reproduce

Build 3 corrals
Have 200 food in your resource counter (e.g. i want pizza 200)
Select all three corrals and press the autoqueue icon, start producing sheep (50 food each).
3 sheep are made and after that 2 corrals turn off the autoqueue. so far so good.
Why are 2 icons displayed in the corral that is still producing?
See image below for more clarity.

reproducible

A25b [25860]: Issue is reproducible
A24b [24937]: autoqueue does not exist, it was added with [25381]

The ticket can be closed if it is not a problem. I just expected these two icons not to be displayed, that's all.

#6491 fixed Shadow framebuffer error, can't set shadows at "very high" level even when there is enough memory. nani

Description

0ad shadow buffer crashes if shadow setting is very high even if there is enough memory. My hunch is that is trying to allocate at the integrated graphics. Resolution 4k, integrated VRAM memory 500 MB, dedicated GPU 4GB.

(Already set all system/nvidia control panel to only use the dedicated gpu for 0ad)

Windows 10. Attachment with the system info.

#6490 fixed Idle error Freagarach Langbart

Description

to reproduce

start a game
select all your units
click any kind of formation
select them all with the following hotkey combo
- alt (include offscreen) + # (select next idle unit)

ERROR: CCacheLoader failed to find archived or source file for: "art/textures/ui/session/portraits/formations/box.png"

IRC 0ad-dev 3/Apr/22

[07:23:38] Freagarach Langbart: #6490 is caused by giving formations cmpIdentity.

#6489 fixed Crashes on Start up Plaguedocd

Description

Whenever I try to start the game I get this error

Details: unhandled exception (Access violation reading 0x00000024)

Location: unknown:0 (?)

Call stack:

(error while dumping stack: No stack frames found) errno = 0 (No error reported here) OS error = 0 (no error code was set)

#6487 invalid OOS at first Turn Asger

Description

When trying to play a multiplayer game we get an OOS at Turn one.

#6485 fixed IRC topic missing Langbart

Description

The topic for #0ad, #0ad-dev and #0ad-design are missing.

#6484 fixed Data counter clashes with tech icon in top right corner phosit Langbart

Description

to reproduce

Issue (1)

start a game with the default game settings
Select the CC and research something
press hotkey to enable FPS overlay
The tech icon disappears
See GIF below for more clarity

Issue (2)

enable FPS from the options settings not with the hotkey (If you enable the FPS with the hotkey and go into the option settings, you would expect it to be saved, but no, the next time you restart the app, the FPS is off again.)
start a game
Select the CC and research something
data counter is always above the tech icon
See GIF below for more clarity

bisect

[26523]

reproducible

Issue (1) is not reproducible on A25b.
Issue (2) is reproducible to a certain extent, but as soon as you trigger an additional hotkey (e.g. elapsed time) the tech icon moves below the data Counter. This is currently not the case while testing it on the latest GIT version [26735].

#6480 fixed [macOS] MSAA crash Vladislav Belov Langbart

Description

to reproduce

start game in main menu
enable MSAA on macOS in the options

start a match --> crash

WARNING: Wrong MSAA sample count: msaa2.
Process 19666 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x0000000000000000
error: memory read failed for 0x0
Target 0: (pyrogenesis) stopped.

Even worse when simply starting the main menu with the MSAA option being stored in the user.cfg file, the game crashes immediately

lldb

(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x0000000000000000
    frame #1: 0x00000001003fcffd pyrogenesis`Renderer::Backend::GL::CTexture::Create(device=0x0000000105176e70, name="PostProcColorMS", type=TEXTURE_2D_MULTISAMPLE, format=<unavailable>, width=1920, height=1200, defaultSamplerDesc=0x00007ffeefbfe438, MIPLevelCount=1, sampleCount=4) at Texture.cpp:250:4 [opt]
    frame #2: 0x00000001003edada pyrogenesis`Renderer::Backend::GL::CDevice::CreateTexture(this=<unavailable>, name=<unavailable>, type=<unavailable>, format=<unavailable>, width=<unavailable>, height=1200, defaultSamplerDesc=0x00007ffeefbfe438, MIPLevelCount=1, sampleCount=4) at Device.cpp:791:9 [opt]
    frame #3: 0x00000001003a4036 pyrogenesis`CPostprocManager::CreateMultisampleBuffer(this=0x000000010b9360c0) at PostprocManager.cpp:609:41 [opt]
    frame #4: 0x00000001003a3390 pyrogenesis`CPostprocManager::UpdateAntiAliasingTechnique(this=0x000000010b9360c0) at PostprocManager.cpp:572:3 [opt]
    frame #5: 0x00000001003a20e5 pyrogenesis`CPostprocManager::Initialize(this=0x000000010b9360c0) at PostprocManager.cpp:103:2 [opt]
    frame #6: 0x00000001003b5ad1 pyrogenesis`CSceneRenderer::RenderSubmissions(this=0x000000010b936230, deviceCommandContext=0x000000010b0b5530, waterScissor=0x00007ffeefbfedb0) at SceneRenderer.cpp:827:19 [opt]
    frame #7: 0x00000001003b6ce0 pyrogenesis`CSceneRenderer::RenderScene(this=0x000000010b936230, deviceCommandContext=0x000000010b0b5530, scene=0x000000010b0bba40) at SceneRenderer.cpp:1163:2 [opt]
    frame #8: 0x00000001003a94ee pyrogenesis`CRenderer::RenderFrameImpl(this=0x000000010b0b4c00, renderGUI=<unavailable>, renderLogger=<unavailable>) at Renderer.cpp:462:22 [opt]
    frame #9: 0x00000001003a92ed pyrogenesis`CRenderer::RenderFrame(this=0x000000010b0b4c00, needsPresent=true) at Renderer.cpp:417:3 [opt]
    frame #10: 0x00000001000069f1 pyrogenesis`RunGameOrAtlas(int, char const**) [inlined] Frame() at main.cpp:452:13 [opt]
    frame #11: 0x0000000100006140 pyrogenesis`RunGameOrAtlas(argc=<unavailable>, argv=<unavailable>) at main.cpp:691 [opt]
    frame #12: 0x0000000100004736 pyrogenesis`main(argc=1, argv=0x00007ffeefbff680) at main.cpp:743:2 [opt]
    frame #13: 0x00007fff6b64dcc9 libdyld.dylib`start + 1

it used to display a warning in A25b #5969

bisect

The change from simply displaying a warning to an instant crash came with [26366].

IRC 0ad-dev 28/Mar/22

20:31	Vladislav	Langbart: I believe it might be macOS driver bug, so bisect might lead to introducing MSAA.
20:31		Langbart: could you run the game with GL debug enabled?
20:32		Just set: renderer.backend.debug* = "true" in cfg.

#6479 duplicate Crash in Campaign after collecting Treasures JustConfused

Description

Every time on the Sporades-Islands when I collect a drop/Treasure the game just Crashes. I am on Linux.

#6478 needsinfo Game crashes when trying to join multiplayer match Uiuiuiui0815

Description

The game crashes when I try to join a multiplayer match from a Windows machine to a Linux machine. Both use Alpha XXV. I atteched all of the error messanges down below.

#6477 invalid [Trac] - Wrong date Langbart

Description

The wrong date for tickets is displayed in the Trac timeline.

#6476 fixed Can't run debug build on linux Vladislav Belov phosit

Description

If I run pyrogenesis_dbg i get:

Assertion failed: "nm*sz <= ARRAY_SIZE(alloc_bootstrap_buffer)"
Location: Profile.cpp:599 (calloc)

Call stack:

(0x563b9774a2c5) ./binaries/system/pyrogenesis_dbg(+0xa4c2c5) [0x563b9774a2c5]
(0x563b9771d9f0) ./binaries/system/pyrogenesis_dbg(+0xa1f9f0) [0x563b9771d9f0]
(0x563b9771de93) ./binaries/system/pyrogenesis_dbg(+0xa1fe93) [0x563b9771de93]
(0x563b9771e476) ./binaries/system/pyrogenesis_dbg(+0xa20476) [0x563b9771e476]
(0x563b9730c48f) ./binaries/system/pyrogenesis_dbg(calloc+0x9a) [0x563b9730c48f]
(0x7f1107fe2562) /usr/lib/libglib-2.0.so.0(g_malloc0+0x22) [0x7f1107fe2562]
(0x7f1107ff8683) /usr/lib/libglib-2.0.so.0(+0x74683) [0x7f1107ff8683]
(0x7f1107ff9d17) /usr/lib/libglib-2.0.so.0(g_slice_alloc+0x277) [0x7f1107ff9d17]
(0x7f1107fc6403) /usr/lib/libglib-2.0.so.0(g_hash_table_new_full+0x23) [0x7f1107fc6403]
(0x7f1107fe2464) /usr/lib/libglib-2.0.so.0(+0x5e464) [0x7f1107fe2464]
(0x7f1107fa10c9) /usr/lib/libglib-2.0.so.0(+0x1d0c9) [0x7f1107fa10c9]
(0x7f110da67ede) /lib64/ld-linux-x86-64.so.2(+0x5ede) [0x7f110da67ede]
(0x7f110da67fcc) /lib64/ld-linux-x86-64.so.2(+0x5fcc) [0x7f110da67fcc]
(0x7f110da7f96a) /lib64/ld-linux-x86-64.so.2(+0x1d96a) [0x7f110da7f96a]

errno = 0 (Unknown error (0, 0x0))
OS error = ?

test_dbg also don't work:

Assertion failed: "nm*sz <= ARRAY_SIZE(alloc_bootstrap_buffer)"
Location: Profile.cpp:599 (calloc)

Call stack:

(0x558f9906cab2) ./binaries/system/test_dbg(+0xc43ab2) [0x558f9906cab2]
(0x558f990412c4) ./binaries/system/test_dbg(+0xc182c4) [0x558f990412c4]
(0x558f99041767) ./binaries/system/test_dbg(+0xc18767) [0x558f99041767]
(0x558f99041d4a) ./binaries/system/test_dbg(+0xc18d4a) [0x558f99041d4a]
(0x558f98c2a7f7) ./binaries/system/test_dbg(calloc+0x9a) [0x558f98c2a7f7]
(0x7f176e60e562) /usr/lib/libglib-2.0.so.0(g_malloc0+0x22) [0x7f176e60e562]
(0x7f176e624683) /usr/lib/libglib-2.0.so.0(+0x74683) [0x7f176e624683]
(0x7f176e625d17) /usr/lib/libglib-2.0.so.0(g_slice_alloc+0x277) [0x7f176e625d17]
(0x7f176e5f2403) /usr/lib/libglib-2.0.so.0(g_hash_table_new_full+0x23) [0x7f176e5f2403]
(0x7f176e60e464) /usr/lib/libglib-2.0.so.0(+0x5e464) [0x7f176e60e464]
(0x7f176e5cd0c9) /usr/lib/libglib-2.0.so.0(+0x1d0c9) [0x7f176e5cd0c9]
(0x7f1774093ede) /lib64/ld-linux-x86-64.so.2(+0x5ede) [0x7f1774093ede]
(0x7f1774093fcc) /lib64/ld-linux-x86-64.so.2(+0x5fcc) [0x7f1774093fcc]
(0x7f17740ab96a) /lib64/ld-linux-x86-64.so.2(+0x1d96a) [0x7f17740ab96a]

errno = 0 (Unknown error (0, 0x0))
OS error = ?

I'm on Parabola (derived from Arch) linux. I used this build instructions:

export WX_CONFIG=wx-config-gtk3
cd 0ad/build/workspaces
./update-workspaces.sh -j9
cd gcc
make config=debug -j9

make config=debug -j9 outputs this warnings many times:

/usr/include/features.h:412:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
  412 | #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
      |    ^~~~~~~

#6475 fixed windows: parsing of the log folder in the terms for the feedback is broken Vladislav Belov marder

Description

Reproducible

The feature was added with [21898] and after testing past Alpha versions with VirtualBox. The issue is reproducible for A25 [25860], A24 [24936] and A23b [21935].

#6474 fixed [macOS] Spidermonkey fails to build - part 2 Langbart

Description

to reproduce

Try to build Spidermonkey

Error

AttributeError: module 'distutils' has no attribute 'sysconfig'
ERROR: Error building spidermonkey

Around 2 weeks ago a different issue was solved (#6447), between now and then nothing was changed for the patch.sh file.
Why could I build SM 2 weeks ago and now it fails?

Two players (kumikumi and minohaka) have also reported this issue.

IRC 0ad-dev - 13/Mar/22

07:31 < kumikumi> I spent some time today trying to build the latest release on M1, with not particularly high expectations. I had to upgrade some dependencies and I tried to do something with python and virtualenv, now I'm stuck at "AttributeError: module 'distutils' has no attribute 'sysconfig'"
07:31 < kumikumi> but I think there may still be some bigger obstacles ahead

IRC 0ad-dev 26/Mar/22

15:05 < minohaka> I got an m1 mac and python v3.10.0 installed through pyenv
15:06 < minohaka> whenever I try to build the libs I get this error: AttributeError: module 'distutils' has no attribute 'sysconfig'. Did you mean: 'config'?
15:07 <@Stan> Hey minohaka

Both players also tested the special wraitii/0ad/tree/esr91-0AD branch from wraitii and the issue did not occur there.

Traceback

Traceback (most recent call last):
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/build-debug/../js/src/../../configure.py", line 181, in <module>
    sys.exit(main(sys.argv))
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/build-debug/../js/src/../../configure.py", line 52, in main
    sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 445, in run
    self.include_file(path)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 436, in include_file
    exec_(code, self)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/util.py", line 53, in exec_
    exec(object, globals, locals)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/moz.configure", line 7, in <module>
    include('build/moz.configure/init.configure')
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 773, in include_impl
    self.include_file(what)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 436, in include_file
    exec_(code, self)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/util.py", line 53, in exec_
    exec(object, globals, locals)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/build/moz.configure/init.configure", line 254, in <module>
    def virtualenv_python3(env_python, build_env, mozconfig, help):
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 756, in decorator
    depends = DependsFunction(self, func, dependencies, when=when)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 129, in __init__
    sandbox._value_for(self)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 542, in _value_for
    return self._value_for_depends(obj)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/util.py", line 1018, in method_call
    cache[args] = self.func(instance, *args)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 551, in _value_for_depends
    value = obj.result()
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/util.py", line 1018, in method_call
    cache[args] = self.func(instance, *args)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 155, in result
    return self._func(*resolved_args)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 1161, in wrapped
    return new_func(*args, **kwargs)
  File "/Users/paria/0ad/libraries/source/spidermonkey/mozjs-78.6.0/build/moz.configure/init.configure", line 378, in virtualenv_python3
    if not distutils.sysconfig.get_python_lib():
AttributeError: module 'distutils' has no attribute 'sysconfig'
ERROR: Error building spidermonkey

possible workaround

Adding the following lines to FixMacBuild.diff solved the problem for me and made it possible to build Spidermonkey.

--- a/build/moz.configure/init.configure
+++ b/build/moz.configure/init.configure
@@ -375,9 +375,6 @@
         sys.exit(subprocess.call([python] + sys.argv))
 
     # We are now in the virtualenv
-    if not distutils.sysconfig.get_python_lib():
-        die('Could not determine python site packages directory')
-
     str_version = '.'.join(str(v) for v in version)
 
     return namespace(

The lines were also removed by mhentges (Mitchell Hentges) with diff D129863 - Bug 1730712: Use consistent Python version throughout configure. Wacky way for the time being to build Spidermonkey until wraitii moves 0 A.D. to SM91.

#6473 invalid Delenda errors on Atlas Valleys (8) kete

Description

The Delenda Est mod has too many errors on the map Atlas Valleys, which has eight players. The errors start while the map is loading. I'll paste those errors. After a while, the errors go away and then come and go until at one point, they're covering up too much of the screen. I remember some JavaScript errors or warnings. Here are the initial errors:

0 A.D. (0.0.25) Main log (warnings and errors only)

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/sueb/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/sueb/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/sueb/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/sueb/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/sueb/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/sueb/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/sueb/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/sueb/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/scyth/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/scyth/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/scyth/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/scyth/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/scyth/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/scyth/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/scyth/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/scyth/support_female_citizen'

ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/units/imp/support_female_citizen.xml"

ERROR: Failed to load entity template 'units/imp/support_female_citizen'