Opened 6 years ago

Closed 17 months ago

Last modified 17 months ago

#1090 closed enhancement (fixed)

[PATCH] Improve load game UI

Reported by: Ben Brian Owned by: mimo
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords:
Cc: Patch:

Description (last modified by Ben Brian)

Currently when loading a saved game, it shows a list with timestamp and map name for each game. I would like to see at minimum:

  • Timestamp
  • Map name
  • User's description of the game
  • Players
    • Name / player number
    • Civ
    • Status (defeated/active)
  • Elapsed time

Possible enhancements:

  • Small screenshot
  • Game version; mod(s) used

It doesn't all have to be shown on one line, but rather have a common UI panel to display details for the currently selected game.

Attachments (8)

loadsave.patch (3.1 KB) - added by mimo 18 months ago.
with fixes following IRC comments
loadsave-v2.patch (6.4 KB) - added by mimo 18 months ago.
new version with map preview
load.png (841.8 KB) - added by mimo 18 months ago.
screenshot of the new panel
loadsave-v3.patch (16.9 KB) - added by mimo 17 months ago.
loadsave-v4.patch (18.5 KB) - added by mimo 17 months ago.
playercomponent_savegamesummaryreplaycleanup.patch (45.1 KB) - added by elexis 17 months ago.
cleans up related and related related code in several ways, most notably changes the player component to trigger the defeat directly instead of sending a message to it to remove duplicate messages.
playercomponent_savegamesummaryreplaycleanup_v2.patch (54.6 KB) - added by elexis 17 months ago.
fixed order of execution bug, added more cleanup because the patch wasnt big enough
playercomponent_savegamesummaryreplaycleanup_v3.patch (25.7 KB) - added by elexis 17 months ago.
split unrelated parts

Download all attachments as: .zip

Change History (21)

comment:1 Changed 6 years ago by Philip Taylor

Also it should be possible to delete saved games from the UI, since people apparently like keeping their list clean.

comment:2 Changed 6 years ago by ben

In 11233:

Adds saved game deletion. Refs #1090
Documents a few things related to saved games.

comment:3 Changed 5 years ago by Ben Brian

Description: modified (diff)

#1683 was a duplicate.

comment:4 Changed 4 years ago by Ben Brian

Description: modified (diff)

r13579 added saved game descriptions

comment:5 Changed 4 years ago by Ben Brian

Description: modified (diff)

comment:6 Changed 18 months ago by mimo

Component: Core engineUI & Simulation
Keywords: review added; gui removed
Summary: Improve load game UI[PATCH] Improve load game UI

Changed 18 months ago by mimo

Attachment: loadsave.patch added

with fixes following IRC comments

comment:7 Changed 18 months ago by elexis

  • translate("Players: %(players)")
  • The tooltip doesn't state anything that isn't self-evident
  • A map preview would be great
  • Didn't test, but I doubt merging all these infos into a single string without newlines will show up correctly, especially with 8 players. Shouldn't there be labels like in the gamesetup/lobby/replay menu?

comment:8 Changed 18 months ago by elexis

Keywords: review removed

Changed 18 months ago by mimo

Attachment: loadsave-v2.patch added

new version with map preview

Changed 18 months ago by mimo

Attachment: load.png added

screenshot of the new panel

Changed 17 months ago by mimo

Attachment: loadsave-v3.patch added

comment:9 Changed 17 months ago by mimo

Keywords: review added
Milestone: BacklogAlpha 21

added some info on players (taken from the replay menu, with some common parts moved to gui/common)

Changed 17 months ago by mimo

Attachment: loadsave-v4.patch added

comment:10 Changed 17 months ago by mimo

Owner: set to mimo
Resolution: fixed
Status: newclosed

In 18409:

improve load game UI, fixes #1090

comment:11 Changed 17 months ago by mimo

Keywords: review removed

comment:12 Changed 17 months ago by elexis

In 18422:

Savegame GUI cleanup..

Move duplicate reallyDeleteGame to shared file.
Inline getPlayerInfoText since it is used only once, refs #1090.
Merge deleteGame and deleteGameWithoutConfirmation.
Use let instead of var.

Changed 17 months ago by elexis

cleans up related and related related code in several ways, most notably changes the player component to trigger the defeat directly instead of sending a message to it to remove duplicate messages.

Changed 17 months ago by elexis

fixed order of execution bug, added more cleanup because the patch wasnt big enough

Changed 17 months ago by elexis

split unrelated parts

comment:13 Changed 17 months ago by elexis

In 18440:

Savegame / summary screen / replay menu cleanup, refs #1090.

Savegame / replay menu selected game information:

Show players who won the game (not only defeat).
Show translated civs instead of the civ code.
Use a translation for "%(team)s:\n%(playerDescriptions)s".
Merge nearly duplicate objects passed to formatPlayerInfo.
Merge deleteGame and deleteGameWithoutConfirmation.

Summary screen:

Construct the summary screen title in place, not in the session, nor replay menu.
Remove g_Players from the replay metadata since all relevant information is contained in the sim data.
Split g_GameData into gui and sim.
Access g_GameData instead of data for consistency.
Move code from XML to JS.
Don't use victory music when observers enter the summary screen (just keep the current track like when exiting the game as a player).
Rename updateObjectPlayerPosition to initPlayerBoxPositions.

Note: See TracTickets for help on using tickets.