#1213 closed enhancement (fixed)
[PATCH] [ATLAS] Multi-Selection object rotation
Reported by: | michael | Owned by: | trompetin17 |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 18 |
Component: | Atlas editor | Keywords: | |
Cc: | Patch: |
Description
Multi-Selection object rotation. Right-click rotation (as with single objects). Just rough calculate a center point of the selection and use that as a center for rotation.
Attachments (8)
Change History (22)
comment:1 by , 12 years ago
Keywords: | atlas added |
---|---|
Priority: | Nice to Have → If Time Permits |
comment:2 by , 12 years ago
Milestone: | Alpha 10 → Backlog |
---|---|
Summary: | Atlas: Multi-Selection object rotation → [ATLAS] Multi-Selection object rotation |
by , 9 years ago
comment:3 by , 9 years ago
Keywords: | review patch added |
---|---|
Milestone: | Backlog → Alpha 18 |
Owner: | set to |
Summary: | [ATLAS] Multi-Selection object rotation → [PATCH] [ATLAS] Multi-Selection object rotation |
by , 9 years ago
Attachment: | 1213.2.diff added |
---|
follow-up: 6 comment:4 by , 9 years ago
As said through IRC, it would be nice when (as a third option maybe) the selected entities would keep their relative rotation to each other (as an extension to the rotation where the entities would move around)
by , 9 years ago
Attachment: | 1213.3.diff added |
---|
by , 9 years ago
Attachment: | 1213.4.diff added |
---|
comment:6 by , 9 years ago
this is the video about how I implemented http://youtu.be/Z3ynovnPwhs
- shift for translate without rotation itself
- ctrl(command in osx) for translate with rotation itself
Replying to niektb:
As said through IRC, it would be nice when (as a third option maybe) the selected entities would keep their relative rotation to each other (as an extension to the rotation where the entities would move around)
comment:8 by , 9 years ago
Priority: | If Time Permits → Nice to Have |
---|
follow-up: 10 comment:9 by , 9 years ago
In RotateObjectsFromCenterPoint
, m_centerPoint
should be camel case m_CenterPoint
and you don't need to initialize it (the default constructor is 0,0,0 but this line actually causes a build error in MSVC). Similarly m_angleInitialRotation
should be capitalized.
I get these other build errors in VS2010:
1> TransformObject.cpp 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(555): error C2864: 'TransformObject::sRotating::rotateFromCenterPoint' : only static const integral data members can be initialized within a class 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2039: 'mUpdateVisualSelectedObjects' : is not a member of 'AtlasMessage' 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2065: 'mUpdateVisualSelectedObjects' : undeclared identifier 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2059: syntax error : ')' 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2039: 'mUpdateVisualSelectedObjects' : is not a member of 'AtlasMessage' 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2039: 'mUpdateVisualSelectedObjects' : is not a member of 'AtlasMessage'
by , 9 years ago
Attachment: | 1213.6.diff added |
---|
comment:10 by , 9 years ago
Status: | new → assigned |
---|
Done. This tickets was depending #1163, but I didnt update this one with last changes over these ticket.
Replying to historic_bruno:
In
RotateObjectsFromCenterPoint
,m_centerPoint
should be camel casem_CenterPoint
and you don't need to initialize it (the default constructor is 0,0,0 but this line actually causes a build error in MSVC). Similarlym_angleInitialRotation
should be capitalized.I get these other build errors in VS2010:
1> TransformObject.cpp 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(555): error C2864: 'TransformObject::sRotating::rotateFromCenterPoint' : only static const integral data members can be initialized within a class 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2039: 'mUpdateVisualSelectedObjects' : is not a member of 'AtlasMessage' 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2065: 'mUpdateVisualSelectedObjects' : undeclared identifier 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2059: syntax error : ')' 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2039: 'mUpdateVisualSelectedObjects' : is not a member of 'AtlasMessage' 1>..\..\..\source\tools\atlas\AtlasUI\ScenarioEditor\Tools\TransformObject.cpp(560): error C2039: 'mUpdateVisualSelectedObjects' : is not a member of 'AtlasMessage'
follow-up: 12 comment:11 by , 9 years ago
Seems to work well, but I would make the current Ctrl behavior the default, that should be the most common and useful type of rotation. Then make the other two functions use the modifier keys.
comment:12 by , 9 years ago
Done. Replying to historic_bruno:
Seems to work well, but I would make the current Ctrl behavior the default, that should be the most common and useful type of rotation. Then make the other two functions use the modifier keys.
by , 9 years ago
Attachment: | 1213.8.diff added |
---|
this ticket depend on #1163 (Buildind Constraint)
Here is my video about implementation
http://youtu.be/2MQoelad0Is