#1223 closed enhancement (fixed)
[PATCH] Redesign Sound System
| Reported by: | Kieran P | Owned by: | stwf |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 11 |
| Component: | Core engine | Keywords: | patch |
| Cc: | Patch: |
Description (last modified by )
Redesign the sound engine. Current one is broken and full of hacks.
- During redesign, aim to solve the current issues, namely:
- Further improve sound system (#961)
- Sequential/random sounds
- Fading sounds
- Looping sounds
Attachments (5)
Change History (25)
comment:1 by , 12 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 12 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 12 years ago
| Description: | modified (diff) |
|---|
comment:4 by , 12 years ago
comment:5 by , 12 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
by , 12 years ago
| Attachment: | new_sound_manager_1.diff added |
|---|
comment:6 by , 12 years ago
OK, this version builds on mac and linux
Fully supports the SoundGroup.xml as well as allowing for control of the Sound item from Javascript.
The missing feature is for position. It seems like the implementation of this merits some discussions on the forums.
Bugs carried over from the previous code include the playing of sounds that aren't on the screen and special intensity levels which also probably needs some discussion.
comment:7 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:8 by , 12 years ago
| Keywords: | patch review added |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
comment:9 by , 12 years ago
| Keywords: | sound, music patch review → sound, music, patch review |
|---|---|
| Resolution: | → fixed |
| Status: | reopened → closed |
| Summary: | New Sound System → New Sound System [PATCH] |
comment:10 by , 12 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:11 by , 12 years ago
| Keywords: | music removed |
|---|---|
| Summary: | New Sound System [PATCH] → [PATCH] New Sound System |
comment:12 by , 12 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | [PATCH] New Sound System → [PATCH] Redesign Sound System |
by , 12 years ago
| Attachment: | patch12.diff added |
|---|
comment:13 by , 12 years ago
This patch contains the first pass of functionality for the new sound manager. All fields of the SoundGroup xml should be supported and directionality for on screen sounds includeed.
[PATCH REQUEST]
follow-up: 15 comment:14 by , 12 years ago
OK, new path. This fixes the issues with acknowledgements and some situations where the screen coordinates were not being correctly calculated. Also confirmed that sond gains are being applied correctly.
comment:15 by , 12 years ago
Replying to stwf:
OK, new path. This fixes the issues with acknowledgements and some situations where the screen coordinates were not being correctly calculated. Also confirmed that sond gains are being applied correctly.
After applying the patch and resolving a few conflicts, I ran into these build errors:
10>..\..\..\source\soundmanager\CSoundManager.cpp(24): fatal error C1083: Cannot open include file: 'soundmanager/js/JSoundPlayer.h': No such file or directory 18>..\..\..\source\main.cpp(42): fatal error C1083: Cannot open include file: 'lib/res/sound/snd_mgr.h': No such file or directory
by , 12 years ago
| Attachment: | RealPatch1.diff added |
|---|
comment:16 by , 12 years ago
THis version fixes some compiler warnings and guards against a segfault due to a missing resource, and now logs it. Loud music startup also addressed.
comment:18 by , 12 years ago
| Keywords: | review sound removed |
|---|---|
| Resolution: | → fixed |
| Status: | reopened → closed |
Old ticket: #138 Related: #685