Opened 18 years ago

Closed 15 years ago

Last modified 5 years ago

#128 closed task (fixed)

Minor fixes/improvements related to GUI — at Version 4

Reported by: Jan Wassenberg Owned by: sluzky
Priority: If Time Permits Milestone: Pre-Alpha 1
Component: Core engine Keywords: gui
Cc: gustav, gee Patch:

Description (last modified by sluzky)

  • We now get warnings whenever there is a C++ file that is empty or doesn't contain any meaningful info (e.g. stuff that would end up in the compiled static library). Accordingly: decide if CGUIScrollBarStyle.cpp and CGUIList.cpp can be removed.
  • Some parts of the GUI still use the old and obsolete PS_ERROR mechanism. Removing that would be nice, to avoid confusion. Also, localization would be helped a bit by not having error text hard-coded in English.

If a return-value-based approach is still desired (instead of tossing exceptions), we could simply assign numbers to the error definitions, rename them a bit, and be done. Otherwise, we can move that over to Philip's error mechanism, i.e. throwing exceptions. I can help out and/or do all the work - just let me know which is preferable. (old TODO entry: move GUIbase.h errors (DECLARE_ERROR) into e.g. Philip's error mechanism, remove DECLARE_ERROR, remove ps/errors.h.)

Change History (4)

comment:1 by sluzky, 15 years ago

Owner: set to sluzky
Status: newassigned

comment:2 by sluzky, 15 years ago

Description: modified (diff)

deleted the remaining CGUIList.cpp

comment:3 by sluzky, 15 years ago

Resolution: fixed
Status: assignedclosed

(In [7147]) refactoring all PS_RESULT in GUI to PSRETURN/PSERROR closes #128

comment:4 by sluzky, 15 years ago

Description: modified (diff)

gonna buff up the log for a while until all GUI settings are fixed

Note: See TracTickets for help on using tickets.