This Trac instance is not used for development anymore!

We migrated our development workflow to git and Gitea.
To test the future redirection, replace trac by ariadne in the page URL.

Opened 13 years ago

Closed 13 years ago

#1400 closed defect (fixed)

Random map fortress raises an error when Thebans selected

Reported by: FeXoR Owned by:
Priority: Nice to Have Milestone: Alpha 11
Component: UI & Simulation Keywords:
Cc: Patch:

Description

When trying to generate a random map with a players civilization set to Thebans an error occurs due to the missing wall style "theb".

Added it (just a deepcopy of Hellenes because I couldn't find templates for Thebans) and adjusted some documentation.

Attachments (2)

wall_builder.js.diff (9.1 KB ) - added by FeXoR 13 years ago.
Patch to add wall style "theb"
wall_builder.js (46.0 KB ) - added by FeXoR 13 years ago.
The fixed file in case the patch doesn't apply

Download all attachments as: .zip

Change History (11)

by FeXoR, 13 years ago

Attachment: wall_builder.js.diff added

Patch to add wall style "theb"

by FeXoR, 13 years ago

Attachment: wall_builder.js added

The fixed file in case the patch doesn't apply

comment:1 by historic_bruno, 13 years ago

For now, I would say don't use Thebans, they're not an option in game setup anyway :) Either they're a work in progress or will not be a full civ.

comment:2 by historic_bruno, 13 years ago

Milestone: Alpha 10Alpha 11

comment:3 by FeXoR, 13 years ago

I'm sorry, but "don't use them" does not make much sense to me. I didn't add the civilization Thebans but someone did and so it can be chosen in Atlas. I have no influence on what anybody selects in Atlas when generating random maps. If anybody uses Thebans on a map that using the wall_tool for every player as well (like fortress) an error will occur. I can't remove Thebans and I can't prevent anyone to select it in Atlas but I can prevent the game from raising an error and work sane... So I added this patch. It's not a big thing because it's just a deepcopy of Hellenes wall style... I add it back to Alpha 10 (only this time). Instead of changing the milestone you could have added it. The code is not much to review and if you really think the actual version of this file is better or you don't want to review the one varable name changed as well and the documentation, just add the line including "Theb"...

Version 0, edited 13 years ago by FeXoR (next)

comment:4 by FeXoR, 13 years ago

Milestone: Alpha 11Alpha 10

comment:5 by historic_bruno, 13 years ago

Component: Atlas editorUI & Simulation
Keywords: review alpha10 removed
Milestone: Alpha 10Alpha 11

Thebans moved to internal in [11858], they were only public by mistake. I'll leave this ticket open as we'll need a new patch for wall_builder once Thebans are really added :)

comment:6 by FeXoR, 13 years ago

Thanks, that sounds like the best way. Sorry for my rude words but I was tired and didn't find a more clear phrase like "Your decision but support Theband or not?" or something.

When Thebans are added it would be nice to send a note or post in the forum so I can add them properly and upload a new patch here.

Last edited 13 years ago by FeXoR (previous) (diff)

comment:7 by historic_bruno, 13 years ago

Priority: Must HaveNice to Have

comment:8 by FeXoR, 13 years ago

AFAIK this is no issue any more and can be closed.

Other changes regarding the same files are here: http://trac.wildfiregames.com/ticket/1449

Last edited 13 years ago by FeXoR (previous) (diff)

comment:9 by O.Davoodi, 13 years ago

Keywords: patch removed
Resolution: fixed
Status: newclosed
Summary: [PATCH] Random map fortress raises an error when Thebans selectedRandom map fortress raises an error when Thebans selected
Note: See TracTickets for help on using tickets.