Opened 13 years ago
Closed 13 years ago
#1400 closed defect (fixed)
Random map fortress raises an error when Thebans selected
| Reported by: | FeXoR | Owned by: | |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 11 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description
When trying to generate a random map with a players civilization set to Thebans an error occurs due to the missing wall style "theb".
Added it (just a deepcopy of Hellenes because I couldn't find templates for Thebans) and adjusted some documentation.
Attachments (2)
Change History (11)
by , 13 years ago
| Attachment: | wall_builder.js.diff added |
|---|
comment:1 by , 13 years ago
For now, I would say don't use Thebans, they're not an option in game setup anyway :) Either they're a work in progress or will not be a full civ.
comment:2 by , 13 years ago
| Milestone: | Alpha 10 → Alpha 11 |
|---|
comment:3 by , 13 years ago
I'm sorry, but "don't use them" does not make much sense to me. I didn't add the civilization Thebans but someone did and so it can be chosen in Atlas. I have no influence on what anybody selects in Atlas when generating random maps. If anybody uses Thebans on a map that using the wall_tool for every player as well (like fortress) an error will occur. I can't remove Thebans and I can't prevent anyone to select it in Atlas but I can help preventing the game from raising an error and work sane... So I added this patch. It's not a big thing because it's just a deepcopy of Hellenes wall style... I add it back to Alpha 10 (only this time). Instead of changing the milestone you could have added it. The code is not much to review and if you really think the actual version of this file is better or you don't want to review the one varable name changed as well and the documentation, just add the line including "Theb"...
comment:4 by , 13 years ago
| Milestone: | Alpha 11 → Alpha 10 |
|---|
comment:5 by , 13 years ago
| Component: | Atlas editor → UI & Simulation |
|---|---|
| Keywords: | review alpha10 removed |
| Milestone: | Alpha 10 → Alpha 11 |
Thebans moved to internal in [11858], they were only public by mistake. I'll leave this ticket open as we'll need a new patch for wall_builder once Thebans are really added :)
comment:6 by , 13 years ago
Thanks, that sounds like the best way. Sorry for my rude words but I was tired and didn't find a more clear phrase like "Your decision but support Theband or not?" or something.
When Thebans are added it would be nice to send a note or post in the forum so I can add them properly and upload a new patch here.
comment:7 by , 13 years ago
| Priority: | Must Have → Nice to Have |
|---|
comment:8 by , 13 years ago
AFAIK this is no issue any more and can be closed.
Other changes regarding the same files are here: http://trac.wildfiregames.com/ticket/1449
comment:9 by , 13 years ago
| Keywords: | patch removed |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| Summary: | [PATCH] Random map fortress raises an error when Thebans selected → Random map fortress raises an error when Thebans selected |

Patch to add wall style "theb"