Opened 5 years ago

Closed 5 years ago

#1427 closed enhancement (fixed)

[PATCH] Clarification of usage of s3tc

Reported by: pcpa Owned by:
Priority: If Time Permits Milestone: Alpha 11
Component: Build & Packages Keywords: patch
Cc: Patch:


I made a 0ad package and requested it to be reviewed, for packing in Fedora, but would like to have some information about possible legal issues with s3tc.

For safety, I made a patch to disable nvtt and use the existing --without-nvtt option, so that it will not require the implementation in nvidia-texture-tools.

The information I would like to have is

o Once built without nvtt, it will only have the implementation in the

bundled but not built nvtt tree?

o The textures in 0ad-data are already compressed? From my understanding,

that would mean it could just send it to the graphics engine, but then, it would have issues, for example with things like team coloring, or is that just an alpha, and the color is in the model below it?

Thanks for any information, and many thanks for the great open source project!

Attachments (1)

0ad-r11863-without-nvtt.patch (1.3 KB) - added by pcpa 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by pcpa


comment:1 Changed 5 years ago by leper

Keywords: patch review added
Milestone: BacklogAlpha 11
Summary: Clarification of usage of s3tc[PATCH] Clarification of usage of s3tc

As far as I know (but don't take any of this for granted) s3tc is only used in nvtt, so your patch should work. The source code will still be there, but it won't be built thus it won't be present in the resulting binary (or rather there won't be any nvtt libs). (This is without regarding CompressedTextures)

The textures (in 0ad-data) are already converted (cached) during the run of the archive builder (which generates the

Regarding the patch: I would use something like ...alse" ] && [ "$without_nvtt" = "false" ]; instead of using -a .

On a related note: It would be nice if you referred to SubmittingPatches when doing so. It's also nice to leave a comment if you attach a patch to a ticket.

Last edited 5 years ago by leper (previous) (diff)

comment:2 Changed 5 years ago by ben

In 12127:

Adds --without-nvtt option to so we don't attempt to build NVTT in that case, based on patch by pcpa. Refs #1427

comment:3 Changed 5 years ago by Ben Brian

Keywords: review removed

comment:4 Changed 5 years ago by Kieran P

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.