This Trac instance is not used for development anymore!

We migrated our development workflow to git and Gitea.
To test the future redirection, replace trac by ariadne in the page URL.

Changes between Initial Version and Version 1 of Ticket #1449, comment 19


Ignore:
Timestamp:
06/18/12 02:08:55 (13 years ago)
Author:
vts

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1449, comment 19

    initial v1  
    7878
    7979  - In `placeCircularWall`, near the end of the nested for loop, it looks like you can reuse the computed values of `targetX` to `targetY`
    80     for the values of `x` and `y`. No need to do the computation again. Also, shouldn't it cap `maxAngle` at `2PI` (but then I don't quite understand what that `if (maxAngle >= 2*PI - 0.001)` is all about.
     80    for the values of `x` and `y`. No need to do the computation again. Also, shouldn't it cap `maxAngle` at `2PI`? Do you intentionally support angles that are bigger than a complete revolution? If so, then I'm a bit confused what that `if (maxAngle >= 2*PI - 0.001)` is all about.
    8181   
    8282  - Some statements appear to have missing semicolons at the end. JS does not require semicolons at the end of statements, but we