Changes between Version 1 and Version 2 of Ticket #1449, comment 21
- Timestamp:
- 06/20/12 18:54:50 (13 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #1449, comment 21
v1 v2 3 3 I don't know though why the patch is not already added. It fixes 3 bugs and is better then the versions before! That doesn't mean whe have to stop the discussion ofc. 4 4 5 I will listen to advises (and always have) and try to make changes appropriate to them, but I didn't add this patch to discuss everything (though I'm grateful for that happening) but to fix bugs (that would be fixed after my second upload already). IMO the important thing about patches is that they fix the issue while discussions and advises can be made in the forum (in this case http://www.wildfiregames.com/forum/index.php?showtopic=15750) and I will upload new versions there until a bug is found (which most of the time happens if new content was added that doesn't take into account RMGEN like the celt split civs here).5 I will listen to advises (and always have) and try to make changes appropriate to them, but I didn't add this patch to discuss everything (though I'm grateful for that happening) but to fix bugs (that would be fixed after my second upload already). IMO the important thing about patches is that they fix the issue while discussions and advises can be made in the forum (in this case http://www.wildfiregames.com/forum/index.php?showtopic=15750) and I will upload new versions there until a bug is found in the SVN version (which most of the time happens if new content was added that doesn't take into account RMGEN like the celt split civs here). 6 6 7 7 So is the idea just to, while you're at it, go through the whole stuff? Then we can do it in the forum and if you see fit you add a patch. But if errors occur and a patch is available that fixes that, it should be added ASAP IMO despite other things that should be changed in that area of code.
