[PATCH] Prevent land fauna from attacking ships

[Peter]

When ship attack lion, lion reply and attack ship, but he gets "into" the ship, to the core for attack, It causes of graphic issue. Lion just get absorbed by ship. And the second, I wish you could highlight cursos.And made spears a lil bit bigger, cuz sometimes hard to see it when grass on a background

[historic_bruno]

Hmm sounds like multiple problems. We should prevent ships from attacking land units and vice versa. And most gaia animals should stay away from water, especially deeper water, I think that could be done with passability classes.

[erraunt]

The patch mentioned above solves nothing. (will change it as soon as I have a proper one)

[erraunt]

Ok, so I came up with this simple if which prevent's non SeaCreature(s) from attacking Ship(s). This solves the problem from this ticket. Anyways I believe it is extremely ugly, if anyone comes up with a neater idea, express it here and I will be more then glad to execute it (if one wants so of course).

[erraunt]

After consulting this with Imarok on the IRC, I prepared an alternative solution - added Ship to the restricted classes of all the animal templates, it has some downside - if someone creates a SeaCreature based on one of these templates, it will not be able to attack Ships (Shark is created like that but it is not able to attack anyways so it is not a problem), or if someone does not used this templates he may create a land animal able to attack a Ship. To me both solutions are not that nice but at the same time both resolve the problem.

[fatherbushido]

based on erraunt patch, removes useless identity entry, adress defensive animal case

[fatherbushido]

merge some elephant templates in the same move

[elexis]

• It was always fun when gaia elephants destroyed towers, civic centers or ships, because some arrow missed the target and hit the elephant :D

If there is a graphical issue with gaia elephants attacking ships, then there is likely one with war elephants too and many other units?

Does this also occur when just walking to the target instead of attack-moving there?

Why do structures become restricted?

• IMO it were nice to use relative for Health, Loot, ResourceSupply and where else possible

[fatherbushido]

• Yes, perhaps elephants should still attack structure.
• The situation is different imo for players units and for animals (gaia animals will be stuck at the coast trying to attack the ship)
• Indeed (just use addition as there'll be issue with mul and integers for loot and resourcesupply)

[elexis]

Feel free to correct the milestone with a commit if it's well tested and addresses the comments. Relative templates probably not that crucial.

[fatherbushido]

needs to be worked and thought again

[elexis]

The empty identity components were removed already. fb's patch still seems ready to go mostly, so putting this under rfc. Would be nice if he or me finds the time to put it to phabricator or commit it. Also with regards to the attack cursor issue, females shouldn't be able to attack ships.

[elexis]

As we can see, unifying the Footprint is not advisable:

[elexis]

From left to right, current stats:

African Bush (800 food, 300 HP, 75 XP, biggest footprint) Asian (650 food, 250 HP, 60 XP) North African (500 food, 200 HP, 50 XP, smallest footprint)

Loot was added for all eles in r10473

[elexis]

North African Elephant added without crush damage in r7259, added other damage in r9487 but forgot to add the crush damage. African Bush Elephant added with 10 crush damage in r8363. Asian Elephant added with 20 crush damage in r9900.

[elexis]

In 19295:

Merge duplicate elephant templates to a new inherited template. Patch by fatherbushido, refs #1487.

Prevent these elephants from attacking structures, which can happen incidentally if the animal is attacked by garrisoned arrows that were meant to hit attacking players and because that is unexpected to players and had been reported as a bug and cheating players.
Prevent them from attacking ships, because they can't reach them in most cases.

Unifty their Attack stats that had neglible differences, besides the missing Crush damage of the North African Elephant variant, forgotton to make consistent in rP9487 with rP8363.
Add the large passability class to the North African and Asian elephant, which was forgotton by rP16868.

[elexis]

• Agreeing to keep the Loot values (removing Loot of the African Bush elephant must have been oversight).
• Agreeing to add template_unit_fauna_hunt_defensive_elephant.xml to the root tempalte directory, as that contains all inherited ones.
• Agreeing that changing hp, xp and resource supply stats to additive relative numbers doesn't help, because if someone changes the parent template significantly, the relative numbers in the child templates become wrong too
• Agreeing that the infant template shouldn't inherit the new parent template, because it only shares Sound
• Agreeing that Structure should become restricted, because it is unexpected that gaia elephants destroy garrisoned civic centers that incidentally attacked a near elephant when the arrows intended to hit attacking enemies instead. This is commonly perceived as a bug, so it's better to remove that ability from the Gaia elephants.
• The empty Identity components had been nuked already, so that, besides the Loot part, is the only thing that was rebased / changed from your patch.
• The non-elephant changes should become a separate diff.

Thanks for the great cleanup patch!

[elexis]

In 19296:

Prevent animals from attacking siege engines and ships, prevent females from attacking ships and heroes.
Overviewed by fatherbushido, refs #1487.

[elexis]

In 19303:

Fix an oversight in 19296: Spartan females should remain able to attack heroes.

Differential Revision: D226
Patch By: Grugnas
Refs #1487