Changes between Initial Version and Version 1 of Ticket #1516, comment 14


Ignore:
Timestamp:
Jul 22, 2012, 12:38:15 AM (12 years ago)
Author:
historic_bruno

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1516, comment 14

    initial v1  
    1 About the patch: line 338 in `project_create()` looks redundant because the flag is already set a few lines earlier in `project_set_build_flags()`. I'm not sure what was intended.
     1About the `premake4.lua` patch: line 338 in `project_create()` looks redundant because the flag is already set a few lines earlier in `project_set_build_flags()`. I'm not sure what was intended.
    22
    33To address the comment on line 332, I don't think we should check for minimal-flags before adding to the rpath, since that will most likely result in a broken build if bundled Spidermonkey was used. The issue was mostly that it's unnecessary if `--with-system-mozjs185` is used and the patch fixes that :)