[PATCH] Change player color in the gamesetup

[O.Davoodi]

Discussion here http://www.wildfiregames.com/forum/index.php?showtopic=16318

[Adrián Chaves]

Patch based on the work started by Spahbod.

[Adrián Chaves]

Based on the previous work that Spahbod posted in the forums, I’m attaching a patch which in addition does the following:

• Keeps color display names in a string of their own, in preparation for the internationalization feature (#67).
• Sorts colors in the drop-down list by color.

Although I was planning on doing so, I refrained from including ancient-themed colors. I think that needs more discussion (even if we all agree on doing it, we still need to agree on the RGB and display name of the values to be added), and I’ll try to bump the forum thread about it.

Adding new colors is as easy as editing the relevand JavaScript object in code. In the future, we could even move such data into a separated .json file if needed.

Note also that the implementation is prepared to deal with a color defined in simulation/data/player_defaults.json not being available in the JavaScript object that defined colors and color names in the GUI code. This is to keep simulation and gui code separated, as they should not depend in one another. When this occurs (a color is unknown in the GUI), the drop-down list shows empty, and lets you either keep the current, unknown color, or change to another color; if you change, you can not select back any unknown color. (you’ll probably need to actually read the code to understand this, just look for “-1” in the patch)

[sanderd17]

Can you make this patch work for skirmish maps too?

And the patch causes some problems when using a low resolution. The colour picker should be made smaller. Maybe only showing coloured squares instead of colour names?

[Stan]

WIP patch, it's currently broken for some reason, help is appreciated. I can't get the drop down to appear

[Stan]

Note that the json file will be removed, I added it in the patch, cause I forgot to delete it. It actually use default_players to get the colors.

[elexis]

• Please create the patch relatively to the trunk directory, so that we can apply the patch from there

settings.js

• PlayerColors instead of Player_Colors
• the code was updated

gamesetup.js

• ++o instead of o++. I'd prefer n or i over o. But even better would be to remove that loop and just use array.find(...).length if possible.

• getIndexOfColor don't need to do var playerColorsSorted = getPlayerColorsSorted(); every cycle, only once. replace the for loop by a call to findIndex

• rgbToHsl - exact same function as in lobby.js. we should annoy the devs with a ticket that moves rgbToHsland hslToRgb to a new file common/color.js (the other color functions from lobby.js are almost all baloney, for example the rainbow colored pony-nicknames, and must be deleted in #3383 or so instead of being moved)

getPlayerColorsSorted()

• early return
• [] instead of new Array()
• replacing for with map might be possible
• if the block has only one line, the brackets can be removed (unless neede for aesthetics)
• let instead of var in nested blocks so that theoretically a bit of performance can be saved
• outerloop: try to avoid jumping to labels, I bet we can use a map or something similar for the inner loop and omit the problem that way

copyRgbValuesFromColorIntoColor

• whitespace

gamesetup.xml

• a tab missing
• the position/size you gave the color picker is almost identical to the position of the player assignment dropdown. That might be why the former is invisible (but shows the tooltip when hovering) and why the latter seems disabled. The values are "left top right bottom". The "right" value of the left element must be smaller than the "left" value of the right element, etc. Where do you want to palce the color picker? Left of the playername? The xml should be moved to the correct location too.

Some rtfm's: ​https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf and the other array functions linked there ​https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions ​http://trac.wildfiregames.com/wiki/Coding_Conventions

[Stan]

WIP2

[Stan]

Working Color Dropdown

[Stan]

Some Cleanup

[elexis]

• hardcore cleanup
• gaia color not selectable anymore
• colors are actually used ingame after selecting them

TODO:

• only host can chose colors
• dropdown element should list only colors that are not picked yet
• discovered a dropdown list GUI bug. looks like the width of the scrollbar is subtracted even if the scrollbar doesn't exist. Might also have something to do with the xml / width.

[Stan]

• As agreed on IRC, it's better for now that only the host can change colors, so that there is no fight about it.
• There is no need for not showing colors, since we swap between them when they are being used.
• Only the gui bug remains on certain resolutions. see #3415

[elexis]

Mock language that contains the longest strings found in the translations of r17026.