Changes between Initial Version and Version 1 of Ticket #1646, comment 5


Ignore:
Timestamp:
Jan 12, 2013, 12:01:05 AM (7 years ago)
Author:
zoot
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1646, comment 5

    initial v1  
    55Would it not be better to do that when multiple requirements are implemented? Then we will know how the format will look.
    66>  * The required count appears red, as if it's an unmet requirement. It will remain red even when the count is satisfied, which is an inconsistency in the UI. The logic would only grow messier to solve that with conditional colors or visibility.
    7 This is not strictly true. When the count is satisfied, the check on [https://github.com/zootzoot/0ad/compare/unmet-requirements-tooltips#L0R673 unit_commands.js:673] will fail, and the string won't shown in the tooltip.
     7This is not strictly true. When the count is satisfied, the check on [https://github.com/zootzoot/0ad/compare/unmet-requirements-tooltips#L0R673 unit_commands.js:673] will fail, and the string won't be shown in the tooltip.
    88>  * I think the logic in `GetRequirementsVars()` should be combined with `getFormattedRequirementsTooltip()`
    99`GetRequirementsVars()` is really just a glorified getter, modelled on the structure of `CheckTechnologyRequirements()`. The idea being that all the logic for parsing technology requirements should be contained in the component to which it is native.