Opened 12 years ago

Closed 8 years ago

Last modified 8 years ago

#1670 closed defect (fixed)

[PATCH] Gatherers do not drop off last batch of resources before next queued order

Reported by: zoot Owned by: mimo
Priority: Should Have Milestone: Alpha 20
Component: UI & Simulation Keywords:
Cc: Patch:

Description

If a worker is gathering from e.g. a farm field and that worker has a pending queued order, it will keep gathering and shuttling back to a dropsite until the resource node is depleted. However, it fails to drop off the last batch of resources it gathered before the resource node depleted, instead beginning working on the queued order immediately, carrying the batch of resources with it.

Attachments (1)

ticket1670.patch (1.9 KB ) - added by mimo 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Deiz, 12 years ago

How should this behave?

At present, when the resource is exhausted and the unit has no queued orders, it will attempt to find another nearby resource of the same type, and if that fails, will drop off its carried resources at the nearest dropsite.

I think that a gatherer with queued orders should always drop its resources off if it's carrying something and its next order isn't another gather order. If the next order is a gather order, it should drop resources off if either a) it's at its carrying capacity or b) the queued gather order is for a different type than what's being carried.

On a somewhat-related note, it seems to me that Gather orders should push ReturnResource orders in front of themselves if a unit has been told to gather the type that it's already carrying and it can't carry any more. The current behaviour has the unit walk to the target, try to gather, fail, and then return to the dropsite, a complete waste of time.

comment:2 by wraitii, 8 years ago

Milestone: BacklogAlpha 20

Hasn't this been fixed?

comment:3 by elexis, 8 years ago

Reminds me of #1791 #3144 #3479 #3274

by mimo, 8 years ago

Attachment: ticket1670.patch added

comment:4 by mimo, 8 years ago

Component: Core engineUI & Simulation
Keywords: review added
Summary: Gatherers do not drop off last batch of resources before next queued order[PATCH] Gatherers do not drop off last batch of resources before next queued order

comment:5 by mimo, 8 years ago

Owner: set to mimo
Resolution: fixed
Status: newclosed

In 17521:

drop resources before switching to next queued order, fixes #1670

comment:6 by mimo, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.