Opened 12 years ago
Last modified 5 years ago
#1682 new enhancement
[PATCH] Minor updates to LICENSE.txt
Reported by: | pcpa | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Backlog |
Component: | Build & Packages | Keywords: | patch |
Cc: | paulo.cesar.pereira.de.andrade@… | Patch: |
Description (last modified by )
It is desirable to have a more descriptive LICENSE.txt for Linux distros that want to package 0ad. At first I would suggest using information from http://anonscm.debian.org/viewvc/pkg-games/packages/trunk/0ad/debian/copyright?view=markup but since I also made a license review for my Fedora 0ad review request, I made a simple patch with what should matter for builds from source. It does not highlight possible issues with s3tc, neither the fact that the LICENSE.txt details in some cases information about files not added to the source tarball.
Attachments (2)
Change History (12)
by , 12 years ago
Attachment: | license-linux.patch added |
---|
comment:1 by , 12 years ago
Cc: | added |
---|---|
Keywords: | patch review added |
Summary: | Minor updates to LICENSE.txt → [PATCH] Minor updates to LICENSE.txt |
follow-up: 4 comment:2 by , 11 years ago
A couple of notes:
/source/tools/fontbuilder2
IBM/CPL
/source/tools/replayprofile
MIT or dual MIT and GPL
Those are licenses for libraries used by tools (IBM
/CPL
for Packer.py
; MIT
and GPL
for jquery.js
; MIT
for jquery.flot.js
/jquery.flot.navigate.js
). I'm not sure what license the tools themselves have, probably "GPL version 2 (or later)" as anything else inside the 'source' directory (unless another license is explicitly specified for some file/subfolder).
Re libraries/ , in LICENSE.txt
already stated "Various - see individual directories and files for details", I'm not sure that is worth bloating the root license file with all those details, maybe we can do it the same way as it is done with art/ (/binaries/data/mods/art) (which has its own license.txt linked from the main one), i.e. put another license.txt
into libraries/ with all the details and refer it from the main LICENSE.txt
.
/build/premake
BSD
This is the license of premake itself, I think that folder also contains some our custom scripts or something. Would be good to clear this too.
comment:3 by , 11 years ago
Yeah I'd rather have a license.txt
for each of the tools
and libraries
directories, at least the ones that aren't 100% written by WFG. As in the above examples, I'd don't know that we can give sufficient detail in a single file. It might be more convenient for some people, but it's also more difficult to read and maintain.
comment:4 by , 11 years ago
Replying to fcxSanya:
I'm not sure what license the tools themselves have, probably "GPL version 2 (or later)" as anything else inside the 'source' directory (unless another license is explicitly specified for some file/subfolder).
We discussed this with Philip on IRC yesterday: see discussion here from 19:07 to 20:07.
follow-up: 6 comment:5 by , 11 years ago
I've attempted to update the license based on the above comments, proposing a new source/tools/LICENSE.txt
which details each subdirectory.
A few are currently unknown:
- autobuild2 - I can't tell what's written by Philip or using bits of library code from elsewhere. Also unclear on license of Visual Studio sample code
- fontbuilder2/FontLoader.py - adapted from code posted on http://cairographics.org/freetypepython/
- selectiontexgen - written by vtsj, no explicit license (yet)
- templatessorter - written by fcxSanya, same
- webservices - code used from various sources and some likely written by Philip
comment:6 by , 11 years ago
Replying to historic_bruno:
I've attempted to update the license based on the above comments, proposing a new
source/tools/LICENSE.txt
which details each subdirectory.
Looks good.
- templatessorter - written by fcxSanya, same
We can distribute it under MIT to be consistent with the Philip's tools license.
by , 11 years ago
Attachment: | license-updates.patch added |
---|
comment:7 by , 11 years ago
Thanks for clarifying that :)
The new patch adds a libraries/LICENSE.txt
and organizes the root LICENSE.txt
into alphabetical order. I think this covers everything that would be distributed with the game, except the contents of /docs
and some of /binaries
- e.g. there is "art" in there outside of the public mod. Then the unknowns listed above and finishing build/
should be all that's left.
comment:9 by , 11 years ago
Keywords: | review removed |
---|
comment:10 by , 5 years ago
Description: | modified (diff) |
---|
In r22457:
Updates library LICENSE.txt for libsodium and macOS patches
license-linux.patch