Changes between Initial Version and Version 1 of Ticket #1707, comment 37


Ignore:
Timestamp:
Jul 26, 2013, 9:58:35 AM (11 years ago)
Author:
wraitii

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1707, comment 37

    initial v1  
    11Alright, uploaded two things... I noticed an issue with the entity map: if the last element is made invalid, the iterator will crash because of bad memory access. This is bad.
    22
    3 RangeManagerOpt.2 is an updated version that reverts iterator changes and makes the RangeManager check for validity in the loops. This is not too nice but works cleanly.
     3RangeManagerOpt.2 is an updated version that reverts iterator changes and makes the RangeManager check for validity in the loops. This is not too nice but works cleanly.
    44
    5 EntityMap.h is an updated version of the entityMap that works with the original RangeMangerOpt.patch, which checks on "erase" if the reased element is the last, and if so removes it from m_Data so that the last element is always valid. It seems to work but it could be slow.
     5EntityMap.3.h is an updated version of the entityMap that works with the original RangeMangerOpt.patch, which checks on "erase" if the reased element is the last, and if so removes it from m_Data so that the last element is always valid. It seems to work but it could be slow.
    66
    77I've updated both cases to take into account mrf' observations.