Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#1712 closed defect (fixed)

[PATCH][ATLAS] Music and ambient sounds keep playing after simulation test

Reported by: historic_bruno Owned by: trompetin17
Priority: Should Have Milestone: Alpha 18
Component: Atlas editor Keywords:
Cc: Patch:

Description

Once an Atlas simulation test is reset, any currently playing music and ambient sounds should stop.

Attachments (3)

sound_1712.patch (2.3 KB) - added by trompetin17 5 years ago.
Fixed
1712.patch (3.0 KB) - added by trompetin17 5 years ago.
1712_dic.diff (2.3 KB) - added by trompetin17 5 years ago.

Download all attachments as: .zip

Change History (25)

comment:1 Changed 7 years ago by stwf

Milestone: BacklogAlpha 14
Owner: set to stwf

comment:2 Changed 6 years ago by Kieran P

Milestone: Alpha 14Alpha 15

comment:3 Changed 6 years ago by wraitii

Milestone: Alpha 15Alpha 16

comment:4 Changed 6 years ago by Michael D. Hafer

Milestone: Alpha 16Alpha 17

comment:5 Changed 6 years ago by historic_bruno

Owner: stwf deleted

comment:6 Changed 5 years ago by trompetin17

Keywords: review patch added
Owner: set to trompetin17
Summary: [ATLAS] Music and ambient sounds keep playing after simulation test[PATCH][ATLAS] Music and ambient sounds keep playing after simulation test

comment:7 Changed 5 years ago by trompetin17

When you press reset, the music is fade to silent

comment:8 Changed 5 years ago by sanderd17

Can you rename your methods to "pauseMusic"? We try to make a difference between sound and music (at least in the higher level, not in the lower level, as it all ends up with the same code anyway).

Sound is the collection of event sounds, selection sounds, shouts, ... while music is the background music.

Changed 5 years ago by trompetin17

Attachment: sound_1712.patch added

Fixed

comment:9 Changed 5 years ago by trompetin17

Done

comment:10 Changed 5 years ago by sanderd17

Cc: historic_bruno added

Hmm, looking closer at this patch, I'm not sure if the music should stop on pause too, or if the soundmanager should just be reset when the game is reset.

comment:11 Changed 5 years ago by trompetin17

Hi anything new about this ticket?

comment:12 Changed 5 years ago by Itms

Keywords: review removed

Hi trompetin, sorry for having taken so much time before looking back at your patch.

Concerning the code itself, don't forget to update the copyright date of the source files you modify.

About the functionality, I agree with sanderd17 saying that the music should not be just considered as "paused", but the sound manager should be reset when you click the "Reset" button. I don't think the music should stop when hitting "Pause".

Given that I saw you active recently, there is a chance you can write a new patch before release (feature freeze will happen on Sunday 14th and we'll have to review the patch before). Can you tell us if you think it's possible? If not, no worries, just postpone it to A18 and we'll be quicker at reviewing next time ;)

Thanks for your work on this!

comment:13 in reply to:  12 Changed 5 years ago by trompetin17

DONE!, the music only "stop" when you press reset

Replying to Itms:

Hi trompetin, sorry for having taken so much time before looking back at your patch.

Concerning the code itself, don't forget to update the copyright date of the source files you modify.

About the functionality, I agree with sanderd17 saying that the music should not be just considered as "paused", but the sound manager should be reset when you click the "Reset" button. I don't think the music should stop when hitting "Pause".

Given that I saw you active recently, there is a chance you can write a new patch before release (feature freeze will happen on Sunday 14th and we'll have to review the patch before). Can you tell us if you think it's possible? If not, no worries, just postpone it to A18 and we'll be quicker at reviewing next time ;)

Thanks for your work on this!

comment:14 Changed 5 years ago by stanislas69

Keywords: review added

Changed 5 years ago by trompetin17

Attachment: 1712.patch added

comment:15 Changed 5 years ago by trompetin17

Changed Pause to Reset

comment:16 Changed 5 years ago by Itms

Resolution: fixed
Status: newclosed

In 15734:

Stop music when resetting the simulation test mode in Atlas.

Patch by trompetin17, fixes #1712

comment:17 Changed 5 years ago by Itms

Cc: stwf historic_bruno removed
Keywords: patch review removed

Thanks for the patch! :)

comment:18 Changed 5 years ago by stanislas69

Resolution: fixed
Status: closedreopened

If the simulation is running when you create a new map, the music keeps playing.

Choice 1 : Prevent the player from creating a new map when simulation is running

Choice 2 : Reset Sound State on Map Create.

comment:19 Changed 5 years ago by Itms

Milestone: Alpha 17Alpha 18

Changed 5 years ago by trompetin17

Attachment: 1712_dic.diff added

comment:20 Changed 5 years ago by trompetin17

Keywords: review Atlas patch added

I fixed this one, please review 1712_dic.diff please

comment:21 Changed 5 years ago by Itms

Resolution: fixed
Status: reopenedclosed

In 16084:

Stop music in Atlas when reloading a map, patch by trompetin17, fixes #1712.

comment:22 Changed 5 years ago by Itms

Keywords: review Atlas patch removed

Thanks for the patch :)

Note: See TracTickets for help on using tickets.