Changes between Initial Version and Version 1 of Ticket #1771, comment 8
- Timestamp:
- 05/22/13 21:50:37 (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #1771, comment 8
initial v1 2 2 * In the new `CModel::RemoveFlagsRec` function, you are checking if the `MODELFLAG_IGNORE_LOS` flag is being removed, but then ignore LOS, where I think it should be doing the opposite (not ignoring LOS) 3 3 * In `CCmpVisualActor::InitModel`, where you are setting material defines, I think those are only going to apply to the parent model, not to all the sub-models recursively (e.g. props) 4 * Also there's no reason to set modelFlagsto 0 before adding the flag, in fact, there's no need to use the variable at all, it can be passed directly into `RemoveFlagsRec`4 * Also there's no reason to set `modelFlags` to 0 before adding the flag, in fact, there's no need to use the variable at all, it can be passed directly into `RemoveFlagsRec` 5 5 6 6 However, because it's not only flags that need to be recursively removed but also materials that need to be defined, I have modified the original patch to use a `CModel::RemoveShadowsRec` function instead. This patch seems to work, except the decal on some preview models still receives a shadow, which is slightly annoying.
