[PATCH] Hero button

[historic_bruno]

The session UI should have a hero button. When the player has a living hero, it will show the portrait and any useful stats (e.g. health). When the button is pressed, the camera should focus on the hero. The button should appear consistent with the session UI style.

Here's an old mockup as an example:

[historic_bruno]

Old mockup from Michael

[michael]

Note, we'll probably have to move the framerate counter to somewhere else, which shouldn't be much of a hassle, except deciding where to put it.

[Manuel Núñez]

I have a wip patch but I'm wondering two issues:

• Where should I move the framerate counter?
• Should the portrait include a health bar?

[Manuel Núñez]

The patch moves the framerate counter to the right top of the screen and do not include a health bar in the hero button.

The button behaves as the group buttons. Single clic to select and double clic to select and center camera.

The tooltip is quite similar to the one proposed in the mockup.

[Manuel Núñez]

Fps counter moved slightly down, just below time counter.

Removed unnecessary Select function.

[Yves]

I think it should support displaying multiple heros. Normal games are restricted to one hero but there could be multiple heros in screnarios or campaigns.

[Manuel Núñez]

The patch keeps track of multiple heroes in Player component, however the changes purposed for the session.xml file add only one button object. Nevertheless, It would be very easy to extend it to show several heroes.

Assuming we have to support multiple heroes... how many should be supported?

[Yves]

I think it should display all heroes but do something smart if there are so many heroes that it would cover too much of the screen (like making it scrollable or scaling the images down). But I think for the moment it's fine to just add all heroes and don't cover the case where there are too many (if you don't want to do that work now to cover such a special case). I think the UI has to become more flexible in the future anyway and such cases can be covered once the UI offers more features.

[Yves]

If you place a Mill you get this error:

ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: JavaScript error: simulation/components/Player.js line 513 TypeError: cmpIdentity is null ([object Object])@simulation/components/Player.js:513 GetFormationUnitAIs([object Array],1)@simulation/helpers/Commands.js:1146 ProcessCommand(1,[object Object])@simulation/helpers/Commands.js:136 TryConstructBuilding(1,[object Object],false,[object Object])@simulation/helpers/Commands.js:800 ProcessCommand(1,[object Object])@simulation/helpers/Commands.js:262
ERROR: Failed to call ProcessCommand() global script function

[alpha123]

This does seem to break building placement with the above error for all buildings (not just mills) over here.

But the button looks great. :D

[alpha123]

Turns out it was a pretty trivial fix; you simply forgot to check if cmpIdentity was undefined a few times.

I fixed that, and also took the liberty of adding a hotkey for it, currently bound to ' (it's near the , and . hotkeys, which select all idle warriors/workers).

' cycles through living heroes, Shift+' adds them to the selection, and Alt+' selects all heroes.

[alpha123]

Fixes a bug and adds a hotkey.

[alpha123]

Fix a couple of little bugs with the hotkey. Should be very solid now.

[alpha123]

I opted to remove the hotkey, because I ended up refactoring the code so that I could use it for cycling any entity. I'll put the hero hotkey along with some building cycling hotkeys in another patch.

[alpha123]

Removed hotkey (moved to another ticket)

[leper]

Fixed in r13339.

Thanks for the patches.

[historic_bruno]

Bug Report

[alpha123]

Figures. The one thing I didn't test.... :P

Trivial fix though.

[alpha123]

Fix errors when attempting to center on a garrisoned hero

[fabio]

It would be nice to have the hero icon become reddish when his healt is low. Similar to the building icon when you have not enough resources to build them. Let me know if you want a new ticket for this.

[leper]

In 13346:

Fix errors when the hero is garrisoned. Patch by alpha123. Refs #1802.

[leper]

A new ticket for that would be nice, maybe add something like centering on the building the hero is garrisoned in too. (Could be a simple ticket for someone new to our codebase)

[fabio]

See #1902.

[elexis]

In 23089:

Decouple panel entities code from session code and use class notation, refs #5387, #3000, #1902, #1802, rP18361.

Change the logic to only insert/delete buttonhandlers on ownershipchange and update only the entitystate dependent part on simulation update.

Differential Revision: ​https://code.wildfiregames.com/D2387