Changes between Initial Version and Version 1 of Ticket #1859, comment 1


Ignore:
Timestamp:
Mar 11, 2013, 10:08:59 AM (11 years ago)
Author:
wraitii

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1859, comment 1

    initial v1  
    11Uploaded a new patch... So basically I've given a good look at the code and it seems like Myconid was actually doing the caching to some extent, only he did it in a way that I think was pretty convoluted. The above patch does basically the same thing in a simpler to read way. It caches only the first sampler, not the other ones (which Myconid's did) but there is less overhead for other things so it balances that. The lag caused by binding texture is completely irrelevant anyway as it's incredibly small compared to the cost of actually rendering the models ( < 1%). It could however be updated to cache all textures but I'm not sure how interesting that would be since sorting is only done against the first texture (could speed up trees, perhaps).
    22
    3 Not too sure why there was a definition for "materialBuckets[key" so if you have an idea, do tell me.
     3Not too sure why 2 steps were necessary to push models in "materialBuckets[key]" so if you have an idea, do tell me.