Changes between Initial Version and Version 1 of Ticket #1910, comment 3


Ignore:
Timestamp:
Jun 9, 2013, 1:11:00 AM (11 years ago)
Author:
zoot

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1910, comment 3

    initial v1  
    1 Not a full review or anything, but from a quick glance I'm a bit confused as to why you choose to implement this as system component? Why not make it a regular component that can be used by templates that require the splash damage effect? Gameplay components should ideally never be implemented as system components, since they need to be hardcoded into the engine, reducing moddability.
     1Not a full review or anything, but from a quick glance I'm a bit confused as to why you choose to implement this as a system component? Why not make it a regular component that can be used by templates that require the splash damage effect? Gameplay components should ideally never be implemented as system components, since they need to be hardcoded into the engine, reducing moddability.
    22
    3 I would also suggest giving your component a more descriptive name, like DeathBlast or something, or people will confuse it with other components concerned with damage.
     3I would also suggest giving your component a more descriptive name, like `DeathBlast` or something, or people will confuse it with other components concerned with damage.