Changes between Version 2 and Version 3 of Ticket #1910, comment 32


Ignore:
Timestamp:
Oct 18, 2016, 11:01:11 PM (8 years ago)
Author:
fatherbushido

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1910, comment 32

    v2 v3  
    1 all that seems nice.
    2 i forgot, as leper said in a previous comment, you can save an identation level in getplayerstodamzge by doing return at l76 after the if and removing else
    3 for 7, i mean that you call a method of the attack component of an entity for wich you have call the destroy order (it wouldn t be a matter for the damage component wich is a system component), but as the destroying of an entity is slow, perhaps it (luckily) works.
     1- all that seems nice.
     2- i forgot, as leper said in a previous comment, you can save an identation level in getplayerstodamzge by doing return at l76 after the if and removing else
     3- for 7, i mean that you call a method of the attack component of an entity for wich you have call the destroy order (it wouldn t be a matter for the damage component wich is a system component), but as the destroying of an entity is slow, perhaps it (luckily) works.