Changes between Initial Version and Version 47 of Ticket #1910


Ignore:
Timestamp:
May 4, 2017, 3:07:38 PM (7 years ago)
Author:
fatherbushido
Comment:

Sorry Mate-86 for the delay, are you still interested on that one? If so you can create an account on code.wildfiregames.com and upload the patch here. I read some stuff.

From a gameplay point of view that things could be used in main mod for the iberian ship or the fireraiser.

Concerning the current patch, I guess we could get rid of the Attack.prototype.CauseDeathDamage function. Moreover, even if it makes sense to have the stats in the Attack component as it's nothing else than a splash damage, I would be more for putting them in a small component like "Explosion" or "ExplodeOnDeath" or something like that which call directly CauseSplashDamage. Both (having that in Attack or not) have pros and cons. That can then listen to death message (bad) or directly call from the Health component like you did (better). EDIT: keeping like in the patch is perhaps better :p

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1910

    • Property Cc Josh added
    • Property Summary Unit death damage[PATCH] Unit death damage
    • Property Priority If Time PermitsNice to Have
    • Property Keywords patch rfc added; Simple removed
    • Property Milestone BacklogWork In Progress
    • Property Owner set to Mate-86