Changes between Initial Version and Version 1 of Ticket #1919, comment 10


Ignore:
Timestamp:
Aug 25, 2013, 1:51:50 PM (11 years ago)
Author:
Doménique

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1919, comment 10

    initial v1  
    11I just uploaded an updated patch with the current state. It's still not ready but at least it compiles against the current svn revision. There are two issue at the moment preventing this patch from being implemented:
    22
    3 * (GENERAL CODE) There is a general commands panel bug. As leper correctly wrote, any pack command button is laid over the first trainable entity. Thus that unit cannot be trained, which is a show stopper. Worse, when the (un)packable entity is not the first one selected, the Pack buttons are not shown at all (or maybe its panel is hidden below a trainable/buildable buttons panel). This is not unique to my patch but rather an existing bug. Normally it doesn't rear its ugly head, because currently there are no packable units that can also train or build entities. I'm not sure whether this bug warrants a separate ticket. Perhaps I can find a fix, but that will take some extra time as I'm not really familiar with the GUI code.
     3* (moved to #2084) There is a general commands panel bug. As leper correctly wrote, any pack command button is laid over the first trainable entity. Thus that unit cannot be trained, which is a show stopper. Worse, when the (un)packable entity is not the first one selected, the Pack buttons are not shown at all (or maybe its panel is hidden below a trainable/buildable buttons panel). This is not unique to my patch but rather an existing bug. Normally it doesn't rear its ugly head, because currently there are no packable units that can also train or build entities. I'm not sure whether this bug warrants a separate ticket. Perhaps I can find a fix, but that will take some extra time as I'm not really familiar with the GUI code.
    44
    55* (THIS PATCH) The transfer of the production queue needs some work. Testing shows it refunds money upon transforming, while the queue does get transferred (a.k.a. free units). Sometimes the training time resets as well. This worked fine before :S