| | 6 | |
| | 7 | In general about the patches though: |
| | 8 | * I think "const size_t value;" and "int getStuff(const MyStuff& arg) const" is all right, but "const size_t* const pvalue;" is a bit pushing the limits of readability :). Furthermore it should give no performance boost, since it's just a compile time check to make the variable read-only. The assembly generated has no difference. So having "int getStuff(const size_t arg)" is totally unnecessary, however "void doStuff(const MyStuff& arg)" still makes sense - since you are guaranteeing the value passed by reference will not change. |
| | 9 | |
| | 10 | * Storing calculations in temporary variables is common sense and good practice in general, so that's the correct way to go. |
| | 11 | * Passing larger than 4-byte values by reference is also a good thing to do. In general 0 A.D. has too many copy-on-move and temporary objects, so it's important to reduce that. |
| | 12 | |
| | 13 | If you have created new tickets to categorize the patches and have removed the old patches, I can give you a better review than this. :) |
