Changes between Version 2 and Version 3 of Ticket #2022, comment 10


Ignore:
Timestamp:
Dec 29, 2013, 5:52:26 PM (10 years ago)
Author:
wraitii

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2022, comment 10

    v2 v3  
    11Cleaned up Kuranes' patch, removing unnecessary consts, and a few changes which I deemed useless too (this is to my liking, but since nobody was reviewing the above patch).
    2 The idea behind the patch is simply to make class members a few variables that otherwise are temporaries in CalculateTerritories(), which is probably called often enough that this makes sense, even though it's not a huge improvement.
     2The idea behind the patch is simply to make a few variables that otherwise are temporaries in CalculateTerritories() class members, and CalculateTerritories() is probably called often enough that this makes sense, even though it's not a huge improvement in term of memory fragmentation. It's not a code obfuscation either so I'm tempted to like it.
    33I've added a few comments starting with "wraitii" to explain a few things. I've inlined the grid functions, and left those he added though we likely don't need them.
    44Kuranes had a liking to save the end of loops in a local variable just in front of the loop. It's fairly ugly, might be or might not be faster (should check assembly code). I've kept most of them.