Opened 10 years ago

Closed 9 years ago

#2024 closed defect (wontfix)

[PATCH] branching in minimap texture filling

Reported by: tuan kuranes Owned by: tuan kuranes
Priority: Nice to Have Milestone: Alpha 15
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by tuan kuranes)

Avoiding "if" inside big loops allows CPU to avoid branch mispredictions. In this case, just memsetting all to 0 prior the loop avoid some if in the loop code just to fill it with zeroes.

Attachments (1)

branch.patch (3.2 KB ) - added by tuan kuranes 10 years ago.

Download all attachments as: .zip

Change History (7)

by tuan kuranes, 10 years ago

Attachment: branch.patch added

comment:1 by tuan kuranes, 10 years ago

Description: modified (diff)
Summary: branching in minimap texture filling[PATCH] branching in minimap texture filling

comment:2 by Kieran P, 10 years ago

Keywords: patch review added
Milestone: BacklogAlpha 14
Priority: Should HaveNice to Have

comment:3 by historic_bruno, 9 years ago

Owner: set to tuan kuranes

comment:4 by Kieran P, 9 years ago

Milestone: Alpha 14Alpha 15

comment:5 by Jorma Rebane, 9 years ago

Keywords: reviewed added; review removed

Looks like it doesn't actually change much in terms of performance, since any gain you get from the branching optimization is negated by the memset.

I'll have to close this for now.

Last edited 9 years ago by Jorma Rebane (previous) (diff)

comment:6 by Jorma Rebane, 9 years ago

Keywords: reviewed removed
Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.