Changes between Version 4 and Version 36 of Ticket #2041


Ignore:
Timestamp:
Sep 4, 2014, 6:26:56 PM (10 years ago)
Author:
historic_bruno
Comment:

Replying to niektb:

But what about the error you posted?

The error restarting the engine after mod selection is fixed by yashi's patch (​cec49f5). Then the following are still issues:

  • Text input interacts differently with hotkeys, this is most noticeable with the backquote !` key in a text input field. It is also a console.toggle hotkey, it will both add the backquote and open the console.
    • In SDL1, it ignores the hotkey as a special case and inputs a backquote.
    • SDL2 sends three events for this single key press (actually one is a custom event sent by the hotkey handler): key down, hotkey down, and text input. The events aren't connected in the API, and I don't know that I can count on their order.
    • I think similar problems would occur with other hotkeys that have visible input characters.
  • In Windows, debugging the game in fullscreen is impossible, the window seems to maintain focus over VS. There may be other fullscreen focus-related issues.
  • Atlas errors on Linux?

Replying to yashi:

First, with SDL2, mouse tilt does not work. This seems to be an API change on SDL. My mouse reports that button 6 and 7 when I tilt left and right, respectively.

What functionality is mouse tilt in the game?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2041

    • Property Cc againsttcpa84@… added
    • Property Priority Should Have → Must Have
    • Property Keywords patch review added
    • Property Milestone Backlog → Alpha 17

  • Ticket #2041 – Description

    v4 v36  
    1 This ticket is for working on [http://www.libsdl.org/download-2.0.php SDL2] support (first stable release on 2013-08-13). Doc for 1.2 -> 2.0 migration [http://wiki.libsdl.org/moin.fcg/MigrationGuide here].
     1This ticket is for working on [http://www.libsdl.org/download-2.0.php SDL2] support (first stable release on 2013-08-13). Doc for 1.2 -> 2.0 migration [http://wiki.libsdl.org/MigrationGuide here].
    22
    33Known problems:
    4 * Text input has changed in SDL2 to better support CJK, see [http://wiki.libsdl.org/moin.fcg/Tutorials/TextInput TextInput tutorial] and this [http://forums.libsdl.org/viewtopic.php?t=8340 forum topic]. Basically Unicode characters may take multiple key presses to generate and we're now expected to use the text input API. In particular, `SDL_Keysym.unicode` is used by all text input in the game, but that was deprecated and has now been removed in the latest RC.
    5 * Using SDL on Windows conflicts with our hardware cursor implementation. This can be fixed by using SDL2's color cursors on all platforms, provided it works, #935 has a patch for that.
    6 * WMI shutdown crashes, moving it before SDL shutdown fixes that.
     4* ~~Text input has changed in SDL2 to better support CJK, see [http://wiki.libsdl.org/Tutorials/TextInput TextInput tutorial] and this [http://forums.libsdl.org/viewtopic.php?t=8340 forum topic]. Basically Unicode characters may take multiple key presses to generate and we're now expected to use the text input API. In particular, `SDL_Keysym.unicode` is used by all text input in the game, but that was deprecated and has now been removed in the latest RC.~~
     5* ~~Using SDL on Windows conflicts with our hardware cursor implementation. This can be fixed by using SDL2's color cursors on all platforms, provided it works, #935 has a patch for that.~~
     6* ~~WMI shutdown crashes, moving it before SDL shutdown fixes that.~~
    77* Atlas is broken on Linux, OpenGL functions fail in the engine thread (note the GL context is created by wxWidgets in the GUI thread)