Changes between Version 21 and Version 23 of Ticket #2048


Ignore:
Timestamp:
Sep 6, 2013, 10:36:15 AM (11 years ago)
Author:
sanderd17
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2048

    • Property Keywords patch, review → patch review
    • Property Owner set to sanderd17
    • Property Milestone Backlog → Alpha 15

  • Ticket #2048 – Description

    v21 v23  
    2121All js changes can be found in auras_js.diff. This patch needs the template changes to work.
    2222
     23'''Renaming methods and messages'''
     24
     25There are a few things I want to rename. First, I want to rename the MT_TechnologyModification message to something more general like MT_ValueModification. It's logical it's used by multiple components (at least Auras and Technologies). I also want to remove the player parameter from it, as the technology and aura components already send it to the right entities. So that player check is not needed.
     26
     27Next, I also want an extra ValueManager component, which should work as the current TechnologyManager on the c++ side (consequently, remove the c++ side of the TechnologyManager), but as a different component on the JS side, where the implementation of the old Technology helper functions really happens. The ValueManager should a system component and be the only one that knows about all components that can change values (currently Auras and Technologies).
     28
     29The JS global technology helper functions should also be renamed to things like ApplyValueModificationsToEntity and similar. So their names are more general.
     30
     31I have no patches ready for this, as I'd like to get these in using cumulative patches.
     32
    2333'''cpp changes'''
    2434
    25 I switched the cpp interface to use the same functions as the JS interface. '''This does require a clean_workspaces'''.
    26 
    27 The cpp changes aren't big, but it takes a long time to compile
    28 
    29 All changes to make the cpp components compatible can be found in auras_cpp.diff. This patch can also be applied on its own (doesn't need the other two patches)
     35The current cpp patch is rubbish. Instead, the only changes needed are renaming the methods so they comply with the above renamed things. Also get the player checks out of it, as it doesn't matter. The patch is still available here, but not for inclusion, just to easily see where current c++ technologies are used.
    3036
    3137'''Changed templates:'''