[PATCH] P-51 Mustang improvements

[scythetwirler]

Prevented sinking into water. Kills the plane upon contact with water. Allows one unit to be garrisoned inside. Adds pitch and roll. Made the plane repairable (and not healable). Made the landing look more realistic.

[sanderd17]

Some comments:

• The SinkDepth should be a part of CCmpPosition. As it can be re-used for amphibious animals and vehicles. As CCmpPosition already has an element "Altitude", it should probably be named something like "WaterAltitude". And it should also be implemented in CCmpPosition.

• You should investigate on the difference between the "SetHeightFixed" and "SetHeightOffset" methods of CCmpPosition. While you're descending or ascending, and while you're on the ground. It would be good to use "SetHeightOffset", as you wouldn't have to bother with calculating the difference to the ground every time, nor would you have to bother with that sink depth if it's properly implemented in CCmpPosition. While you're flying at constant height, the usage of a fixed height can indeed give better results.

[scythetwirler]

Discussed on IRC with sanderd17.

Patch does not implement the second bullet. Removes the extraneous SinkDepth. Disallows ungarrisoning in midair or when the plane is moving. (credits to sanderd17 for allowGarrisoning patch)

[peter]

In 13694:

Make planes about 20% cooler. Fixes #2067.

[alpha123]

Thanks for the patch. :)

I changed allowGarrisoning to a sparse array and IsGarrisoningAllowed to just do this.allowGarrisoning.every(function (x) x).

Sorry I forgot to credit you guys in the commit message. :/

[sanderd17]

As the ids are strings, and not integers, transforming it to a sparse array doesn't work. So I will fix that again to a normal object (the key gets added, but isn't found with the .every function).

Besides, sparse arrays are dangerous for performance as sometimes it can happen the interpreter handles it as a dense array (thus looping over all members). While objects are always handled as sparse, so don't cause those issues.

[sanderd17]

In 13697:

fix (dis)allowing of garrisoning by other components. Refs #2067

[fabio]

It looks good, but there are still two problems:

• plane can disappear out of the map;
• plane does not sink if you let it move over the water before it flies (let it start and soon after press stop, it moves forward on land and water without flying).

[scythetwirler]

Thanks, fabio! Fixed your second bullet. However, I'm not quite sure how to go about the plane disappearing off the map problem (planes could have already gone off the map before landing was implemented).

[scythetwirler]

Fixes sinking on water.

[wraitii]

In 13710:

Fix flying unit not crashing in water when they should. Patch by scythewirler. refs #2067