Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#2077 closed defect (fixed)

Valgrind errors from CPatchRData::RenderWater

Reported by: historic_bruno Owned by: wraitii
Priority: Should Have Milestone: Alpha 17
Component: Core engine Keywords:
Cc: wraitii Patch:

Description

Valgrind running on my Ubuntu VM reported these errors on Cycladic Archipelago 6 with all water options enabled, but they may only be driver bugs or false positives. If not generally reproducible, just close the ticket.

http://pastebin.com/YuNAvVnY

Change History (3)

comment:1 by wraitii, 11 years ago

Mmh, it's a little surprising since it appears to be some error with the way the vbo is defined… And I don't think I've ever changed the way the water is rendered in this… And I don't really see how the VBO might be wrong. Might be a driver error. I can't run Valgrind on OS X so I'd need further data.

comment:2 by wraitii, 10 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 15473:

Change the water texture to a new, bigger one, created in Blender (thanks to Enrique). Change settings so that they are more logical, yet allow reverting back to an even lower quality setting. Add a WIP high setting (with foam) which isn't finished yet.
Change the shader itself so that the effects look nicer and are more consistent across settings.
Rework the water mesh generation (simpler system). Fix a few issues.

May work oddly with Atlas since I haven't been able to compile yet.

Refs #1875 (maybe fix), Fixes #2077 (I'll assume it does), Fixes #2114 (assumption again), refs #48.

comment:3 by Stan, 10 years ago

Milestone: BacklogAlpha 17
Note: See TracTickets for help on using tickets.