Opened 11 years ago

Closed 11 years ago

Last modified 7 years ago

#2137 closed enhancement (fixed)

[PATCH] Switch Renderer scripting to global functions

Reported by: Yves Owned by: Yves
Priority: Should Have Milestone: Alpha 15
Component: Core engine Keywords: Spidermonkey
Cc: Patch:

Description

Same goal, same comments and same approach as #2126.

Any comments are welcome, otherwise I'll commit the patch this weekend.

Attachments (2)

renderer_global_functions_v1.0.diff​ (27.6 KB ) - added by Yves 11 years ago.
renderer_global_functions_v1.1.diff​ (27.6 KB ) - added by Yves 11 years ago.
Removed some unneeded includes and improved the naming of the JS functions.

Download all attachments as: .zip

Change History (7)

by Yves, 11 years ago

Attachment: renderer_global_functions_v1.0.diff​ added

comment:1 by Yves, 11 years ago

I'll try to improve the macro to allow naming without UPPERCASE (thanks to Philip for that hint). I'll also remove the CStr.h include and replace a ScriptInterface.h include with a forward declaration.

by Yves, 11 years ago

Attachment: renderer_global_functions_v1.1.diff​ added

Removed some unneeded includes and improved the naming of the JS functions.

comment:2 by Yves, 11 years ago

Resolution: → fixed
Status: new → closed

In 13877:

Changes the Renderer to expose global functions to scripts instead of using CJSObject.
Fixes #2137
Refs #1886

comment:3 by Yves, 11 years ago

Keywords: review removed

comment:4 by Yves, 11 years ago

In 14026:

Remove ScriptableObject/CJSObject

Since all remaining uses of ScriptableObject/CJSObject have been removed, the related files can now also be removed.
Closes #2212
Refs #2126
Refs #2137
Refs #1886

comment:5 by elexis, 7 years ago

In 20019:

Remove unused Renderer function from rP13877.

Refs #2137
Reviewed By: Vladislav

Note: See TracTickets for help on using tickets.