Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2140 closed task (fixed)

[PATCH] Switch Console scripting to global functions

Reported by: Yves Owned by: Yves
Priority: Should Have Milestone: Alpha 15
Component: Core engine Keywords: Spidermonkey
Cc: Patch:

Description

Same goal, same comments and same approach as #2126. I don't use macros here because there are less similar functions. The console didn't actually use CJSObject, but it implemented properties directly using the JSAPI.

I've tested the Console_Write funtion from the console and reading settings from GameView using the console.

Any comments are welcome!

Attachments (1)

console_global_functions_v1.0.diff (14.6 KB ) - added by Yves 11 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by Yves, 11 years ago

Thanks to Philip for the review! I've created ticket #2141 to have a closer look if logging the errors in the console is the right thing to do. This patch keeps the current behaviour and just changes the syntax. The console isn't very useful at the current state but we decided to keep it. Maybe in the future additional functionality will make it more useful.

comment:2 by Yves, 11 years ago

Resolution: fixed
Status: newclosed

In 13884:

Changes the Console to expose global functions to scripts instead of properties.
Fixes #2140
Refs #1886

comment:3 by Yves, 11 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.