Opened 11 years ago
Last modified 15 months ago
#2162 new enhancement
Group health
Reported by: | Josef Kufner | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Backlog |
Component: | UI – In-game | Keywords: | |
Cc: | Patch: | Phab:D4289 |
Description
When group has focus, there is bar showing overall health of the group. It would be nice to see this "summary health bar" also on the shortcut icon (numbers 0-9) at the left edge of the screen.
Attachments (3)
Change History (25)
comment:1 by , 11 years ago
comment:2 by , 10 years ago
Owner: | set to |
---|
follow-up: 5 comment:4 by , 10 years ago
If you do this, also take a look at the discussion here: #1902
You could take two tickets at once.
comment:5 by , 10 years ago
comment:6 by , 10 years ago
What the patch does:
- adds health bar to groups which shows the current health status of your group (green)
- adds members bar to groups which shows how many members of your group are still alive (orange)
- adds attack color fade when group is attacked
- adds a little death icon when a member of the group dies which disappears after some time
What could be improved:
I think performance would be better if the OnHealthChanged Method in UnitAI would be used to update the health of a group. In that case it would be great, if a component could trigger an update of the GUI (f.e. groupStatusChanged(groupId)) but I think with the current code this is not possible.
comment:7 by , 10 years ago
Keywords: | patch review health group added |
---|---|
Milestone: | Backlog → Alpha 16 |
Summary: | Group health → [PATCH] Group health |
by , 10 years ago
Attachment: | group_health_patch_v2.2.patch added |
---|
resolved confict with current SVN version.
comment:8 by , 10 years ago
Keywords: | wip added |
---|---|
Summary: | [PATCH] Group health → [WIP PATCH] Group health |
comment:9 by , 10 years ago
Milestone: | Alpha 16 → Alpha 17 |
---|
follow-up: 11 comment:10 by , 10 years ago
Hello boeseRaupe, sorry for taking so long reviewing the patches, especially this one.
I see you added a 'wip' keyword here some time ago, is there any progress? For my part I couldn't apply your patch due to changes in the code.
Let us know! And thanks for your work so far.
comment:11 by , 10 years ago
Replying to Itms:
Hello boeseRaupe, sorry for taking so long reviewing the patches, especially this one.
I see you added a 'wip' keyword here some time ago, is there any progress? For my part I couldn't apply your patch due to changes in the code.
Let us know! And thanks for your work so far.
At the moment I have no time to do anything...:( Hence no progress. ;)
comment:12 by , 10 years ago
Keywords: | wip removed |
---|
comment:13 by , 10 years ago
Summary: | [WIP PATCH] Group health → [PATCH] Group health |
---|
comment:14 by , 10 years ago
Keywords: | review health group removed |
---|---|
Milestone: | Alpha 17 → Backlog |
No problem, good luck for all your other tasks! :)
comment:15 by , 8 years ago
Keywords: | review added |
---|---|
Milestone: | Backlog → Alpha 20 |
comment:16 by , 8 years ago
Keywords: | review removed |
---|---|
Milestone: | Alpha 20 → Backlog |
I like the idea, but the patch is outdated and needs to be rebased again. Also some minor style issues:
- unneeded comments, comments should also start with capital letters
- Maybe it is possible to implement the same functionality without a
dirty
variable DeathCycle
sounds weird, how about saving thedeathTime
and have it zero if the units are not dead?groupDeathShowIconTicks
should be given in seconds or milliseconds- If you create a new object and set properties after it, use
{ "prop1": value1, ... }
- Likely some unneeded variables, I can try to simplify if someone provides an otherwise updated patch.
comment:17 by , 5 years ago
Component: | UI & Simulation → In-game UI |
---|
Move tickets to In-game UI
as UI & Simulation
got some sub components.
comment:18 by , 3 years ago
Keywords: | simple added; patch removed |
---|---|
Milestone: | Backlog → Alpha 26 |
Owner: | removed |
Summary: | [PATCH] Group health → Group health |
Patch is heavily outdated, but the idea is nice enough to be tried for A26.
comment:19 by , 2 years ago
Keywords: | simple removed |
---|---|
Owner: | set to |
Patch: | → Phab:D4289 |
comment:20 by , 2 years ago
Owner: | removed |
---|
comment:21 by , 2 years ago
Milestone: | Alpha 26 → Alpha 27 |
---|
I would like something similar on the hero button.