Changes between Initial Version and Version 1 of Ticket #2305, comment 29


Ignore:
Timestamp:
Oct 17, 2016, 12:24:13 AM (7 years ago)
Author:
fcxSanya

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2305, comment 29

    initial v1  
    2121* "magic cookie" is a term/value from RFC 5389, the document doesn't state where the value comes from as far as I can see
    2222* `default.cfg` and `CFG_GET_VAL`: yeah, I just recently made a patch introducing a new config option for another ticket: #2845, but didn't reach this particular TODO item here yet
    23 * `assert`/`ENSURE`: I replaced one of `assert`'s with a 'normal if' in [https://github.com/0ad/0ad/commit/35da3c1c1dc7863c3170a44f21c1cda6e3971f33 35da3c1] and I think I will do the same with remaining ones, since they check the data based on incoming message from third-party service (STUN server) rather than ensure that the code itself produces the proper data (what is their purpose as far as I understand)
     23* `assert`/`ENSURE`: I replaced one of `assert`'s with a 'normal if' in [https://github.com/0ad/0ad/commit/35da3c1c1dc7863c3170a44f21c1cda6e3971f33 35da3c1] and I think I will do the same with remaining ones, since they check the data based on incoming message from a third-party service (STUN server) rather than ensure that the code itself produces the proper data (what is their purpose as far as I understand)
    2424* broken indentation: did you look at the diff attached here (`stk_stun_wip_2016-08-28.diff`​) or at the code in the github branch: https://github.com/0ad/0ad/compare/master...AlexanderOlkhovskiy:stk-stun ? I tried to fix the indentation in [https://github.com/0ad/0ad/commit/d5fef015b9f2e81503f8273fddbc428ddf5aa245 d5fef01] (which was committed into the git branch after `stk_stun_wip_2016-08-28.diff`​, but before your review), I may have missed something or may have done something wrong though.
    2525