Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#2348 closed task (fixed)

Temorarily remove the JS debugger

Reported by: Yves Owned by: Yves
Priority: Should Have Milestone: Alpha 16
Component: Non-game systems Keywords: SpiderMonkey, debugger
Cc: Patch:

Description

#2241 breaks the JS debugger (or makes worse what is already broken). Because the SpiderMonkey upgrade (#1886) is going to break the debugger anyway, it should be temporarily removed until the update is done and I can start fixing/rewriting it. What definitely needs to be removed or excluded from compiling are the files using the JS debugging API, because these won't compile with the new SpiderMonkey.

Of course this also means doing something sensible with:

Attachments (1)

fix_compiling_error.patch (1.0 KB) - added by Michael 6 years ago.
includes precompiled.h again

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by Yves

Status: newassigned

comment:2 Changed 6 years ago by Yves

I have added notifications to the wiki pages listed above.

comment:3 Changed 6 years ago by Yves

Resolution: fixed
Status: assignedclosed

In 14506:

Disables the JS debugger.
It's completely broken since r14496 and will have to be updated for the new SpiderMonkey API.
I only uncomment it at the moment because I plan to fix/reimplement it soon after the upgrade.

Closes #2348
Refs #2241
Refs #1886

comment:4 Changed 6 years ago by Michael

DebuggingServer? and ThreadDebugger? are not compiling anymore because precompiled.h is not included. Is this wanted ?

Changed 6 years ago by Michael

Attachment: fix_compiling_error.patch added

includes precompiled.h again

comment:5 Changed 6 years ago by Yves

Please try a clean rebuild. It doesn't make sense for me that a file only containing comments needs any header files included. On which platform are you building?

comment:6 Changed 6 years ago by Yves

In 14511:

I completely missed the header files when disabling the JS debugger.

Refs #2348

comment:7 in reply to:  6 Changed 6 years ago by Michael

Replying to Yves:

In 14511:

I completely missed the header files when disabling the JS debugger.

Refs #2348

Hmm. Something I'm doing wrong. I updated and reverted the SVN to the newest version, cleaned all the projects and started rebuild all. But still two projects fail.

I pasted the log of the build process here: http://pastebin.com/FUifrL8S

PS: I compile with Visual Express 2010 on Win7 32 bit.

comment:8 Changed 6 years ago by Yves

Philip just told me that Visual Studio uses a special flag to check for precompiled.h in each source file. So it doesn't really need it but it checks for it and therefore fails. I'll fix it soon.

comment:9 Changed 6 years ago by Yves

In 14512:

Adds precompiled.h include because Visual Studio checks for that even though the file only contains comments.
Thanks to boeseRaupe for reporting.

Refs #2348

Note: See TracTickets for help on using tickets.