Changes between Initial Version and Version 1 of Ticket #2357, comment 10


Ignore:
Timestamp:
Jan 10, 2014, 6:37:09 PM (10 years ago)
Author:
Michael

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2357, comment 10

    initial v1  
    88> * Session.js line 502 doesnt need to query the player ID. The first argument given to any GuiInterface method is the player id anyway. So that's just a lost call.
    99
    10 Forgot to remove this, after I noticed this.
     10Forgot to remove this, after I noticed that its called this way.
    1111
    1212> * UnitAI shouldn't have to worry about counters too much. It's nice if it can notify the cmpPlayer when the state of a unit changed. But cmpPlayer should handle ownership changes on its own. This would make the code a lot more simple, as it only needs to work in the idle case (probably both regular and formation idle), and only ever needs to query the own player component. Having a function to query the cmpPlayer of a different player in UnitAI isn't very clear IMO. And querying the own player can already be done with a single command.